From: Grant Likely <grant.likely@secretlab.ca>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linuxppc-dev@ozlabs.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH] alsa/soc: add locking to mpc5200-psc-ac97 driver
Date: Tue, 30 Jun 2009 10:53:26 -0600 [thread overview]
Message-ID: <fa686aa40906300953n28016d4v179a1c7ed3198399@mail.gmail.com> (raw)
In-Reply-To: <20090630085917.GA13961@sirena.org.uk>
On Tue, Jun 30, 2009 at 2:59 AM, Mark
Brown<broonie@opensource.wolfsonmicro.com> wrote:
> On Mon, Jun 29, 2009 at 08:26:12PM -0400, Jon Smirl wrote:
>
>> Does your touchscreen driver use this mutex? Or was this mutex needed
>> just for the AC97 driver?
>
> It's in the register accesses so everything accessing the chip registers
> will use it.
The mutexes are needed. The ac97 bus doesn't have any knowledge about
what codec(s) will be wired up to it so it must protect against
multiple access. In my case both the wm9712 audio codec driver and
the wm9712 touchscreen driver perform register accesses.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2009-07-01 0:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-29 23:42 [PATCH] alsa/soc: add locking to mpc5200-psc-ac97 driver Grant Likely
2009-06-30 0:26 ` Jon Smirl
2009-06-30 8:59 ` Mark Brown
2009-06-30 16:53 ` Grant Likely [this message]
2009-06-30 6:18 ` Wolfram Sang
2009-06-30 13:42 ` Jon Smirl
2009-06-30 13:53 ` Mark Brown
2009-07-01 8:56 ` Wolfram Sang
2009-07-01 13:32 ` Jon Smirl
2009-07-01 13:55 ` Wolfram Sang
2009-07-01 14:44 ` Grant Likely
2009-07-02 13:51 ` Eric Millbrandt
2009-06-30 16:50 ` Grant Likely
2009-06-30 18:33 ` Jon Smirl
2009-06-30 19:08 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40906300953n28016d4v179a1c7ed3198399@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).