From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id E911FB6EDE for ; Sat, 8 Aug 2009 04:30:02 +1000 (EST) MIME-Version: 1.0 Sender: glikely@secretlab.ca In-Reply-To: <9e4733910908070934se43b2a9lfe72e89e0e247ea3@mail.gmail.com> References: <9e4733910908070903p539b8987p8351df5b3d328fdd@mail.gmail.com> <9e4733910908070934se43b2a9lfe72e89e0e247ea3@mail.gmail.com> From: Grant Likely Date: Fri, 7 Aug 2009 12:29:40 -0600 Message-ID: Subject: Re: PSC clock divider To: Jon Smirl Content-Type: text/plain; charset=ISO-8859-1 Cc: linuxppc-dev List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Aug 7, 2009 at 10:34 AM, Jon Smirl wrote: > On Fri, Aug 7, 2009 at 12:15 PM, Grant Likely wrote: >>> Should I modify mpc52xx_set_psc_clkdiv() to take in a frequency and >>> them move this code into mpc52xx_common.c? That allows the sysclk >>> parameter to be eliminated for SPI. >> >> Yes, please do. > > Can mpc5xxx_clocks.c be eliminated and this function: > > mpc5xxx_get_bus_frequency(struct device_node *node) > > be moved into mpc52cc_common.c? No. mpc5xxx_get_bus_frequency is not mpc5200 specific. It is used by mpc5121 also. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.