linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab.ca>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: "David S. Miller" <davem@davemloft.net>, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2/3] powerpc/pci: move pci_64.c device tree scanning code into pci-common.c
Date: Fri, 21 Aug 2009 08:54:25 -0600	[thread overview]
Message-ID: <fa686aa40908210754s5e54af99sdbd11eb6ec48b5f9@mail.gmail.com> (raw)
In-Reply-To: <20090821160116.b4a7b713.sfr@canb.auug.org.au>

On Fri, Aug 21, 2009 at 12:01 AM, Stephen Rothwell<sfr@canb.auug.org.au> wr=
ote:
>
> And similarly with sparc's pci_parse_of_addrs() and pci_parse_of_flags
> () ? =A0Maybe create drivers/of/pci.c (or drivers/pci/of.c)? =A0Or maybe =
they
> are still too different?
>
> There is probably scope for more consolidation there.

I agree, but I'll do those things in a separate patch.  I'm making as
few code changes as possible in this patch to ease review.

g.

--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

  reply	other threads:[~2009-08-21 14:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-21  5:30 [RFC PATCH 0/3] Make 64-bit PCI device tree scanning code common Grant Likely
2009-08-21  5:30 ` [PATCH 1/3] powerpc/pci: Remove dead checks for CONFIG_PPC_OF Grant Likely
2009-08-21  5:46   ` Stephen Rothwell
2009-08-21  5:30 ` [PATCH 2/3] powerpc/pci: move pci_64.c device tree scanning code into pci-common.c Grant Likely
2009-08-21  6:01   ` Stephen Rothwell
2009-08-21 14:54     ` Grant Likely [this message]
2009-08-21 15:17       ` Stephen Rothwell
2009-08-21  6:05   ` Benjamin Herrenschmidt
2009-08-21 14:54     ` Grant Likely
2009-08-21  5:30 ` [PATCH 3/3] powerpc/pci: Merge ppc32 and ppc64 versions of phb_scan() Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa686aa40908210754s5e54af99sdbd11eb6ec48b5f9@mail.gmail.com \
    --to=grant.likely@secretlab.ca \
    --cc=davem@davemloft.net \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).