Re: [PATCH] USB: Add support for Xilinx USB host controller

[Grant Likely <grant.likely@secretlab.ca>]

On Tue, Sep 15, 2009 at 3:10 PM, Julie Zhu <julie.zhu@xilinx.com> wrote:
> Add bus glue driver for Xilinx USB host controller. The controller can be
> configured as HS only or HS/FS hybrid. The driver uses the device tree fi=
le
> to configure the driver according to the setting in the hardware system.
>
> This driver has been tested with usbtest using the NET2280 PCI card.
>
> Signed-off-by: Julie Zhu <julie.zhu@xilinx.com>

As Ben said, this is nice tight code.  Two comments below.

> +/**
> + * ehci_xilinx_port_handed_over - hand the port out if failed to enable =
it
> + * @hcd: =A0 =A0 =A0 Pointer to the usb_hcd device to which the host con=
troller bound
> + * @portnum:Port number to which the device is attached.
> + *
> + * This function is used as a place to tell the user that the Xilinx USB=
 host
> + * controller does support LS devices. And in an HS only configuration, =
it
> + * does not support FS devices neither. It is hoped that this can help a

s/neither/either

[...]
> +static struct of_device_id ehci_hcd_xilinx_of_match[] =3D {
> + =A0 =A0 =A0 {
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 .compatible =3D "usb-ehci",
> + =A0 =A0 =A0 },

This looks wrong.  Since this driver only works with Xilinx USB controllers=
,
it should be binding against "xlnx,xps-usb-host-1.00.a", and the meaning of
that binding needs to be documented in Documentation/powerpc/dts-bindings.

Having this driver bind against the generic "usb-ehci" will cause conflicts
with the ehci-ppc-of driver.

Cheers,
g.

--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.