From: Grant Likely <grant.likely@secretlab.ca>
To: michael@ellerman.id.au
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 6/6] powerpc: Enable sparse irq_descs on powerpc
Date: Wed, 14 Oct 2009 18:33:17 -0600 [thread overview]
Message-ID: <fa686aa40910141733r466f327meab2d52f21618aff@mail.gmail.com> (raw)
In-Reply-To: <1255564276.9651.14.camel@concordia>
On Wed, Oct 14, 2009 at 5:51 PM, Michael Ellerman
<michael@ellerman.id.au> wrote:
> On Wed, 2009-10-14 at 12:44 -0600, Grant Likely wrote:
>> Why not make sparse IRQs manditory for all platforms? =A0Is there a
>> performance concern with doing so? =A0From a maintenance perspective,
>> I'd rather see IRQ descs manged in one way only to keep the code
>> simple.
>
> I agree on the maintenance angle. My thinking was we'd run with it
> optional but default y for a release or two, and if no one complains we
> can make it mandatory.
>
> It does make some code paths bigger, and looking up an irq_desc is going
> to take slightly more cycles. I don't think it's a big issue, but I
> thought we should try it for a while before making it mandatory. The
> code has only been tested on x86 and sh as far as I know.
No guts, no glory. I say throw it into linux-next to give it some
time before the next merge window. I don't think you'll get any
better results by having it optional for a few releases (in fact, I
suspect that people who do have problems will just end up turning it
off and waiting for someone else to report/fix the problems). If this
is the direction IRQ handling is going, then just make the change and
force any bugs to be dealt with before the next release.
> ps. thanks for the review
You're welcome.
g.
--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2009-10-15 0:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-14 5:44 [PATCH 1/6] powerpc: Make NR_IRQS a CONFIG option Michael Ellerman
2009-10-14 5:44 ` [PATCH 2/6] powerpc/pseries: Use irq_has_action() in eeh_disable_irq() Michael Ellerman
2009-10-14 18:33 ` Grant Likely
2009-10-14 5:44 ` [PATCH 3/6] powerpc: Remove get_irq_desc() Michael Ellerman
2009-10-14 19:02 ` Grant Likely
2009-10-14 5:44 ` [PATCH 4/6] powerpc: Make virq_debug_show() cope with sparse irq_descs Michael Ellerman
2009-10-14 18:34 ` Grant Likely
2009-10-14 5:45 ` [PATCH 5/6] powerpc: Rearrange and fix show_interrupts() for " Michael Ellerman
2009-10-14 18:37 ` Grant Likely
2009-10-14 5:45 ` [PATCH 6/6] powerpc: Enable sparse irq_descs on powerpc Michael Ellerman
2009-10-14 18:44 ` Grant Likely
2009-10-14 23:51 ` Michael Ellerman
2009-10-15 0:33 ` Grant Likely [this message]
2009-10-14 18:59 ` [PATCH 1/6] powerpc: Make NR_IRQS a CONFIG option Grant Likely
2009-10-14 23:47 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40910141733r466f327meab2d52f21618aff@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).