From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-gx0-f212.google.com (mail-gx0-f212.google.com [209.85.217.212]) by ozlabs.org (Postfix) with ESMTP id 5AAD5B7B93 for ; Sun, 8 Nov 2009 06:46:35 +1100 (EST) Received: by gxk4 with SMTP id 4so2044397gxk.8 for ; Sat, 07 Nov 2009 11:46:34 -0800 (PST) MIME-Version: 1.0 Sender: glikely@secretlab.ca In-Reply-To: <20091107193318.GB31789@sirena.org.uk> References: <20091107081631.18908.82921.stgit@angua> <20091107083448.18908.80366.stgit@angua> <20091107181153.GA31789@sirena.org.uk> <20091107193318.GB31789@sirena.org.uk> From: Grant Likely Date: Sat, 7 Nov 2009 12:46:14 -0700 Message-ID: Subject: Re: [alsa-devel] [PATCH 6/6] ASoC/mpc5200: Add fudge factor to value reported by .pointer() To: Mark Brown Content-Type: text/plain; charset=ISO-8859-1 Cc: alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, lrg@slimlogic.co.uk List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, Nov 7, 2009 at 12:33 PM, Mark Brown wrote: > On Sat, Nov 07, 2009 at 11:19:54AM -0700, Grant Likely wrote: >> On Sat, Nov 7, 2009 at 11:11 AM, Mark Brown > >> > It occurs to me that in terms of dealing with what's going on here this >> > probably is achieving exactly the same effect as Jon's code in that it >> > tells ALSA that things are a bit ahead of where the buffer started. > >> Possibly, but I can both reproduce and eliminate the problem Jon is >> seeing regardless of whether or not this patch, so I'm not yet >> convinced. > > That doesn't entirely surprise me; I'm not convinced that the original > approach entirely deals with the issue rather than just making it much > harder to see. Indeed. I'm at the point where I'm far more interested in achieving "correctness" than trying to hobble together a set of conditions that appears to work most of the time. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.