From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw0-f199.google.com (mail-yw0-f199.google.com [209.85.211.199]) by ozlabs.org (Postfix) with ESMTP id 2D809B70CF for ; Thu, 12 Nov 2009 07:18:57 +1100 (EST) Received: by ywh37 with SMTP id 37so1444647ywh.17 for ; Wed, 11 Nov 2009 12:18:56 -0800 (PST) MIME-Version: 1.0 Sender: glikely@secretlab.ca In-Reply-To: <16246194.1257928342802.JavaMail.ngmail@webmail19.ha2.local> References: <1257884778.14374.5@antares> <16246194.1257928342802.JavaMail.ngmail@webmail19.ha2.local> From: Grant Likely Date: Wed, 11 Nov 2009 13:18:36 -0700 Message-ID: Subject: Re: Re: [PATCH 3/3] mpc52xx/wdt: WDT uses GPT api To: =?ISO-8859-1?Q?Albrecht_Dre=DF?= Content-Type: text/plain; charset=ISO-8859-1 Cc: linuxppc-dev@ozlabs.org, devicetree-discuss@lists.ozlabs.org, wim@iguana.be List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Nov 11, 2009 at 1:32 AM, Albrecht Dre=DF = wrote: > Hi Grant: > > O.k., thanks for your comments. =A0If Wim doesn't have any objections to = it, I will provide a merged patch. =A0One consequence I forgot to mention i= s that we loose the ability to build the wdt support as module, but I don't= think it's a real problem. I'm not too worried about this. It is also potentially possible to rework the entire GPT driver as a module. But there are non-trivial architecture fiddly bits needed to make it safe to load IRQ controllers in a module. > I think we still should keep the kernel config option enable/disable the = wdt support, which would mask out the wdt code if disabled. =A0Is that ok f= or you? Yup. g. --=20 Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.