From: Grant Likely <grant.likely@secretlab.ca>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Stephen Neuendorffer <stephenn@xilinx.com>,
Alon Ziv <alonz@discretix.com>,
linuxppc-dev@lists.ozlabs.org, John Linn <John.Linn@xilinx.com>
Subject: Re: Bug in drivers/serial/of_serial.c?
Date: Sun, 22 Nov 2009 15:43:26 -0700 [thread overview]
Message-ID: <fa686aa40911221443p6e6f5e4dt5ef2e90b1c2624e0@mail.gmail.com> (raw)
In-Reply-To: <fa686aa40911221442t4526dd65v5a0f9659e8767e47@mail.gmail.com>
On Sun, Nov 22, 2009 at 3:42 PM, Grant Likely <grant.likely@secretlab.ca> w=
rote:
> On Sat, Nov 21, 2009 at 12:45 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>> On Saturday 21 November 2009, Grant Likely wrote:
>>> BTW, while looking at that file... Arnd, does the .type =3D "serial"
>>> stuff really need to be there?
>>
>> Well, serial is one of the few that actually has some preexisting
>> binding with a well defined device-type, so I guess we should use
>> it.
>
> But device-type describes a OpenFirmware API, not a device register
> interface. =A0Once we're in the kernel and talking to the hardware
> directly, device-type has no real meaning because we're not using the
> OpenFirmware interface to talk to serial devices in a generic manner.
And looking for it in the driver forces us to put meaningless
"device_type" properties in the flat trees, where they make no sense
whatsoever.
g.
--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2009-11-22 22:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-15 9:30 Bug in drivers/serial/of_serial.c? Alon Ziv
2009-11-16 8:09 ` Arnd Bergmann
2009-11-19 12:47 ` Alon Ziv
2009-11-19 13:01 ` Arnd Bergmann
2009-11-19 13:32 ` Alon Ziv
2009-11-19 13:41 ` Arnd Bergmann
2009-11-19 13:49 ` Alon Ziv
2009-11-19 14:09 ` Arnd Bergmann
2009-11-19 16:03 ` Greg KH
2009-11-19 17:22 ` Stephen Neuendorffer
2009-11-19 17:33 ` Arnd Bergmann
2009-11-19 17:42 ` Stephen Neuendorffer
2009-11-20 21:58 ` Grant Likely
2009-11-20 22:11 ` John Linn
2009-11-21 7:51 ` Grant Likely
2009-11-21 19:45 ` Arnd Bergmann
2009-11-22 22:42 ` Grant Likely
2009-11-22 22:43 ` Grant Likely [this message]
2009-11-20 21:56 ` Grant Likely
[not found] ` <977C41F842E66D4CB2E41332313B615008FC3C2F@XSJ-EXCHVS1.xlnx.xilinx.com>
2009-11-19 17:36 ` John Linn
2009-11-19 17:20 ` Stephen Neuendorffer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40911221443p6e6f5e4dt5ef2e90b1c2624e0@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=John.Linn@xilinx.com \
--cc=alonz@discretix.com \
--cc=arnd@arndb.de \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=stephenn@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).