From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw0-f187.google.com (mail-yw0-f187.google.com [209.85.211.187]) by ozlabs.org (Postfix) with ESMTP id 589F11007E2 for ; Mon, 23 Nov 2009 09:43:48 +1100 (EST) Received: by ywh17 with SMTP id 17so4623713ywh.2 for ; Sun, 22 Nov 2009 14:43:46 -0800 (PST) MIME-Version: 1.0 Sender: glikely@secretlab.ca In-Reply-To: References: <8B957E110B62714A84290A01A597805F05CA0AA0@Exchange.discretix.com> <200911212045.42767.arnd@arndb.de> From: Grant Likely Date: Sun, 22 Nov 2009 15:43:26 -0700 Message-ID: Subject: Re: Bug in drivers/serial/of_serial.c? To: Arnd Bergmann Content-Type: text/plain; charset=ISO-8859-1 Cc: Stephen Neuendorffer , Alon Ziv , linuxppc-dev@lists.ozlabs.org, John Linn List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sun, Nov 22, 2009 at 3:42 PM, Grant Likely w= rote: > On Sat, Nov 21, 2009 at 12:45 PM, Arnd Bergmann wrote: >> On Saturday 21 November 2009, Grant Likely wrote: >>> BTW, while looking at that file... Arnd, does the .type =3D "serial" >>> stuff really need to be there? >> >> Well, serial is one of the few that actually has some preexisting >> binding with a well defined device-type, so I guess we should use >> it. > > But device-type describes a OpenFirmware API, not a device register > interface. =A0Once we're in the kernel and talking to the hardware > directly, device-type has no real meaning because we're not using the > OpenFirmware interface to talk to serial devices in a generic manner. And looking for it in the driver forces us to put meaningless "device_type" properties in the flat trees, where they make no sense whatsoever. g. --=20 Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.