From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 Sender: glikely@secretlab.ca In-Reply-To: References: <20091124215908.559.23998.stgit@angua> From: Grant Likely Date: Tue, 24 Nov 2009 18:33:33 -0700 Message-ID: Subject: Re: [PATCH v2 11/11] of: unify phandle name in struct device_node To: Segher Boessenkool Content-Type: text/plain; charset=ISO-8859-1 Cc: sfr@canb.auug.org.au, monstr@monstr.eu, microblaze-uclinux@itee.uq.edu.au, devicetree-discuss@lists.ozlabs.org, sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, davem@davemloft.net List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Nov 24, 2009 at 6:30 PM, Segher Boessenkool wrote: >> In struct device_node, the phandle is named 'linux_phandle' for PowerPC >> and MicroBlaze, and 'node' for SPARC. =A0There is no good reason for the >> difference, it is just an artifact of the code diverging over a couple >> of years. =A0This patch renames both to simply .phandle. >> >> Note: the .node also existed in PowerPC/MicroBlaze, but the only user >> seems to be arch/powerpc/platforms/powermac/pfunc_core.c. =A0It doesn't >> look like the assignment between .linux_phandle and .node is >> significantly different enough to warrant the separate code paths >> unless ibm,phandle properties actually appear in Apple device trees. >> >> I think it is safe to eliminate the old .node property and use >> linux_phandle everywhere. > > =A0^^^^^^^^^^^^ =A0You forgot to update one :-) Heeheehee. oops. g. --=20 Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.