From: Grant Likely <grant.likely@secretlab.ca>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: sfr@canb.auug.org.au, monstr@monstr.eu,
microblaze-uclinux@itee.uq.edu.au,
devicetree-discuss@lists.ozlabs.org, sparclinux@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, davem@davemloft.net
Subject: Re: [PATCH 06/11] of/flattree: merge early_init_devtree() and early_init_move_devtree()
Date: Thu, 10 Dec 2009 23:19:00 -0700 [thread overview]
Message-ID: <fa686aa40912102219s11a2aba3nc61bc0f53b0e9ffe@mail.gmail.com> (raw)
In-Reply-To: <1259208248.16367.230.camel@pasglop>
On Wed, Nov 25, 2009 at 9:04 PM, Benjamin Herrenschmidt
<benh@kernel.crashing.org> wrote:
> On Tue, 2009-11-24 at 01:19 -0700, Grant Likely wrote:
>> =A0/**
>> + * early_init_move_devtree - move tree to an unused area, if needed.
>> + *
>> + * The device tree may be allocated beyond our memory limit, or inside =
the
>> + * crash kernel region for kdump. If so, move it out of the way.
>> + */
>> +#if defined(CONFIG_PPC)
>> +static void __init early_init_move_devtree(void)
>
> And you still end up with an ifdef mess in the common code ...
The #ifdefs are temporary. I'm leaving them in now exactly because
they are ugly and show where the code needs to be refactored and
reorganized. Once everything is merged, I'll probably do exactly what
you suggest. I just cannot yet tell the exact structure of it until I
see the merged version.
g.
--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2009-12-11 6:19 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-24 8:17 [PATCH 00/11] Yet another series of OF merge patches Grant Likely
2009-11-24 8:17 ` [PATCH 01/11] of/flattree: Merge early_init_dt_check_for_initrd() Grant Likely
2009-11-26 3:51 ` Benjamin Herrenschmidt
2009-11-26 4:02 ` Grant Likely
2009-11-24 8:18 ` [PATCH 02/11] of/flattree: Merge earlyinit_dt_scan_root() Grant Likely
2009-11-26 3:54 ` Benjamin Herrenschmidt
2009-11-26 4:03 ` Grant Likely
2009-11-24 8:18 ` [PATCH 03/11] of/flattree: merge dt_mem_next_cell Grant Likely
2009-11-26 3:55 ` Benjamin Herrenschmidt
2009-11-24 8:18 ` [PATCH 04/11] of/flattree: eliminate cell_t typedef Grant Likely
2009-11-26 3:59 ` Benjamin Herrenschmidt
2009-11-26 4:05 ` Grant Likely
2009-11-26 5:27 ` Benjamin Herrenschmidt
2009-11-26 21:36 ` Segher Boessenkool
2009-11-26 21:40 ` Benjamin Herrenschmidt
2009-11-26 23:32 ` David Miller
2009-12-11 6:43 ` Grant Likely
2009-11-26 6:28 ` M. Warner Losh
2009-11-26 7:06 ` Benjamin Herrenschmidt
2009-11-26 7:52 ` Mitch Bradley
2009-11-24 8:18 ` [PATCH 05/11] of/flattree: merge early_init_dt_scan_chosen() Grant Likely
2009-11-24 8:19 ` [PATCH 06/11] of/flattree: merge early_init_devtree() and early_init_move_devtree() Grant Likely
2009-11-26 4:04 ` Benjamin Herrenschmidt
2009-12-11 6:19 ` Grant Likely [this message]
2009-12-07 7:08 ` Jeremy Kerr
2009-12-11 6:20 ` Grant Likely
2009-11-24 8:19 ` [PATCH 07/11] of: merge machine_is_compatible() Grant Likely
2009-11-26 4:05 ` Benjamin Herrenschmidt
2009-12-11 6:54 ` Grant Likely
2009-11-24 8:19 ` [PATCH 08/11] of: Merge of_node_get() and of_node_put() Grant Likely
2009-11-26 4:06 ` Benjamin Herrenschmidt
2009-11-24 8:19 ` [PATCH 09/11] of: merge of_attach_node() & of_detach_node() Grant Likely
2009-11-26 4:07 ` Benjamin Herrenschmidt
2009-12-10 22:21 ` Grant Likely
2009-11-24 8:19 ` [PATCH 10/11] microblaze: gut implementation of early_init_dt_scan_cpus() Grant Likely
2009-11-24 8:20 ` [PATCH 11/11] of: unify phandle name in struct device_node Grant Likely
2009-11-24 17:37 ` David Miller
2009-11-24 20:33 ` Grant Likely
2009-11-24 21:10 ` David Miller
2009-11-24 21:06 ` Benjamin Herrenschmidt
2009-11-24 21:39 ` Grant Likely
2009-11-26 12:28 ` [PATCH 00/11] Yet another series of OF merge patches Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40912102219s11a2aba3nc61bc0f53b0e9ffe@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=microblaze-uclinux@itee.uq.edu.au \
--cc=monstr@monstr.eu \
--cc=sfr@canb.auug.org.au \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).