From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yx0-f179.google.com (mail-yx0-f179.google.com [209.85.210.179]) by ozlabs.org (Postfix) with ESMTP id 0B6CEB6F1B for ; Tue, 12 Jan 2010 06:59:41 +1100 (EST) Received: by yxe9 with SMTP id 9so10898547yxe.26 for ; Mon, 11 Jan 2010 11:59:40 -0800 (PST) MIME-Version: 1.0 Sender: glikely@secretlab.ca In-Reply-To: <4B4B7F13.3090809@freescale.com> References: <200912081339.50722.roman.fietze@telemotive.de> <200912220755.09756.roman.fietze@telemotive.de> <200912220759.23453.roman.fietze@telemotive.de> <4B4B7F13.3090809@freescale.com> From: Grant Likely Date: Mon, 11 Jan 2010 12:59:20 -0700 Message-ID: Subject: Re: [PATCH 02/13] powerpc/5200: LocalPlus driver: use SCLPC register structure To: Scott Wood Content-Type: text/plain; charset=ISO-8859-1 Cc: linuxppc-dev@lists.ozlabs.org, Roman Fietze List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Jan 11, 2010 at 12:42 PM, Scott Wood wrot= e: > Grant Likely wrote: >> >> Please don't. =A0I know that a lot of other 5200 code uses register map >> structures in this way, but I consider it bad practice. =A0I coded this >> driver without a structure for a reason. =A0The reason I haven't removed >> the other 5200 register map structures is the code impact would be >> huge, it would probably cause breakage, and it would break all >> out-of-tree patches touching the same code for no measurable >> advantage. > > FWIW, over on the U-Boot side patches are getting NACKed by Wolfgang if t= hey > don't use register structures. :-P > > They're nice from a type-safety and namespacing perspective, though they = get > ugly pretty quickly if there are gaps. Regardless, I see no reason to change existing code in either direction. g. --=20 Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.