From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw0-f201.google.com (mail-yw0-f201.google.com [209.85.211.201]) by ozlabs.org (Postfix) with ESMTP id 12AA0B7C31 for ; Tue, 12 Jan 2010 09:59:09 +1100 (EST) Received: by ywh39 with SMTP id 39so20456455ywh.17 for ; Mon, 11 Jan 2010 14:59:07 -0800 (PST) MIME-Version: 1.0 Sender: glikely@secretlab.ca In-Reply-To: <20100109110104.GA20100@x200> References: <1262830753.577814.127040702434.1.gpush@pororo> <20100109110104.GA20100@x200> From: Grant Likely Date: Mon, 11 Jan 2010 15:58:47 -0700 Message-ID: Subject: Re: [PATCH] proc_devtree: fix THIS_MODULE without module.h To: Alexey Dobriyan Content-Type: text/plain; charset=ISO-8859-1 Cc: Jeremy Kerr , linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, Jan 9, 2010 at 4:01 AM, Alexey Dobriyan wrote: > On Thu, Jan 07, 2010 at 01:19:13PM +1100, Jeremy Kerr wrote: >> Commit e22f628395432b967f2f505858c64450f7835365 introduced a build >> breakage for ARM devtree work: the THIS_MODULE macro was added, but we >> don't have module.h >> >> This change adds the necessary #include to get THIS_MODULE defined. >> While we could just replace it with NULL (PROC_FS is a bool, not a >> tristate), using THIS_MODULE will prevent unexpected breakage if we >> ever do compile this as a module. > > I'd say, remove .owner line. > It definitely not needed in non-modular code. No. Jeremy's fix is the better one. Having the .owner line doesn't cost anything and it is better to have it populated; even if only as an example. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.