linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab.ca>
To: michal.simek@petalogix.com
Cc: Arnd Bergmann <arnd@arndb.de>,
	thunderbird2k@gmx.net, LKML <linux-kernel@vger.kernel.org>,
	linuxppc-dev@ozlabs.org,
	John Williams <john.williams@petalogix.com>
Subject: Re: xilinx-pci driver and pci in general
Date: Mon, 18 Jan 2010 10:36:07 -0700	[thread overview]
Message-ID: <fa686aa41001180936p1fd34dd4pdf675583ce5ccd86@mail.gmail.com> (raw)
In-Reply-To: <4B4DE58D.10008@petalogix.com>

On Wed, Jan 13, 2010 at 8:23 AM, Michal Simek
<michal.simek@petalogix.com> wrote:
> Hi guys,
>
> We (John and partially I) did initial support for pci on Microblaze.
> It is based on powerpc files and almost everything is the same.
> There are some small differences which could be easily removed that's why I
> think that will be good to move that file to any generic location.
> That's why I would like to know your opinion about this step.
> If you don't like or prefer we will add that modified versions to
> arch/microblaze and in future we can merge them and move to any other
> location.
>
> Affected files: xilinx-pci.c, pci_32.c pci-common.c, indirect_pci.c and some
> headers.

My preference is to move the common bits to a common location first,
and then modify to make it suitable for Microblaze also.  I've just
finished doing a bunch of fdt merge work where PowerPC and Microblaze
diverged in subtle ways.  It isn't a whole lot of fun.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

      parent reply	other threads:[~2010-01-18 17:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-13 15:23 xilinx-pci driver and pci in general Michal Simek
2010-01-14  2:07 ` Benjamin Herrenschmidt
2010-01-15  9:23   ` Michal Simek
2010-01-18 17:39     ` Grant Likely
2010-01-18 17:38   ` Grant Likely
2010-01-18 17:36 ` Grant Likely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa686aa41001180936p1fd34dd4pdf675583ce5ccd86@mail.gmail.com \
    --to=grant.likely@secretlab.ca \
    --cc=arnd@arndb.de \
    --cc=john.williams@petalogix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=michal.simek@petalogix.com \
    --cc=thunderbird2k@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).