From: Grant Likely <grant.likely@secretlab.ca>
To: Anatolij Gustschin <agust@denx.de>
Cc: wd@denx.de, dzu@denx.de, linuxppc-dev@ozlabs.org,
linux-i2c@vger.kernel.org, Piotr Ziecik <kosmo@semihalf.com>
Subject: Re: [PATCH 04/11] i2c-mpc: Add MPC5121 I2C bus support
Date: Thu, 21 Jan 2010 10:12:17 -0700 [thread overview]
Message-ID: <fa686aa41001210912r5fd2a5a4g8a072e0c41ee4107@mail.gmail.com> (raw)
In-Reply-To: <1263932653-3634-5-git-send-email-agust@denx.de>
On Tue, Jan 19, 2010 at 1:24 PM, Anatolij Gustschin <agust@denx.de> wrote:
> From: Piotr Ziecik <kosmo@semihalf.com>
>
> =A0 =A0- Update Kconfig for i2c-mpc driver.
> =A0 =A0- Enable I2C interrupts on MPC5121.
>
> diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c
> index f627001..84eeb25 100644
> --- a/drivers/i2c/busses/i2c-mpc.c
> +++ b/drivers/i2c/busses/i2c-mpc.c
> @@ -540,6 +540,29 @@ static int __devinit fsl_i2c_probe(struct of_device =
*op,
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0}
> =A0 =A0 =A0 =A0}
>
> + =A0 =A0 =A0 if (of_device_is_compatible(op->node, "fsl,mpc5121-i2c")) {
Rather than doing stuff like this with explicit compatible checks in
the probe hook, consider using the .data pointer in the of match
table.
g.
--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2010-01-21 17:12 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 20:24 [PATCH 0/11] Update support for MPC512x Anatolij Gustschin
2010-01-19 20:24 ` [PATCH 01/11] fs_enet: Add support for MPC512x to fs_enet driver Anatolij Gustschin
2010-01-19 20:48 ` Scott Wood
2010-01-20 11:20 ` Anatolij Gustschin
2010-01-20 17:02 ` Scott Wood
2010-01-19 20:24 ` [PATCH 02/11] fs_enet: Add FEC TX Alignment workaround for MPC5121 Anatolij Gustschin
2010-01-19 20:37 ` David Miller
2010-01-19 23:42 ` Stephen Rothwell
2010-01-20 4:04 ` David Miller
2010-01-20 10:22 ` Wolfram Sang
2010-01-19 20:24 ` [PATCH 03/11] powerpc/mpc5121: Add machine restart support Anatolij Gustschin
2010-01-20 11:28 ` Wolfram Sang
2010-01-26 7:53 ` Anatolij Gustschin
2010-01-19 20:24 ` [PATCH 04/11] i2c-mpc: Add MPC5121 I2C bus support Anatolij Gustschin
2010-01-21 17:12 ` Grant Likely [this message]
2010-01-22 12:15 ` Wolfgang Grandegger
2010-01-19 20:24 ` [PATCH 05/11] rtc: Add MPC5121 Real time clock driver Anatolij Gustschin
2010-01-20 11:01 ` Wolfram Sang
2010-01-20 22:19 ` [rtc-linux] " Alessandro Zummo
2010-01-19 20:24 ` [PATCH 06/11] mtd: Add MPC5121 NAND Flash Controller driver Anatolij Gustschin
2010-01-20 10:49 ` Wolfram Sang
2010-01-25 15:56 ` Anatolij Gustschin
2010-01-19 20:24 ` [PATCH 07/11] dma: Add MPC512x DMA driver Anatolij Gustschin
2010-01-21 17:22 ` Grant Likely
2010-01-26 8:03 ` Anatolij Gustschin
2010-01-19 20:24 ` [PATCH 08/11] powerpc/mpc5121: add USB host support Anatolij Gustschin
2010-01-21 17:43 ` Grant Likely
2010-01-25 17:00 ` Anatolij Gustschin
2010-01-27 16:52 ` Grant Likely
2010-01-19 20:24 ` [PATCH 09/11] powerpc/mpc512x: shared DIU framebuffer support Anatolij Gustschin
2010-01-19 20:24 ` [PATCH 10/11] powerpc/mpc5121: update mpc5121ads DTS Anatolij Gustschin
2010-01-19 20:24 ` [PATCH 11/11] powerpc/mpc5121: Add default config for MPC5121ADS Anatolij Gustschin
2010-01-21 17:47 ` Grant Likely
2010-01-20 11:22 ` [PATCH 0/11] Update support for MPC512x Wolfram Sang
2010-01-26 8:06 ` Anatolij Gustschin
2010-01-26 12:16 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa41001210912r5fd2a5a4g8a072e0c41ee4107@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=agust@denx.de \
--cc=dzu@denx.de \
--cc=kosmo@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).