From: Grant Likely <grant.likely@secretlab.ca>
To: Anatolij Gustschin <agust@denx.de>
Cc: linuxppc-dev@ozlabs.org, linux-usb@vger.kernel.org,
Bruce Schmid <duck@freescale.com>,
wd@denx.de, dzu@denx.de
Subject: Re: [PATCH 5/8 v2] powerpc/mpc5121: add USB host support
Date: Wed, 27 Jan 2010 09:54:36 -0700 [thread overview]
Message-ID: <fa686aa41001270854m2e52a19eoa4361809231f53a@mail.gmail.com> (raw)
In-Reply-To: <1264594052-20317-6-git-send-email-agust@denx.de>
On Wed, Jan 27, 2010 at 5:07 AM, Anatolij Gustschin <agust@denx.de> wrote:
> Platform specific code for MPC5121 USB Host support.
> MPC5121 Rev 2.0 silicon EHCI registers are big endian.
> Add appropriate support by specifying "fsl,big-endian-regs"
> property in device tree node for USB controller. Also
> allow specifying DRVVBUS and PWR_FAULT signal polarity
> of the MPC5121 internal PHY using "fsl,invert-drvvbus" and
> "fsl,invert-pwr-fault" properties.
[...]
> --- a/Documentation/powerpc/dts-bindings/fsl/usb.txt
> +++ b/Documentation/powerpc/dts-bindings/fsl/usb.txt
> @@ -33,6 +33,14 @@ Recommended properties :
> =A0- interrupt-parent : the phandle for the interrupt controller that
> =A0 =A0services interrupts for this device.
>
> +Optional properties :
> + - fsl,big-endian-regs : boolean; if defined, indicates the USB host
> + =A0 controller registers format is big endian.
As commented in previous thread, this property should be dropped, and
the driver should test for fsl,mpc5121-usb2-dr directly. fsl-usb2-dr
should also be dropped from the compatible list of the .dts file.
g.
next prev parent reply other threads:[~2010-01-27 16:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-27 12:07 [PATCH 0/8] Update support for MPC512x Anatolij Gustschin
2010-01-27 12:07 ` [PATCH 1/8 v2] powerpc/mpc5121: Add machine restart support Anatolij Gustschin
2010-01-27 15:46 ` Grant Likely
2010-01-27 12:07 ` [PATCH 2/8 v2] rtc: Add MPC5121 Real time clock driver Anatolij Gustschin
2010-01-27 15:58 ` Grant Likely
2010-01-27 12:07 ` [PATCH 3/8 v2] mtd: Add MPC5121 NAND Flash Controller driver Anatolij Gustschin
2010-01-27 16:43 ` Grant Likely
2010-01-27 20:24 ` Wolfgang Denk
2010-01-27 12:07 ` [PATCH 4/8 v2] dma: Add MPC512x DMA driver Anatolij Gustschin
2010-01-27 12:07 ` [PATCH 5/8 v2] powerpc/mpc5121: add USB host support Anatolij Gustschin
2010-01-27 12:36 ` Jan Andersson
2010-01-27 15:45 ` Anatolij Gustschin
2010-01-27 16:54 ` Grant Likely [this message]
2010-01-27 12:07 ` [PATCH 6/8 v2] powerpc/mpc5121: shared DIU framebuffer support Anatolij Gustschin
2010-01-27 12:07 ` [PATCH 7/8 v2] powerpc/mpc5121: update mpc5121ads DTS Anatolij Gustschin
2010-01-27 12:07 ` [PATCH 8/8 v2] powerpc/mpc5121: Add default config for MPC5121 Anatolij Gustschin
2010-01-27 14:23 ` [PATCH 0/8] Update support for MPC512x Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa41001270854m2e52a19eoa4361809231f53a@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=agust@denx.de \
--cc=duck@freescale.com \
--cc=dzu@denx.de \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).