From: Grant Likely <grant.likely@secretlab.ca>
To: Anatolij Gustschin <agust@denx.de>
Cc: linuxppc-dev@ozlabs.org, wd@denx.de, dzu@denx.de
Subject: Re: [PATCH 1/3] serial: mpc52xx_uart: re-enable mpc5121 PSC UART support
Date: Tue, 9 Feb 2010 09:13:03 -0700 [thread overview]
Message-ID: <fa686aa41002090813j525cdd4dm8950232a5efefd13@mail.gmail.com> (raw)
In-Reply-To: <1265096864-3506-2-git-send-email-agust@denx.de>
On Tue, Feb 2, 2010 at 12:47 AM, Anatolij Gustschin <agust@denx.de> wrote:
> Currently the support for MPC5121 PSC UART in the mpc52xx_uart
> driver is broken (only console pre-initialized by the bootloader
> works). Re-enable it now by providing MPC5121 specific ops
> for PSCx clock activation, FIFO controller init/uninit and
> MPC5121 PSC FIFO shared interrupt handling functions.
>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> ---
> This patch has been tested using 5200/5121 multiplatform kernel
> on tqm5200 and mpc5121ads boards (mpc52xx_uart staticaly linked
> and as a driver module).
>
> @@ -1164,7 +1378,8 @@ mpc52xx_uart_of_probe(struct of_device *op, const s=
truct of_device_id *match)
> =A0 =A0 =A0 =A0/* Add the port to the uart sub-system */
> =A0 =A0 =A0 =A0ret =3D uart_add_one_port(&mpc52xx_uart_driver, port);
> =A0 =A0 =A0 =A0if (ret) {
> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 irq_dispose_mapping(port->irq);
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (!(port->irqflags & IRQF_SHARED))
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 irq_dispose_mapping(port->i=
rq);
I'd just drop the irq_dispose_mapping() entirely. It doesn't really
cost anything to leave the mapping around when unloading the driver.
Otherwise, looks good to me. You can add my acked-by in the next spin.
g.
next prev parent reply other threads:[~2010-02-09 16:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-02 7:47 [PATCH 0/3] powerpc: mpc5121: PSC UART support Anatolij Gustschin
2010-02-02 7:47 ` [PATCH 1/3] serial: mpc52xx_uart: re-enable mpc5121 " Anatolij Gustschin
2010-02-09 16:13 ` Grant Likely [this message]
2010-02-02 7:47 ` [PATCH 2/3] powerpc: doc/dts-bindings: document mpc5121 psc uart dts-bindings Anatolij Gustschin
2010-02-09 16:15 ` Grant Likely
2010-02-02 7:47 ` [PATCH 3/3] powerpc: mpc5121: enable support for more PSC UARTs Anatolij Gustschin
2010-02-09 16:20 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa41002090813j525cdd4dm8950232a5efefd13@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=agust@denx.de \
--cc=dzu@denx.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).