From: Grant Likely <grant.likely@secretlab.ca>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: Michal Simek <monstr@monstr.eu>,
David Brownell <dbrownell@users.sourceforge.net>,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
microblaze-uclinux@itee.uq.edu.au,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH 2/3] of: Introduce safe accessors for node->data
Date: Tue, 9 Feb 2010 10:25:22 -0700 [thread overview]
Message-ID: <fa686aa41002090925q30f362d6x4d14894a72439125@mail.gmail.com> (raw)
In-Reply-To: <20100205205043.GB4178@oksana.dev.rtsoft.ru>
On Fri, Feb 5, 2010 at 1:50 PM, Anton Vorontsov
<avorontsov@ru.mvista.com> wrote:
> Platform code use node->data to store some private information
> associated with a node.
>
> Previously there was no need for any locks and accessors since we were
> initializing the data mostly at boot time and never modified it later.
>
> Though, nowadays OF GPIO infrastructure supports GPIO chips detaching,
> so to handle this correctly we have to introduce locking for the
> node->data field.
I'm not convinced this is needed. What's wrong with using the
whole-tree devtree_lock?
g.
next prev parent reply other threads:[~2010-02-09 17:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-05 20:49 [PATCH RFC 0/3] Implement refcounting for OF GPIO chips Anton Vorontsov
2010-02-05 20:50 ` [PATCH 1/3] of platforms: Move common static initialization to of_node_init() Anton Vorontsov
2010-02-09 17:22 ` Grant Likely
2010-02-05 20:50 ` [PATCH 2/3] of: Introduce safe accessors for node->data Anton Vorontsov
2010-02-09 17:25 ` Grant Likely [this message]
2010-02-09 19:10 ` Anton Vorontsov
2010-02-05 20:50 ` [PATCH 3/3] of/gpio: Introduce of_put_gpio(), add ref counting for OF GPIO chips Anton Vorontsov
2010-02-09 9:15 ` Michal Simek
2010-02-09 9:20 ` Michal Simek
2010-02-09 17:28 ` Grant Likely
2010-02-09 19:14 ` Anton Vorontsov
2010-02-15 19:49 ` Grant Likely
2010-02-15 20:59 ` Anton Vorontsov
2010-02-09 9:40 ` [PATCH RFC 0/3] Implement refcounting " Michal Simek
2010-02-09 17:29 ` Grant Likely
2010-02-09 19:06 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa41002090925q30f362d6x4d14894a72439125@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=avorontsov@ru.mvista.com \
--cc=davem@davemloft.net \
--cc=dbrownell@users.sourceforge.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=microblaze-uclinux@itee.uq.edu.au \
--cc=monstr@monstr.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).