From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 Sender: glikely@secretlab.ca In-Reply-To: References: <27bab769-0788-4b48-96a7-ced65e40144c@SG2EHSMHS007.ehs.local> From: Grant Likely Date: Fri, 26 Feb 2010 17:17:47 -0700 Message-ID: Subject: Re: Proposal to move PCI out of arch/powerpc and into drivers/of To: Kumar Gala Content-Type: text/plain; charset=ISO-8859-1 Cc: devicetree-discuss@ozlabs.org, michal.simek@petalogix.com, microblaze-uclinux@itee.uq.edu.au, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, John Linn , John Williams List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Feb 26, 2010 at 4:50 PM, Kumar Gala wro= te: > > On Feb 26, 2010, at 5:07 PM, John Linn wrote: > >> Hi all, >> >> We are in the process of putting PCI/PCIe into the microblaze >> architecture. >> >> In order to not duplicate/fork the PCI code in Powerpc, we're proposing >> to move the PCI code from arch/powerpc into drivers/of such that it >> would be common code for Powerpc and MicroBlaze. >> >> This would be the 1st part of a refactoring that would occur with the >> PCI code. >> >> Ben H., would you mind if that happened (move arch/powerpc/kernel/pci* >> to drivers/of/*)? >> >> Thanks, >> John > > John, > > Does MicroBlaze firmware produce full OF style PCI device tree's or do wh= at we do on embedded systems and just have the root and leave the probing t= o the kernel? Mostly like we do on ppc embedded. Let the kernel do the probing. I'm also going to want to be able to do the same think on ARM, so I also would like to make the code common. > =A0I haven't looked at the OF side of what we do in PPC in a while but I = know we have some major differences between PPC32 & PPC64 because of assump= tions about what the firmware provides (or doesnt). I'm not too worried about this. I did some work on ppc32 to allow both probing and static PCI device definition on the same bus segment (although I didn't get all of it merged). There are difference between ppc32 & ppc64, but it seemed to me that the divergence was more just a matter of convenience rather than any particular technical hurdles preventing a common approach. I think the 32 and 64 bit paths can be mostly merged. g.