From: Grant Likely <grant.likely@secretlab.ca>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, Feng Kan <fkan@amcc.com>,
Tirumala R Marri <tmarri@appliedmicro.com>,
Feng Kan <fkan@appliedmicro.com>
Subject: Re: [PATCH] fix the problem where pcix node is probed again as pci node.
Date: Tue, 30 Mar 2010 16:28:06 -0600 [thread overview]
Message-ID: <fa686aa41003301528w36550e40j417bedfae7da3de@mail.gmail.com> (raw)
In-Reply-To: <1269983680.7101.53.camel@pasglop>
On Tue, Mar 30, 2010 at 3:14 PM, Benjamin Herrenschmidt
<benh@kernel.crashing.org> wrote:
> On Wed, 2010-03-31 at 07:48 +1100, Benjamin Herrenschmidt wrote:
>> On Tue, 2010-03-30 at 10:41 -0700, Feng Kan wrote:
>> > From: Feng Kan <fkan@appliedmicro.com>
>> >
>> > The current matching scheme make the pci node match to pcix or pciex node.
>> > To avoid the match, change the method so only one type of initialization
>> > is called per node.
>>
>> No, your patch is not right. The problem was introduced by a patch from
>> Grant that incorrectly made of_device_is_compatible do a substring
>> match. Grant should have fixed that now. Grant ? Is your fix upstream
>> yet ? If not, can you send that ASAP ?
>
> Better if I CC him too :-)
The fix is in upstream. Commit 1976152fd8e706135deed6cf333e347c08416056
g.
prev parent reply other threads:[~2010-03-30 22:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 17:41 [PATCH] fix the problem where pcix node is probed again as pci node Feng Kan
2010-03-30 20:48 ` Benjamin Herrenschmidt
2010-03-30 21:14 ` Benjamin Herrenschmidt
2010-03-30 22:02 ` Feng Kan
2010-03-30 22:28 ` Benjamin Herrenschmidt
2010-03-30 22:28 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa41003301528w36550e40j417bedfae7da3de@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=benh@kernel.crashing.org \
--cc=fkan@amcc.com \
--cc=fkan@appliedmicro.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=tmarri@appliedmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).