From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-x243.google.com (mail-pa0-x243.google.com [IPv6:2607:f8b0:400e:c03::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3sD2DQ2zplzDr45 for ; Tue, 16 Aug 2016 16:16:06 +1000 (AEST) Received: by mail-pa0-x243.google.com with SMTP id cf3so4740028pad.2 for ; Mon, 15 Aug 2016 23:16:06 -0700 (PDT) Subject: Re: [PATCH v5 02/13] kexec_file: Change kexec_add_buffer to take kexec_buf as argument. To: Thiago Jung Bauermann References: <1470956898-5991-1-git-send-email-bauerman@linux.vnet.ibm.com> <1470956898-5991-3-git-send-email-bauerman@linux.vnet.ibm.com> <20160815073049.GB21080@balbir.ozlabs.ibm.com> <1906561.y8blzB2uZ8@hactar> Cc: kexec@lists.infradead.org, Stewart Smith , Baoquan He , linuxppc-dev@lists.ozlabs.org, x86@kernel.org, "H. Peter Anvin" , linux-kernel@vger.kernel.org, Ingo Molnar , Paul Mackerras , Eric Biederman , Thomas Gleixner , Dave Young , Andrew Morton , Vivek Goyal From: Balbir Singh Message-ID: Date: Tue, 16 Aug 2016 16:15:55 +1000 MIME-Version: 1.0 In-Reply-To: <1906561.y8blzB2uZ8@hactar> Content-Type: text/plain; charset=windows-1252 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 16/08/16 00:49, Thiago Jung Bauermann wrote: > Am Montag, 15 August 2016, 17:30:49 schrieb Balbir Singh: >> On Thu, Aug 11, 2016 at 08:08:07PM -0300, Thiago Jung Bauermann wrote: >>> Adapt all callers to the new function prototype. >> >> Could you please expand on this? > > Is the following better? > > Adapt all callers to set up a kexec_buf to pass to kexec_add_buffer. Yes and the reason for doing so? Consolidation/clarity of implementation? > >> Looks good otherwise >> >> Acked-by: Balbir Singh > > Thank you for reviewing this series! >