From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>
Cc: linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Bartosz Golaszewski <brgl@kernel.org>,
Herve Codina <herve.codina@bootlin.com>,
Paul Louvel <paul.louvel@bootlin.com>
Subject: Re: [PATCH] soc: fsl: qe: properly scan GPIO nodes at startup
Date: Thu, 30 Jul 2026 13:15:25 +0200 [thread overview]
Message-ID: <fb520f00-1331-4136-8421-d82bdd46c48a@kernel.org> (raw)
In-Reply-To: <178539922190.574381.1359588018451529893.b4-ty@kernel.org>
On 30/07/2026 10:14, Christophe Leroy (CS GROUP) wrote:
>
> On Wed, 29 Jul 2026 16:10:36 +0200, Christophe Leroy (CS GROUP) wrote:
>> Before commit 156460811def ("soc: fsl: qe: Change GPIO driver to a
>> proper platform driver") qe_add_gpiochips() was walking the device
>> tree to find all nodes with compatible "fsl,mpc8323-qe-pario-bank".
>>
>> After that commit the discovery is handled by the platform core,
>> therefore it is necessary to call of_platform_default_populate() on
>> the par_io node.
>>
>> [...]
>
> Applied, thanks!
>
> [1/1] soc: fsl: qe: properly scan GPIO nodes at startup
> commit: cf91e5909e620b77164b53c9b316a5c1f11f9ea7
You left very little time to respond to this - one day - and introduced
undocumented disallowed ABI. Please drop the patch. I will be objecting
to the entire pull request.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-07-30 11:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 14:10 [PATCH] soc: fsl: qe: properly scan GPIO nodes at startup Christophe Leroy (CS GROUP)
2026-07-29 15:14 ` Bartosz Golaszewski
2026-07-29 15:21 ` Herve Codina
2026-07-30 8:11 ` Christophe Leroy (CS GROUP)
2026-07-30 9:29 ` Herve Codina
2026-07-30 8:14 ` Christophe Leroy (CS GROUP)
2026-07-30 11:15 ` Krzysztof Kozlowski [this message]
2026-07-30 12:04 ` Christophe Leroy (CS GROUP)
2026-07-30 12:09 ` Bartosz Golaszewski
2026-07-30 11:14 ` Krzysztof Kozlowski
2026-07-30 12:01 ` Christophe Leroy (CS GROUP)
2026-07-30 12:05 ` Krzysztof Kozlowski
2026-07-30 12:14 ` Christophe Leroy (CS GROUP)
2026-07-30 12:15 ` Krzysztof Kozlowski
2026-07-30 12:27 ` Christophe Leroy (CS GROUP)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb520f00-1331-4136-8421-d82bdd46c48a@kernel.org \
--to=krzk@kernel.org \
--cc=brgl@kernel.org \
--cc=chleroy@kernel.org \
--cc=herve.codina@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paul.louvel@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox