From: Kumar Gala <kumar.gala@freescale.com>
To: "Allen Curtis" <acurtis@onz.com>
Cc: linuxppc-embedded <linuxppc-embedded@ozlabs.org>
Subject: Re: RFC: cpm2_devices.c
Date: Wed, 15 Jun 2005 09:29:39 -0500 [thread overview]
Message-ID: <fd3c79c765947d1c1ab4af33e463850a@freescale.com> (raw)
In-Reply-To: <c2628642aad8b8107d0e9db84535ea0c@onz.com>
>> I'm trying to stay away from basing things on the structure. Since
>> the offsets are truly fixed I see not reason to try to make sure that
>> the immap structure is always correct for all cases. Hopefully this
>> will end up removing the need to ifdef the immap structure as we go
>> forward.
>>
>
> I am not sure I understand the purpose of each access method. How is
> the immap structure used vs. the platform resources list? Going half
> way without a clear distinction of purpose will just confuse the
> matter. (my opinion)
Agreed, I guess what I mean is going forward drivers should contain
their own structure defn.
>> pq2_* instead of mpc82xx_ (8240/1/5 is not handled here) or cpm2_
>> (85xx has cpm2).
>
> I used the name CPM2 because that is how all the files are now renamed.
> Based on the #ifdef in your patch, you can see that 82xx and 83xx use
> the same device definitions. Lets change the name.
Sure but... I'll change the file names to pq2_ which is what makes the
most sense at the end of they.
- kumar
next prev parent reply other threads:[~2005-06-15 14:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-14 18:18 RFC: cpm2_devices.c Allen Curtis
2005-06-15 3:35 ` Kumar Gala
2005-06-15 3:57 ` Allen Curtis
2005-06-15 4:13 ` Kumar Gala
2005-06-15 4:41 ` Allen Curtis
2005-06-15 14:24 ` Jason McMullan
2005-06-15 15:06 ` Kumar Gala
2005-06-15 17:48 ` Allen Curtis
2005-06-15 18:05 ` Vitaly Bordug
2005-06-15 14:29 ` Kumar Gala [this message]
2005-06-15 14:30 ` Kumar Gala
2005-06-16 15:12 ` Dan Malek
2005-06-16 15:33 ` Kumar Gala
2005-06-16 15:42 ` Allen Curtis
2005-06-16 15:53 ` Kumar Gala
2005-06-16 16:39 ` Allen Curtis
2005-06-16 19:33 ` Dan Malek
2005-06-15 7:55 ` Vitaly Bordug
2005-06-15 14:25 ` Kumar Gala
2005-06-15 14:33 ` Jason McMullan
2005-06-15 15:01 ` Kumar Gala
2005-06-15 15:31 ` Vitaly Bordug
2005-06-15 15:41 ` Kumar Gala
2005-06-15 16:07 ` Vitaly Bordug
2005-06-16 6:42 ` Pantelis Antoniou
2005-06-16 9:33 ` Wolfgang Denk
2005-06-16 15:02 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd3c79c765947d1c1ab4af33e463850a@freescale.com \
--to=kumar.gala@freescale.com \
--cc=acurtis@onz.com \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).