* Re: linux-next: Tree for Sep 20 (ppc32: ADB_CUDA Kconfig warning)
[not found] <20230920133714.351f83f9@canb.auug.org.au>
@ 2023-09-20 15:52 ` Randy Dunlap
2023-09-22 0:10 ` Michael Ellerman
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2023-09-20 15:52 UTC (permalink / raw)
To: Stephen Rothwell, Linux Next Mailing List
Cc: linuxppc-dev, Linux Kernel Mailing List, Nicholas Piggin
[-- Attachment #1: Type: text/plain, Size: 1273 bytes --]
On 9/19/23 20:37, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20230919:
>
> The mm tree lost its boot warning.
>
> The drm-misc tree gained a conflict against Linus' tree.
>
> Non-merge commits (relative to Linus' tree): 6006
> 3996 files changed, 459968 insertions(+), 111742 deletions(-)
>
> ----------------------------------------------------------------------------
4 out of 10 randconfigs have this warning:
WARNING: unmet direct dependencies detected for ADB_CUDA
Depends on [n]: MACINTOSH_DRIVERS [=n] && (ADB [=n] || PPC_PMAC [=y]) && !PPC_PMAC64 [=n]
Selected by [y]:
- PPC_PMAC [=y] && PPC_BOOK3S [=y] && CPU_BIG_ENDIAN [=y] && POWER_RESET [=y] && PPC32 [=y]
WARNING: unmet direct dependencies detected for ADB_CUDA
Depends on [n]: MACINTOSH_DRIVERS [=n] && (ADB [=n] || PPC_PMAC [=y]) && !PPC_PMAC64 [=n]
Selected by [y]:
- PPC_PMAC [=y] && PPC_BOOK3S [=y] && CPU_BIG_ENDIAN [=y] && POWER_RESET [=y] && PPC32 [=y]
WARNING: unmet direct dependencies detected for ADB_CUDA
Depends on [n]: MACINTOSH_DRIVERS [=n] && (ADB [=n] || PPC_PMAC [=y]) && !PPC_PMAC64 [=n]
Selected by [y]:
- PPC_PMAC [=y] && PPC_BOOK3S [=y] && CPU_BIG_ENDIAN [=y] && POWER_RESET [=y] && PPC32 [=y]
One failing randconfig file is attached.
--
~Randy
[-- Attachment #2: config-r7483.gz --]
[-- Type: application/gzip, Size: 30171 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: Tree for Sep 20 (ppc32: ADB_CUDA Kconfig warning)
2023-09-20 15:52 ` linux-next: Tree for Sep 20 (ppc32: ADB_CUDA Kconfig warning) Randy Dunlap
@ 2023-09-22 0:10 ` Michael Ellerman
2023-09-22 4:51 ` Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Michael Ellerman @ 2023-09-22 0:10 UTC (permalink / raw)
To: Randy Dunlap, Stephen Rothwell, Linux Next Mailing List, tanyuan
Cc: linuxppc-dev, Linux Kernel Mailing List, Nicholas Piggin
Randy Dunlap <rdunlap@infradead.org> writes:
> On 9/19/23 20:37, Stephen Rothwell wrote:
>> Hi all,
>>
>> Changes since 20230919:
>>
>> The mm tree lost its boot warning.
>>
>> The drm-misc tree gained a conflict against Linus' tree.
>>
>> Non-merge commits (relative to Linus' tree): 6006
>> 3996 files changed, 459968 insertions(+), 111742 deletions(-)
>>
>> ----------------------------------------------------------------------------
>
> 4 out of 10 randconfigs have this warning:
>
> WARNING: unmet direct dependencies detected for ADB_CUDA
> Depends on [n]: MACINTOSH_DRIVERS [=n] && (ADB [=n] || PPC_PMAC [=y]) && !PPC_PMAC64 [=n]
> Selected by [y]:
> - PPC_PMAC [=y] && PPC_BOOK3S [=y] && CPU_BIG_ENDIAN [=y] && POWER_RESET [=y] && PPC32 [=y]
>
> WARNING: unmet direct dependencies detected for ADB_CUDA
> Depends on [n]: MACINTOSH_DRIVERS [=n] && (ADB [=n] || PPC_PMAC [=y]) && !PPC_PMAC64 [=n]
> Selected by [y]:
> - PPC_PMAC [=y] && PPC_BOOK3S [=y] && CPU_BIG_ENDIAN [=y] && POWER_RESET [=y] && PPC32 [=y]
>
> WARNING: unmet direct dependencies detected for ADB_CUDA
> Depends on [n]: MACINTOSH_DRIVERS [=n] && (ADB [=n] || PPC_PMAC [=y]) && !PPC_PMAC64 [=n]
> Selected by [y]:
> - PPC_PMAC [=y] && PPC_BOOK3S [=y] && CPU_BIG_ENDIAN [=y] && POWER_RESET [=y] && PPC32 [=y]
Crud. Caused by:
a3ef2fef198c ("powerpc/32: Add dependencies of POWER_RESET for pmac32")
I was suspicious of that select, I should have been *more* suspicious :)
I think this is a fix. The PPC32 isn't needed because ADB depends on (PPC_PMAC && PPC32).
diff --git a/arch/powerpc/platforms/powermac/Kconfig b/arch/powerpc/platforms/powermac/Kconfig
index 8bdae0caf21e..84f101ec53a9 100644
--- a/arch/powerpc/platforms/powermac/Kconfig
+++ b/arch/powerpc/platforms/powermac/Kconfig
@@ -2,7 +2,7 @@
config PPC_PMAC
bool "Apple PowerMac based machines"
depends on PPC_BOOK3S && CPU_BIG_ENDIAN
- select ADB_CUDA if POWER_RESET && PPC32
+ select ADB_CUDA if POWER_RESET && ADB
select MPIC
select FORCE_PCI
select PPC_INDIRECT_PCI if PPC32
cheers
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: linux-next: Tree for Sep 20 (ppc32: ADB_CUDA Kconfig warning)
2023-09-22 0:10 ` Michael Ellerman
@ 2023-09-22 4:51 ` Randy Dunlap
2023-10-07 17:32 ` Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2023-09-22 4:51 UTC (permalink / raw)
To: Michael Ellerman, Stephen Rothwell, Linux Next Mailing List,
tanyuan
Cc: linuxppc-dev, Linux Kernel Mailing List, Nicholas Piggin
On 9/21/23 17:10, Michael Ellerman wrote:
> Randy Dunlap <rdunlap@infradead.org> writes:
>> On 9/19/23 20:37, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20230919:
>>>
>>> The mm tree lost its boot warning.
>>>
>>> The drm-misc tree gained a conflict against Linus' tree.
>>>
>>> Non-merge commits (relative to Linus' tree): 6006
>>> 3996 files changed, 459968 insertions(+), 111742 deletions(-)
>>>
>>> ----------------------------------------------------------------------------
>>
>> 4 out of 10 randconfigs have this warning:
>>
>> WARNING: unmet direct dependencies detected for ADB_CUDA
>> Depends on [n]: MACINTOSH_DRIVERS [=n] && (ADB [=n] || PPC_PMAC [=y]) && !PPC_PMAC64 [=n]
>> Selected by [y]:
>> - PPC_PMAC [=y] && PPC_BOOK3S [=y] && CPU_BIG_ENDIAN [=y] && POWER_RESET [=y] && PPC32 [=y]
>>
>> WARNING: unmet direct dependencies detected for ADB_CUDA
>> Depends on [n]: MACINTOSH_DRIVERS [=n] && (ADB [=n] || PPC_PMAC [=y]) && !PPC_PMAC64 [=n]
>> Selected by [y]:
>> - PPC_PMAC [=y] && PPC_BOOK3S [=y] && CPU_BIG_ENDIAN [=y] && POWER_RESET [=y] && PPC32 [=y]
>>
>> WARNING: unmet direct dependencies detected for ADB_CUDA
>> Depends on [n]: MACINTOSH_DRIVERS [=n] && (ADB [=n] || PPC_PMAC [=y]) && !PPC_PMAC64 [=n]
>> Selected by [y]:
>> - PPC_PMAC [=y] && PPC_BOOK3S [=y] && CPU_BIG_ENDIAN [=y] && POWER_RESET [=y] && PPC32 [=y]
>
> Crud. Caused by:
>
> a3ef2fef198c ("powerpc/32: Add dependencies of POWER_RESET for pmac32")
>
> I was suspicious of that select, I should have been *more* suspicious :)
>
> I think this is a fix. The PPC32 isn't needed because ADB depends on (PPC_PMAC && PPC32).
Yes, that fixes the problem. Thanks.
Tested-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
>
> diff --git a/arch/powerpc/platforms/powermac/Kconfig b/arch/powerpc/platforms/powermac/Kconfig
> index 8bdae0caf21e..84f101ec53a9 100644
> --- a/arch/powerpc/platforms/powermac/Kconfig
> +++ b/arch/powerpc/platforms/powermac/Kconfig
> @@ -2,7 +2,7 @@
> config PPC_PMAC
> bool "Apple PowerMac based machines"
> depends on PPC_BOOK3S && CPU_BIG_ENDIAN
> - select ADB_CUDA if POWER_RESET && PPC32
> + select ADB_CUDA if POWER_RESET && ADB
> select MPIC
> select FORCE_PCI
> select PPC_INDIRECT_PCI if PPC32
>
> cheers
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: Tree for Sep 20 (ppc32: ADB_CUDA Kconfig warning)
2023-09-22 4:51 ` Randy Dunlap
@ 2023-10-07 17:32 ` Randy Dunlap
0 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2023-10-07 17:32 UTC (permalink / raw)
To: Michael Ellerman, Stephen Rothwell, Linux Next Mailing List,
tanyuan
Cc: linuxppc-dev, Linux Kernel Mailing List, Nicholas Piggin
Hi Michael,
On 9/21/23 21:51, Randy Dunlap wrote:
>
>
> On 9/21/23 17:10, Michael Ellerman wrote:
>> Randy Dunlap <rdunlap@infradead.org> writes:
>>> On 9/19/23 20:37, Stephen Rothwell wrote:
>>>> Hi all,
>>>>
>>>> Changes since 20230919:
>>>>
>>>> The mm tree lost its boot warning.
>>>>
>>>> The drm-misc tree gained a conflict against Linus' tree.
>>>>
>>>> Non-merge commits (relative to Linus' tree): 6006
>>>> 3996 files changed, 459968 insertions(+), 111742 deletions(-)
>>>>
>>>> ----------------------------------------------------------------------------
>>>
>>> 4 out of 10 randconfigs have this warning:
>>>
>>> WARNING: unmet direct dependencies detected for ADB_CUDA
>>> Depends on [n]: MACINTOSH_DRIVERS [=n] && (ADB [=n] || PPC_PMAC [=y]) && !PPC_PMAC64 [=n]
>>> Selected by [y]:
>>> - PPC_PMAC [=y] && PPC_BOOK3S [=y] && CPU_BIG_ENDIAN [=y] && POWER_RESET [=y] && PPC32 [=y]
>>>
>>> WARNING: unmet direct dependencies detected for ADB_CUDA
>>> Depends on [n]: MACINTOSH_DRIVERS [=n] && (ADB [=n] || PPC_PMAC [=y]) && !PPC_PMAC64 [=n]
>>> Selected by [y]:
>>> - PPC_PMAC [=y] && PPC_BOOK3S [=y] && CPU_BIG_ENDIAN [=y] && POWER_RESET [=y] && PPC32 [=y]
>>>
>>> WARNING: unmet direct dependencies detected for ADB_CUDA
>>> Depends on [n]: MACINTOSH_DRIVERS [=n] && (ADB [=n] || PPC_PMAC [=y]) && !PPC_PMAC64 [=n]
>>> Selected by [y]:
>>> - PPC_PMAC [=y] && PPC_BOOK3S [=y] && CPU_BIG_ENDIAN [=y] && POWER_RESET [=y] && PPC32 [=y]
>>
>> Crud. Caused by:
>>
>> a3ef2fef198c ("powerpc/32: Add dependencies of POWER_RESET for pmac32")
>>
>> I was suspicious of that select, I should have been *more* suspicious :)
>>
>> I think this is a fix. The PPC32 isn't needed because ADB depends on (PPC_PMAC && PPC32).
>
> Yes, that fixes the problem. Thanks.
>
> Tested-by: Randy Dunlap <rdunlap@infradead.org>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
>
Will you be merging this fix?
Thanks.
>>
>> diff --git a/arch/powerpc/platforms/powermac/Kconfig b/arch/powerpc/platforms/powermac/Kconfig
>> index 8bdae0caf21e..84f101ec53a9 100644
>> --- a/arch/powerpc/platforms/powermac/Kconfig
>> +++ b/arch/powerpc/platforms/powermac/Kconfig
>> @@ -2,7 +2,7 @@
>> config PPC_PMAC
>> bool "Apple PowerMac based machines"
>> depends on PPC_BOOK3S && CPU_BIG_ENDIAN
>> - select ADB_CUDA if POWER_RESET && PPC32
>> + select ADB_CUDA if POWER_RESET && ADB
>> select MPIC
>> select FORCE_PCI
>> select PPC_INDIRECT_PCI if PPC32
>>
>> cheers
>
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-07 17:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230920133714.351f83f9@canb.auug.org.au>
2023-09-20 15:52 ` linux-next: Tree for Sep 20 (ppc32: ADB_CUDA Kconfig warning) Randy Dunlap
2023-09-22 0:10 ` Michael Ellerman
2023-09-22 4:51 ` Randy Dunlap
2023-10-07 17:32 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).