From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF625C433EF for ; Sun, 5 Jun 2022 09:49:48 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4LGBfz0ZRyz3c7r for ; Sun, 5 Jun 2022 19:49:47 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=arm.com (client-ip=217.140.110.172; helo=foss.arm.com; envelope-from=anshuman.khandual@arm.com; receiver=) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lists.ozlabs.org (Postfix) with ESMTP id 4LGBfS03Qpz2ync for ; Sun, 5 Jun 2022 19:49:17 +1000 (AEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1AB5DD6E; Sun, 5 Jun 2022 02:48:44 -0700 (PDT) Received: from [10.163.37.253] (unknown [10.163.37.253]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 241D53F73D; Sun, 5 Jun 2022 02:48:35 -0700 (PDT) Message-ID: Date: Sun, 5 Jun 2022 15:18:35 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 6/6] openrisc/mm: Enable ARCH_HAS_VM_GET_PAGE_PROT Content-Language: en-US To: Stafford Horne References: <20220603101411.488970-1-anshuman.khandual@arm.com> <20220603101411.488970-7-anshuman.khandual@arm.com> From: Anshuman Khandual In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Paul Mackerras , sparclinux@vger.kernel.org, Will Deacon , Jonas Bonn , linux-s390@vger.kernel.org, x86@kernel.org, linux-csky@vger.kernel.org, Ingo Molnar , Geert Uytterhoeven , Vasily Gorbik , Heiko Carstens , openrisc@lists.librecores.org, Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, Dinh Nguyen , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 6/5/22 11:37, Stafford Horne wrote: > On Fri, Jun 03, 2022 at 03:44:11PM +0530, Anshuman Khandual wrote: >> This defines and exports a platform specific custom vm_get_page_prot() via >> subscribing ARCH_HAS_VM_GET_PAGE_PROT. Subsequently all __SXXX and __PXXX >> macros can be dropped which are no longer needed. >> >> Cc: Jonas Bonn >> Cc: openrisc@lists.librecores.org >> Cc: linux-kernel@vger.kernel.org >> Acked-by: Stafford Horne >> Signed-off-by: Anshuman Khandual > > Is it possible to retract my Acked-by? I was following the discussion of this > new function actually being sub optimal. So as far as I am concerned all these > architecture patches should be nak'ed. Sure, alright. I am planning to redo these arch patches via making the protection_map[] array private to the platforms but possibly with a common look up function as Christophe had suggested earlier.