From: Mauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com>
To: Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au,
gwshan@linux.vnet.ibm.com
Subject: Re: [PATCH v3] powerpc/pseries: use pci_host_bridge.release_fn() to kfree(phb)
Date: Thu, 11 Aug 2016 14:35:09 -0300 [thread overview]
Message-ID: <fe4d23ab-ede0-3b6b-dd6e-7c89b4044f76@linux.vnet.ibm.com> (raw)
In-Reply-To: <fa66d691-6059-e1dd-0aa2-69346d49f16e@au1.ibm.com>
On 08/11/2016 02:01 AM, Andrew Donnellan wrote:
> In cxl, we currently call:
>
> pci_remove_root_bus(phb->bus);
> pcibios_free_controller(phb);
>
> which appears to break with this patch after I wire up
> pci_set_host_bridge_release() in cxl, as phb can be freed before we call
> pcibios_free_controller().
Ugh; you're right. I believe the user is expected to use either one way
or another, but now I see it's not that intuitive -- a design fault.
I'll address this w/ the other review/suggestion by Gavin; replying it.
> Missing a '---' here :)
>
>> Changelog:
Ok, thanks!
--
Mauricio Faria de Oliveira
IBM Linux Technology Center
next prev parent reply other threads:[~2016-08-11 17:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-10 21:45 [PATCH v3] powerpc/pseries: use pci_host_bridge.release_fn() to kfree(phb) Mauricio Faria de Oliveira
2016-08-10 22:21 ` Mauricio Faria de Oliveira
2016-08-11 5:01 ` Andrew Donnellan
2016-08-11 6:29 ` Gavin Shan
2016-08-11 7:06 ` Andrew Donnellan
2016-08-11 17:35 ` Mauricio Faria de Oliveira [this message]
2016-08-11 6:40 ` Gavin Shan
2016-08-11 18:00 ` Mauricio Faria de Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe4d23ab-ede0-3b6b-dd6e-7c89b4044f76@linux.vnet.ibm.com \
--to=mauricfo@linux.vnet.ibm.com \
--cc=andrew.donnellan@au1.ibm.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).