From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-mm@kvack.org, kaleshsingh@google.com,
joel@joelfernandes.org, akpm@linux-foundation.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [RFC PATCH 3/6] mm/mremap: Use pmd/pud_poplulate to update page table entries
Date: Tue, 2 Feb 2021 20:20:21 +0530 [thread overview]
Message-ID: <ff04cf20-2197-a61e-929f-0ce4c1c72ab8@linux.ibm.com> (raw)
In-Reply-To: <YBkttA/rS/1ZHY8a@hirez.programming.kicks-ass.net>
On 2/2/21 4:17 PM, Peter Zijlstra wrote:
> On Tue, Feb 02, 2021 at 02:41:13PM +0530, Aneesh Kumar K.V wrote:
>> pmd/pud_populate is the right interface to be used to set the respective
>> page table entries. Some architectures do assume that set_pmd/pud_at
>> can only be used to set a hugepage PTE. Since we are not setting up a hugepage
>> PTE here, use the pmd/pud_populate interface.
>
> Since you did the audit, it might be nice to record which architectures
> that are. Also, how much work to fix them?
>
I didn't audit them completely primarily because I don't follow the page
table format of other archs. But I guess arm64, s390 appears to make
that assumption.
Moreover set_pmd_at was added as part of THP patch series.
BTW why should we fix those architectures ? isn't pmd_populate the right
interface for updating pmd entries other than hugepage pte ?
-aneesh
next prev parent reply other threads:[~2021-02-03 2:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 9:11 [RFC PATCH 1/6] selftest/mremap_test: Update the test to handle pagesize other than 4K Aneesh Kumar K.V
2021-02-02 9:11 ` [RFC PATCH 2/6] selftest/mremap_test: Avoid crash with static build Aneesh Kumar K.V
2021-02-02 9:11 ` [RFC PATCH 3/6] mm/mremap: Use pmd/pud_poplulate to update page table entries Aneesh Kumar K.V
2021-02-02 10:47 ` Peter Zijlstra
2021-02-02 14:50 ` Aneesh Kumar K.V [this message]
2021-02-02 9:11 ` [RFC PATCH 4/6] mm/mremap: Use mmu gather interface instead of flush_tlb_range Aneesh Kumar K.V
2021-02-02 9:11 ` [RFC PATCH 5/6] mm/mremap: Allow arch runtime override Aneesh Kumar K.V
2021-02-02 9:11 ` [RFC PATCH 6/6] powerpc/mm: Enable move pmd/pud Aneesh Kumar K.V
2021-02-02 13:29 ` [RFC PATCH 1/6] selftest/mremap_test: Update the test to handle pagesize other than 4K Li Xinhai
2021-02-02 14:51 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff04cf20-2197-a61e-929f-0ce4c1c72ab8@linux.ibm.com \
--to=aneesh.kumar@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=joel@joelfernandes.org \
--cc=kaleshsingh@google.com \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).