From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A34DEEFB816 for ; Tue, 24 Feb 2026 08:29:44 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4fKrVt6Jv8z3cJN; Tue, 24 Feb 2026 19:29:42 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2600:3c0a:e001:78e:0:1991:8:25" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1771921782; cv=none; b=VkEDoSUXf98Yt4hCzHY5PG4U07Ekzazs1WCwlb8vmQn5VVjg7mhhWPeo9LgsyjjEShEVz6YWtWmUBXfDdlzggykFJ3MAX2w0bEvQco216MvRqbOONA1OKm6hWLvOP68x90uDNl/P27vKqmtTu6hqiYVP0VGNcnUYW0GO8W+RrR4GBmoslBVe9zvkvFzZhj+9ab4NXE6Pzbxfz45WG4ZEgoK6o+uqNph2y6JqS9KH9zR0Nm0DM8Q0UgkcUyCAjCIGHrBdpiC88KF2dXu+Q1GjCkcOS0kMO+Q3/eJeYh43GoJQU1wv0H7m0kE+Czd9BmIV0u1jf6lQfkza0kDGycQECQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1771921782; c=relaxed/relaxed; bh=BPTyswEAWcYBdxG+lq8T+yaWTvmllBTsbkuk0kDdtsI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EI50z9w1x3IRG6KFsth5UgwPoeZulPhBhFC++H7Pox1iIw7btqAjoU8q1FDEGGgMIzHA5nG/RAhhEGZctnmQ5XsMEqkTBMckaM/w/RDerLKn00g9aqlpFyy8ri2BO4IVfsrikQG4zOPUroM3LjX0jFh8r3+Yi7SaJ8HTdA3BqN21fJOtGD8f8WtbDwnga1Znudq3Im4JhSBRlavwO2NkWr2Pp73DNHJhgjVDgUetUV/fjkpJVKA/SDgrFXiTBaezLLp0tOoiXxj07jBucLUbtm5X5NPyH5Vbt9hTQmisDUTmYhV5YgKrab4YJ+bDDQY/eU74SNb5HQghFVNJod5jOQ== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=SNHr9FXZ; dkim-atps=neutral; spf=pass (client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org; envelope-from=chleroy@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=SNHr9FXZ; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org; envelope-from=chleroy@kernel.org; receiver=lists.ozlabs.org) Received: from sea.source.kernel.org (sea.source.kernel.org [IPv6:2600:3c0a:e001:78e:0:1991:8:25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4fKrVs5cT2z3cHf for ; Tue, 24 Feb 2026 19:29:41 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id AE5F64336F; Tue, 24 Feb 2026 08:29:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0C05C116D0; Tue, 24 Feb 2026 08:29:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771921779; bh=s889kssXllyZaSNT87Eq7q+8jDDE7Yxpqk+iIio+e2U=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=SNHr9FXZ68PnehoZL3L7xEXBRGUdm+0EhLsocHU+9tirzHDCoLqN3V2QCmwM00mFp 56eX4kO7yFSccVeMpCCHciajM3Exp8jX0CTK437GW390X7hsqkFXgOMqHpzSo9dwOr gAWupmJ7IajiuRhF2F2wvCsyzFNkCXYWPJYSqlW0sxBoOO7rXoeWr/Lrd7Pi+rlqaN uBwxTs8OpkFlRcTp7R8Fk4g1NXn7uLLvkQySG7lSr0UvbIGBeeebslLmBC16yR0B+K ypauaUdj+Vw7FA8SQSuJZm+95Wy19zR4mLaCokOhS0Hp6PJmuRilzyiPWckoq9+kgV Czu3m3TQWWTwA== Message-ID: Date: Tue, 24 Feb 2026 09:29:33 +0100 X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next] net: fs_enet: allow nvmem to override MAC address To: Rosen Penev , netdev@vger.kernel.org Cc: Pantelis Antoniou , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "open list:FREESCALE SOC FS_ENET DRIVER" , open list References: <20260224014607.353378-1-rosenp@gmail.com> Content-Language: fr-FR From: "Christophe Leroy (CS GROUP)" In-Reply-To: <20260224014607.353378-1-rosenp@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Le 24/02/2026 à 02:46, Rosen Penev a écrit : > NVMEM typically loads after the ethernet driver and > of_get_ethdev_address returns -EPROBE_DEFER. return in such a case to > allow NVMEM to work. > > Signed-off-by: Rosen Penev > --- > drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c > index 2cbcc29408e3..d3c772ed5fc9 100644 > --- a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c > +++ b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c > @@ -951,7 +951,9 @@ static int fs_enet_probe(struct platform_device *ofdev) > spin_lock_init(&fep->lock); > spin_lock_init(&fep->tx_lock); > > - of_get_ethdev_address(ofdev->dev.of_node, ndev); > + ret = of_get_ethdev_address(ofdev->dev.of_node, ndev); > + if (ret == -EPROBE_DEFER) > + goto out_cleanup_data; What about other error cases ? Shouldn't it exit on all types of errors ? > > ret = fep->ops->allocate_bd(ndev); > if (ret) > -- > 2.53.0 > >