From: Anthony Foiani <tkil@scrye.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: "Robert P. J. Day" <rpjday@crashcourse.ca>,
Jeff Garzik <jeff@garzik.org>,
ashish kalra <ashish.kalra@freescale.com>,
Adrian Bunk <bunk@stusta.de>
Subject: ppc/sata-fsl: orphan config value: CONFIG_MPC8315_DS
Date: Thu, 17 May 2012 11:08:18 -0600 [thread overview]
Message-ID: <ghave7n25.fsf@dworkin.scrye.com> (raw)
Greetings.
I was occasionally running into problems at boot time on an
MPC8315-based board (derived from the MPC831xRDB, apparently), using
SATA to talk to an SSD. My vendor suggested that I enable
CONFIG_MPC8315_DS.
That symbol is only found once in the entire kernel codebase:
$ git checkout v3.4-rc7
HEAD is now at 36be505... Linux 3.4-rc7
$ git grep -nH CONFIG_MPC8315_DS
drivers/ata/sata_fsl.c:729:#ifdef CONFIG_MPC8315_DS
There is no kconfig support for it at all.
It was added in 2007; further, this is the only commit in the entire
git history that contains this string:
commit e7eac96e8f0e57a6e9f94943557bc2b23be31471
Author: ashish kalra <ashish.kalra@freescale.com>
Date: Wed Oct 31 19:28:02 2007 +0800
ata/sata_fsl: Move MPC8315DS link speed limit workaround to specific ifdef
Signed-off-by: ashish kalra <ashish.kalra@freescale.com>
Signed-off-by: Li Yang <leoli@freescale.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
index 5892472..e076e1f 100644
--- a/drivers/ata/sata_fsl.c
+++ b/drivers/ata/sata_fsl.c
@@ -652,6 +652,7 @@ static int sata_fsl_port_start(struct ata_port *ap)
VPRINTK("HControl = 0x%x\n", ioread32(hcr_base + HCONTROL));
VPRINTK("CHBA = 0x%x\n", ioread32(hcr_base + CHBA));
+#ifdef CONFIG_MPC8315_DS
/*
* Workaround for 8315DS board 3gbps link-up issue,
* currently limit SATA port to GEN1 speed
@@ -664,6 +665,7 @@ static int sata_fsl_port_start(struct ata_port *ap)
sata_fsl_scr_read(ap, SCR_CONTROL, &temp);
dev_printk(KERN_WARNING, dev, "scr_control, speed limited to %x\n",
temp);
+#endif
return 0;
}
This otherwise-unsupported variable was noted by Robert Day in 2008;
Adrian Bunk suggested a patch, but the Freescale folks said that it
was for a not-yet-mainlined board, so the patch was dropped:
http://marc.info/?l=linux-ide&m=121783965216004&w=2
As Robert notied again in 2010, it still wasn't mainlined:
http://marc.info/?l=linux-ide&m=121783965216004&w=2
And, obviously, it still isn't today.
Can the Freescale people tell us exactly what we should be testing to
determine when to enforce this restriction? A config variable that
points to a non-existent board doesn't seem much help.
Thanks,
Tony
next reply other threads:[~2012-05-17 17:15 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-17 17:08 Anthony Foiani [this message]
2012-05-21 6:31 ` ppc/sata-fsl: orphan config value: CONFIG_MPC8315_DS Li Yang-R58472
2012-05-26 6:53 ` Anthony Foiani
2012-05-29 18:02 ` Scott Wood
2012-05-29 22:07 ` Anthony Foiani
2012-05-29 22:57 ` Scott Wood
2012-05-30 10:59 ` Li Yang
2012-05-30 20:07 ` Anthony Foiani
2012-05-30 20:14 ` Anthony Foiani
2012-05-30 20:20 ` Scott Wood
2012-05-30 20:52 ` Anthony Foiani
2013-04-30 6:41 ` Anthony Foiani
2013-04-30 18:15 ` Scott Wood
2013-05-01 0:34 ` Anthony Foiani
2013-05-01 0:42 ` Scott Wood
2013-05-01 2:06 ` Anthony Foiani
2013-05-01 18:05 ` Scott Wood
2013-05-01 23:35 ` Anthony Foiani
2013-05-02 0:13 ` Scott Wood
2013-04-30 21:35 ` Jeff Garzik
2013-05-02 6:37 ` Anthony Foiani
2013-05-08 12:04 ` Anthony Foiani
-- strict thread matches above, loose matches on Subject: below --
2013-08-23 19:25 Scott Wood
2013-08-23 23:41 ` Anthony Foiani
2013-08-23 23:47 ` Scott Wood
2013-08-24 8:03 ` Anthony Foiani
2013-08-27 10:51 ` Xie Shaohui-B21989
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ghave7n25.fsf@dworkin.scrye.com \
--to=tkil@scrye.com \
--cc=ashish.kalra@freescale.com \
--cc=bunk@stusta.de \
--cc=jeff@garzik.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).