From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx2.suse.de", Issuer "CAcert Class 3 Root" (verified OK)) by ozlabs.org (Postfix) with ESMTP id 3F7CCDDDFF for ; Thu, 27 Dec 2007 02:57:06 +1100 (EST) From: Andreas Schwab To: Michael Buesch Subject: Re: [PATCH] powerpc: Do not fail build if mkimage is not available References: <200712261453.41849.mb@bu3sch.de> <200712261610.28489.mb@bu3sch.de> <200712261635.43188.mb@bu3sch.de> Date: Wed, 26 Dec 2007 16:56:57 +0100 In-Reply-To: <200712261635.43188.mb@bu3sch.de> (Michael Buesch's message of "Wed\, 26 Dec 2007 16\:35\:42 +0100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Cc: Andrew Morton , linuxppc-dev@ozlabs.org, paulus@au.ibm.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Michael Buesch writes: > On Wednesday 26 December 2007 16:33:57 Andreas Schwab wrote: >> Michael Buesch writes: >> >> > On Wednesday 26 December 2007 15:47:05 Andreas Schwab wrote: >> >> Michael Buesch writes: >> >> >> >> > + if ! [ -x mkimage ]; then >> >> >> >> What is this supposed to test? >> > >> > from man test: >> >> You didn't answer my question. > > I'm not sure how I can make the manual text any clearer I know very well what it *does*, thank you. But that does mean that is does what it is *supposed* to do. > -x FILE > FILE exists and execute (or search) permission is granted ^^^^ > It tests if the program exists and is executable. ^^^^^^^ Observe the fine difference in the choice of words. > That would help a lot not wasting my time. How about testing your changes first? Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."