From: Andreas Schwab <schwab@suse.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: "Étienne Bersac" <bersace03@gmail.com>,
"Stephen Rothwell" <sfr@canb.auug.org.au>,
linuxppc-dev <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH] windfarm: add PowerMac 12,1 support
Date: Sun, 23 Mar 2008 02:01:46 +0100 [thread overview]
Message-ID: <jefxui8d8l.fsf@sykes.suse.de> (raw)
In-Reply-To: <1206228673.9540.115.camel@pmac.infradead.org> (David Woodhouse's message of "Sat\, 22 Mar 2008 23\:31\:13 +0000")
David Woodhouse <dwmw2@infradead.org> writes:
> - all = all && pm121_register_control(ct, "optical-driver-fan", FAN_OD);
> - all = all && pm121_register_control(ct, "hard-driver-fan", FAN_HD);
> - all = all && pm121_register_control(ct, "cpu-driver-fan", FAN_CPU);
> - all = all && pm121_register_control(ct, "cpufreq-clamp", CPUFREQ);
> + all = pm121_register_control(ct, "optical-drive-fan", FAN_OD) && all;
> + all = pm121_register_control(ct, "hard-drive-fan", FAN_HD) && all;
> + all = pm121_register_control(ct, "cpu-fan", FAN_CPU) && all;
> + all = pm121_register_control(ct, "cpufreq-clamp", CPUFREQ) && all;
You can also write all &= ... if pm121_register_control always return
0/1 (or make it 0/1 with !!).
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2008-03-23 1:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-26 11:55 [PATCH] windfarm: add PowerMac 12,1 support Étienne Bersac
2008-03-22 19:35 ` David Woodhouse
2008-03-22 22:13 ` Benjamin Herrenschmidt
2008-03-22 23:02 ` David Woodhouse
2008-03-22 23:14 ` David Woodhouse
2008-03-22 23:25 ` Benjamin Herrenschmidt
2008-03-22 23:25 ` Stephen Rothwell
2008-03-22 23:31 ` David Woodhouse
2008-03-23 1:01 ` Andreas Schwab [this message]
2008-03-23 5:38 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2008-04-29 5:39 Benjamin Herrenschmidt
2007-12-06 1:20 Étienne Bersac
2007-12-06 15:30 ` Étienne Bersac
2007-12-10 15:11 ` Étienne Bersac
2007-12-10 15:39 ` Arnd Bergmann
2007-12-10 17:17 ` Étienne Bersac
2007-12-10 17:22 ` Étienne Bersac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jefxui8d8l.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=bersace03@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).