From: Andreas Schwab <schwab@suse.de>
To: Cedric Pradalier <cedric.pradalier@inrialpes.fr>
Cc: Linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 001/001 Updated again] PMAC HD runtime blinking control
Date: Wed, 25 Jan 2006 12:06:44 +0100 [thread overview]
Message-ID: <jey814y3az.fsf@sykes.suse.de> (raw)
In-Reply-To: <20060124222513.48ef0276.cedric.pradalier@inrialpes.fr> (Cedric Pradalier's message of "Tue, 24 Jan 2006 22:25:13 +1000")
Cedric Pradalier <cedric.pradalier@inrialpes.fr> writes:
> @@ -427,6 +432,15 @@ static void pmac_ide_kauai_selectproc(id
>
> #ifdef CONFIG_BLK_DEV_IDE_PMAC_BLINK
>
> +MODULE_AUTHOR("Paul Mackerras & Ben. Herrenschmidt");
> +MODULE_DESCRIPTION("Support for IDE interfaces on PowerMacs");
> +MODULE_LICENSE("GPL");
> +
> +static int activity_led = 0;
No need to zero-initialize a static variable.
> @@ -437,8 +451,7 @@ static spinlock_t pmu_blink_lock;
> static unsigned long pmu_blink_stoptime;
> static int pmu_blink_ledstate;
> static struct timer_list pmu_blink_timer;
> -static int pmu_ide_blink_enabled;
> -
> +static int pmu_ide_blink_enabled = 0;
Same.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2006-01-25 11:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-22 2:19 [PATCH 001/001] PMAC HD runtime blinking control Cedric Pradalier
2006-01-22 2:49 ` Benjamin Herrenschmidt
2006-01-22 8:11 ` Cedric Pradalier
2006-01-22 8:25 ` Benjamin Herrenschmidt
2006-01-23 13:38 ` [PATCH 001/001 Updated] " Cedric Pradalier
2006-01-23 13:47 ` Benjamin Herrenschmidt
2006-01-23 21:31 ` Cedric Pradalier
2006-01-23 23:10 ` Benjamin Herrenschmidt
2006-01-24 12:25 ` [PATCH 001/001 Updated again] " Cedric Pradalier
2006-01-24 23:14 ` Benjamin Herrenschmidt
2006-01-25 11:06 ` Andreas Schwab [this message]
2006-01-25 11:27 ` Cedric Pradalier
2006-01-25 12:44 ` Andreas Schwab
2006-01-22 11:56 ` [PATCH 001/001] " Arkadiusz Miskiewicz
2006-01-22 21:59 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jey814y3az.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=Linuxppc-dev@ozlabs.org \
--cc=cedric.pradalier@inrialpes.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).