From: Andreas Schwab <schwab@suse.de>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: Makefile check for older binutils broken?
Date: Wed, 26 Oct 2005 21:59:20 +0200 [thread overview]
Message-ID: <jezmow3v8n.fsf@sykes.suse.de> (raw)
In-Reply-To: <20051026133648.GA10373@logos.cnet> (Marcelo Tosatti's message of "Wed, 26 Oct 2005 11:36:48 -0200")
Marcelo Tosatti <marcelo.tosatti@cyclades.com> writes:
> Anyway, surrounding the verification command around an eval expression
> does the trick correcting the situation. Is it any good?
Not at all. You have effectively disabled the check completely.
> diff --git a/arch/ppc/Makefile b/arch/ppc/Makefile
> index 0432a25..cdd9250 100644
> --- a/arch/ppc/Makefile
> +++ b/arch/ppc/Makefile
> @@ -126,7 +126,7 @@ checkbin:
> false; \
> fi ; \
> fi
> - @if ! /bin/echo dssall | $(AS) -many -o $(TOUT) >/dev/null 2>&1 ; then \
> + @if ! [[ "/bin/echo dssall | $(AS) -many -o $(TOUT) >/dev/null 2>&1" ]] ; then \
A non-empty string is always true.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2005-10-26 19:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-26 13:36 Makefile check for older binutils broken? Marcelo Tosatti
2005-10-26 19:59 ` Andreas Schwab [this message]
2005-10-26 16:08 ` Marcelo Tosatti
2005-10-26 22:02 ` Tom Rini
2005-10-28 8:52 ` Marcelo Tosatti
2005-10-28 16:10 ` Tom Rini
2005-10-28 13:14 ` Marcelo Tosatti
2005-11-01 16:33 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jezmow3v8n.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).