From: Milton Miller <miltonm@bga.com>
To: Kumar Gala <galak@kernel.crashing.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [RFC] powerpc: respect how command line nr_cpus is set
Date: Wed, 11 May 2011 19:26:01 -0500 [thread overview]
Message-ID: <kumar-ncpu-reply@mdm.bga.com> (raw)
In-Reply-To: <1304540257-19831-1-git-send-email-galak@kernel.crashing.org>
On Wed, 04 May 2011 around 10:17:37 -0000, Kumar Gala wrote:
> We should utilize nr_cpus as the max # of CPUs that we can have present
> instead of NR_CPUS. This way we actually respect how nr_cpus is set on
> the command line rather than ignoring it.
>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
>
> ---
> I think this is what we should be doing, but would like someone else to take
> a look.
>
> - k
>
> arch/powerpc/kernel/setup-common.c | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
This looks very similar to my patch at
http://patchwork.ozlabs.org/patch/95080/ except I also updated the
comment. Also, the variable is nr_cpu_ids while the parameter
is nr_cpus=, the first instance in in the changelog is referring to
the variable while the second is the parameter.
Sorry I took me so long get that part of my series tested and posted.
milton
prev parent reply other threads:[~2011-05-12 0:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 20:17 [RFC][PATCH] powerpc: respect how command line nr_cpus is set Kumar Gala
2011-05-05 2:25 ` Benjamin Herrenschmidt
2011-05-05 11:38 ` Kumar Gala
2011-05-05 22:29 ` Benjamin Herrenschmidt
2011-05-12 0:26 ` Milton Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=kumar-ncpu-reply@mdm.bga.com \
--to=miltonm@bga.com \
--cc=benh@kernel.crashing.org \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).