From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by ozlabs.org (Postfix) with ESMTP id 1D88EDDEE7 for ; Sat, 2 May 2009 09:02:31 +1000 (EST) From: Andreas Schwab To: "H. Peter Anvin" Subject: Re: [PATCH v2 1/6] Add new macros for page-aligned data and bss sections. References: <1241121253-32341-1-git-send-email-tabbott@mit.edu> <1241121253-32341-2-git-send-email-tabbott@mit.edu> <20090501091848.GB18326@uranus.ravnborg.org> <49FB2449.1010301@zytor.com> <20090501171717.GA26401@uranus.ravnborg.org> <49FB2EDC.9050300@zytor.com> <20090501174457.GA26559@uranus.ravnborg.org> <49FB35C4.6060107@zytor.com> Date: Sat, 02 May 2009 01:02:12 +0200 In-Reply-To: <49FB35C4.6060107@zytor.com> (H. Peter Anvin's message of "Fri, 01 May 2009 10:47:48 -0700") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-mips@linux-mips.org, linux-m68k@vger.kernel.org, linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Denys Vlasenko , Tim Abbott , Heiko Carstens , linuxppc-dev@ozlabs.org, Waseem, Paul Mackerras , Greg Ungerer , sparclinux@vger.kernel.org, Sam Ravnborg , Bryan Wu , linux-s390@vger.kernel.org, Jesper Nilsson , Yoshinori Sato , "David S. Miller" , Helge Deller , Ingo Molnar , Geert Uytterhoeven , Russell King , user-mode-linux-devel@lists.sourceforge.net, microblaze-uclinux@itee.uq.edu.au, Jeff Dike , Jeff Arnold , Michal Simek , Mikael Starvik , Cyrill Gorcunov , Thomas Gleixner , Daher , Richard Henderson , Chris Zankel , dev-etrax@axis.com, Tony Luck , Haavard Skinnemoen , linux-parisc@vger.kernel.org, Linux kernel mailing list , Ralf Baechle , Anders Kaseorg , Kyle McMartin , Paul Mundt , linux-alpha@vger.kernel.org, Martin Schwidefsky , uclinux-dist-devel@blackfin.uclinux.org, Linus Torvalds , Hirokazu Takata List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , "H. Peter Anvin" writes: > Sam Ravnborg wrote: >>> >>> What's wrong with @? >> arm does not support it :-( >> I recall it denote a comment in arm assembler. >> >> I could do some magic to detect the ARM case but I'm reluctant to do so. >> I could also ignore the arm issue for now as it is not used by arm, >> but that strikes me as the wrong approach. >> > > If we really have to use different tokens, I would say: > > #ifdef __ARM__ > # define _PROGBITS %progbits /* or whatever */ > # define _NOBITS %nobits > #else > # define _PROGBITS @progbits > # define _NOBITS @nobits > #endif GAS has always supported both '@' and '%', so '%' can be used everywhere. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."