* Re: [PATCH] ssb: pci: implement serdes workaround [not found] <1301657212-12126-1-git-send-email-zajec5@gmail.com> @ 2011-05-31 9:37 ` Andreas Schwab 2011-05-31 15:14 ` Larry Finger 0 siblings, 1 reply; 6+ messages in thread From: Andreas Schwab @ 2011-05-31 9:37 UTC (permalink / raw) To: Rafał Miłecki Cc: linuxppc-dev, John W. Linville, linux-wireless-u79uwXL29TY76Z2rM5mHXA, Michael Büsch, b43-dev-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r Rafał Miłecki <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes: > +/************************************************** > + * Workarounds. > + **************************************************/ > + > +static u8 ssb_pcicore_polarity_workaround(struct ssb_pcicore *pc) > +{ > + return (ssb_pcie_read(pc, 0x204) & 0x10) ? 0xC0 : 0x80; > +} > + > +static void ssb_pcicore_serdes_workaround(struct ssb_pcicore *pc) > +{ > + const u8 serdes_pll_device = 0x1D; > + const u8 serdes_rx_device = 0x1F; > + u16 tmp; > + > + ssb_pcie_mdio_write(pc, serdes_rx_device, 1 /* Control */, > + ssb_pcicore_polarity_workaround(pc)); > + tmp = ssb_pcie_mdio_read(pc, serdes_pll_device, 1 /* Control */); > + if (tmp & 0x4000) > + ssb_pcie_mdio_write(pc, serdes_pll_device, 1, tmp & ~0x4000); > +} b43-pci-bridge 0001:10:12.0: enabling device (0004 -> 0006) ssb: Core 0 found: ChipCommon (cc 0x800, rev 0x0D, vendor 0x4243) ssb: Core 1 found: IEEE 802.11 (cc 0x812, rev 0x09, vendor 0x4243) ssb: Core 2 found: PCI (cc 0x804, rev 0x0C, vendor 0x4243) ssb: Core 3 found: PCMCIA (cc 0x80D, rev 0x07, vendor 0x4243) Machine check in kernel mode. Caused by (from SRR1=149030): Transfer error ack signal Oops: Machine check, sig: 7 [#1] PowerMac Modules linked in: crc_itu_t ssb(+) snd_aoa_soundbus sungem sungem_phy NIP: c0013324 LR: f2143e84 CTR: c001331c REGS: c2ca5b80 TRAP: 0200 Not tainted (3.0.0-rc1) MSR: 00149030 <EE,ME,IR,DR> CR: 22004422 XER: 20000000 TASK = ef9cef90[285] 'modprobe' THREAD: c2ca4000 GPR00: c2d1f87c c2ca5c30 ef9cef90 00002381 00000134 00000204 00000080 c2ca5bc8 GPR08: 04773e80 c2d1f87c 00000000 c001331c ffffffff 1002833c f2141968 f214821c GPR16: f21478b7 f2148250 f21478c0 f2147894 00100100 00200200 00001310 c2d1fb2c GPR24: f2147ee8 00000000 00000000 00000000 f2148204 c2d1f800 00000134 c2d1f800 NIP [c0013324] ioread32+0x8/0x14 LR [f2143e84] ssb_pci_read32+0x4c/0x5c [ssb] Call Trace: [c2ca5c30] [c2d1f800] 0xc2d1f800 (unreliable) [c2ca5c40] [f2146244] ssb_pcie_read+0x4c/0x54 [ssb] [c2ca5c50] [f2146440] ssb_pcicore_serdes_workaround+0x1c/0x170 [ssb] [c2ca5c70] [f2141c24] ssb_attach_queued_buses+0x94/0x288 [ssb] [c2ca5cd0] [f2142078] ssb_bus_register+0xe4/0x160 [ssb] [c2ca5cf0] [f2142134] ssb_bus_pcibus_register+0x40/0x80 [ssb] [c2ca5d00] [f2144a60] ssb_pcihost_probe+0xd8/0x114 [ssb] [c2ca5d30] [c018f6ac] local_pci_probe+0x28/0x38 [c2ca5d40] [c0190690] pci_device_probe+0x68/0x94 [c2ca5d70] [c02bc8a4] driver_probe_device+0xc8/0x170 [c2ca5d90] [c02bc9bc] __driver_attach+0x70/0x98 [c2ca5db0] [c02bb9ec] bus_for_each_dev+0x60/0x90 [c2ca5de0] [c02bc538] driver_attach+0x24/0x34 [c2ca5df0] [c02bc11c] bus_add_driver+0xbc/0x23c [c2ca5e10] [c02bcfc8] driver_register+0xb8/0x144 [c2ca5e30] [c01908c8] __pci_register_driver+0x4c/0xc8 [c2ca5e50] [f214486c] ssb_pcihost_register+0x50/0x60 [ssb] [c2ca5e60] [f214c094] b43_pci_ssb_bridge_init+0x18/0xbc [ssb] [c2ca5e70] [f214c05c] ssb_modinit+0x5c/0x7c [ssb] [c2ca5e80] [c00049d8] do_one_initcall+0xe0/0x1c0 [c2ca5eb0] [c005f7b0] sys_init_module+0x164c/0x1850 [c2ca5f40] [c0010cd8] ret_from_syscall+0x0/0x40 --- Exception: c01 at 0xff0b714 LR = 0x100050f0 Instruction dump: 0c030000 4c00012c 5463043e 4e800020 7c0004ac a0630000 0c030000 4c00012c 5463043e 4e800020 7c0004ac 7c601c2c <0c030000> 4c00012c 4e800020 7c0004ac ---[ end trace 9824f03a7724930b ]--- Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ssb: pci: implement serdes workaround 2011-05-31 9:37 ` [PATCH] ssb: pci: implement serdes workaround Andreas Schwab @ 2011-05-31 15:14 ` Larry Finger 2011-05-31 15:54 ` Andreas Schwab 0 siblings, 1 reply; 6+ messages in thread From: Larry Finger @ 2011-05-31 15:14 UTC (permalink / raw) To: Andreas Schwab Cc: Rafał Miłecki, Michael Büsch, public-b43-dev-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linuxppc-dev, John W. Linville, public-linux-wireless-u79uwXL29TY76Z2rM5mHXA On 05/31/2011 04:37 AM, Andreas Schwab wrote: > > > Rafał Miłecki<zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes: > >> +/************************************************** >> + * Workarounds. >> + **************************************************/ >> + >> +static u8 ssb_pcicore_polarity_workaround(struct ssb_pcicore *pc) >> +{ >> + return (ssb_pcie_read(pc, 0x204)& 0x10) ? 0xC0 : 0x80; >> +} >> + >> +static void ssb_pcicore_serdes_workaround(struct ssb_pcicore *pc) >> +{ >> + const u8 serdes_pll_device = 0x1D; >> + const u8 serdes_rx_device = 0x1F; >> + u16 tmp; >> + >> + ssb_pcie_mdio_write(pc, serdes_rx_device, 1 /* Control */, >> + ssb_pcicore_polarity_workaround(pc)); >> + tmp = ssb_pcie_mdio_read(pc, serdes_pll_device, 1 /* Control */); >> + if (tmp& 0x4000) >> + ssb_pcie_mdio_write(pc, serdes_pll_device, 1, tmp& ~0x4000); >> +} > > b43-pci-bridge 0001:10:12.0: enabling device (0004 -> 0006) > ssb: Core 0 found: ChipCommon (cc 0x800, rev 0x0D, vendor 0x4243) > ssb: Core 1 found: IEEE 802.11 (cc 0x812, rev 0x09, vendor 0x4243) > ssb: Core 2 found: PCI (cc 0x804, rev 0x0C, vendor 0x4243) > ssb: Core 3 found: PCMCIA (cc 0x80D, rev 0x07, vendor 0x4243) > Machine check in kernel mode. > Caused by (from SRR1=149030): Transfer error ack signal > Oops: Machine check, sig: 7 [#1] > PowerMac > Modules linked in: crc_itu_t ssb(+) snd_aoa_soundbus sungem sungem_phy > NIP: c0013324 LR: f2143e84 CTR: c001331c > REGS: c2ca5b80 TRAP: 0200 Not tainted (3.0.0-rc1) > MSR: 00149030<EE,ME,IR,DR> CR: 22004422 XER: 20000000 > TASK = ef9cef90[285] 'modprobe' THREAD: c2ca4000 > GPR00: c2d1f87c c2ca5c30 ef9cef90 00002381 00000134 00000204 00000080 c2ca5bc8 > GPR08: 04773e80 c2d1f87c 00000000 c001331c ffffffff 1002833c f2141968 f214821c > GPR16: f21478b7 f2148250 f21478c0 f2147894 00100100 00200200 00001310 c2d1fb2c > GPR24: f2147ee8 00000000 00000000 00000000 f2148204 c2d1f800 00000134 c2d1f800 > NIP [c0013324] ioread32+0x8/0x14 > LR [f2143e84] ssb_pci_read32+0x4c/0x5c [ssb] > Call Trace: > [c2ca5c30] [c2d1f800] 0xc2d1f800 (unreliable) > [c2ca5c40] [f2146244] ssb_pcie_read+0x4c/0x54 [ssb] > [c2ca5c50] [f2146440] ssb_pcicore_serdes_workaround+0x1c/0x170 [ssb] > [c2ca5c70] [f2141c24] ssb_attach_queued_buses+0x94/0x288 [ssb] > [c2ca5cd0] [f2142078] ssb_bus_register+0xe4/0x160 [ssb] > [c2ca5cf0] [f2142134] ssb_bus_pcibus_register+0x40/0x80 [ssb] > [c2ca5d00] [f2144a60] ssb_pcihost_probe+0xd8/0x114 [ssb] > [c2ca5d30] [c018f6ac] local_pci_probe+0x28/0x38 > [c2ca5d40] [c0190690] pci_device_probe+0x68/0x94 > [c2ca5d70] [c02bc8a4] driver_probe_device+0xc8/0x170 > [c2ca5d90] [c02bc9bc] __driver_attach+0x70/0x98 > [c2ca5db0] [c02bb9ec] bus_for_each_dev+0x60/0x90 > [c2ca5de0] [c02bc538] driver_attach+0x24/0x34 > [c2ca5df0] [c02bc11c] bus_add_driver+0xbc/0x23c > [c2ca5e10] [c02bcfc8] driver_register+0xb8/0x144 > [c2ca5e30] [c01908c8] __pci_register_driver+0x4c/0xc8 > [c2ca5e50] [f214486c] ssb_pcihost_register+0x50/0x60 [ssb] > [c2ca5e60] [f214c094] b43_pci_ssb_bridge_init+0x18/0xbc [ssb] > [c2ca5e70] [f214c05c] ssb_modinit+0x5c/0x7c [ssb] > [c2ca5e80] [c00049d8] do_one_initcall+0xe0/0x1c0 > [c2ca5eb0] [c005f7b0] sys_init_module+0x164c/0x1850 > [c2ca5f40] [c0010cd8] ret_from_syscall+0x0/0x40 > --- Exception: c01 at 0xff0b714 > LR = 0x100050f0 > Instruction dump: > 0c030000 4c00012c 5463043e 4e800020 7c0004ac a0630000 0c030000 4c00012c > 5463043e 4e800020 7c0004ac 7c601c2c<0c030000> 4c00012c 4e800020 7c0004ac > ---[ end trace 9824f03a7724930b ]--- We get a PPC machine check if we try to read a non-existent register, whereas x86 returns all 1's on reads. Obviously, this section needs to be conditionalized depending on revision info. From the traceback, it must be the serdes_pll_device read that failed. The specs say that should be a valid register for PCIe and PCI core rev 3 - 5. As the PCI core in this device is 0xc, should we be in this routine? See http://bcm-v4.sipsolutions.net/PCI-E. Larry ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ssb: pci: implement serdes workaround 2011-05-31 15:14 ` Larry Finger @ 2011-05-31 15:54 ` Andreas Schwab 2011-05-31 16:17 ` Larry Finger 0 siblings, 1 reply; 6+ messages in thread From: Andreas Schwab @ 2011-05-31 15:54 UTC (permalink / raw) To: Larry Finger Cc: Rafał Miłecki, Michael Büsch, public-b43-dev-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linuxppc-dev, John W. Linville, public-linux-wireless-u79uwXL29TY76Z2rM5mHXA Larry Finger <Larry.Finger@lwfinger.net> writes: > From the traceback, it must be the serdes_pll_device read that failed. Why not ssb_pcicore_polarity_workaround (note r4 == 0x134)? Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ssb: pci: implement serdes workaround 2011-05-31 15:54 ` Andreas Schwab @ 2011-05-31 16:17 ` Larry Finger 2011-05-31 17:07 ` Andreas Schwab 0 siblings, 1 reply; 6+ messages in thread From: Larry Finger @ 2011-05-31 16:17 UTC (permalink / raw) To: Andreas Schwab Cc: Rafał Miłecki, Michael Büsch, public-b43-dev-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linuxppc-dev, John W. Linville, public-linux-wireless-u79uwXL29TY76Z2rM5mHXA On 05/31/2011 10:54 AM, Andreas Schwab wrote: > Larry Finger<Larry.Finger@lwfinger.net> writes: > >> From the traceback, it must be the serdes_pll_device read that failed. > > Why not ssb_pcicore_polarity_workaround (note r4 == 0x134)? Mainly because the last two steps in the traceback are [c2ca5c40] [f2146244] ssb_pcie_read+0x4c/0x54 [ssb] [c2ca5c50] [f2146440] ssb_pcicore_serdes_workaround+0x1c/0x170 [ssb] Larry ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ssb: pci: implement serdes workaround 2011-05-31 16:17 ` Larry Finger @ 2011-05-31 17:07 ` Andreas Schwab 2011-05-31 17:32 ` Andreas Schwab 0 siblings, 1 reply; 6+ messages in thread From: Andreas Schwab @ 2011-05-31 17:07 UTC (permalink / raw) To: Larry Finger Cc: Rafał Miłecki, Michael Büsch, public-b43-dev-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linuxppc-dev, John W. Linville, public-linux-wireless-u79uwXL29TY76Z2rM5mHXA Larry Finger <Larry.Finger@lwfinger.net> writes: > On 05/31/2011 10:54 AM, Andreas Schwab wrote: >> Larry Finger<Larry.Finger@lwfinger.net> writes: >> >>> From the traceback, it must be the serdes_pll_device read that failed. >> >> Why not ssb_pcicore_polarity_workaround (note r4 == 0x134)? > > Mainly because the last two steps in the traceback are > > [c2ca5c40] [f2146244] ssb_pcie_read+0x4c/0x54 [ssb] > [c2ca5c50] [f2146440] ssb_pcicore_serdes_workaround+0x1c/0x170 [ssb] Which exactly is what ssb_pcicore_polarity_workaround is doing. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ssb: pci: implement serdes workaround 2011-05-31 17:07 ` Andreas Schwab @ 2011-05-31 17:32 ` Andreas Schwab 0 siblings, 0 replies; 6+ messages in thread From: Andreas Schwab @ 2011-05-31 17:32 UTC (permalink / raw) To: Larry Finger Cc: Rafał Miłecki, Michael Büsch, public-b43-dev-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linuxppc-dev, John W. Linville, public-linux-wireless-u79uwXL29TY76Z2rM5mHXA Andreas Schwab <schwab@linux-m68k.org> writes: > Larry Finger <Larry.Finger@lwfinger.net> writes: > >> On 05/31/2011 10:54 AM, Andreas Schwab wrote: >>> Larry Finger<Larry.Finger@lwfinger.net> writes: >>> >>>> From the traceback, it must be the serdes_pll_device read that failed. >>> >>> Why not ssb_pcicore_polarity_workaround (note r4 == 0x134)? >> >> Mainly because the last two steps in the traceback are >> >> [c2ca5c40] [f2146244] ssb_pcie_read+0x4c/0x54 [ssb] >> [c2ca5c50] [f2146440] ssb_pcicore_serdes_workaround+0x1c/0x170 [ssb] > > Which exactly is what ssb_pcicore_polarity_workaround is doing. 0000022c <ssb_pcicore_serdes_workaround>: 22c: 94 21 ff e0 stwu r1,-32(r1) 230: 7c 08 02 a6 mflr r0 234: 38 80 02 04 li r4,516 238: 90 01 00 24 stw r0,36(r1) 23c: bf a1 00 14 stmw r29,20(r1) 240: 7c 7f 1b 78 mr r31,r3 244: 4b ff fd bd bl 0 <ssb_pcie_read> Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-05-31 17:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1301657212-12126-1-git-send-email-zajec5@gmail.com>
2011-05-31 9:37 ` [PATCH] ssb: pci: implement serdes workaround Andreas Schwab
2011-05-31 15:14 ` Larry Finger
2011-05-31 15:54 ` Andreas Schwab
2011-05-31 16:17 ` Larry Finger
2011-05-31 17:07 ` Andreas Schwab
2011-05-31 17:32 ` Andreas Schwab
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).