From: Stewart Smith <stewart@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@ozlabs.org
Cc: skiboot@lists.ozlabs.org
Subject: Re: [RFC PATCH 3/3] powerpc/powernv: Remove unused definitions in opal-api.h
Date: Wed, 18 Feb 2015 08:15:18 +1100 [thread overview]
Message-ID: <m33864i6jd.fsf@oc8180480414.ibm.com> (raw)
In-Reply-To: <1424163715-10370-3-git-send-email-mpe@ellerman.id.au>
Michael Ellerman <mpe@ellerman.id.au> writes:
> This removes definitions in opal-api.h that are completely unused in
> Linux.
>
> For each of these I see three possibilities, 1) we *should* be using
> them in Linux and patches will arrive to do that, 2) they are not used
> but should stay in the header to document the API for some important
> reason, 3) they are not used and needn't be part of the API.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Agree. The diff is now a TODO list for patches.
Reviewed-by: Stewart Smith <stewart@linux.vnet.ibm.com>
next prev parent reply other threads:[~2015-02-17 21:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-17 9:01 [PATCH 1/3] powerpc/powernv: Move OPAL API definitions to opal-api.h Michael Ellerman
2015-02-17 9:01 ` [PATCH 2/3] powerpc/powernv: Move opal-api.h closer to the Skiboot version Michael Ellerman
2015-02-17 21:14 ` Stewart Smith
2015-02-17 9:01 ` [RFC PATCH 3/3] powerpc/powernv: Remove unused definitions in opal-api.h Michael Ellerman
2015-02-17 21:15 ` Stewart Smith [this message]
2015-02-17 21:12 ` [PATCH 1/3] powerpc/powernv: Move OPAL API definitions to opal-api.h Stewart Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m33864i6jd.fsf@oc8180480414.ibm.com \
--to=stewart@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=skiboot@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox