From: Ronald Wahl <rwa@peppercon.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev list <linuxppc-dev@lists.linuxppc.org>
Subject: Re: Fix for autonegotiation of ppc 40x ethernet driver
Date: Wed, 08 Oct 2003 10:51:36 +0200 [thread overview]
Message-ID: <m365j0863r.fsf@gandalf.peppercon.de> (raw)
In-Reply-To: <1065602490.30751.84.camel@gaston> (Benjamin Herrenschmidt's message of "Wed, 08 Oct 2003 10:41:31 +0200")
On Wed, 08 Oct 2003 10:41:31 +0200, Benjamin Herrenschmidt wrote:
> On Wed, 2003-10-08 at 10:17, Ronald Wahl wrote:
>> Hello,
>>
>> I have found a bug in the ethernet driver for the PPC 40x. The problem
>> is that the driver doesn't deal correctly if a user wants a limited
>> advertising range (via ethtool interface) - lets say 10Mbps/Halfduplex
>> and 10MBps/Fullduplex. The link always enters 100MBps/Fullduplex mode if
>> the link partner supports it. This is an incorrect behavior. I appended
>> a fix for this (against 2.4.22+ of the linuxppc 3.4 devel tree). It
>> would be nice if this change could be reviewed and incorporated into the
>> official code. If any questions arise - just ask...
> Hi !
> There may well be a bug in the code, but I'm not sure this is
> the proper fix. When setting up a forced mode, I'm not sure it's
I wont force a single mode. I want to limit the advertising to a
limited _range_. So autonegotiation is still enabled - just with a
limited range. The forcing of a mode (i.e. disabling autonegotiation)
is working already without this patch.
> worth playing with advertise at all in fact... Just having the
> link up shall be enough if aneg is disabled, we could ignore
> LPA/ADVERTISE completely. Or maybe just read back BMCR from
> read_link...
- ron
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2003-10-08 8:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-08 8:17 Fix for autonegotiation of ppc 40x ethernet driver Ronald Wahl
2003-10-08 8:41 ` Benjamin Herrenschmidt
2003-10-08 8:51 ` Ronald Wahl [this message]
2003-10-08 8:56 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m365j0863r.fsf@gandalf.peppercon.de \
--to=rwa@peppercon.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).