From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lists.ozlabs.org (Postfix) with ESMTP id C7B351A0C66 for ; Sat, 6 Dec 2014 05:01:15 +1100 (AEDT) From: Ashutosh Dixit To: Dan Streetman Subject: Re: [PATCH linux-next] Documentation: Build mic/mpssd only for x86_64 References: <25c04eb72c621fc9bdf0aae25782ff5bad5a4b97.1417728278.git.ashutosh.dixit@intel.com> Date: Fri, 05 Dec 2014 10:18:57 -0800 In-Reply-To: (Dan Streetman's message of "Thu, 4 Dec 2014 20:27:06 -0700") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jonathan Corbet , Peter Foley , Siva Yerramreddy , Jiri Kosina , Randy Dunlap , "linux-doc@vger.kernel.org" , "Dutt, Sudeep" , "Yokoyama, Caz" , Daniel Borkmann , Greg Kroah-Hartman , "Rao, Nikhil" , "linuxppc-dev@lists.ozlabs.org" , Jennings , linux-kernel , "Chandramouli, Dasaratharaman" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Dec 04 2014 at 07:27:06 PM, Dan Streetman wrote: > On Thu, Dec 4, 2014 at 4:27 PM, Ashutosh Dixit wrote: >> mic/mpssd along with MIC drivers are currently only usable on >> x86_64. So build mic/mpssd only for x86_64 to avoid build breaks on >> big-endian systems. > > Only building for x86_64 is fine, but in that case what's the point of > leaving the htole16() et. al. functions in mpssd.c? Shouldn't they be > removed? I am hoping that once glibc is fixed we can remove this limitation on building only for x86_64, so I'd rather htole16() et. al. stayed. As I said earlier, I'm fine with your patch too, but restricting the build for x86_64 seems to be the smallest patch which provides an acceptable solution.