From: Andreas Schwab <schwab@suse.de>
To: linuxppc-dev@ozlabs.org
Subject: Fix spurious error return in FBIO_RADEON_SET_MIRROR
Date: Wed, 26 Jan 2005 02:05:43 +0100 [thread overview]
Message-ID: <m3llahc848.fsf@igel.m5r.de> (raw)
FBIO_RADEON_SET_MIRROR always returns with -EINVAL even if successful due
to an inappropriate fall-through.
Signed-off-by: Andreas Schwab <schwab@suse.de>
--- linux-2.6.10/drivers/video/aty/radeon_base.c.~1~ 2004-12-29 20:17:12.00=
0000000 +0100
+++ linux-2.6.10/drivers/video/aty/radeon_base.c 2005-01-26 01:48:17.000000=
000 +0100
@@ -911,7 +911,7 @@ static int radeonfb_ioctl (struct inode=20
=20
OUTREG(CRTC_EXT_CNTL, tmp);
=20
- break;
+ return 0;
case FBIO_RADEON_GET_MIRROR:
if (!rinfo->is_mobility)
return -EINVAL;
Andreas.
--=20
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstra=C3=9Fe 5, 90409 N=C3=BCrnberg, Germany
Key fingerprint =3D 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
reply other threads:[~2005-01-26 1:17 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3llahc848.fsf@igel.m5r.de \
--to=schwab@suse.de \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).