From: Stewart Smith <stewart@linux.vnet.ibm.com>
To: Cedric Le Goater <clg@fr.ibm.com>, mpe@ellerman.id.au
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/powernv: check OPAL_REGISTER_DUMP_REGION calls exist
Date: Thu, 26 Feb 2015 08:53:52 +1100 [thread overview]
Message-ID: <m3pp8xejyn.fsf@oc8180480414.ibm.com> (raw)
In-Reply-To: <54EE3E93.6070001@fr.ibm.com>
Cedric Le Goater <clg@fr.ibm.com> writes:
> On 02/25/2015 10:16 PM, Stewart Smith wrote:
>> C=C3=A9dric Le Goater <clg@fr.ibm.com> writes:
>>> On Open Power systems, such call fails in OPAL :=20
>>>
>>> OPAL: Called with bad token 101 !
>>>
>>> The check on the OPAL_UNREGISTER_DUMP_REGION call is added for=20
>>> symmetry. I did not see any errors for it.
>>=20
>> I've already put in a patch to squash this:
>> Message-Id:
>> <1423718729-17992-2-git-send-email-stewart@linux.vnet.ibm.com>
>>=20
>> Just waiting on mpe to merge :)
>
> ok fine, I missed it :)=20
>
> I am also tempted to fix OPAL_READ_TPO but the proper way to do this=20
> would be to move the lowlevel OPAL code from drivers/rtc/rtc-opal.c to=20
> a new file under arch/powerpc/platforms/powernv/. How does that sound ?=20
shouldn't we be detecting things from DT and acting on it? From a quick
glance perhaps we're not quite doing the checks in all the right places?
prev parent reply other threads:[~2015-02-25 21:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 17:43 [PATCH] powerpc/powernv: check OPAL_REGISTER_DUMP_REGION calls exist Cédric Le Goater
2015-02-25 21:16 ` Stewart Smith
2015-02-25 21:28 ` Cedric Le Goater
2015-02-25 21:53 ` Stewart Smith [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3pp8xejyn.fsf@oc8180480414.ibm.com \
--to=stewart@linux.vnet.ibm.com \
--cc=clg@fr.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox