LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* Re: 2.6.23-rc3 broken on G5
From: Paul Mackerras @ 2007-08-19  2:01 UTC (permalink / raw)
  To: Andreas Schwab; +Cc: linuxppc-dev
In-Reply-To: <jey7g9i3qk.fsf@sykes.suse.de>

Andreas Schwab writes:

> 1.25 GB.  It also has an nvidia gfx card, in case it matters.

Could you try this patch and see if it fixes it?  It puts the code
back to being a bit closer to what it was before.

Paul.

diff --git a/arch/powerpc/mm/slb.c b/arch/powerpc/mm/slb.c
index a73d2d7..1cef209 100644
--- a/arch/powerpc/mm/slb.c
+++ b/arch/powerpc/mm/slb.c
@@ -226,8 +226,12 @@ void slb_initialize(void)
 	vflags = SLB_VSID_KERNEL | vmalloc_llp;
 
 	/* Invalidate the entire SLB (even slot 0) & all the ERATS */
+	asm volatile("isync":::"memory");
+	asm volatile("slbmte  %0,%0"::"r" (0) : "memory");
+	asm volatile("isync; slbia; isync":::"memory");
+
 	slb_shadow_update(PAGE_OFFSET, lflags, 0);
-	asm volatile("isync; slbia; sync; slbmte  %0,%1; isync" ::
+	asm volatile("slbmte  %0,%1; isync" ::
 		     "r" (get_slb_shadow()->save_area[0].vsid),
 		     "r" (get_slb_shadow()->save_area[0].esid) : "memory");
 

^ permalink raw reply related

* Re: [PATCH] Consolidate XILINX_VIRTEX board support
From: David H. Lynch Jr. @ 2007-08-19  1:34 UTC (permalink / raw)
  Cc: linuxppc-embedded
In-Reply-To: <87vebryfrv.fsf@sleipner.barco.com>

arch/boot/simple/embed_config.c jusst seems to be a random collection of 
board specific code anyway.
A giant case statement implimented with #ifdef's. It is just screaming 
to be done some better way.

Peter Korsgaard wrote:
>>>>>> "WR" == Wolfgang Reissnegger <wolfgang.reissnegger@xilinx.com> writes:
>>>>>>             
>
> Hi,
>
> WR> diff --git a/arch/ppc/boot/simple/Makefile b/arch/ppc/boot/simple/Makefile
> WR> index 5b87779..05631fe 100644
> WR> --- a/arch/ppc/boot/simple/Makefile
> WR> +++ b/arch/ppc/boot/simple/Makefile
> WR> @@ -187,8 +187,7 @@ boot-$(CONFIG_REDWOOD_6)	+= embed_config.o
> WR>  boot-$(CONFIG_8xx)		+= embed_config.o
> WR>  boot-$(CONFIG_8260)		+= embed_config.o
> WR>  boot-$(CONFIG_EP405)		+= embed_config.o
> WR> -boot-$(CONFIG_XILINX_ML300)	+= embed_config.o
> WR> -boot-$(CONFIG_XILINX_ML403)	+= embed_config.o
> WR> +boot-$(CONFIG_XILINX_VIRTEX)	+= embed_config.o
>
> Don't do that. Other boards with Xilinx FPGAs don't necessarily need
> embed_config.c
>
> WR>  boot-$(CONFIG_BSEIP)		+= iic.o
> WR>  boot-$(CONFIG_MBX)		+= iic.o pci.o qspan_pci.o
> WR>  boot-$(CONFIG_MV64X60)		+= misc-mv64x60.o
> WR> diff --git a/arch/ppc/boot/simple/embed_config.c b/arch/ppc/boot/simple/embed_config.c
> WR> index 840bff2..e0b8954 100644
> WR> --- a/arch/ppc/boot/simple/embed_config.c
> WR> +++ b/arch/ppc/boot/simple/embed_config.c
> WR> @@ -744,7 +744,7 @@ embed_config(bd_t **bdp)
> WR>  }
> WR>  #endif /* WILLOW */
>  
> WR> -#if defined(CONFIG_XILINX_ML300) || defined(CONFIG_XILINX_ML403)
> WR> +#if defined(CONFIG_XILINX_VIRTEX)
> WR>  void
> WR>  embed_config(bd_t ** bdp)
>
> .. And if they do, they might have another embed_config (E.G. if the
> bootloader provides a valid struct bd_t).
>
>   


-- 
Dave Lynch 					  	    DLA Systems
Software Development:  				         Embedded Linux
717.627.3770 	       dhlii@dlasys.net 	  http://www.dlasys.net
fax: 1.253.369.9244 			           Cell: 1.717.587.7774
Over 25 years' experience in platforms, languages, and technologies too numerous to list.

"Any intelligent fool can make things bigger and more complex... It takes a touch of genius - and a lot of courage to move in the opposite direction."
Albert Einstein

^ permalink raw reply

* Re: Best Linux tree for Xilinx support.
From: David H. Lynch Jr. @ 2007-08-19  1:29 UTC (permalink / raw)
  To: Leonid; +Cc: linuxppc-embedded
In-Reply-To: <406A31B117F2734987636D6CCC93EE3C02053B0F@ehost011-3.exch011.intermedia.net>

Leonid wrote:
> I deem such approach is not very good one. I'm using precisely same IP
> cores like GPIO, EMAC, SPI, CAN, etc... in Virtex and Spartan FPGAs
> which means (OK, may be cores are different somewhat for different FPGAs
> but low level Xilinx code is the same). That means at least 2 different
> CPU architectures (PPC and Microblaze). 
>   
    Most device drivers are outside the arch tree, only board specific 
configuration
    is inside.
   
    While there is a great deal of similarity between the microblaze and 
ppc code that
    would be under the arch tree's they are still as distinct as 
different architecures.
    Maybe there would be some way to share some of the code, but for the 
most part
    the similar or identical code falls outside the arch tree.

> A How EDK project parameters get into Linux kernel? This is huge issue
> which can be divided on several items.
>   
    Xilinx has their own idea's and thus far they do not seem to fit 
well with the
norms of Linux kernel developers. It is extremely unlikely the latter 
will change.

    I did the BSP for the Pico E1x series of boards. While it is based 
heavily on Grant's
MLXXX work that I am trying to track, very little of it is even xilinx 
specific.

    One the key distinctions between FPGA based systems and typical 
systems is that
the core is very very small. In a Pico E1x, you can only count on:
    A processor,
    an MMU,
    memory,
    and some serial (or pseudo serial) device capable of functioning as 
a console.
    Flash, Ethernet, Specific Uarts, Even interrupts and interrupt 
handling are
    all optional.
   
> A.2. There is also a question how these definitions get into .c and Make
> files. Petalogix has interesting solution when they bump all XILINX
> parameters to autoconf.h and .config files thus making them available
> for both compiler and make. What's your approach?
>   
    With all respect to Petalogix and the significant work they have 
done, I can not see migrating all
    the xparameters.h values into .config being adopted. Besides little 
of none of those values are
    needed outside the core of the BSP.

    I am not particular enamored with the CONFIG_VIRTEX or    
    CONFIG_VIRTEX_4 flags either. There is very very little that knowing
    the exact FPGA tells Linux. As an example Pico E12's, E14's and E16's
    are fundimentally very similar, despite having different form factors,
    being on different cards (CF, CardBus, ExpressBus), and using different
    Xilinx parts (sometimes on the same model)

    I beleive that the long term effort is to put everything into device 
tree's
    then the device information for the product is
        dynamically created, or stored in flash or otherwise provided to 
Linux
    at boot. But that is pretty close to the extent of my knowledge of 
device
    trees at this time.  

> A.4. Is it assumed that Xilinx low level code will stay intact as it is
> supplied with EDK package or you are going to prepare special Linux
> Xilinx set (mostly because of name convention)?
>   
    I do not beleive anyone is anticipating the Xilinx EDK code making 
its way into
a kernel.org Linux source.

> B How drivers get registered - via platform devices structure in
> virtex.c file or something different?
>   
    I beleive the current approach is mostly using platform devices - though
individual drivers may vary. I beleive the longterm approach is to use 
device
trees - I am not sure how the two interrelate.


-- 
Dave Lynch 					  	    DLA Systems
Software Development:  				         Embedded Linux
717.627.3770 	       dhlii@dlasys.net 	  http://www.dlasys.net
fax: 1.253.369.9244 			           Cell: 1.717.587.7774
Over 25 years' experience in platforms, languages, and technologies too numerous to list.

"Any intelligent fool can make things bigger and more complex... It takes a touch of genius - and a lot of courage to move in the opposite direction."
Albert Einstein

^ permalink raw reply

* [PATCH 3/3 v2][POWERPC] Stop include asm-ppc when building ARCH=powerpc for ppc32
From: Kumar Gala @ 2007-08-18 17:11 UTC (permalink / raw)
  To: linuxppc-dev
In-Reply-To: <Pine.LNX.4.64.0708181207530.31362@blarg.am.freescale.net>

We no longer have any dependancies on include/asm-ppc so we can get ride
of the makefile hacks to include it in the build process.

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---

Actually remove all the bits related to include fixup, not just comment
them out :)

 arch/powerpc/Makefile |   17 +----------------
 1 files changed, 1 insertions(+), 16 deletions(-)

diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile
index 6c1e36c..d6ab02e 100644
--- a/arch/powerpc/Makefile
+++ b/arch/powerpc/Makefile
@@ -63,8 +63,7 @@ endif

 LDFLAGS_vmlinux	:= -Bstatic

-# The -Iarch/$(ARCH)/include is temporary while we are merging
-CPPFLAGS-$(CONFIG_PPC32) := -Iarch/$(ARCH) -Iarch/$(ARCH)/include
+CPPFLAGS-$(CONFIG_PPC32) := -Iarch/$(ARCH)
 AFLAGS-$(CONFIG_PPC32)	:= -Iarch/$(ARCH)
 CFLAGS-$(CONFIG_PPC64)	:= -mminimal-toc -mtraceback=none  -mcall-aixdesc
 CFLAGS-$(CONFIG_PPC32)	:= -Iarch/$(ARCH) -ffixed-r2 -mmultiple
@@ -72,9 +71,6 @@ CPPFLAGS	+= $(CPPFLAGS-y)
 AFLAGS		+= $(AFLAGS-y)
 CFLAGS		+= -msoft-float -pipe $(CFLAGS-y)
 CPP		= $(CC) -E $(CFLAGS)
-# Temporary hack until we have migrated to asm-powerpc
-LINUXINCLUDE-$(CONFIG_PPC32)	:= -Iarch/$(ARCH)/include
-LINUXINCLUDE    += $(LINUXINCLUDE-y)

 CHECKFLAGS	+= -m$(SZ) -D__powerpc__ -D__powerpc$(SZ)__

@@ -172,19 +168,8 @@ install:
 archclean:
 	$(Q)$(MAKE) $(clean)=$(boot)

-archmrproper:
-	$(Q)rm -rf arch/$(ARCH)/include
-
 archprepare: checkbin

-ifeq ($(CONFIG_PPC32),y)
-# Temporary hack until we have migrated to asm-powerpc
-include/asm: arch/$(ARCH)/include/asm
-arch/$(ARCH)/include/asm: FORCE
-	$(Q)if [ ! -d arch/$(ARCH)/include ]; then mkdir -p arch/$(ARCH)/include; fi
-	$(Q)ln -fsn $(srctree)/include/asm-$(OLDARCH) arch/$(ARCH)/include/asm
-endif
-
 # Use the file '.tmp_gas_check' for binutils tests, as gas won't output
 # to stdout and these checks are run even on install targets.
 TOUT	:= .tmp_gas_check
-- 
1.5.2.2

^ permalink raw reply related

* [PATCH 2/3 v2][POWERPC] Copy over headers from arch/ppc to arch/powerpc that we need
From: Kumar Gala @ 2007-08-18 17:09 UTC (permalink / raw)
  To: linuxppc-dev
In-Reply-To: <Pine.LNX.4.64.0708181206070.31362@blarg.am.freescale.net>

To build arch/powerpc without including asm-ppc/ we need these files
in asm-powerpc/

Moved some headers under arch/powerpc/platforms if they were only used by
platform files and fixed up the source file includes to match the new
locations

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---

Moved mpc10x.h, gg2.h, hydra.h into platforms. Removed new file diffs
from the patch.

 arch/powerpc/platforms/chrp/gg2.h                |   61 ++
 arch/powerpc/platforms/chrp/hydra.h              |  102 ++
 arch/powerpc/platforms/chrp/pci.c                |    4 +-
 arch/powerpc/platforms/chrp/setup.c              |    4 +-
 arch/powerpc/platforms/embedded6xx/linkstation.c |    3 +-
 arch/powerpc/platforms/embedded6xx/ls_uart.c     |    3 +-
 arch/powerpc/platforms/embedded6xx/mpc10x.h      |  180 ++++
 include/asm-powerpc/8xx_immap.h                  |  564 ++++++++++
 include/asm-powerpc/commproc.h                   |  692 ++++++++++++
 include/asm-powerpc/cpm2.h                       | 1248 ++++++++++++++++++++++
 include/asm-powerpc/highmem.h                    |  135 +++
 include/asm-powerpc/immap_cpm2.h                 |  648 +++++++++++
 include/asm-powerpc/kgdb.h                       |   57 +
 include/asm-powerpc/mpc52xx_psc.h                |  191 ++++
 14 files changed, 3886 insertions(+), 6 deletions(-)
 create mode 100644 arch/powerpc/platforms/chrp/gg2.h
 create mode 100644 arch/powerpc/platforms/chrp/hydra.h
 create mode 100644 arch/powerpc/platforms/embedded6xx/mpc10x.h
 create mode 100644 include/asm-powerpc/8xx_immap.h
 create mode 100644 include/asm-powerpc/commproc.h
 create mode 100644 include/asm-powerpc/cpm2.h
 create mode 100644 include/asm-powerpc/highmem.h
 create mode 100644 include/asm-powerpc/immap_cpm2.h
 create mode 100644 include/asm-powerpc/kgdb.h
 create mode 100644 include/asm-powerpc/mpc52xx_psc.h

diff --git a/arch/powerpc/platforms/chrp/pci.c b/arch/powerpc/platforms/chrp/pci.c
index 0c6dba9..fd80703 100644
--- a/arch/powerpc/platforms/chrp/pci.c
+++ b/arch/powerpc/platforms/chrp/pci.c
@@ -11,9 +11,7 @@
 #include <asm/io.h>
 #include <asm/pgtable.h>
 #include <asm/irq.h>
-#include <asm/hydra.h>
 #include <asm/prom.h>
-#include <asm/gg2.h>
 #include <asm/machdep.h>
 #include <asm/sections.h>
 #include <asm/pci-bridge.h>
@@ -21,6 +19,8 @@
 #include <asm/rtas.h>

 #include "chrp.h"
+#include "gg2.h"
+#include "hydra.h"

 /* LongTrail */
 void __iomem *gg2_pci_config_base;
diff --git a/arch/powerpc/platforms/chrp/setup.c b/arch/powerpc/platforms/chrp/setup.c
index dde5ef4..03ccf1a 100644
--- a/arch/powerpc/platforms/chrp/setup.c
+++ b/arch/powerpc/platforms/chrp/setup.c
@@ -37,12 +37,10 @@
 #include <asm/io.h>
 #include <asm/pgtable.h>
 #include <asm/prom.h>
-#include <asm/gg2.h>
 #include <asm/pci-bridge.h>
 #include <asm/dma.h>
 #include <asm/machdep.h>
 #include <asm/irq.h>
-#include <asm/hydra.h>
 #include <asm/sections.h>
 #include <asm/time.h>
 #include <asm/i8259.h>
@@ -51,6 +49,8 @@
 #include <asm/xmon.h>

 #include "chrp.h"
+#include "gg2.h"
+#include "hydra.h"

 void rtas_indicator_progress(char *, unsigned short);

diff --git a/arch/powerpc/platforms/embedded6xx/linkstation.c b/arch/powerpc/platforms/embedded6xx/linkstation.c
index 8c60e02..61ca02c 100644
--- a/arch/powerpc/platforms/embedded6xx/linkstation.c
+++ b/arch/powerpc/platforms/embedded6xx/linkstation.c
@@ -18,9 +18,10 @@
 #include <asm/time.h>
 #include <asm/prom.h>
 #include <asm/mpic.h>
-#include <asm/mpc10x.h>
 #include <asm/pci-bridge.h>

+#include "mpc10x.h"
+
 static struct mtd_partition linkstation_physmap_partitions[] = {
 	{
 		.name   = "mtd_firmimg",
diff --git a/arch/powerpc/platforms/embedded6xx/ls_uart.c b/arch/powerpc/platforms/embedded6xx/ls_uart.c
index f7a4def..0d9f150 100644
--- a/arch/powerpc/platforms/embedded6xx/ls_uart.c
+++ b/arch/powerpc/platforms/embedded6xx/ls_uart.c
@@ -4,10 +4,11 @@
 #include <linux/serial_reg.h>
 #include <linux/serial_8250.h>
 #include <asm/io.h>
-#include <asm/mpc10x.h>
 #include <asm/prom.h>
 #include <asm/termbits.h>

+#include "mpc10x.h"
+
 static void __iomem *avr_addr;
 static unsigned long avr_clock;
-- 
1.5.2.2

^ permalink raw reply related

* [PATCH 1/3 v2][POWERPC] Remove old includes from arch/ppc
From: Kumar Gala @ 2007-08-18 17:07 UTC (permalink / raw)
  To: linuxppc-dev
In-Reply-To: <Pine.LNX.4.64.0708181203320.31362@blarg.am.freescale.net>

Remove includes of files that existed in arch/ppc that we dont need in
arch/powerpc anymore.  The following includes were removed:

 <asm/amigappc.h>
 <asm/bootinfo.h>
 <asm/ppcboot.h>
 <asm/ppc_sys.h>
 <asm/residual.h>
 <asm/m8260_pci.h>

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---

Added m8260_pci.h to the cleanup.

 arch/powerpc/kernel/setup_32.c               |    2 --
 arch/powerpc/platforms/52xx/lite5200.c       |    1 -
 arch/powerpc/platforms/82xx/m82xx_pci.h      |    2 --
 arch/powerpc/platforms/82xx/mpc82xx.c        |    1 -
 arch/powerpc/platforms/82xx/mpc82xx_ads.c    |    1 -
 arch/powerpc/platforms/82xx/pq2ads.h         |    1 -
 arch/powerpc/platforms/83xx/mpc832x_mds.c    |    1 -
 arch/powerpc/platforms/83xx/mpc834x_itx.c    |    1 -
 arch/powerpc/platforms/83xx/mpc834x_mds.c    |    1 -
 arch/powerpc/platforms/83xx/mpc836x_mds.c    |    1 -
 arch/powerpc/platforms/85xx/mpc85xx_cds.c    |    1 -
 arch/powerpc/platforms/85xx/mpc85xx_mds.c    |    1 -
 arch/powerpc/platforms/8xx/m8xx_setup.c      |    4 ++--
 arch/powerpc/platforms/8xx/mpc86xads.h       |    1 -
 arch/powerpc/platforms/8xx/mpc86xads_setup.c |    1 -
 arch/powerpc/platforms/8xx/mpc885ads.h       |    1 -
 arch/powerpc/platforms/8xx/mpc885ads_setup.c |    1 -
 arch/powerpc/platforms/chrp/smp.c            |    1 -
 arch/powerpc/platforms/embedded6xx/ls_uart.c |    1 -
 arch/powerpc/platforms/powermac/bootx_init.c |    1 -
 20 files changed, 2 insertions(+), 23 deletions(-)

diff --git a/arch/powerpc/kernel/setup_32.c b/arch/powerpc/kernel/setup_32.c
index 7ec6ba5..a288a5f 100644
--- a/arch/powerpc/kernel/setup_32.c
+++ b/arch/powerpc/kernel/setup_32.c
@@ -18,13 +18,11 @@
 #include <linux/cpu.h>
 #include <linux/console.h>

-#include <asm/residual.h>
 #include <asm/io.h>
 #include <asm/prom.h>
 #include <asm/processor.h>
 #include <asm/pgtable.h>
 #include <asm/setup.h>
-#include <asm/amigappc.h>
 #include <asm/smp.h>
 #include <asm/elf.h>
 #include <asm/cputable.h>
diff --git a/arch/powerpc/platforms/52xx/lite5200.c b/arch/powerpc/platforms/52xx/lite5200.c
index 84bd3da..ce3f695 100644
--- a/arch/powerpc/platforms/52xx/lite5200.c
+++ b/arch/powerpc/platforms/52xx/lite5200.c
@@ -35,7 +35,6 @@
 #include <asm/io.h>
 #include <asm/machdep.h>
 #include <asm/ipic.h>
-#include <asm/bootinfo.h>
 #include <asm/irq.h>
 #include <asm/prom.h>
 #include <asm/udbg.h>
diff --git a/arch/powerpc/platforms/82xx/m82xx_pci.h b/arch/powerpc/platforms/82xx/m82xx_pci.h
index 9cd8893..65e38a7 100644
--- a/arch/powerpc/platforms/82xx/m82xx_pci.h
+++ b/arch/powerpc/platforms/82xx/m82xx_pci.h
@@ -8,8 +8,6 @@
  * 2 of the License, or (at your option) any later version.
  */

-#include <asm/m8260_pci.h>
-
 #define SIU_INT_IRQ1   ((uint)0x13 + CPM_IRQ_OFFSET)

 #ifndef _IO_BASE
diff --git a/arch/powerpc/platforms/82xx/mpc82xx.c b/arch/powerpc/platforms/82xx/mpc82xx.c
index cc9900d..c706871 100644
--- a/arch/powerpc/platforms/82xx/mpc82xx.c
+++ b/arch/powerpc/platforms/82xx/mpc82xx.c
@@ -36,7 +36,6 @@
 #include <asm/time.h>
 #include <asm/io.h>
 #include <asm/machdep.h>
-#include <asm/bootinfo.h>
 #include <asm/pci-bridge.h>
 #include <asm/mpc8260.h>
 #include <asm/irq.h>
diff --git a/arch/powerpc/platforms/82xx/mpc82xx_ads.c b/arch/powerpc/platforms/82xx/mpc82xx_ads.c
index 2d1b05b..c0a0c56 100644
--- a/arch/powerpc/platforms/82xx/mpc82xx_ads.c
+++ b/arch/powerpc/platforms/82xx/mpc82xx_ads.c
@@ -37,7 +37,6 @@
 #include <asm/time.h>
 #include <asm/io.h>
 #include <asm/machdep.h>
-#include <asm/bootinfo.h>
 #include <asm/pci-bridge.h>
 #include <asm/mpc8260.h>
 #include <asm/irq.h>
diff --git a/arch/powerpc/platforms/82xx/pq2ads.h b/arch/powerpc/platforms/82xx/pq2ads.h
index 5b5cca6..6f749b7 100644
--- a/arch/powerpc/platforms/82xx/pq2ads.h
+++ b/arch/powerpc/platforms/82xx/pq2ads.h
@@ -23,7 +23,6 @@
 #define __MACH_ADS8260_DEFS

 #include <linux/seq_file.h>
-#include <asm/ppcboot.h>

 /* For our show_cpuinfo hooks. */
 #define CPUINFO_VENDOR		"Freescale Semiconductor"
diff --git a/arch/powerpc/platforms/83xx/mpc832x_mds.c b/arch/powerpc/platforms/83xx/mpc832x_mds.c
index 2c8e641..61e3f1c 100644
--- a/arch/powerpc/platforms/83xx/mpc832x_mds.c
+++ b/arch/powerpc/platforms/83xx/mpc832x_mds.c
@@ -32,7 +32,6 @@
 #include <asm/io.h>
 #include <asm/machdep.h>
 #include <asm/ipic.h>
-#include <asm/bootinfo.h>
 #include <asm/irq.h>
 #include <asm/prom.h>
 #include <asm/udbg.h>
diff --git a/arch/powerpc/platforms/83xx/mpc834x_itx.c b/arch/powerpc/platforms/83xx/mpc834x_itx.c
index 47ba544..6d06645 100644
--- a/arch/powerpc/platforms/83xx/mpc834x_itx.c
+++ b/arch/powerpc/platforms/83xx/mpc834x_itx.c
@@ -30,7 +30,6 @@
 #include <asm/io.h>
 #include <asm/machdep.h>
 #include <asm/ipic.h>
-#include <asm/bootinfo.h>
 #include <asm/irq.h>
 #include <asm/prom.h>
 #include <asm/udbg.h>
diff --git a/arch/powerpc/platforms/83xx/mpc834x_mds.c b/arch/powerpc/platforms/83xx/mpc834x_mds.c
index 4c9ff9c..f8aba9a 100644
--- a/arch/powerpc/platforms/83xx/mpc834x_mds.c
+++ b/arch/powerpc/platforms/83xx/mpc834x_mds.c
@@ -30,7 +30,6 @@
 #include <asm/io.h>
 #include <asm/machdep.h>
 #include <asm/ipic.h>
-#include <asm/bootinfo.h>
 #include <asm/irq.h>
 #include <asm/prom.h>
 #include <asm/udbg.h>
diff --git a/arch/powerpc/platforms/83xx/mpc836x_mds.c b/arch/powerpc/platforms/83xx/mpc836x_mds.c
index 84b5893..69970b9 100644
--- a/arch/powerpc/platforms/83xx/mpc836x_mds.c
+++ b/arch/powerpc/platforms/83xx/mpc836x_mds.c
@@ -38,7 +38,6 @@
 #include <asm/io.h>
 #include <asm/machdep.h>
 #include <asm/ipic.h>
-#include <asm/bootinfo.h>
 #include <asm/irq.h>
 #include <asm/prom.h>
 #include <asm/udbg.h>
diff --git a/arch/powerpc/platforms/85xx/mpc85xx_cds.c b/arch/powerpc/platforms/85xx/mpc85xx_cds.c
index 6a171e9..0402334 100644
--- a/arch/powerpc/platforms/85xx/mpc85xx_cds.c
+++ b/arch/powerpc/platforms/85xx/mpc85xx_cds.c
@@ -35,7 +35,6 @@
 #include <asm/io.h>
 #include <asm/machdep.h>
 #include <asm/ipic.h>
-#include <asm/bootinfo.h>
 #include <asm/pci-bridge.h>
 #include <asm/mpc85xx.h>
 #include <asm/irq.h>
diff --git a/arch/powerpc/platforms/85xx/mpc85xx_mds.c b/arch/powerpc/platforms/85xx/mpc85xx_mds.c
index be25ecd..53830c9 100644
--- a/arch/powerpc/platforms/85xx/mpc85xx_mds.c
+++ b/arch/powerpc/platforms/85xx/mpc85xx_mds.c
@@ -38,7 +38,6 @@
 #include <asm/time.h>
 #include <asm/io.h>
 #include <asm/machdep.h>
-#include <asm/bootinfo.h>
 #include <asm/pci-bridge.h>
 #include <asm/mpc85xx.h>
 #include <asm/irq.h>
diff --git a/arch/powerpc/platforms/8xx/m8xx_setup.c b/arch/powerpc/platforms/8xx/m8xx_setup.c
index f169355..f00c8d1 100644
--- a/arch/powerpc/platforms/8xx/m8xx_setup.c
+++ b/arch/powerpc/platforms/8xx/m8xx_setup.c
@@ -36,13 +36,11 @@

 #include <asm/mmu.h>
 #include <asm/reg.h>
-#include <asm/residual.h>
 #include <asm/io.h>
 #include <asm/pgtable.h>
 #include <asm/mpc8xx.h>
 #include <asm/8xx_immap.h>
 #include <asm/machdep.h>
-#include <asm/bootinfo.h>
 #include <asm/time.h>
 #include <asm/prom.h>
 #include <asm/fs_pd.h>
@@ -55,7 +53,9 @@ struct mpc8xx_pcmcia_ops m8xx_pcmcia_ops;
 #endif

 void m8xx_calibrate_decr(void);
+#ifdef CONFIG_8xx_WDT
 extern void m8xx_wdt_handler_install(bd_t *bp);
+#endif
 extern int cpm_pic_init(void);
 extern int cpm_get_irq(void);

diff --git a/arch/powerpc/platforms/8xx/mpc86xads.h b/arch/powerpc/platforms/8xx/mpc86xads.h
index 59bad2f..dd10cd2 100644
--- a/arch/powerpc/platforms/8xx/mpc86xads.h
+++ b/arch/powerpc/platforms/8xx/mpc86xads.h
@@ -15,7 +15,6 @@
 #ifndef __ASM_MPC86XADS_H__
 #define __ASM_MPC86XADS_H__

-#include <asm/ppcboot.h>
 #include <sysdev/fsl_soc.h>

 /* U-Boot maps BCSR to 0xff080000 */
diff --git a/arch/powerpc/platforms/8xx/mpc86xads_setup.c b/arch/powerpc/platforms/8xx/mpc86xads_setup.c
index d881647..8f64f48 100644
--- a/arch/powerpc/platforms/8xx/mpc86xads_setup.c
+++ b/arch/powerpc/platforms/8xx/mpc86xads_setup.c
@@ -31,7 +31,6 @@
 #include <asm/processor.h>
 #include <asm/system.h>
 #include <asm/time.h>
-#include <asm/ppcboot.h>
 #include <asm/mpc8xx.h>
 #include <asm/8xx_immap.h>
 #include <asm/commproc.h>
diff --git a/arch/powerpc/platforms/8xx/mpc885ads.h b/arch/powerpc/platforms/8xx/mpc885ads.h
index 7c31aec..14db124 100644
--- a/arch/powerpc/platforms/8xx/mpc885ads.h
+++ b/arch/powerpc/platforms/8xx/mpc885ads.h
@@ -15,7 +15,6 @@
 #ifndef __ASM_MPC885ADS_H__
 #define __ASM_MPC885ADS_H__

-#include <asm/ppcboot.h>
 #include <sysdev/fsl_soc.h>

 /* U-Boot maps BCSR to 0xff080000 */
diff --git a/arch/powerpc/platforms/8xx/mpc885ads_setup.c b/arch/powerpc/platforms/8xx/mpc885ads_setup.c
index bd5ff7a..d3da385 100644
--- a/arch/powerpc/platforms/8xx/mpc885ads_setup.c
+++ b/arch/powerpc/platforms/8xx/mpc885ads_setup.c
@@ -32,7 +32,6 @@
 #include <asm/processor.h>
 #include <asm/system.h>
 #include <asm/time.h>
-#include <asm/ppcboot.h>
 #include <asm/mpc8xx.h>
 #include <asm/8xx_immap.h>
 #include <asm/commproc.h>
diff --git a/arch/powerpc/platforms/chrp/smp.c b/arch/powerpc/platforms/chrp/smp.c
index a137d13..10a4a4d 100644
--- a/arch/powerpc/platforms/chrp/smp.c
+++ b/arch/powerpc/platforms/chrp/smp.c
@@ -26,7 +26,6 @@
 #include <asm/io.h>
 #include <asm/prom.h>
 #include <asm/smp.h>
-#include <asm/residual.h>
 #include <asm/time.h>
 #include <asm/machdep.h>
 #include <asm/mpic.h>
diff --git a/arch/powerpc/platforms/embedded6xx/ls_uart.c b/arch/powerpc/platforms/embedded6xx/ls_uart.c
index d0bee9f..f7a4def 100644
--- a/arch/powerpc/platforms/embedded6xx/ls_uart.c
+++ b/arch/powerpc/platforms/embedded6xx/ls_uart.c
@@ -5,7 +5,6 @@
 #include <linux/serial_8250.h>
 #include <asm/io.h>
 #include <asm/mpc10x.h>
-#include <asm/ppc_sys.h>
 #include <asm/prom.h>
 #include <asm/termbits.h>

diff --git a/arch/powerpc/platforms/powermac/bootx_init.c b/arch/powerpc/platforms/powermac/bootx_init.c
index 9d73d02..cf66091 100644
--- a/arch/powerpc/platforms/powermac/bootx_init.c
+++ b/arch/powerpc/platforms/powermac/bootx_init.c
@@ -17,7 +17,6 @@
 #include <asm/prom.h>
 #include <asm/page.h>
 #include <asm/bootx.h>
-#include <asm/bootinfo.h>
 #include <asm/btext.h>
 #include <asm/io.h>

-- 
1.5.2.2

^ permalink raw reply related

* [PATCH 0/3 v2] Remove need for include/asm-ppc
From: Kumar Gala @ 2007-08-18 17:05 UTC (permalink / raw)
  To: linuxppc-dev

This patch series removes the need for include/asm-ppc in the ARCH=powerpc
build for ppc32.  They exist in the following git tree:

  master.kernel.org:/pub/scm/linux/kernel/git/galak/powerpc.git for-2.6.24

posting here for everyone else to see.

Updated with changes suggested by Arnd & Segher. (removal 82xx pci header
and moving some headers under platforms if not globally needed).

- k

^ permalink raw reply

* Re: [PATCH 6/7 v2] fs_enet: Be an of_platform device when CONFIG_PPC_CPM_NEW_BINDING is set.
From: Kumar Gala @ 2007-08-18 16:36 UTC (permalink / raw)
  To: Scott Wood; +Cc: netdev, jgarzik, linuxppc-dev
In-Reply-To: <20070817181718.GA15792@ld0162-tx32.am.freescale.net>


On Aug 17, 2007, at 1:17 PM, Scott Wood wrote:

> The existing OF glue code was crufty and broken.  Rather than fix  
> it, it
> will be removed, and the ethernet driver now talks to the device tree
> directly.
>
> The old, non-CONFIG_PPC_CPM_NEW_BINDING code can go away once CPM
> platforms are dropped from arch/ppc (which will hopefully be soon),  
> and
> existing arch/powerpc boards that I wasn't able to test on for this
> patchset get converted (which should be even sooner).
>
> mii-bitbang.c now also uses the generic bitbang code.
>
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> ---
> Sorry, the previous version of this patch had bb_ops in the wrong
> place, and wouldn't build when not using the new binding.

This patch seems to mix moving to using the device tree directly w/o  
some other modifications.  Can it be broken into those two changes as  
they'd be easier to review.

- k

^ permalink raw reply

* Re: still using stabs debug format?
From: Kumar Gala @ 2007-08-18 16:33 UTC (permalink / raw)
  To: Segher Boessenkool; +Cc: linuxppc-dev@ozlabs.org list, Ed Swarthout
In-Reply-To: <4948353cd5e9c566a8151eca8c4bbcb7@kernel.crashing.org>


On Aug 17, 2007, at 7:54 PM, Segher Boessenkool wrote:

>> Is anyone really still using the stabs format for kernel debug?
>>
>> can we kill off the .stabs references?
>
> What, you want to replace them with dwarf markup?  Or just
> get rid of the debug info completely?

There are two users today:

* N_SO for file information we can easily make into .file
* N_FUN used in _GLOBAL() that marks it a 'function' is a bit  
misleading since we use this for both functions and data.  Not sure  
what to do about that one, any suggestions?

- k

^ permalink raw reply

* Re: [RFC PATCH v0.1] net driver: mpc52xx fec
From: Domen Puncer @ 2007-08-18 10:06 UTC (permalink / raw)
  To: Matt Sealey; +Cc: linuxppc-embedded
In-Reply-To: <20070810095153.GC13994@moe.telargo.com>

Hi!

On 10/08/07 11:51 +0200, Domen Puncer wrote:
> Index: work-powerpc.git/arch/powerpc/boot/dts/lite5200b.dts
> ===================================================================
> --- work-powerpc.git.orig/arch/powerpc/boot/dts/lite5200b.dts
> +++ work-powerpc.git/arch/powerpc/boot/dts/lite5200b.dts
> +		mdio@3000 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			device_type = "mdio";
> +			compatible = "mpc5200b-fec-phy";
> +			reg = <3000 400>;	// fec range, since we need to setup fec interrupts
> +			interrupts = <2 5 0>;	// these are for "mii command finished", not link changes & co.
> +			interrupt-parent = <&mpc5200_pic>;
> +
> +			phy0:ethernet-phy@0 {
> +				device_type = "ethernet-phy";
> +				reg = <0>;
> +			};
>  		};

I am struggling with this part on Efika.
I would like to add this to the device tree from
fixup_device_tree_efika() (arch/powerpc/kernel/prom_init.c).

AFAICS client-services doesn't offer anything like new-device,
so I guess "interpret" or "call-method" will have to be used.

I have read some docs, but I'm still wandering in the dark.
Can I please get an example?
Pretty please with a cherry on top?


	Domen

^ permalink raw reply

* Re: 2.6.23-rc3 broken on G5
From: Andreas Schwab @ 2007-08-18  9:36 UTC (permalink / raw)
  To: Paul Mackerras; +Cc: linuxppc-dev
In-Reply-To: <18118.41979.148016.177427@cargo.ozlabs.ibm.com>

Paul Mackerras <paulus@samba.org> writes:

> How much RAM does your machine have?

1.25 GB.  It also has an nvidia gfx card, in case it matters.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

^ permalink raw reply

* Re: 2.6.23-rc3 broken on G5
From: Paul Mackerras @ 2007-08-18  7:47 UTC (permalink / raw)
  To: Andreas Schwab; +Cc: linuxppc-dev
In-Reply-To: <jefy2j6qtq.fsf@sykes.suse.de>

Andreas Schwab writes:

> It's a dual 1.8GHz.  Config is attached.

OK, your config works on my dual G5 (if I build in the SCSI disk
driver and the sata_svw driver so it can find my root patition).

How much RAM does your machine have?

Paul.

^ permalink raw reply

* Re: [PATCH 2/3] [POWERPC] Copy over headers from arch/ppc to arch/powerpc that we need
From: Kumar Gala @ 2007-08-18  5:40 UTC (permalink / raw)
  To: Segher Boessenkool; +Cc: linuxppc-dev, Paul Mackerras
In-Reply-To: <a79f1cbe580d675c6bb231e4e3a0326b@kernel.crashing.org>


On Aug 17, 2007, at 6:25 PM, Segher Boessenkool wrote:

>>  include/asm-powerpc/8xx_immap.h   |  564 +++++++++++++++++
>>  include/asm-powerpc/commproc.h    |  692 ++++++++++++++++++++
>>  include/asm-powerpc/cpm2.h        | 1248 +++++++++++++++++++++++++ 
>> ++++++++++++
>>  include/asm-powerpc/gg2.h         |   61 ++
>>  include/asm-powerpc/highmem.h     |  135 ++++
>>  include/asm-powerpc/hydra.h       |  102 +++
>>  include/asm-powerpc/immap_cpm2.h  |  648 +++++++++++++++++++
>>  include/asm-powerpc/kgdb.h        |   57 ++
>>  include/asm-powerpc/m8260_pci.h   |  187 ++++++
>>  include/asm-powerpc/mpc10x.h      |  180 ++++++
>>  include/asm-powerpc/mpc52xx_psc.h |  191 ++++++
>
> Can't we move most of this to the dir where they are used,
> instead?

The following are shared between arch/powerpc code and drivers:

  include/asm-powerpc/8xx_immap.h   |  564 +++++++++++++++++
  include/asm-powerpc/commproc.h    |  692 ++++++++++++++++++++
  include/asm-powerpc/cpm2.h        | 1248 +++++++++++++++++++++++++++ 
++++++++++
  include/asm-powerpc/immap_cpm2.h  |  648 +++++++++++++++++++
  include/asm-powerpc/mpc52xx_psc.h |  191 ++++++

These could possibly move, I'll look into it:
  include/asm-powerpc/gg2.h         |   61 ++		[into platforms/chrp]
  include/asm-powerpc/hydra.h       |  102 +++		[into platforms/chrp]
  include/asm-powerpc/kgdb.h        |   57 ++		[not sure, maybe leave  
here for now]
  include/asm-powerpc/mpc10x.h      |  180 ++++++	[into platforms/ 
embedded6xx]

Needs to live in include/asm-powerpc:
  include/asm-powerpc/highmem.h     |  135 ++++

Will kill this one per Scott/Arnd:
  include/asm-powerpc/m8260_pci.h   |  187 ++++++

- k

^ permalink raw reply

* Re: [PATCH] [POWERPC] Fix interrupt routing and setup of ULI M1575 on FSL boards
From: Kumar Gala @ 2007-08-18  5:30 UTC (permalink / raw)
  To: Paul Mackerras; +Cc: linuxppc-dev
In-Reply-To: <18118.13541.470351.661964@cargo.ozlabs.ibm.com>


On Aug 17, 2007, at 6:53 PM, Paul Mackerras wrote:

> Kumar Gala writes:
>
>> Its a regression in that the ULI M1575 doesn't really work properly
>> on some of these boards in certain situations.
>
> Well, "it doesn't work" isn't of itself a regression, a regression is
> "it used to work and now it doesn't".

Interesting, maybe I was grouping both of these together as things  
that could go in after the -rc1.  I was under the impression that bug  
fixes could also go in post -rc1.

> In any case the lateness x largeness product (LxL) of that patch is a
> bit too high.  Is there a simpler way to fix it that doesn't involve
> moving all that code around?

I'm not really sure how to accomplish that.  I could possibly  
duplicate the 'fixes' in each board port but that seems pointless and  
I doubt would reduce the code modifications amount any.

Most of this has to due with the kernel / firmware / device tree  
interface.  If we have a new firmware that modifies the memory map  
and requires changes to the device tree and kernel is that a fix?

I understand the concern related to the LxL.  I'd also say the set of  
users this effects is very small since its just the two boards.

I leave it up to you if you want to grab this patch or not for  
2.6.23.  If not please pull all these into your for-2.6.24 branch.

- k

^ permalink raw reply

* Re: Booting new MPC5200B board
From: Jon Smirl @ 2007-08-18  2:33 UTC (permalink / raw)
  To: linuxppc-embedded
In-Reply-To: <9e4733910708171247n15475e4l2c86cade776d3fb3@mail.gmail.com>

On 8/17/07, Jon Smirl <jonsmirl@gmail.com> wrote:
> I'm using OSELAS-tiny-5 to compile a kernel for my new Phytec
> 5200B-tiny board with u-boot. When I try booting the kernel via tftpd
> I get this error about the RAMDisk. Why does it want a RAMDisk, and
> how do I supply it with one?

The problem with the RAMDisk error is caused by the board shipping
with uboot 1.1.4. Upgrading to 1.2.0 fixes it.

1.1.4 doesn't implement dtb support
 bootm 0x500000 - 0x400000
gets interpreted as load a RAM disk at 00000.

-- 
Jon Smirl
jonsmirl@gmail.com

^ permalink raw reply

* Re: [PATCH] powerpc: Implement atomic{, 64}_{read, write}() without volatile
From: Segher Boessenkool @ 2007-08-18  1:29 UTC (permalink / raw)
  To: Paul Mackerras; +Cc: linux-arch, linuxppc-dev, linux-kernel
In-Reply-To: <18116.61246.856760.243185@cargo.ozlabs.ibm.com>

>> Instead, use asm() like all other atomic operations already do.
>
>> +static __inline__ long atomic64_read(const atomic_t *v)
>
>> +static __inline__ void atomic64_set(atomic_t *v, long i)
>
> s/atomic_t/atomic64_t/ in both lines.  I've edited my copy of the 
> patch.

Ouch, sorry about that.


Segher

^ permalink raw reply

* Re: still using stabs debug format?
From: Segher Boessenkool @ 2007-08-18  0:54 UTC (permalink / raw)
  To: Kumar Gala; +Cc: linuxppc-dev@ozlabs.org list, Ed Swarthout
In-Reply-To: <A0830B08-2A3A-4BC1-BAAB-82D1C1D3CB7E@kernel.crashing.org>

> Is anyone really still using the stabs format for kernel debug?
>
> can we kill off the .stabs references?

What, you want to replace them with dwarf markup?  Or just
get rid of the debug info completely?


Segher

^ permalink raw reply

* Re: [PATCH] [POWERPC] Fix interrupt routing and setup of ULI M1575 on FSL boards
From: Paul Mackerras @ 2007-08-17 23:53 UTC (permalink / raw)
  To: Kumar Gala; +Cc: linuxppc-dev
In-Reply-To: <D6CFE4FC-5112-450B-B13F-2DC40165EB71@kernel.crashing.org>

Kumar Gala writes:

> Its a regression in that the ULI M1575 doesn't really work properly  
> on some of these boards in certain situations.

Well, "it doesn't work" isn't of itself a regression, a regression is
"it used to work and now it doesn't".

In any case the lateness x largeness product (LxL) of that patch is a
bit too high.  Is there a simpler way to fix it that doesn't involve
moving all that code around?

Paul.

^ permalink raw reply

* Re: Patches for ppc?
From: Satya @ 2007-08-17 23:28 UTC (permalink / raw)
  To: Johan Borkhuis; +Cc: Linuxppc-dev, David Woodhouse
In-Reply-To: <46C5B40F.5040209@dutchspace.nl>

hi,
what's the issue with arch/ppc again? why is it being phased out? I am
working with the IBM Blue Gene/L which is based on ppc440. I need to
get a patch in too! :)

I noticed that head_44x.S has been copied to arch/powerpc/kernel in
the current head tree, but is it functional yet? has everything been
moved to arch/powerpc ? how about the include files ?

thanks!
satya.

On 8/17/07, Johan Borkhuis <j.borkhuis@dutchspace.nl> wrote:
> David Woodhouse wrote:
> > On Fri, 2007-08-17 at 16:36 +0200, Johan Borkhuis wrote:
> >
> >> Well, this is one of the minor issues I have with the ppc architecture,
> >> but I am quite happy with it. Even for this I could make a workaround,
> >> but I guess this is something that other might stumble upon.
> >>
> >> I would like to move to powerpc, but for the moment there is no official
> >> support for powerpc, for ppc there is, but I don't have the time to move
> >> this to powerpc. So I am afraid I don't have much choice.
> >>
> >
> > It's times like this you suddenly realise you should have paid the extra
> > cash for a licence which allows you access to the source code?
> >
> >
> That is not the problem: we have access to all the sources, but I am
> waiting for the official support for the powerpc architecure. I am using
> an MVME3100 board from Motorola and I know that they are working on it,
> but it is not released (yet).
>
> Kind regards,
>     Johan Borkhuis
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>

^ permalink raw reply

* Re: [PATCH 2/3] [POWERPC] Copy over headers from arch/ppc to arch/powerpc that we need
From: Segher Boessenkool @ 2007-08-17 23:25 UTC (permalink / raw)
  To: Kumar Gala; +Cc: linuxppc-dev, Paul Mackerras
In-Reply-To: <Pine.LNX.4.64.0708170213040.15311@blarg.am.freescale.net>

>  include/asm-powerpc/8xx_immap.h   |  564 +++++++++++++++++
>  include/asm-powerpc/commproc.h    |  692 ++++++++++++++++++++
>  include/asm-powerpc/cpm2.h        | 1248 
> +++++++++++++++++++++++++++++++++++++
>  include/asm-powerpc/gg2.h         |   61 ++
>  include/asm-powerpc/highmem.h     |  135 ++++
>  include/asm-powerpc/hydra.h       |  102 +++
>  include/asm-powerpc/immap_cpm2.h  |  648 +++++++++++++++++++
>  include/asm-powerpc/kgdb.h        |   57 ++
>  include/asm-powerpc/m8260_pci.h   |  187 ++++++
>  include/asm-powerpc/mpc10x.h      |  180 ++++++
>  include/asm-powerpc/mpc52xx_psc.h |  191 ++++++

Can't we move most of this to the dir where they are used,
instead?


Segher

^ permalink raw reply

* Re: [PATCH 1/1] libata: pata_pdc2027x PLL input clock fix
From: Mikael Pettersson @ 2007-08-17 20:51 UTC (permalink / raw)
  To: alan, jeff; +Cc: dwm, mikpe, linux-ide, bahadir.balban, linuxppc-dev, albertl

On Thu, 16 Aug 2007 21:19:40 +0100, Alan Cox wrote:
> > > Unfortunately this breaks pata_pdc2027x on my PowerMac G3:
> > 
> > Did this ever get resolved?
> 
> All went quiet so I assume its gone away ?

-ENOTIME

The regression is still there in 2.6.23-rc3 (I just checked),
but I haven't had time to debug it yet. I'll try to do something
about it this weekend.

^ permalink raw reply

* Re: [PATCH 2/3] [POWERPC] Copy over headers from arch/ppc to arch/powerpc that we need
From: Arnd Bergmann @ 2007-08-17 17:42 UTC (permalink / raw)
  To: linuxppc-dev
In-Reply-To: <200708171905.52855.arnd@arndb.de>

On Friday 17 August 2007, Arnd Bergmann wrote:
> The m8260_pci.h file is not namespace clean, it defines macros like
> PCI_CFG_ADDR_REG that are likely to create conflicts at some point of
> time. Since the only file including this header is 
> arch/powerpc/platforms/82xx/m82xx_pci.h, I'd suggest merging the two,
> to make sure nobody can accidentally include it.

Upon closer inspection, none of the definitions in this file are
actually used in arch/powerpc, or should be.

So, can we just kill that file, as you did with the others in your
first patch?

	Arnd <><

^ permalink raw reply

* Re: [PATCH 2/3] [POWERPC] Copy over headers from arch/ppc to arch/powerpc that we need
From: Scott Wood @ 2007-08-17 20:50 UTC (permalink / raw)
  To: Arnd Bergmann; +Cc: linuxppc-dev
In-Reply-To: <20070817204502.GA6128@ld0162-tx32.am.freescale.net>

On Fri, Aug 17, 2007 at 03:45:02PM -0500, Scott Wood wrote:
> On Fri, Aug 17, 2007 at 07:05:52PM +0200, Arnd Bergmann wrote:
> > The m8260_pci.h file is not namespace clean, it defines macros like
> > PCI_CFG_ADDR_REG that are likely to create conflicts at some point of
> > time. Since the only file including this header is 
> > arch/powerpc/platforms/82xx/m82xx_pci.h, I'd suggest merging the two,
> > to make sure nobody can accidentally include it.
> 
> Better yet, just get rid of that define -- nothing uses it AFAICT.

To elaborate, I grepped for all of the symbols defined in m8260_pci.h,
and none get any hits in arch/powerpc.

-Scott

^ permalink raw reply

* Re: [PATCH 2/3] [POWERPC] Copy over headers from arch/ppc to arch/powerpc that we need
From: Scott Wood @ 2007-08-17 20:45 UTC (permalink / raw)
  To: Arnd Bergmann; +Cc: linuxppc-dev
In-Reply-To: <200708171905.52855.arnd@arndb.de>

On Fri, Aug 17, 2007 at 07:05:52PM +0200, Arnd Bergmann wrote:
> The m8260_pci.h file is not namespace clean, it defines macros like
> PCI_CFG_ADDR_REG that are likely to create conflicts at some point of
> time. Since the only file including this header is 
> arch/powerpc/platforms/82xx/m82xx_pci.h, I'd suggest merging the two,
> to make sure nobody can accidentally include it.

Better yet, just get rid of that define -- nothing uses it AFAICT.

-Scott

^ permalink raw reply

* Re: [PATCH 0/3] Remove need for include/asm-ppc
From: Arnd Bergmann @ 2007-08-17 17:06 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: Paul Mackerras
In-Reply-To: <Pine.LNX.4.64.0708170157140.15311@blarg.am.freescale.net>

On Friday 17 August 2007, Kumar Gala wrote:
> This patch series removes the need for include/asm-ppc in the ARCH=3Dpowe=
rpc
> build for ppc32. =A0They exist in the following git tree:
>=20
> =A0 master.kernel.org:/pub/scm/linux/kernel/git/galak/powerpc.git for-2.6=
=2E24
>=20
> posting here for everyone else to see.

Cool stuff. At one point I started doing a partial version of your patch 1/=
3,
but gave up soon when it grew too big.

	Arnd <><

^ permalink raw reply


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox