* [PATCH] ppc: remove unused amiga_free_irq and mach_free_irq
From: Fernando Luis Vázquez Cao @ 2007-08-22 7:23 UTC (permalink / raw)
To: linuxppc-dev; +Cc: paulus, linux-kernel
amiga_free_irq and mach_free_irq are never used, so delete them.
Signed-off-by: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>
---
diff -urNp linux-2.6.23-rc3-orig/arch/ppc/amiga/config.c linux-2.6.23-rc3/arch/ppc/amiga/config.c
--- linux-2.6.23-rc3-orig/arch/ppc/amiga/config.c 2007-08-22 15:53:20.000000000 +0900
+++ linux-2.6.23-rc3/arch/ppc/amiga/config.c 2007-08-22 15:56:15.000000000 +0900
@@ -72,7 +72,6 @@ static void amiga_sched_init(irqreturn_t
/* amiga specific irq functions */
extern void amiga_init_IRQ (void);
extern void (*amiga_default_handler[]) (int, void *, struct pt_regs *);
-extern void amiga_free_irq (unsigned int irq, void *dev_id);
extern void amiga_enable_irq (unsigned int);
extern void amiga_disable_irq (unsigned int);
static void amiga_get_model(char *model);
@@ -378,7 +377,6 @@ void __init config_amiga(void)
mach_init_IRQ = amiga_init_IRQ;
#ifndef CONFIG_APUS
mach_default_handler = &amiga_default_handler;
- mach_free_irq = amiga_free_irq;
enable_irq = amiga_enable_irq;
disable_irq = amiga_disable_irq;
#endif
^ permalink raw reply
* [PATCH] ppc: remove unused amiga_request_irq and mach_request_irq
From: Fernando Luis Vázquez Cao @ 2007-08-22 7:20 UTC (permalink / raw)
To: linuxppc-dev; +Cc: paulus, linux-kernel
amiga_request_irq and mach_request_irq are never used, so delete them.
Signed-off-by: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>
---
diff -urNp linux-2.6.23-rc3-orig/arch/ppc/amiga/config.c linux-2.6.23-rc3/arch/ppc/amiga/config.c
--- linux-2.6.23-rc3-orig/arch/ppc/amiga/config.c 2007-07-09 08:32:17.000000000 +0900
+++ linux-2.6.23-rc3/arch/ppc/amiga/config.c 2007-08-22 15:45:51.000000000 +0900
@@ -72,10 +72,6 @@ static void amiga_sched_init(irqreturn_t
/* amiga specific irq functions */
extern void amiga_init_IRQ (void);
extern void (*amiga_default_handler[]) (int, void *, struct pt_regs *);
-extern int amiga_request_irq (unsigned int irq,
- void (*handler)(int, void *, struct pt_regs *),
- unsigned long flags, const char *devname,
- void *dev_id);
extern void amiga_free_irq (unsigned int irq, void *dev_id);
extern void amiga_enable_irq (unsigned int);
extern void amiga_disable_irq (unsigned int);
@@ -382,7 +378,6 @@ void __init config_amiga(void)
mach_init_IRQ = amiga_init_IRQ;
#ifndef CONFIG_APUS
mach_default_handler = &amiga_default_handler;
- mach_request_irq = amiga_request_irq;
mach_free_irq = amiga_free_irq;
enable_irq = amiga_enable_irq;
disable_irq = amiga_disable_irq;
^ permalink raw reply
* [PATCH] ppc: remove unused sys_request_irq
From: Fernando Luis Vázquez Cao @ 2007-08-22 8:24 UTC (permalink / raw)
To: linuxppc-dev; +Cc: paulus, linux-kernel
sys_request_irq is never used, so delete it.
Signed-off-by: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>
---
diff -urNp linux-2.6.23-rc3-orig/arch/ppc/amiga/ints.c linux-2.6.23-rc3/arch/ppc/amiga/ints.c
--- linux-2.6.23-rc3-orig/arch/ppc/amiga/ints.c 2007-07-09 08:32:17.000000000 +0900
+++ linux-2.6.23-rc3/arch/ppc/amiga/ints.c 2007-08-22 17:12:48.000000000 +0900
@@ -75,38 +75,6 @@ irq_node_t *new_irq_node(void)
return NULL;
}
-int sys_request_irq(unsigned int irq,
- void (*handler)(int, void *, struct pt_regs *),
- unsigned long flags, const char *devname, void *dev_id)
-{
- if (irq < IRQ1 || irq > IRQ7) {
- printk("%s: Incorrect IRQ %d from %s\n",
- __FUNCTION__, irq, devname);
- return -ENXIO;
- }
-
-#if 0
- if (!(irq_list[irq].flags & IRQ_FLG_STD)) {
- if (irq_list[irq].flags & IRQ_FLG_LOCK) {
- printk("%s: IRQ %d from %s is not replaceable\n",
- __FUNCTION__, irq, irq_list[irq].devname);
- return -EBUSY;
- }
- if (!(flags & IRQ_FLG_REPLACE)) {
- printk("%s: %s can't replace IRQ %d from %s\n",
- __FUNCTION__, devname, irq, irq_list[irq].devname);
- return -EBUSY;
- }
- }
-#endif
-
- irq_list[irq].handler = handler;
- irq_list[irq].flags = flags;
- irq_list[irq].dev_id = dev_id;
- irq_list[irq].devname = devname;
- return 0;
-}
-
void sys_free_irq(unsigned int irq, void *dev_id)
{
if (irq < IRQ1 || irq > IRQ7) {
^ permalink raw reply
* [PATCH] ppc: remove unused sys_free_irq
From: Fernando Luis Vázquez Cao @ 2007-08-22 8:24 UTC (permalink / raw)
To: linuxppc-dev; +Cc: paulus, linux-kernel
sys_free_irq is never used, so delete it.
Signed-off-by: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>
---
diff -urNp linux-2.6.23-rc3-orig/arch/ppc/amiga/ints.c linux-2.6.23-rc3/arch/ppc/amiga/ints.c
--- linux-2.6.23-rc3-orig/arch/ppc/amiga/ints.c 2007-08-22 17:14:32.000000000 +0900
+++ linux-2.6.23-rc3/arch/ppc/amiga/ints.c 2007-08-22 17:15:27.000000000 +0900
@@ -75,23 +75,6 @@ irq_node_t *new_irq_node(void)
return NULL;
}
-void sys_free_irq(unsigned int irq, void *dev_id)
-{
- if (irq < IRQ1 || irq > IRQ7) {
- printk("%s: Incorrect IRQ %d\n", __FUNCTION__, irq);
- return;
- }
-
- if (irq_list[irq].dev_id != dev_id)
- printk("%s: Removing probably wrong IRQ %d from %s\n",
- __FUNCTION__, irq, irq_list[irq].devname);
-
- irq_list[irq].handler = (*mach_default_handler)[irq];
- irq_list[irq].flags = 0;
- irq_list[irq].dev_id = NULL;
- irq_list[irq].devname = default_names[irq];
-}
-
asmlinkage void process_int(unsigned long vec, struct pt_regs *fp)
{
if (vec >= VEC_INT1 && vec <= VEC_INT7 && !MACH_IS_BVME6000) {
^ permalink raw reply
* Only one phy can be accessed through ioctls to a socket (patch available)
From: DI BACCO ANTONIO - technolabs @ 2007-08-22 8:56 UTC (permalink / raw)
To: linuxppc-embedded
In file fs_enet-main.c in function fs_ioctl the phy_mii_ioctl can be
issued only to the phydev associated with the FEC. If I have several
PHYs and only one associated to the FEC I cannot access all the PHYs. I
have a patch to overcome this limitation, is it interesting or not
useful?
=20
I need this patch because I have instantiated a virtual "Fixed PHY" and
I have associated it to my FEC, anyway I would like to access registers
of my physical PHY.
=20
Bye.
^ permalink raw reply
* Re: C67x00 Driver IRQ Problem.
From: Peter Korsgaard @ 2007-08-22 9:15 UTC (permalink / raw)
To: linuxppc-embedded
In-Reply-To: <939D37AEB47F1F49B88FAB6599B6023501A17279@hsv1dafpew02.das.gov.sanm.corp>
>>>>> "RJM" == Robertson, Joseph M <joseph.robertson@sanmina-sci.com> writes:
Hi,
RJM> c67x00 c67x00.0: USB OTG controller, p:0x43e00000, v:0xc5058000, irq:3
RJM> irq 3: nobody cared (try booting with the "irqpoll" option)
So most likely c67x00_hpi_status doesn't return != 0. Could you add a
printk to c67x00_irq to check?
--
Bye, Peter Korsgaard
^ permalink raw reply
* Badness in local_bh_enable at kernel/softirq.c:137 (linux_denx_2.6.19.2)
From: DI BACCO ANTONIO - technolabs @ 2007-08-22 9:16 UTC (permalink / raw)
To: linuxppc-embedded
[-- Attachment #1: Type: text/plain, Size: 889 bytes --]
Sending ioctls to a socket I receive the following problem (only the
first time I send a ioctl):
Badness in local_bh_enable at kernel/softirq.c:137
Call Trace:
[C0593C90] [C000A6E8] show_stack+0x48/0x190 (unreliable)
[C0593CC0] [C0003734] check_bug_trap+0xa4/0xb8
[C0593CD0] [C0004354] program_check_exception+0x2e4/0x4fc
[C0593CF0] [C0003344] ret_from_except_full+0x0/0x4c
[C0593DB0] [C01A1BD4] klist_iter_exit+0x28/0x44
[C0593DC0] [C01198E0] phy_read+0x40/0x58
[C0593DE0] [C0119A94] phy_mii_ioctl+0x70/0x18c
[C0593E00] [C011BFCC] fs_ioctl+0x60/0xb4
[C0593E20] [C0146C30] dev_ifsioc+0x174/0x3dc
[C0593E40] [C0147784] dev_ioctl+0x468/0x4d0
[C0593EB0] [C013A1D0] sock_ioctl+0x38/0x210
[C0593ED0] [C009C8D0] do_ioctl+0x38/0x84
[C0593EE0] [C009C9A8] vfs_ioctl+0x8c/0x418
[C0593F10] [C009CD74] sys_ioctl+0x40/0x74
[C0593F40] [C0002CE4] ret_from_syscall+0x0/0x38
[-- Attachment #2: Type: text/html, Size: 1692 bytes --]
^ permalink raw reply
* Re: [PATCH] ppc: remove unused amiga_request_irq and mach_request_irq
From: Paul Mackerras @ 2007-08-22 9:44 UTC (permalink / raw)
To: Fernando Luis Vázquez Cao; +Cc: linuxppc-dev, linux-kernel
In-Reply-To: <1187767237.25624.11.camel@sebastian.kern.oss.ntt.co.jp>
Fernando Luis V=E1zquez Cao writes:
> amiga=5Frequest=5Firq and mach=5Frequest=5Firq are never used, so del=
ete them.
OK, but is there a particular reason you want to do this=3F
The whole of arch/ppc is going away eventually, so I don't think we
need to remove it piece by piece.
Paul.
^ permalink raw reply
* Patches added to powerpc.git for-2.6.24 branch
From: Paul Mackerras @ 2007-08-22 9:47 UTC (permalink / raw)
To: linuxppc-dev
Josh Boyer (10):
[POWERPC] Rename 4xx paths to 40x
[POWERPC] 4xx Kconfig cleanup
[POWERPC] Rename 44x bootwrapper
[POWERPC] 4xx bootwrapper reworks
[POWERPC] 40x MMU
[POWERPC] 40x decrementer fixes
[POWERPC] Fix 40x build
[POWERPC] Bamboo DTS
[POWERPC] Bamboo board support
[POWERPC] Bamboo zImage wrapper
Olaf Hering (1):
[POWERPC] Advertise correct IDE mode on Pegasos2
Olof Johansson (1):
[POWERPC] Rework SMP timebase handoff for pasemi
Scott Wood (15):
[POWERPC] Whitespace cleanup in arch/powerpc
[POWERPC] Add clrbits8 and setbits8
[POWERPC] Use strcasecmp() rather than strncasecmp() when determining device node compatibility
[POWERPC] bootwrapper: Update .gitignore
[POWERPC] bootwrapper: Set timebase_period_ns from dt_fixup_cpu_clocks
[POWERPC] bootwrapper: dt_xlate_range() bugfixes
[POWERPC] bootwrapper: Add dt_is_compatible()
[POWERPC] bootwrapper: Add 16-bit I/O, sync(), eieio(), and barrier()
[POWERPC] bootwrapper: Add TARGET_HAS_ETHn tests to ppcboot.h
[POWERPC] bootwrapper: serial_console_init() fixes
[POWERPC] bootwrapper: Declare udelay() in ops.h
[POWERPC] bootwrapper: Add CPM serial driver
[POWERPC] bootwrapper: Move linker symbols into ops.h
[POWERPC] bootwrapper: Add 8xx cuboot support
[POWERPC] bootwrapper: Add PowerQUICC II (82xx with CPM) cuboot support
Stephen Rothwell (6):
[POWERPC] iSeries: Clean up lparmap mess
[POWERPC] Move iSeries startup code out of head_64.S
[POWERPC] Move the exception macros into a header file
[POWERPC] Move the iSeries exception vectors
[POWERPC] Split out iSeries specific exception macros
[POWERPC] Exception numbers are not relevant to iSeries
arch/powerpc/Makefile | 2
arch/powerpc/boot/.gitignore | 8
arch/powerpc/boot/44x.c | 85 ---
arch/powerpc/boot/44x.h | 5
arch/powerpc/boot/4xx.c | 192 +++++++
arch/powerpc/boot/4xx.h | 21 +
arch/powerpc/boot/Makefile | 10
arch/powerpc/boot/bamboo.c | 45 ++
arch/powerpc/boot/cpm-serial.c | 249 +++++++++
arch/powerpc/boot/cuboot-83xx.c | 1
arch/powerpc/boot/cuboot-85xx.c | 1
arch/powerpc/boot/cuboot-8xx.c | 45 ++
arch/powerpc/boot/cuboot-pq2.c | 283 ++++++++++
arch/powerpc/boot/cuboot.c | 3
arch/powerpc/boot/dcr.h | 13
arch/powerpc/boot/devtree.c | 70 ++-
arch/powerpc/boot/dts/bamboo.dts | 244 +++++++++
arch/powerpc/boot/dts/mpc8272ads.dts | 376 +++++++-------
arch/powerpc/boot/ebony.c | 6
arch/powerpc/boot/holly.c | 5
arch/powerpc/boot/io.h | 49 ++
arch/powerpc/boot/main.c | 10
arch/powerpc/boot/mpsc.c | 1
arch/powerpc/boot/mv64x60_i2c.c | 2
arch/powerpc/boot/of.c | 2
arch/powerpc/boot/ops.h | 24 +
arch/powerpc/boot/ppcboot.h | 7
arch/powerpc/boot/prpmc2800.c | 6
arch/powerpc/boot/ps3.c | 4
arch/powerpc/boot/serial.c | 19 -
arch/powerpc/boot/treeboot-bamboo.c | 27 +
arch/powerpc/boot/treeboot-ebony.c | 2
arch/powerpc/configs/bamboo_defconfig | 775 ++++++++++++++++++++++++++++
arch/powerpc/kernel/Makefile | 9
arch/powerpc/kernel/asm-offsets.c | 8
arch/powerpc/kernel/head_40x.S | 3
arch/powerpc/kernel/head_64.S | 585 +--------------------
arch/powerpc/kernel/irq.c | 4
arch/powerpc/kernel/lparmap.c | 32 -
arch/powerpc/kernel/ppc_ksyms.c | 2
arch/powerpc/kernel/prom_init.c | 11
arch/powerpc/kernel/time.c | 2
arch/powerpc/mm/40x_mmu.c | 4
arch/powerpc/mm/Makefile | 2
arch/powerpc/platforms/40x/Kconfig | 77 ---
arch/powerpc/platforms/40x/Makefile | 0
arch/powerpc/platforms/44x/Kconfig | 15 -
arch/powerpc/platforms/44x/Makefile | 1
arch/powerpc/platforms/44x/bamboo.c | 66 ++
arch/powerpc/platforms/8xx/m8xx_setup.c | 72 +--
arch/powerpc/platforms/Kconfig | 1
arch/powerpc/platforms/Kconfig.cputype | 2
arch/powerpc/platforms/chrp/pci.c | 29 +
arch/powerpc/platforms/iseries/Makefile | 1
arch/powerpc/platforms/iseries/exception.S | 251 +++++++++
arch/powerpc/platforms/iseries/exception.h | 58 ++
arch/powerpc/platforms/pasemi/setup.c | 24 +
arch/powerpc/sysdev/commproc.c | 20 -
arch/powerpc/sysdev/cpm2_common.c | 2
include/asm-powerpc/exception.h | 309 +++++++++++
include/asm-powerpc/io.h | 3
include/asm-powerpc/iseries/lpar_map.h | 3
include/asm-powerpc/mmu-40x.h | 65 ++
include/asm-powerpc/mmu.h | 3
include/asm-powerpc/page_64.h | 2
include/asm-powerpc/ppc_asm.h | 14 +
include/asm-powerpc/prom.h | 2
include/asm-powerpc/time.h | 2
68 files changed, 3158 insertions(+), 1118 deletions(-)
delete mode 100644 arch/powerpc/boot/44x.c
create mode 100644 arch/powerpc/boot/4xx.c
create mode 100644 arch/powerpc/boot/4xx.h
create mode 100644 arch/powerpc/boot/bamboo.c
create mode 100644 arch/powerpc/boot/cpm-serial.c
create mode 100644 arch/powerpc/boot/cuboot-8xx.c
create mode 100644 arch/powerpc/boot/cuboot-pq2.c
create mode 100644 arch/powerpc/boot/dts/bamboo.dts
create mode 100644 arch/powerpc/boot/treeboot-bamboo.c
create mode 100644 arch/powerpc/configs/bamboo_defconfig
rename arch/powerpc/kernel/{head_4xx.S => head_40x.S} (99%)
delete mode 100644 arch/powerpc/kernel/lparmap.c
rename arch/powerpc/mm/{4xx_mmu.c => 40x_mmu.c} (96%)
rename arch/powerpc/platforms/{4xx/Kconfig => 40x/Kconfig} (68%)
rename arch/powerpc/platforms/{4xx/Makefile => 40x/Makefile} (100%)
create mode 100644 arch/powerpc/platforms/44x/bamboo.c
create mode 100644 arch/powerpc/platforms/iseries/exception.S
create mode 100644 arch/powerpc/platforms/iseries/exception.h
create mode 100644 include/asm-powerpc/exception.h
create mode 100644 include/asm-powerpc/mmu-40x.h
^ permalink raw reply
* Re: [PATCH 3/3] Add support for xupv2p and ml410 boards.
From: Esben Nielsen @ 2007-08-22 10:20 UTC (permalink / raw)
To: Robert Woodworth; +Cc: Stephen Neuendorffer, linuxppc-embedded
In-Reply-To: <1187751864.6266.6.camel@PisteOff>
On Tue, 21 Aug 2007, Robert Woodworth wrote:
> Should the xparameters????.h file *really* be included in the tree?
>
> This file is completely board/EDK/ISE/synthesis specific. I'd rather it
> not be included and have people copy theirs from EDK.
> Or as I have done, sym-link it from my EDK project.
>
>
> Woody.
>
The solution below is in line with what we do in our 2.4 kernel to support
several of our own boards.
When you distribute the kernel you have to distribute the source as well.
You thus have to include xparameters.h such the kernel can be rebuild by
the receiver.
Esben
>
>
> On Tue, 2007-08-21 at 17:53 -0700, wolfgang.reissnegger@xilinx.com
> wrote:
>> From: Stephen Neuendorffer <stephen.neuendorffer@xilinx.com>
>
>> diff --git a/arch/ppc/platforms/4xx/xparameters/xparameters.h b/arch/ppc/platforms/4xx/xparameters/xparameters.h
>> index 01aa043..34d9844 100644
>> --- a/arch/ppc/platforms/4xx/xparameters/xparameters.h
>> +++ b/arch/ppc/platforms/4xx/xparameters/xparameters.h
>> @@ -15,8 +15,12 @@
>>
>> #if defined(CONFIG_XILINX_ML300)
>> #include "xparameters_ml300.h"
>> +#elif defined(CONFIG_XILINX_XUPV2P)
>> + #include "xparameters_xupv2p.h"
>> #elif defined(CONFIG_XILINX_ML403)
>> #include "xparameters_ml403.h"
>> +#elif defined(CONFIG_XILINX_ML41x)
>> + #include "xparameters_ml41x.h"
>> #else
>> /* Add other board xparameter includes here before the #else */
>> #error No xparameters_*.h file included
>> diff --git a/arch/ppc/platforms/4xx/xparameters/xparameters_ml41x.h b/arch/ppc/platforms/4xx/xparameters/xparameters_ml41x.h
>> new file mode 100644
>> index 0000000..06dac67
>> --- /dev/null
>> +++ b/arch/ppc/platforms/4xx/xparameters/xparameters_ml41x.h
>> @@ -0,0 +1,277 @@
>> +
>> +/*******************************************************************
>> +*
>> +* CAUTION: This file is automatically generated by libgen.
>> +* Version: Xilinx EDK 8.2.02 EDK_Im_Sp2.4
>> +* DO NOT EDIT.
>> +*
>> +* Copyright (c) 2005 Xilinx, Inc. All rights reserved.
>> +*
>> +* Description: Driver parameters
>> +*
>> +*******************************************************************/
>> +
>
>
> _______________________________________________
> Linuxppc-embedded mailing list
> Linuxppc-embedded@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-embedded
>
^ permalink raw reply
* How to port PReP to arch/powerpc?
From: Meelis Roos @ 2007-08-22 11:50 UTC (permalink / raw)
To: linuxppc-dev
It seems no one cares for arch/ppc any more but the move to powerpc was
not finished completely (PReP subarch was not migrated but sees users, I
do not know about the user base of the other subarches). So I have been
thinking about migrating PReP support to arch/powerpc myself since I use
it.
Any general guidelines or specific hints about that? I have looked
around in the code and some pieces are clearly PReP specific (setup,
pci, boot) but others seem wuite a bit mixed up with other subarches.
--
Meelis Roos (mroos@linux.ee)
^ permalink raw reply
* Re: How to port PReP to arch/powerpc?
From: Josh Boyer @ 2007-08-22 12:29 UTC (permalink / raw)
To: Meelis Roos; +Cc: linuxppc-dev
In-Reply-To: <Pine.SOC.4.64.0708221444510.5639@math.ut.ee>
On Wed, 22 Aug 2007 14:50:07 +0300 (EEST)
Meelis Roos <mroos@linux.ee> wrote:
> It seems no one cares for arch/ppc any more but the move to powerpc was
> not finished completely (PReP subarch was not migrated but sees users, I
> do not know about the user base of the other subarches). So I have been
> thinking about migrating PReP support to arch/powerpc myself since I use
> it.
The merge is still on-going. So it's not "finished" at all.
> Any general guidelines or specific hints about that? I have looked
> around in the code and some pieces are clearly PReP specific (setup,
> pci, boot) but others seem wuite a bit mixed up with other subarches.
David Gibson and Rob Landley had a quite interesting discussion about
PReP last night on IRC. You might want to contact them and see if they
came to any conclusions.
josh
^ permalink raw reply
* Re: Patches added to powerpc.git for-2.6.24 branch
From: Timur Tabi @ 2007-08-22 12:44 UTC (permalink / raw)
To: Paul Mackerras; +Cc: linuxppc-dev
In-Reply-To: <18124.1591.112487.322248@cargo.ozlabs.ibm.com>
Paul Mackerras wrote:
> Scott Wood (15):
> [POWERPC] Add clrbits8 and setbits8
No love for my similar patch that adds the clrsetbits macros? Or the one that changes immap_86xx.h?
^ permalink raw reply
* Re: How to port PReP to arch/powerpc?
From: Sven Luther @ 2007-08-22 13:04 UTC (permalink / raw)
To: Meelis Roos; +Cc: linuxppc-dev
In-Reply-To: <Pine.SOC.4.64.0708221444510.5639@math.ut.ee>
On Wed, Aug 22, 2007 at 02:50:07PM +0300, Meelis Roos wrote:
> It seems no one cares for arch/ppc any more but the move to powerpc was
> not finished completely (PReP subarch was not migrated but sees users, I
> do not know about the user base of the other subarches). So I have been
> thinking about migrating PReP support to arch/powerpc myself since I use
> it.
>
> Any general guidelines or specific hints about that? I have looked
> around in the code and some pieces are clearly PReP specific (setup,
> pci, boot) but others seem wuite a bit mixed up with other subarches.
I don't have much time for this right now, but i am interested in
helping out in a PReP arch/powerpc port, as this would allow debian to
drop the arch/ppc -prep flavour. I have both a motorola and an IBM PReP
box here to play with and test.
Friendly,
Sven Luther
^ permalink raw reply
* Re: Patches added to powerpc.git for-2.6.24 branch
From: Kumar Gala @ 2007-08-22 13:25 UTC (permalink / raw)
To: Paul Mackerras; +Cc: linuxppc-dev
In-Reply-To: <18124.1591.112487.322248@cargo.ozlabs.ibm.com>
How do we want to handle the include cleanup I've got.
I know you'd like some way of showing it complete. Any ideas?
- k
^ permalink raw reply
* Re: 2.6.23-rc3 is not booting
From: Kumar Gala @ 2007-08-22 13:30 UTC (permalink / raw)
To: sivaji; +Cc: linuxppc-dev
In-Reply-To: <12268833.post@talk.nabble.com>
On Aug 22, 2007, at 1:32 AM, sivaji wrote:
>
> Hai,
> I am using the kernel 2.6.23-rc3. i am trying to boot this
> kernel
> to my 8641D board. It was not booting.
> I go the following message
>
> Bytes transferred = 1505 (5e1 hex)
> ## Booting image at 00200000 ...
> Image Name: Linux-2.6.23-rc3
> Image Type: PowerPC Linux Kernel Image (gzip compressed)
> Data Size: 1801717 Bytes = 1.7 MB
> Load Address: 00000000
> Entry Point: 00000000
> Verifying Checksum ... OK
> Uncompressing Kernel Image ... OK
> Booting using flat device tree at 0x800000
>
> Whether the problem belongs to device tree? I am using the
> mpc8641_hpcn.dts
> file
>
> Pls Advice me.
What rev board/silicon do you have? I'd suggest building the kernel
w/o PCI support and see what happens. Make sure you've got the
latest dts from the kernel tree.
- k
^ permalink raw reply
* RFC: [PATCH v2] Fixup modpost warnings in head*.S for ppc32
From: Kumar Gala @ 2007-08-22 13:58 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Paul Mackerras
Addess the following modpost warnings we get out of the ppc32 head
files:
WARNING: vmlinux.o(.text+0x358): Section mismatch: reference to .init.text:early_init (between 'skpinv' and 'interrupt_base')
WARNING: vmlinux.o(.text+0x380): Section mismatch: reference to .init.text:machine_init (between 'skpinv' and 'interrupt_base')
WARNING: vmlinux.o(.text+0x384): Section mismatch: reference to .init.text:MMU_init (between 'skpinv' and 'interrupt_base')
WARNING: vmlinux.o(.text+0x3aa): Section mismatch: reference to .init.text:start_kernel (between 'skpinv' and 'interrupt_base')
WARNING: vmlinux.o(.text+0x3ae): Section mismatch: reference to .init.text:start_kernel (between 'skpinv' and 'interrupt_base')
Does anyone have any issues with this? This version cleans up 40x based
on the latest for-2.6.24 tree and removes the stabs defn from _ENTRY.
- k
diff --git a/arch/powerpc/kernel/head_32.S b/arch/powerpc/kernel/head_32.S
index 7d73a13..6d332db 100644
--- a/arch/powerpc/kernel/head_32.S
+++ b/arch/powerpc/kernel/head_32.S
@@ -48,20 +48,17 @@
mtspr SPRN_DBAT##n##L,RB; \
1:
- .text
+ .section .text.head, "ax"
.stabs "arch/powerpc/kernel/",N_SO,0,0,0f
.stabs "head_32.S",N_SO,0,0,0f
0:
- .globl _stext
-_stext:
+_ENTRY(_stext);
/*
* _start is defined this way because the XCOFF loader in the OpenFirmware
* on the powermac expects the entry point to be a procedure descriptor.
*/
- .text
- .globl _start
-_start:
+_ENTRY(_start);
/*
* These are here for legacy reasons, the kernel used to
* need to look like a coff function entry for the pmac
@@ -841,7 +838,7 @@ relocate_kernel:
* r3 = dest addr, r4 = source addr, r5 = copy limit, r6 = start offset
* on exit, r3, r4, r5 are unchanged, r6 is updated to be >= r5.
*/
-_GLOBAL(copy_and_flush)
+_ENTRY(copy_and_flush)
addi r5,r5,-4
addi r6,r6,-4
4: li r0,L1_CACHE_BYTES/4
@@ -954,9 +951,9 @@ __secondary_start:
* included in CONFIG_6xx
*/
#if !defined(CONFIG_6xx)
-_GLOBAL(__save_cpu_setup)
+_ENTRY(__save_cpu_setup)
blr
-_GLOBAL(__restore_cpu_setup)
+_ENTRY(__restore_cpu_setup)
blr
#endif /* !defined(CONFIG_6xx) */
@@ -1080,7 +1077,7 @@ start_here:
/*
* Set up the segment registers for a new context.
*/
-_GLOBAL(set_context)
+_ENTRY(set_context)
mulli r3,r3,897 /* multiply context by skew factor */
rlwinm r3,r3,4,8,27 /* VSID = (context & 0xfffff) << 4 */
addis r3,r3,0x6000 /* Set Ks, Ku bits */
diff --git a/arch/powerpc/kernel/head_40x.S b/arch/powerpc/kernel/head_40x.S
index a8e0457..00bdb6d 100644
--- a/arch/powerpc/kernel/head_40x.S
+++ b/arch/powerpc/kernel/head_40x.S
@@ -52,9 +52,9 @@
*
* This is all going to change RSN when we add bi_recs....... -- Dan
*/
- .text
-_GLOBAL(_stext)
-_GLOBAL(_start)
+ .section .text.head, "ax"
+_ENTRY(_stext);
+_ENTRY(_start);
/* Save parameters we are passed.
*/
@@ -89,9 +89,9 @@ turn_on_mmu:
*/
. = 0xc0
crit_save:
-_GLOBAL(crit_r10)
+_ENTRY(crit_r10)
.space 4
-_GLOBAL(crit_r11)
+_ENTRY(crit_r11)
.space 4
/*
@@ -814,7 +814,7 @@ finish_tlb_load:
* The PowerPC 4xx family of processors do not have an FPU, so this just
* returns.
*/
-_GLOBAL(giveup_fpu)
+_ENTRY(giveup_fpu)
blr
/* This is where the main kernel code starts.
diff --git a/arch/powerpc/kernel/head_44x.S b/arch/powerpc/kernel/head_44x.S
index 8869596..7b0fda9 100644
--- a/arch/powerpc/kernel/head_44x.S
+++ b/arch/powerpc/kernel/head_44x.S
@@ -50,9 +50,9 @@
* r7 - End of kernel command line string
*
*/
- .text
-_GLOBAL(_stext)
-_GLOBAL(_start)
+ .section .text.head, "ax"
+_ENTRY(_stext);
+_ENTRY(_start);
/*
* Reserve a word at a fixed location to store the address
* of abatron_pteptrs
diff --git a/arch/powerpc/kernel/head_8xx.S b/arch/powerpc/kernel/head_8xx.S
index 901be47..a6ecdd6 100644
--- a/arch/powerpc/kernel/head_8xx.S
+++ b/arch/powerpc/kernel/head_8xx.S
@@ -38,12 +38,9 @@
#else
#define DO_8xx_CPU6(val, reg)
#endif
- .text
- .globl _stext
-_stext:
- .text
- .globl _start
-_start:
+ .section .text.head, "ax"
+_ENTRY(_stext);
+_ENTRY(_start);
/* MPC8xx
* This port was done on an MBX board with an 860. Right now I only
diff --git a/arch/powerpc/kernel/head_fsl_booke.S b/arch/powerpc/kernel/head_fsl_booke.S
index 1f155d3..d83cbbb 100644
--- a/arch/powerpc/kernel/head_fsl_booke.S
+++ b/arch/powerpc/kernel/head_fsl_booke.S
@@ -52,9 +52,9 @@
* r7 - End of kernel command line string
*
*/
- .text
-_GLOBAL(_stext)
-_GLOBAL(_start)
+ .section .text.head, "ax"
+_ENTRY(_stext);
+_ENTRY(_start);
/*
* Reserve a word at a fixed location to store the address
* of abatron_pteptrs
diff --git a/arch/powerpc/kernel/vmlinux.lds.S b/arch/powerpc/kernel/vmlinux.lds.S
index 0c45855..823a8cb 100644
--- a/arch/powerpc/kernel/vmlinux.lds.S
+++ b/arch/powerpc/kernel/vmlinux.lds.S
@@ -34,6 +34,8 @@ SECTIONS
/* Text and gots */
.text : {
+ ALIGN_FUNCTION();
+ *(.text.head)
_text = .;
TEXT_TEXT
SCHED_TEXT
diff --git a/include/asm-powerpc/ppc_asm.h b/include/asm-powerpc/ppc_asm.h
index 211fdae..2dbd4e7 100644
--- a/include/asm-powerpc/ppc_asm.h
+++ b/include/asm-powerpc/ppc_asm.h
@@ -209,6 +209,10 @@ GLUE(.,name):
#else /* 32-bit */
+#define _ENTRY(n) \
+ .globl n; \
+n:
+
#define _GLOBAL(n) \
.text; \
.stabs __stringify(n:F-1),N_FUN,0,0,n;\
^ permalink raw reply related
* Re: Patches added to powerpc.git for-2.6.24 branch
From: Kumar Gala @ 2007-08-22 14:03 UTC (permalink / raw)
To: Timur Tabi; +Cc: linuxppc-dev, Paul Mackerras
In-Reply-To: <46CC2FB3.4000200@freescale.com>
On Aug 22, 2007, at 7:44 AM, Timur Tabi wrote:
> Paul Mackerras wrote:
>
>> Scott Wood (15):
>> [POWERPC] Add clrbits8 and setbits8
>
> No love for my similar patch that adds the clrsetbits macros? Or
> the one that changes immap_86xx.h?
I think the clrsetbits macros needs some further cleanup. I think
Stephen mentioned doing something like we do for DEF_MMIO_OUT_BE() to
only have one 'actual' macro.
The immap_86xx.h will go through me since its FSL code.
- k
^ permalink raw reply
* Re: RFC: [PATCH v2] Fixup modpost warnings in head*.S for ppc32
From: Josh Boyer @ 2007-08-22 14:03 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev, Paul Mackerras
In-Reply-To: <Pine.LNX.4.64.0708220856530.31744@blarg.am.freescale.net>
On Wed, 22 Aug 2007 08:58:31 -0500 (CDT)
Kumar Gala <galak@kernel.crashing.org> wrote:
> Addess the following modpost warnings we get out of the ppc32 head
> files:
>
> WARNING: vmlinux.o(.text+0x358): Section mismatch: reference to .init.text:early_init (between 'skpinv' and 'interrupt_base')
> WARNING: vmlinux.o(.text+0x380): Section mismatch: reference to .init.text:machine_init (between 'skpinv' and 'interrupt_base')
> WARNING: vmlinux.o(.text+0x384): Section mismatch: reference to .init.text:MMU_init (between 'skpinv' and 'interrupt_base')
> WARNING: vmlinux.o(.text+0x3aa): Section mismatch: reference to .init.text:start_kernel (between 'skpinv' and 'interrupt_base')
> WARNING: vmlinux.o(.text+0x3ae): Section mismatch: reference to .init.text:start_kernel (between 'skpinv' and 'interrupt_base')
>
> Does anyone have any issues with this? This version cleans up 40x based
> on the latest for-2.6.24 tree and removes the stabs defn from _ENTRY.
No signed-off-by on purpose?
> diff --git a/arch/powerpc/kernel/head_40x.S b/arch/powerpc/kernel/head_40x.S
> index a8e0457..00bdb6d 100644
> --- a/arch/powerpc/kernel/head_40x.S
> +++ b/arch/powerpc/kernel/head_40x.S
> @@ -52,9 +52,9 @@
> *
> * This is all going to change RSN when we add bi_recs....... -- Dan
> */
> - .text
> -_GLOBAL(_stext)
> -_GLOBAL(_start)
> + .section .text.head, "ax"
> +_ENTRY(_stext);
> +_ENTRY(_start);
>
> /* Save parameters we are passed.
> */
> @@ -89,9 +89,9 @@ turn_on_mmu:
> */
> . = 0xc0
> crit_save:
> -_GLOBAL(crit_r10)
> +_ENTRY(crit_r10)
> .space 4
> -_GLOBAL(crit_r11)
> +_ENTRY(crit_r11)
> .space 4
>
> /*
> @@ -814,7 +814,7 @@ finish_tlb_load:
> * The PowerPC 4xx family of processors do not have an FPU, so this just
> * returns.
> */
> -_GLOBAL(giveup_fpu)
> +_ENTRY(giveup_fpu)
> blr
I had moved this bit below initial_mmu instead in my version. I
realize there isn't much difference from a technical point of view, but
it seems misleading to label this one as _ENTRY.
josh
^ permalink raw reply
* Re: RFC: [PATCH v2] Fixup modpost warnings in head*.S for ppc32
From: Kumar Gala @ 2007-08-22 14:08 UTC (permalink / raw)
To: Josh Boyer; +Cc: linuxppc-dev, Paul Mackerras
In-Reply-To: <20070822090315.7e0010c4@weaponx.rchland.ibm.com>
On Aug 22, 2007, at 9:03 AM, Josh Boyer wrote:
> On Wed, 22 Aug 2007 08:58:31 -0500 (CDT)
> Kumar Gala <galak@kernel.crashing.org> wrote:
>
>> Addess the following modpost warnings we get out of the ppc32 head
>> files:
>>
>> WARNING: vmlinux.o(.text+0x358): Section mismatch: reference
>> to .init.text:early_init (between 'skpinv' and 'interrupt_base')
>> WARNING: vmlinux.o(.text+0x380): Section mismatch: reference
>> to .init.text:machine_init (between 'skpinv' and 'interrupt_base')
>> WARNING: vmlinux.o(.text+0x384): Section mismatch: reference
>> to .init.text:MMU_init (between 'skpinv' and 'interrupt_base')
>> WARNING: vmlinux.o(.text+0x3aa): Section mismatch: reference
>> to .init.text:start_kernel (between 'skpinv' and 'interrupt_base')
>> WARNING: vmlinux.o(.text+0x3ae): Section mismatch: reference
>> to .init.text:start_kernel (between 'skpinv' and 'interrupt_base')
>>
>> Does anyone have any issues with this? This version cleans up 40x
>> based
>> on the latest for-2.6.24 tree and removes the stabs defn from _ENTRY.
>
> No signed-off-by on purpose?
Yes, since its an RFC, I explicitly didn't put a signed-off-by :)
>> diff --git a/arch/powerpc/kernel/head_40x.S b/arch/powerpc/kernel/
>> head_40x.S
>> index a8e0457..00bdb6d 100644
>> --- a/arch/powerpc/kernel/head_40x.S
>> +++ b/arch/powerpc/kernel/head_40x.S
>> @@ -52,9 +52,9 @@
>> *
>> * This is all going to change RSN when we add bi_recs....... --
>> Dan
>> */
>> - .text
>> -_GLOBAL(_stext)
>> -_GLOBAL(_start)
>> + .section .text.head, "ax"
>> +_ENTRY(_stext);
>> +_ENTRY(_start);
>>
>> /* Save parameters we are passed.
>> */
>> @@ -89,9 +89,9 @@ turn_on_mmu:
>> */
>> . = 0xc0
>> crit_save:
>> -_GLOBAL(crit_r10)
>> +_ENTRY(crit_r10)
>> .space 4
>> -_GLOBAL(crit_r11)
>> +_ENTRY(crit_r11)
>> .space 4
>>
>> /*
>> @@ -814,7 +814,7 @@ finish_tlb_load:
>> * The PowerPC 4xx family of processors do not have an FPU, so
>> this just
>> * returns.
>> */
>> -_GLOBAL(giveup_fpu)
>> +_ENTRY(giveup_fpu)
>> blr
>
> I had moved this bit below initial_mmu instead in my version. I
> realize there isn't much difference from a technical point of view,
> but
> it seems misleading to label this one as _ENTRY.
Do you want to move both crit_r10/r11 & giveup_fpu or just giveup_fpu?
- k
^ permalink raw reply
* Re: [PATCH v5 0/2] SPI support for fsl_soc and mpc832x_rdb
From: Kumar Gala @ 2007-08-22 14:22 UTC (permalink / raw)
To: avorontsov; +Cc: linuxppc-dev
In-Reply-To: <20070821152745.GA28986@localhost.localdomain>
On Aug 21, 2007, at 10:27 AM, Anton Vorontsov wrote:
> On Tue, Aug 21, 2007 at 05:45:37PM +0400, Anton Vorontsov wrote:
>> Hi all,
>>
>> Thanks for the previous reviews, this is v4 against Linus' tree,
>> as of today.
>
> Okay, here is brand-new, shiny v5. Today and only today it comes
> without section mismatch warnings, don't miss your chance. Get it
> free of charge! ;-)
This looks good, have some minor cleanup nits.
- k
^ permalink raw reply
* Re: [PATCH v5 1/2] [POWERPC] fsl_soc: add support for fsl_spi
From: Kumar Gala @ 2007-08-22 14:24 UTC (permalink / raw)
To: Anton Vorontsov; +Cc: linuxppc-dev
In-Reply-To: <20070821152942.GA633@localhost.localdomain>
On Aug 21, 2007, at 10:29 AM, Anton Vorontsov wrote:
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
> arch/powerpc/sysdev/fsl_soc.c | 84 ++++++++++++++++++++++++++++++
> +++++++++++
> arch/powerpc/sysdev/fsl_soc.h | 7 +++
> 2 files changed, 91 insertions(+), 0 deletions(-)
>
> diff --git a/arch/powerpc/sysdev/fsl_soc.c b/arch/powerpc/sysdev/
> fsl_soc.c
> index 1cf29c9..2bdaeb2 100644
> --- a/arch/powerpc/sysdev/fsl_soc.c
> +++ b/arch/powerpc/sysdev/fsl_soc.c
> @@ -24,6 +24,7 @@
> #include <linux/platform_device.h>
> #include <linux/of_platform.h>
> #include <linux/phy.h>
> +#include <linux/spi/spi.h>
> #include <linux/fsl_devices.h>
> #include <linux/fs_enet_pd.h>
> #include <linux/fs_uart_pd.h>
> @@ -1187,3 +1188,86 @@ err:
> arch_initcall(cpm_smc_uart_of_init);
>
> #endif /* CONFIG_8xx */
> +
> +int __init fsl_spi_init(struct spi_board_info *board_infos,
> + unsigned int num_board_infos,
> + void (*activate_cs)(u8 cs, u8 polarity),
> + void (*deactivate_cs)(u8 cs, u8 polarity))
> +{
> + struct device_node *np;
> + unsigned int i;
> + u32 sysclk;
> +
> + np = of_find_node_by_type(NULL, "qe");
> + if (!np)
> + return -ENODEV;
> +
> + sysclk = *(u32 *)of_get_property(np, "bus-frequency", NULL);
> +
> + for (np = NULL, i = 1;
> + (np = of_find_compatible_node(np, "spi", "fsl_spi")) != NULL;
> + i++) {
> + int ret = 0;
> + unsigned int j;
> + const char *mode;
> + struct resource res[2];
> + struct platform_device *pdev = NULL;
> + struct fsl_spi_platform_data pdata = {
> + .activate_cs = activate_cs,
> + .deactivate_cs = deactivate_cs,
> + };
> +
> + memset(res, 0, sizeof(res));
> +
> + mode = of_get_property(np, "mode", NULL);
> + pdata.sysclk = sysclk;
> + pdata.bus_num = *(u32 *)of_get_property(np, "reg", NULL);
> +
> + for (j = 0; j < num_board_infos; j++) {
> + if (board_infos[j].bus_num == pdata.bus_num)
> + pdata.max_chipselect++;
> + }
> +
> + if (!pdata.max_chipselect)
> + goto err;
> +
> + if (!strcmp(mode, "cpu-qe"))
> + pdata.qe_mode = 1;
> +
> + ret = of_address_to_resource(np, 0, &res[0]);
> + if (ret)
> + goto err;
> +
> + res[1].start = res[2].end = irq_of_parse_and_map(np, 0);
> + if (res[1].start == NO_IRQ)
> + goto err;
> +
> + res[1].name = "mpc83xx_spi";
> + res[1].flags = IORESOURCE_IRQ;;
double ;;
can we not use of_irq_to_resource() ?
> +
> + pdev = platform_device_alloc("mpc83xx_spi", i);
> + if (!pdev)
> + goto err;
> +
> + ret = platform_device_add_data(pdev, &pdata, sizeof(pdata));
> + if (ret)
> + goto unreg;
> +
> + ret = platform_device_add_resources(pdev, res,
> + ARRAY_SIZE(res));
> + if (ret)
> + goto unreg;
> +
> + ret = platform_device_register(pdev);
> + if (ret)
> + goto unreg;
> +
> + continue;
> +unreg:
> + platform_device_del(pdev);
> +err:
> + continue;
> + }
> +
> + return spi_register_board_info(board_infos, num_board_infos);
> +}
> diff --git a/arch/powerpc/sysdev/fsl_soc.h b/arch/powerpc/sysdev/
> fsl_soc.h
> index 04e145b..618d91d 100644
> --- a/arch/powerpc/sysdev/fsl_soc.h
> +++ b/arch/powerpc/sysdev/fsl_soc.h
> @@ -8,5 +8,12 @@ extern phys_addr_t get_immrbase(void);
> extern u32 get_brgfreq(void);
> extern u32 get_baudrate(void);
>
> +struct spi_board_info;
> +
> +extern int fsl_spi_init(struct spi_board_info *board_infos,
> + unsigned int num_board_infos,
> + void (*activate_cs)(u8 cs, u8 polarity),
> + void (*deactivate_cs)(u8 cs, u8 polarity));
> +
> #endif
> #endif
> --
> 1.5.0.6
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
^ permalink raw reply
* Re: Patches added to powerpc.git for-2.6.24 branch
From: Timur Tabi @ 2007-08-22 14:22 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev, Paul Mackerras
In-Reply-To: <C3CB0CDB-AA2B-4D24-AEA6-1A7305B5B311@kernel.crashing.org>
Kumar Gala wrote:
> I think the clrsetbits macros needs some further cleanup. I think
> Stephen mentioned doing something like we do for DEF_MMIO_OUT_BE() to
> only have one 'actual' macro.
Yeah I saw that one, but on IRC a few people said they don't like ##, so I
decided against it. Are you saying I should change it anyway?
> The immap_86xx.h will go through me since its FSL code.
I was thinking some more about that file this morning. If you want, I can
rename it to guts.h since it only has one structure in it, and then also
update a few other files that use the global utilities registers to use that
structure instead of using macros.
--
Timur Tabi
Linux Kernel Developer @ Freescale
^ permalink raw reply
* Re: [PATCH v5 2/2] [POWERPC] MPC832x_RDB: update dts to use SPI1 in QE, register mmc_spi stub
From: Kumar Gala @ 2007-08-22 14:25 UTC (permalink / raw)
To: Anton Vorontsov; +Cc: linuxppc-dev
In-Reply-To: <20070821152947.GB633@localhost.localdomain>
On Aug 21, 2007, at 10:29 AM, Anton Vorontsov wrote:
> mmc_spi already tested to work. When it will hit mainline
> the only change that will be needed is replacing "spidev"
> with "mmc_spi".
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
> arch/powerpc/boot/dts/mpc832x_rdb.dts | 2 +-
> arch/powerpc/platforms/83xx/mpc832x_rdb.c | 50 ++++++++++++++++++
> +++++++++++
> 2 files changed, 51 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/mpc832x_rdb.dts b/arch/powerpc/
> boot/dts/mpc832x_rdb.dts
> index e9c332f..1ac0025 100644
> --- a/arch/powerpc/boot/dts/mpc832x_rdb.dts
> +++ b/arch/powerpc/boot/dts/mpc832x_rdb.dts
> @@ -211,7 +211,7 @@
> reg = <4c0 40>;
> interrupts = <2>;
> interrupt-parent = <&qeic>;
> - mode = "cpu";
> + mode = "cpu-qe";
> };
>
> spi@500 {
> diff --git a/arch/powerpc/platforms/83xx/mpc832x_rdb.c b/arch/
> powerpc/platforms/83xx/mpc832x_rdb.c
> index e021b08..cf58d06 100644
> --- a/arch/powerpc/platforms/83xx/mpc832x_rdb.c
> +++ b/arch/powerpc/platforms/83xx/mpc832x_rdb.c
> @@ -15,6 +15,7 @@
> */
>
> #include <linux/pci.h>
> +#include <linux/spi/spi.h>
>
> #include <asm/of_platform.h>
> #include <asm/time.h>
> @@ -24,6 +25,7 @@
> #include <asm/qe_ic.h>
>
> #include "mpc83xx.h"
> +#include "../../sysdev/fsl_soc.h"
we usually do #include <sysdev/fsl_soc.h>
>
> #undef DEBUG
> #ifdef DEBUG
> @@ -32,6 +34,54 @@
> #define DBG(fmt...)
> #endif
>
> +extern int par_io_data_set(u8 port, u8 pin, u8 val);
> +extern int par_io_config_pin(u8 port, u8 pin, int dir, int
> open_drain,
> + int assignment, int has_irq);
> +
> +static void mpc83xx_spi_activate_cs(u8 cs, u8 polarity)
> +{
> + pr_debug("%s %d %d\n", __func__, cs, polarity);
> + par_io_data_set(3, 13, polarity);
> +}
> +
> +static void mpc83xx_spi_deactivate_cs(u8 cs, u8 polarity)
> +{
> + pr_debug("%s %d %d\n", __func__, cs, polarity);
> + par_io_data_set(3, 13, !polarity);
> +}
> +
> +static struct spi_board_info mpc832x_spi_boardinfo = {
> + .bus_num = 0x4c0,
> + .chip_select = 0,
> + .max_speed_hz = 50000000,
> + /*
> + * XXX: This is spidev (spi in userspace) stub, should
> + * be replaced by "mmc_spi" when mmc_spi will hit mainline.
> + */
> + .modalias = "spidev",
> +};
> +
> +static int __init mpc832x_spi_init(void)
> +{
> + if (!machine_is(mpc832x_rdb))
> + return 0;
> +
> + par_io_config_pin(3, 0, 3, 0, 1, 0); /* SPI1 MOSI, I/O */
> + par_io_config_pin(3, 1, 3, 0, 1, 0); /* SPI1 MISO, I/O */
> + par_io_config_pin(3, 2, 3, 0, 1, 0); /* SPI1 CLK, I/O */
> + par_io_config_pin(3, 3, 2, 0, 1, 0); /* SPI1 SEL, I */
> +
> + par_io_config_pin(3, 13, 1, 0, 0, 0); /* !SD_CS, O */
> + par_io_config_pin(3, 14, 2, 0, 0, 0); /* SD_INSERT, I */
> + par_io_config_pin(3, 15, 2, 0, 0, 0); /* SD_PROTECT,I */
> +
> + return fsl_spi_init(&mpc832x_spi_boardinfo, 1,
> + mpc83xx_spi_activate_cs,
> + mpc83xx_spi_deactivate_cs);
> +}
> +
> +device_initcall(mpc832x_spi_init);
> +
> /*
> **********************************************************************
> **
> *
> * Setup the architecture
> --
> 1.5.0.6
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
^ permalink raw reply
* Re: RFC: [PATCH v2] Fixup modpost warnings in head*.S for ppc32
From: Josh Boyer @ 2007-08-22 14:31 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev, Paul Mackerras
In-Reply-To: <490B1783-FA20-4DD8-A580-E71398B9928F@kernel.crashing.org>
On Wed, 22 Aug 2007 09:08:31 -0500
Kumar Gala <galak@kernel.crashing.org> wrote:
>
> On Aug 22, 2007, at 9:03 AM, Josh Boyer wrote:
>
> > On Wed, 22 Aug 2007 08:58:31 -0500 (CDT)
> > Kumar Gala <galak@kernel.crashing.org> wrote:
> >
> >> Addess the following modpost warnings we get out of the ppc32 head
> >> files:
> >>
> >> WARNING: vmlinux.o(.text+0x358): Section mismatch: reference
> >> to .init.text:early_init (between 'skpinv' and 'interrupt_base')
> >> WARNING: vmlinux.o(.text+0x380): Section mismatch: reference
> >> to .init.text:machine_init (between 'skpinv' and 'interrupt_base')
> >> WARNING: vmlinux.o(.text+0x384): Section mismatch: reference
> >> to .init.text:MMU_init (between 'skpinv' and 'interrupt_base')
> >> WARNING: vmlinux.o(.text+0x3aa): Section mismatch: reference
> >> to .init.text:start_kernel (between 'skpinv' and 'interrupt_base')
> >> WARNING: vmlinux.o(.text+0x3ae): Section mismatch: reference
> >> to .init.text:start_kernel (between 'skpinv' and 'interrupt_base')
> >>
> >> Does anyone have any issues with this? This version cleans up 40x
> >> based
> >> on the latest for-2.6.24 tree and removes the stabs defn from _ENTRY.
> >
> > No signed-off-by on purpose?
>
> Yes, since its an RFC, I explicitly didn't put a signed-off-by :)
Ok. I can never tell if people just forgot or if they really meant
to. Maybe we should be like Ben and do: Not-Signed-off-by ;)
> >> diff --git a/arch/powerpc/kernel/head_40x.S b/arch/powerpc/kernel/
> >> head_40x.S
> >> index a8e0457..00bdb6d 100644
> >> --- a/arch/powerpc/kernel/head_40x.S
> >> +++ b/arch/powerpc/kernel/head_40x.S
> >> @@ -52,9 +52,9 @@
> >> *
> >> * This is all going to change RSN when we add bi_recs....... --
> >> Dan
> >> */
> >> - .text
> >> -_GLOBAL(_stext)
> >> -_GLOBAL(_start)
> >> + .section .text.head, "ax"
> >> +_ENTRY(_stext);
> >> +_ENTRY(_start);
> >>
> >> /* Save parameters we are passed.
> >> */
> >> @@ -89,9 +89,9 @@ turn_on_mmu:
> >> */
> >> . = 0xc0
> >> crit_save:
> >> -_GLOBAL(crit_r10)
> >> +_ENTRY(crit_r10)
> >> .space 4
> >> -_GLOBAL(crit_r11)
> >> +_ENTRY(crit_r11)
> >> .space 4
> >>
> >> /*
> >> @@ -814,7 +814,7 @@ finish_tlb_load:
> >> * The PowerPC 4xx family of processors do not have an FPU, so
> >> this just
> >> * returns.
> >> */
> >> -_GLOBAL(giveup_fpu)
> >> +_ENTRY(giveup_fpu)
> >> blr
> >
> > I had moved this bit below initial_mmu instead in my version. I
> > realize there isn't much difference from a technical point of view,
> > but
> > it seems misleading to label this one as _ENTRY.
>
> Do you want to move both crit_r10/r11 & giveup_fpu or just giveup_fpu?
I just moved giveup_fpu. Moving crit_r10/r11 was more work than my 5
minute fixup allowed :). Really, this isn't a big deal either way so
don't stress too much about it.
josh
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox