* Re: [PATCH/RFC] net: Add __napi_sycnhronize() to sync with napi poll
From: Herbert Xu @ 2007-10-16 6:06 UTC (permalink / raw)
To: benh; +Cc: netdev, rdreier, shemminger, davem, linuxppc-dev
In-Reply-To: <1192513792.19073.23.camel@pasglop>
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> Note: I use msleep_interruptible(1); just like napi_disable(). However
> I'm not too happy that the "hot" loop that results of a pending signal
> here will spin without even a cpu_relax ... what do you guys think would
> be the best way to handle this ?
Well since the loop does not check signals at all, it should
just use msleep.
Granted the process will end up in the D state and contribute
to the load average. But if this loop executes long enough
for that to be noticed then we've got bigger problems to worry
about.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply
* Re: [patch 12/13] fb: Move and rename extern declaration for global_mode_option
From: Geert Uytterhoeven @ 2007-10-16 7:18 UTC (permalink / raw)
To: Andrew Morton; +Cc: linuxppc-dev, linux-fbdev-devel, cbe-oss-dev, adaplas
In-Reply-To: <20071015144340.167d1cda.akpm@linux-foundation.org>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1880 bytes --]
On Mon, 15 Oct 2007, Andrew Morton wrote:
> On Fri, 12 Oct 2007 16:51:04 +0200
> Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com> wrote:
>
> > - if (mode_option || (mode_option = global_mode_option)) {
> > + if (mode_option || (mode_option = fb_mode_option)) {
>
> I guess that equals-which-looks-like-it-should-be-equals-equals really
> is intended to be an assignment?
>
> I guess. After staring at it for a while. It's a pretty obnoxious way
> of coding it, especially in kernel context where such things are unexpected...
Subject: fb modedb: Refactor confusing mode_option assignment
fb modedb: Refactor confusing mode_option assignment
Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
---
drivers/video/modedb.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletion(-)
--- a/drivers/video/modedb.c
+++ b/drivers/video/modedb.c
@@ -510,7 +510,9 @@ int fb_find_mode(struct fb_var_screeninf
default_bpp = 8;
/* Did the user specify a video mode? */
- if (mode_option || (mode_option = fb_mode_option)) {
+ if (!mode_option)
+ mode_option = fb_mode_option;
+ if (mode_option) {
const char *name = mode_option;
unsigned int namelen = strlen(name);
int res_specified = 0, bpp_specified = 0, refresh_specified = 0;
With kind regards,
Geert Uytterhoeven
Software Architect
Sony Network and Software Technology Center Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium
Phone: +32 (0)2 700 8453
Fax: +32 (0)2 700 8622
E-mail: Geert.Uytterhoeven@sonycom.com
Internet: http://www.sony-europe.com/
Sony Network and Software Technology Center Europe
A division of Sony Service Centre (Europe) N.V.
Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium
VAT BE 0413.825.160 · RPR Brussels
Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619
^ permalink raw reply
* Re: [PATCH/RFC] net: Add __napi_sycnhronize() to sync with napi poll
From: Benjamin Herrenschmidt @ 2007-10-16 7:37 UTC (permalink / raw)
To: Herbert Xu; +Cc: netdev, rdreier, shemminger, davem, linuxppc-dev
In-Reply-To: <E1IhfZr-0002FE-00@gondolin.me.apana.org.au>
On Tue, 2007-10-16 at 14:06 +0800, Herbert Xu wrote:
> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> >
> > Note: I use msleep_interruptible(1); just like napi_disable(). However
> > I'm not too happy that the "hot" loop that results of a pending signal
> > here will spin without even a cpu_relax ... what do you guys think would
> > be the best way to handle this ?
>
> Well since the loop does not check signals at all, it should
> just use msleep.
>
> Granted the process will end up in the D state and contribute
> to the load average. But if this loop executes long enough
> for that to be noticed then we've got bigger problems to worry
> about.
If Dave & Stephen agree, I'll send a patch changing napi_disable() too
then.
Cheers,
Ben.
^ permalink raw reply
* Re: [PATCH/RFC] net: Add __napi_sycnhronize() to sync with napi poll
From: David Miller @ 2007-10-16 7:44 UTC (permalink / raw)
To: benh; +Cc: netdev, rdreier, shemminger, herbert, linuxppc-dev
In-Reply-To: <1192520223.7205.5.camel@pasglop>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Tue, 16 Oct 2007 17:37:03 +1000
>
> On Tue, 2007-10-16 at 14:06 +0800, Herbert Xu wrote:
> > Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> > >
> > > Note: I use msleep_interruptible(1); just like napi_disable(). However
> > > I'm not too happy that the "hot" loop that results of a pending signal
> > > here will spin without even a cpu_relax ... what do you guys think would
> > > be the best way to handle this ?
> >
> > Well since the loop does not check signals at all, it should
> > just use msleep.
> >
> > Granted the process will end up in the D state and contribute
> > to the load average. But if this loop executes long enough
> > for that to be noticed then we've got bigger problems to worry
> > about.
>
> If Dave & Stephen agree, I'll send a patch changing napi_disable() too
> then.
I agree with the msleep() change.
^ permalink raw reply
* Re: [PATCH] powerpc64 vDSO: linker script indentation
From: Benjamin Herrenschmidt @ 2007-10-16 10:23 UTC (permalink / raw)
To: Roland McGrath
Cc: Linus Torvalds, linux-kernel, linuxppc-dev, Paul Mackerras,
Anton Blanchard, Andrew Morton, Sam Ravnborg
In-Reply-To: <20071016034333.19BEE4D0389@magilla.localdomain>
On Mon, 2007-10-15 at 20:43 -0700, Roland McGrath wrote:
> This cleans up the formatting in the vDSO linker script, mostly just the
> use of whitespace. It's intended to approximate the kernel standard
> conventions for indenting C, treating elements of the linker script about
> like initialized variable definitions.
>
> Signed-off-by: Roland McGrath <roland@redhat.com>
> CC: Sam Ravnborg <sam@ravnborg.org>
Thanks Roland !
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
> arch/powerpc/kernel/vdso64/vdso64.lds.S | 225 +++++++++++++++++--------------
> 1 files changed, 122 insertions(+), 103 deletions(-)
>
> diff --git a/arch/powerpc/kernel/vdso64/vdso64.lds.S b/arch/powerpc/kernel/vdso64/vdso64.lds.S
> index 2d70f35..932b3fd 100644
> --- a/arch/powerpc/kernel/vdso64/vdso64.lds.S
> +++ b/arch/powerpc/kernel/vdso64/vdso64.lds.S
> @@ -10,100 +10,114 @@ ENTRY(_start)
>
> SECTIONS
> {
> - . = VDSO64_LBASE + SIZEOF_HEADERS;
> - .hash : { *(.hash) } :text
> - .gnu.hash : { *(.gnu.hash) }
> - .dynsym : { *(.dynsym) }
> - .dynstr : { *(.dynstr) }
> - .gnu.version : { *(.gnu.version) }
> - .gnu.version_d : { *(.gnu.version_d) }
> - .gnu.version_r : { *(.gnu.version_r) }
> -
> - .note : { *(.note.*) } :text :note
> -
> - . = ALIGN (16);
> - .text :
> - {
> - *(.text .stub .text.* .gnu.linkonce.t.*)
> - *(.sfpr .glink)
> - } :text
> - PROVIDE (__etext = .);
> - PROVIDE (_etext = .);
> - PROVIDE (etext = .);
> -
> - . = ALIGN(8);
> - __ftr_fixup : {
> - *(__ftr_fixup)
> - }
> -
> - . = ALIGN(8);
> - __fw_ftr_fixup : {
> - *(__fw_ftr_fixup)
> - }
> -
> - /* Other stuff is appended to the text segment: */
> - .rodata : { *(.rodata .rodata.* .gnu.linkonce.r.*) }
> - .rodata1 : { *(.rodata1) }
> - .eh_frame_hdr : { *(.eh_frame_hdr) } :text :eh_frame_hdr
> - .eh_frame : { KEEP (*(.eh_frame)) } :text
> - .gcc_except_table : { *(.gcc_except_table) }
> -
> - .opd ALIGN(8) : { KEEP (*(.opd)) }
> - .got ALIGN(8) : { *(.got .toc) }
> - .rela.dyn ALIGN(8) : { *(.rela.dyn) }
> -
> - .dynamic : { *(.dynamic) } :text :dynamic
> -
> - _end = .;
> - PROVIDE (end = .);
> -
> - /* Stabs debugging sections are here too
> - */
> - .stab 0 : { *(.stab) }
> - .stabstr 0 : { *(.stabstr) }
> - .stab.excl 0 : { *(.stab.excl) }
> - .stab.exclstr 0 : { *(.stab.exclstr) }
> - .stab.index 0 : { *(.stab.index) }
> - .stab.indexstr 0 : { *(.stab.indexstr) }
> - .comment 0 : { *(.comment) }
> - /* DWARF debug sectio/ns.
> - Symbols in the DWARF debugging sections are relative to the beginning
> - of the section so we begin them at 0. */
> - /* DWARF 1 */
> - .debug 0 : { *(.debug) }
> - .line 0 : { *(.line) }
> - /* GNU DWARF 1 extensions */
> - .debug_srcinfo 0 : { *(.debug_srcinfo) }
> - .debug_sfnames 0 : { *(.debug_sfnames) }
> - /* DWARF 1.1 and DWARF 2 */
> - .debug_aranges 0 : { *(.debug_aranges) }
> - .debug_pubnames 0 : { *(.debug_pubnames) }
> - /* DWARF 2 */
> - .debug_info 0 : { *(.debug_info .gnu.linkonce.wi.*) }
> - .debug_abbrev 0 : { *(.debug_abbrev) }
> - .debug_line 0 : { *(.debug_line) }
> - .debug_frame 0 : { *(.debug_frame) }
> - .debug_str 0 : { *(.debug_str) }
> - .debug_loc 0 : { *(.debug_loc) }
> - .debug_macinfo 0 : { *(.debug_macinfo) }
> - /* SGI/MIPS DWARF 2 extensions */
> - .debug_weaknames 0 : { *(.debug_weaknames) }
> - .debug_funcnames 0 : { *(.debug_funcnames) }
> - .debug_typenames 0 : { *(.debug_typenames) }
> - .debug_varnames 0 : { *(.debug_varnames) }
> -
> - /DISCARD/ : { *(.note.GNU-stack) }
> - /DISCARD/ : { *(.branch_lt) }
> - /DISCARD/ : { *(.data .data.* .gnu.linkonce.d.*) }
> - /DISCARD/ : { *(.bss .sbss .dynbss .dynsbss) }
> + . = VDSO64_LBASE + SIZEOF_HEADERS;
> +
> + .hash : { *(.hash) } :text
> + .gnu.hash : { *(.gnu.hash) }
> + .dynsym : { *(.dynsym) }
> + .dynstr : { *(.dynstr) }
> + .gnu.version : { *(.gnu.version) }
> + .gnu.version_d : { *(.gnu.version_d) }
> + .gnu.version_r : { *(.gnu.version_r) }
> +
> + .note : { *(.note.*) } :text :note
> +
> + . = ALIGN(16);
> + .text : {
> + *(.text .stub .text.* .gnu.linkonce.t.*)
> + *(.sfpr .glink)
> + } :text
> + PROVIDE(__etext = .);
> + PROVIDE(_etext = .);
> + PROVIDE(etext = .);
> +
> + . = ALIGN(8);
> + __ftr_fixup : { *(__ftr_fixup) }
> +
> + . = ALIGN(8);
> + __fw_ftr_fixup : { *(__fw_ftr_fixup) }
> +
> + /*
> + * Other stuff is appended to the text segment:
> + */
> + .rodata : { *(.rodata .rodata.* .gnu.linkonce.r.*) }
> + .rodata1 : { *(.rodata1) }
> +
> + .eh_frame_hdr : { *(.eh_frame_hdr) } :text :eh_frame_hdr
> + .eh_frame : { KEEP (*(.eh_frame)) } :text
> + .gcc_except_table : { *(.gcc_except_table) }
> +
> + .opd ALIGN(8) : { KEEP (*(.opd)) }
> + .got ALIGN(8) : { *(.got .toc) }
> + .rela.dyn ALIGN(8) : { *(.rela.dyn) }
> +
> + .dynamic : { *(.dynamic) } :text :dynamic
> +
> + _end = .;
> + PROVIDE(end = .);
> +
> + /*
> + * Stabs debugging sections are here too.
> + */
> + .stab 0 : { *(.stab) }
> + .stabstr 0 : { *(.stabstr) }
> + .stab.excl 0 : { *(.stab.excl) }
> + .stab.exclstr 0 : { *(.stab.exclstr) }
> + .stab.index 0 : { *(.stab.index) }
> + .stab.indexstr 0 : { *(.stab.indexstr) }
> + .comment 0 : { *(.comment) }
> +
> + /*
> + * DWARF debug sections.
> + * Symbols in the DWARF debugging sections are relative to the beginning
> + * of the section so we begin them at 0.
> + */
> + /* DWARF 1 */
> + .debug 0 : { *(.debug) }
> + .line 0 : { *(.line) }
> + /* GNU DWARF 1 extensions */
> + .debug_srcinfo 0 : { *(.debug_srcinfo) }
> + .debug_sfnames 0 : { *(.debug_sfnames) }
> + /* DWARF 1.1 and DWARF 2 */
> + .debug_aranges 0 : { *(.debug_aranges) }
> + .debug_pubnames 0 : { *(.debug_pubnames) }
> + /* DWARF 2 */
> + .debug_info 0 : { *(.debug_info .gnu.linkonce.wi.*) }
> + .debug_abbrev 0 : { *(.debug_abbrev) }
> + .debug_line 0 : { *(.debug_line) }
> + .debug_frame 0 : { *(.debug_frame) }
> + .debug_str 0 : { *(.debug_str) }
> + .debug_loc 0 : { *(.debug_loc) }
> + .debug_macinfo 0 : { *(.debug_macinfo) }
> + /* SGI/MIPS DWARF 2 extensions */
> + .debug_weaknames 0 : { *(.debug_weaknames) }
> + .debug_funcnames 0 : { *(.debug_funcnames) }
> + .debug_typenames 0 : { *(.debug_typenames) }
> + .debug_varnames 0 : { *(.debug_varnames) }
> +
> + /DISCARD/ : {
> + *(.note.GNU-stack)
> + *(.branch_lt)
> + *(.data .data.* .gnu.linkonce.d.* .sdata*)
> + *(.bss .sbss .dynbss .dynsbss)
> + }
> }
>
> +/*
> + * Very old versions of ld do not recognize this name token; use the constant.
> + */
> +#define PT_GNU_EH_FRAME 0x6474e550
> +
> +/*
> + * We must supply the ELF program headers explicitly to get just one
> + * PT_LOAD segment, and set the flags explicitly to make segments read-only.
> + */
> PHDRS
> {
> - text PT_LOAD FILEHDR PHDRS FLAGS(5); /* PF_R|PF_X */
> - note PT_NOTE FLAGS(4); /* PF_R */
> - dynamic PT_DYNAMIC FLAGS(4); /* PF_R */
> - eh_frame_hdr 0x6474e550; /* PT_GNU_EH_FRAME, but ld doesn't match the name */
> + text PT_LOAD FILEHDR PHDRS FLAGS(5); /* PF_R|PF_X */
> + dynamic PT_DYNAMIC FLAGS(4); /* PF_R */
> + note PT_NOTE FLAGS(4); /* PF_R */
> + eh_frame_hdr PT_GNU_EH_FRAME;
> }
>
> /*
> @@ -111,17 +125,22 @@ PHDRS
> */
> VERSION
> {
> - VDSO_VERSION_STRING {
> - global:
> - __kernel_datapage_offset; /* Has to be there for the kernel to find */
> - __kernel_get_syscall_map;
> - __kernel_gettimeofday;
> - __kernel_clock_gettime;
> - __kernel_clock_getres;
> - __kernel_get_tbfreq;
> - __kernel_sync_dicache;
> - __kernel_sync_dicache_p5;
> - __kernel_sigtramp_rt64;
> - local: *;
> - };
> + VDSO_VERSION_STRING {
> + global:
> + /*
> + * Has to be there for the kernel to find
> + */
> + __kernel_datapage_offset;
> +
> + __kernel_get_syscall_map;
> + __kernel_gettimeofday;
> + __kernel_clock_gettime;
> + __kernel_clock_getres;
> + __kernel_get_tbfreq;
> + __kernel_sync_dicache;
> + __kernel_sync_dicache_p5;
> + __kernel_sigtramp_rt64;
> +
> + local: *;
> + };
> }
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
^ permalink raw reply
* Re: [PATCH] powerpc32 vDSO: linker script indentation
From: Benjamin Herrenschmidt @ 2007-10-16 10:24 UTC (permalink / raw)
To: Roland McGrath
Cc: Linus Torvalds, linux-kernel, linuxppc-dev, Paul Mackerras,
Anton Blanchard, Andrew Morton, Sam Ravnborg
In-Reply-To: <20071016034414.BAB4F4D0389@magilla.localdomain>
On Mon, 2007-10-15 at 20:44 -0700, Roland McGrath wrote:
> This cleans up the formatting in the vDSO linker script, mostly just the
> use of whitespace. It's intended to approximate the kernel standard
> conventions for indenting C, treating elements of the linker script about
> like initialized variable definitions.
>
> Signed-off-by: Roland McGrath <roland@redhat.com>
> CC: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
> arch/powerpc/kernel/vdso32/vdso32.lds.S | 219 +++++++++++++++++--------------
> 1 files changed, 118 insertions(+), 101 deletions(-)
>
> diff --git a/arch/powerpc/kernel/vdso32/vdso32.lds.S b/arch/powerpc/kernel/vdso32/vdso32.lds.S
> index 26e138c..9352ab5 100644
> --- a/arch/powerpc/kernel/vdso32/vdso32.lds.S
> +++ b/arch/powerpc/kernel/vdso32/vdso32.lds.S
> @@ -1,130 +1,147 @@
> -
> /*
> * This is the infamous ld script for the 32 bits vdso
> * library
> */
> #include <asm/vdso.h>
>
> -/* Default link addresses for the vDSOs */
> OUTPUT_FORMAT("elf32-powerpc", "elf32-powerpc", "elf32-powerpc")
> OUTPUT_ARCH(powerpc:common)
> ENTRY(_start)
>
> SECTIONS
> {
> - . = VDSO32_LBASE + SIZEOF_HEADERS;
> - .hash : { *(.hash) } :text
> - .gnu.hash : { *(.gnu.hash) }
> - .dynsym : { *(.dynsym) }
> - .dynstr : { *(.dynstr) }
> - .gnu.version : { *(.gnu.version) }
> - .gnu.version_d : { *(.gnu.version_d) }
> - .gnu.version_r : { *(.gnu.version_r) }
> -
> - .note : { *(.note.*) } :text :note
> -
> - . = ALIGN (16);
> - .text :
> - {
> - *(.text .stub .text.* .gnu.linkonce.t.*)
> - }
> - PROVIDE (__etext = .);
> - PROVIDE (_etext = .);
> - PROVIDE (etext = .);
> -
> - . = ALIGN(8);
> - __ftr_fixup : {
> - *(__ftr_fixup)
> - }
> + . = VDSO32_LBASE + SIZEOF_HEADERS;
> +
> + .hash : { *(.hash) } :text
> + .gnu.hash : { *(.gnu.hash) }
> + .dynsym : { *(.dynsym) }
> + .dynstr : { *(.dynstr) }
> + .gnu.version : { *(.gnu.version) }
> + .gnu.version_d : { *(.gnu.version_d) }
> + .gnu.version_r : { *(.gnu.version_r) }
> +
> + .note : { *(.note.*) } :text :note
> +
> + . = ALIGN(16);
> + .text : {
> + *(.text .stub .text.* .gnu.linkonce.t.*)
> + }
> + PROVIDE(__etext = .);
> + PROVIDE(_etext = .);
> + PROVIDE(etext = .);
> +
> + . = ALIGN(8);
> + __ftr_fixup : { *(__ftr_fixup) }
>
> #ifdef CONFIG_PPC64
> - . = ALIGN(8);
> - __fw_ftr_fixup : {
> - *(__fw_ftr_fixup)
> - }
> + . = ALIGN(8);
> + __fw_ftr_fixup : { *(__fw_ftr_fixup) }
> #endif
>
> - /* Other stuff is appended to the text segment: */
> - .rodata : { *(.rodata .rodata.* .gnu.linkonce.r.*) }
> - .rodata1 : { *(.rodata1) }
> -
> - .eh_frame_hdr : { *(.eh_frame_hdr) } :text :eh_frame_hdr
> - .eh_frame : { KEEP (*(.eh_frame)) } :text
> - .gcc_except_table : { *(.gcc_except_table) }
> - .fixup : { *(.fixup) }
> -
> - .dynamic : { *(.dynamic) } :text :dynamic
> - .got : { *(.got) }
> - .plt : { *(.plt) }
> -
> - _end = .;
> - __end = .;
> - PROVIDE (end = .);
> -
> -
> - /* Stabs debugging sections are here too
> - */
> - .stab 0 : { *(.stab) }
> - .stabstr 0 : { *(.stabstr) }
> - .stab.excl 0 : { *(.stab.excl) }
> - .stab.exclstr 0 : { *(.stab.exclstr) }
> - .stab.index 0 : { *(.stab.index) }
> - .stab.indexstr 0 : { *(.stab.indexstr) }
> - .comment 0 : { *(.comment) }
> - .debug 0 : { *(.debug) }
> - .line 0 : { *(.line) }
> -
> - .debug_srcinfo 0 : { *(.debug_srcinfo) }
> - .debug_sfnames 0 : { *(.debug_sfnames) }
> -
> - .debug_aranges 0 : { *(.debug_aranges) }
> - .debug_pubnames 0 : { *(.debug_pubnames) }
> -
> - .debug_info 0 : { *(.debug_info .gnu.linkonce.wi.*) }
> - .debug_abbrev 0 : { *(.debug_abbrev) }
> - .debug_line 0 : { *(.debug_line) }
> - .debug_frame 0 : { *(.debug_frame) }
> - .debug_str 0 : { *(.debug_str) }
> - .debug_loc 0 : { *(.debug_loc) }
> - .debug_macinfo 0 : { *(.debug_macinfo) }
> -
> - .debug_weaknames 0 : { *(.debug_weaknames) }
> - .debug_funcnames 0 : { *(.debug_funcnames) }
> - .debug_typenames 0 : { *(.debug_typenames) }
> - .debug_varnames 0 : { *(.debug_varnames) }
> -
> - /DISCARD/ : { *(.note.GNU-stack) }
> - /DISCARD/ : { *(.data .data.* .gnu.linkonce.d.* .sdata*) }
> - /DISCARD/ : { *(.bss .sbss .dynbss .dynsbss) }
> + /*
> + * Other stuff is appended to the text segment:
> + */
> + .rodata : { *(.rodata .rodata.* .gnu.linkonce.r.*) }
> + .rodata1 : { *(.rodata1) }
> +
> + .eh_frame_hdr : { *(.eh_frame_hdr) } :text :eh_frame_hdr
> + .eh_frame : { KEEP (*(.eh_frame)) } :text
> + .gcc_except_table : { *(.gcc_except_table) }
> + .fixup : { *(.fixup) }
> +
> + .dynamic : { *(.dynamic) } :text :dynamic
> + .got : { *(.got) }
> + .plt : { *(.plt) }
> +
> + _end = .;
> + __end = .;
> + PROVIDE(end = .);
> +
> + /*
> + * Stabs debugging sections are here too.
> + */
> + .stab 0 : { *(.stab) }
> + .stabstr 0 : { *(.stabstr) }
> + .stab.excl 0 : { *(.stab.excl) }
> + .stab.exclstr 0 : { *(.stab.exclstr) }
> + .stab.index 0 : { *(.stab.index) }
> + .stab.indexstr 0 : { *(.stab.indexstr) }
> + .comment 0 : { *(.comment) }
> +
> + /*
> + * DWARF debug sections.
> + * Symbols in the DWARF debugging sections are relative to the beginning
> + * of the section so we begin them at 0.
> + */
> + /* DWARF 1 */
> + .debug 0 : { *(.debug) }
> + .line 0 : { *(.line) }
> + /* GNU DWARF 1 extensions */
> + .debug_srcinfo 0 : { *(.debug_srcinfo) }
> + .debug_sfnames 0 : { *(.debug_sfnames) }
> + /* DWARF 1.1 and DWARF 2 */
> + .debug_aranges 0 : { *(.debug_aranges) }
> + .debug_pubnames 0 : { *(.debug_pubnames) }
> + /* DWARF 2 */
> + .debug_info 0 : { *(.debug_info .gnu.linkonce.wi.*) }
> + .debug_abbrev 0 : { *(.debug_abbrev) }
> + .debug_line 0 : { *(.debug_line) }
> + .debug_frame 0 : { *(.debug_frame) }
> + .debug_str 0 : { *(.debug_str) }
> + .debug_loc 0 : { *(.debug_loc) }
> + .debug_macinfo 0 : { *(.debug_macinfo) }
> + /* SGI/MIPS DWARF 2 extensions */
> + .debug_weaknames 0 : { *(.debug_weaknames) }
> + .debug_funcnames 0 : { *(.debug_funcnames) }
> + .debug_typenames 0 : { *(.debug_typenames) }
> + .debug_varnames 0 : { *(.debug_varnames) }
> +
> + /DISCARD/ : {
> + *(.note.GNU-stack)
> + *(.data .data.* .gnu.linkonce.d.* .sdata*)
> + *(.bss .sbss .dynbss .dynsbss)
> + }
> }
>
> +/*
> + * Very old versions of ld do not recognize this name token; use the constant.
> + */
> +#define PT_GNU_EH_FRAME 0x6474e550
>
> +/*
> + * We must supply the ELF program headers explicitly to get just one
> + * PT_LOAD segment, and set the flags explicitly to make segments read-only.
> + */
> PHDRS
> {
> - text PT_LOAD FILEHDR PHDRS FLAGS(5); /* PF_R|PF_X */
> - note PT_NOTE FLAGS(4); /* PF_R */
> - dynamic PT_DYNAMIC FLAGS(4); /* PF_R */
> - eh_frame_hdr 0x6474e550; /* PT_GNU_EH_FRAME, but ld doesn't match the name */
> + text PT_LOAD FILEHDR PHDRS FLAGS(5); /* PF_R|PF_X */
> + dynamic PT_DYNAMIC FLAGS(4); /* PF_R */
> + note PT_NOTE FLAGS(4); /* PF_R */
> + eh_frame_hdr PT_GNU_EH_FRAME;
> }
>
> -
> /*
> * This controls what symbols we export from the DSO.
> */
> VERSION
> {
> - VDSO_VERSION_STRING {
> - global:
> - __kernel_datapage_offset; /* Has to be there for the kernel to find */
> - __kernel_get_syscall_map;
> - __kernel_gettimeofday;
> - __kernel_clock_gettime;
> - __kernel_clock_getres;
> - __kernel_get_tbfreq;
> - __kernel_sync_dicache;
> - __kernel_sync_dicache_p5;
> - __kernel_sigtramp32;
> - __kernel_sigtramp_rt32;
> - local: *;
> - };
> + VDSO_VERSION_STRING {
> + global:
> + /*
> + * Has to be there for the kernel to find
> + */
> + __kernel_datapage_offset;
> +
> + __kernel_get_syscall_map;
> + __kernel_gettimeofday;
> + __kernel_clock_gettime;
> + __kernel_clock_getres;
> + __kernel_get_tbfreq;
> + __kernel_sync_dicache;
> + __kernel_sync_dicache_p5;
> + __kernel_sigtramp32;
> + __kernel_sigtramp_rt32;
> +
> + local: *;
> + };
> }
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
^ permalink raw reply
* Re: [PATCH v2 2/2] [POWERPC] MPC8568E-MDS: add support for flash
From: Anton Vorontsov @ 2007-10-16 10:55 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: linuxppc-dev
In-Reply-To: <4713A474.1000301@ru.mvista.com>
On Mon, Oct 15, 2007 at 09:33:40PM +0400, Sergei Shtylyov wrote:
> Anton Vorontsov wrote:
>
>> MPC8568E-MDS have 1 32MB Spansion x16 CFI flash chip. Let's use it.
>
>> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
>
>> diff --git a/arch/powerpc/boot/dts/mpc8568mds.dts
>> b/arch/powerpc/boot/dts/mpc8568mds.dts
>> index 8e15dba..1198363 100644
>> --- a/arch/powerpc/boot/dts/mpc8568mds.dts
>> +++ b/arch/powerpc/boot/dts/mpc8568mds.dts
>> @@ -47,12 +47,45 @@
>> #address-cells = <2>;
>> #size-cells = <1>;
>> reg = <e0005000 d8>;
>> - ranges = <1 0 f8000000 0008000>;
>> + ranges = <1 0 f8000000 0008000
>> + 0 0 fe000000 2000000>;
>> bcsr@1,0 {
>> device_type = "board-control";
>> reg = <1 0 8000>;
>> };
>> +
>> + flash@0,0 {
>> + compatible = "Spansion,S29GL256N11TFIV2O", "cfi-flash";
>> + reg = <0 0 2000000>;
>> + probe-type = "CFI";
>
> I don't get it -- has physmap_of.c rewrite been already committed?
> If yes, you don't need probe_type; if no, your "compatible" won't work...
I see.
/* Helper function to handle probing of the obsolete "direct-mapped"
* compatible binding, which has an extra "probe-type" property [...]
Obsolete, very good.
> Well, I see that the driver rewrite has been committed (when I wasn't
> looking 8-)...
>> + bank-width = <2>;
>> + device-width = <1>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> +
>> + hrcw@0 {
>> + label = "hrcw";
>> + reg = <0 20001>;
>
> What?! Odd sized partition? Don't try to follow both the old and new
> partition device tree specs -- you'll only get yourself into trouble with
> this. The size-cell doesn't bear r/o flag in the new paritions spec.
Thanks for spotting this. It's, of course, forward-porting "thinko".
>> + read-only;
>> + };
>> +
>> + kernel@20000 {
>> + label = "kernel";
>> + reg = <20000 200000>;
>> + };
>> +
>> + rootfs@220000 {
>> + label = "rootfs";
>> + reg = <220000 1d60000>;
>> + };
>> +
>> + uboot@1f80000 {
>> + label = "u-boot";
>> + reg = <1f80000 80000>;
>> + read-only;
>
> Well, this is not even consistent... :-)
Yup, it was a thinko in the hrcw node, not something I really
meant to spread over all ro nodes.
>> + };
>> + };
>> };
>
> WBR, Sergei
Much thanks for the review,
--
Anton Vorontsov
email: cbou@mail.ru
backup email: ya-cbou@yandex.ru
irc://irc.freenode.net/bd2
^ permalink raw reply
* Re: Merge dtc
From: Josh Boyer @ 2007-10-16 10:53 UTC (permalink / raw)
To: benh; +Cc: linuxppc-dev, Paul Mackerras, David Gibson
In-Reply-To: <1192514497.19073.29.camel@pasglop>
On Tue, 2007-10-16 at 16:01 +1000, Benjamin Herrenschmidt wrote:
> On Tue, 2007-10-16 at 00:50 -0500, Kumar Gala wrote:
> > Just out of interest who's complaining? We don't include mkimage
> > for
> > u-boot related builds and I haven't seen any gripes related to that.
>
> It's a pain in the neck since those are built even for things that don't
> need them (such as 4xx where I use the treeboot images).
You might not need them, but others with 4xx boards do. Boards like
Sequoia, etc don't use OpenBIOS. And your compile didn't fail. It just
didn't create the cuImage.
Anyway, I said a couple months ago we should include mkimage in the
kernel and I never got around to doing it. I'll add it to the list.
josh
^ permalink raw reply
* Re: libfdt: libfdt_env.h must be included first
From: Jon Loeliger @ 2007-10-16 12:38 UTC (permalink / raw)
To: David Gibson; +Cc: linuxppc-dev
In-Reply-To: <20071016035034.GP26787@localhost.localdomain>
So, like, the other day David Gibson mumbled:
> libfdt.h currently includes fdt.h, then libfdt_env.h. This is
> incorrect, because depending on the environment into which libfdt is
> embedded, libfdt_env.h may be needed to define datatypes used in
> fdt.h. This patch corrects the problem.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> ---
>
> I've sent this one before, but I guess it got lost in the backlog.
Sorry. There was some froohah around it and I didn't track
where it landed.
Applied.
jdl
^ permalink raw reply
* Re: dtc: Don't delete *.test.dtb between testgroups
From: Jon Loeliger @ 2007-10-16 12:39 UTC (permalink / raw)
To: David Gibson; +Cc: linuxppc-dev
In-Reply-To: <20071016035320.GQ26787@localhost.localdomain>
So, like, the other day David Gibson mumbled:
> The dtc/libfdt testsuite creates a number of .dtb files during its
> run. To ensure a clean test run, these are currently deleted before
> each group of tests.
>
> This is, in fact, a mistake, since if something goes wrong in the
> first group of tests, deleting the .dtb at the beginning of the second
> group of tests makes it harder to figure out what the problem was.
>
> This patch changes the script to only delete the files once, before
> the whole test run.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Applied.
jdl
^ permalink raw reply
* Re: libfdt: Add functions for handling the "compatible" property
From: Jon Loeliger @ 2007-10-16 12:43 UTC (permalink / raw)
To: David Gibson; +Cc: linuxppc-dev
In-Reply-To: <20071016035825.GR26787@localhost.localdomain>
So, like, the other day David Gibson mumbled:
> This patch adds functions for dealing with the compatible property.
> fdt_node_check_compatible() can be used to determine whether a node is
> compatible with a given string and fdt_node_offset_by_compatible()
> locates nodes with a given compatible string.
>
> Testcases for these functions are also included.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Applied.
jdl
^ permalink raw reply
* Re: dtc: Improve support for string escapes
From: Jon Loeliger @ 2007-10-16 13:14 UTC (permalink / raw)
To: David Gibson; +Cc: linuxppc-dev
In-Reply-To: <20071016064202.GC9052@localhost.localdomain>
So, like, the other day David Gibson mumbled:
> dtc supports the use of C-style escapes (\n, \t and so forth) in
> string property definitions via the data_copy_escape_string()
> function. However, while it supports the most common escape
> characters, it doesn't support the full set that C does, which is a
> potential gotcha.
>
> Worse, a bug in the lexer means that while data_copy_escape_string()
> can handle the \" escape, a string with such an escape won't lex
> correctly.
>
> This patch fixes both problems, extending data_copy_escape_string() to
> support the missing escapes, and fixing the regex for strings in the
> lexer to handle internal escaped quotes.
>
> This also adds a testcase for string escape functionality.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Excellent. Thanks.
> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> +++ dtc/tests/string_escapes.c 2007-10-16 16:34:20.000000000 +1000
> @@ -0,0 +1,42 @@
> +/*
> + * libfdt - Flat Device Tree manipulation
> + * Testcase for strinc escapes in dtc
Applied, modulo fixing that typo.
jdl
^ permalink raw reply
* Re: Merge dtc
From: Grant Likely @ 2007-10-16 13:17 UTC (permalink / raw)
To: Paul Mackerras, Josh Boyer, linuxppc-dev
In-Reply-To: <20071016050217.GA9052@localhost.localdomain>
On 10/15/07, David Gibson <david@gibson.dropbear.id.au> wrote:
> This very large patch incorporates a copy of dtc into the kernel
> source, in arch/powerpc/boot/dtc-src. This means that dtc is no
> longer an external dependency to build kernels with configurations
> which need a dtb file.
Powerpc is probably not going to be the only user of dtc. Microblaze
will be using it too. Can it be put somewhere more common?
Cheers,
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195
^ permalink raw reply
* DTC Updates
From: Jon Loeliger @ 2007-10-16 13:32 UTC (permalink / raw)
To: linuxppc-dev
Guys and Dolls,
I pushed out all of David's recent DTC and libfdt patches.
I also jammed the following patch into the mix as well.
HTH,
jdl
commit 9e32930ebcacfcf7cb7c1c2b8e776eb3957cf6cb
Author: Jon Loeliger <jdl@freescale.com>
Date: Tue Oct 16 07:35:38 2007 -0500
Restore warning message about bison expected output.
It was dropped in ad9593f229362782b953da4b805df713e8468df0.
Signed-off-by: Jon Loeliger <jdl@jdl.com>
diff --git a/Makefile b/Makefile
index 84f0efe..d7d1af5 100644
--- a/Makefile
+++ b/Makefile
@@ -207,6 +207,7 @@ clean: libfdt_clean tests_clean
%.tab.c %.tab.h %.output: %.y
@$(VECHO) BISON $@
+ @$(VECHO) ---- Expect 2 s/r and 2 r/r. ----
$(BISON) -d $<
FORCE:
^ permalink raw reply related
* Re: Merge dtc
From: Kumar Gala @ 2007-10-16 13:41 UTC (permalink / raw)
To: Grant Likely; +Cc: Paul Mackerras, linuxppc-dev
In-Reply-To: <fa686aa40710160617o57564cb4r260a40cd66407852@mail.gmail.com>
On Oct 16, 2007, at 8:17 AM, Grant Likely wrote:
> On 10/15/07, David Gibson <david@gibson.dropbear.id.au> wrote:
>> This very large patch incorporates a copy of dtc into the kernel
>> source, in arch/powerpc/boot/dtc-src. This means that dtc is no
>> longer an external dependency to build kernels with configurations
>> which need a dtb file.
>
> Powerpc is probably not going to be the only user of dtc. Microblaze
> will be using it too. Can it be put somewhere more common?
mkimage should also be put somewhere common since other archs use it.
- k
^ permalink raw reply
* Re: Antwort: Re: ATA flash disk ok, missing ip config
From: Mohamed Hamed @ 2007-10-16 12:44 UTC (permalink / raw)
To: linuxppc-embedded
In-Reply-To: <0FOJ00CF99QJAJ@pmdf-it.hasler.ascom.ch>
Dear Sir,
i'm trying to install qemu in a debian linux system , ubuntu , and when
i finished from installation and trying to run the qemu more error be
found as follow :
(qemu) Uncompressing
Linux.......................................................................... done, booting the kernel.
Linux version 2.6.17-rc3 (paul@wren) (gcc version 4.1.0 (CodeSourcery
ARM)) #53 Thu May 4 15:05:18 BST 2006
CPU: ARM926EJ-Sid(wb) [41069265] revision 5 (ARMv5TEJ)
Machine: ARM-IntegratorCP
Memory policy: ECC disabled, Data cache writeback
CPU0: D VIVT write-through cache
CPU0: I cache: 4096 bytes, associativity 4, 32 byte lines, 32 sets
CPU0: D cache: 65536 bytes, associativity 4, 32 byte lines, 512 sets
Built 1 zonelists
Kernel command line: console=ttyAMA0 root= /dev/nfs
nfsroot=10.1.6.1:/nfs/share/arm,rsize=8192,wsize=8192,hard,intr,tcp,nolock ip=10.1.6.50::10.1.6.1:255.255.255.0:arm.home:eth0
PID hash table entries: 2048 (order: 11, 8192 bytes)
Console: colour dummy device 80x30
Dentry cache hash table entries: 32768 (order: 5, 131072 bytes)
Inode-cache hash table entries: 16384 (order: 4, 65536 bytes)
Memory: 256MB = 256MB total
Memory: 257280KB available (1928K code, 388K data, 104K init)
Mount-cache hash table entries: 512
CPU: Testing write buffer coherency: ok
NET: Registered protocol family 16
NetWinder Floating Point Emulator V0.97 (double precision)
Installing knfsd (copyright (C) 1996 okir@monad.swb.de).
Initializing Cryptographic API
io scheduler noop registered
io scheduler anticipatory registered (default)
io scheduler deadline registered
io scheduler cfq registered
CLCD: Integrator/CP hardware, VGA display
Clock CLCDCLK: setting VCO reg params: S=1 R=39 V=35
Console: switching to colour frame buffer device 80x30
Serial: AMBA PL011 UART driver
mb:16: ttyAMA0 at MMIO 0x16000000 (irq = 1) is a AMBA/PL011
mb:17: ttyAMA1 at MMIO 0x17000000 (irq = 2) is a AMBA/PL011
RAMDISK driver initialized: 16 RAM disks of 8192K size 1024 blocksize
loop: loaded (max 8 devices)
nbd: registered device at major 43
smc91x.c: v1.1, sep 22 2004 by Nicolas Pitre <nico@cam.org>
eth0: SMC91C11xFD (rev 1) at d0816000 IRQ 27 [nowait]
eth0: Ethernet addr: 52:54:00:12:34:56
mice: PS/2 mouse device common for all mice
Green LED off
input: AT Raw Set 2 keyboard as /class/input/input0
input: ImExPS/2 Generic Explorer Mouse as /class/input/input1
NET: Registered protocol family 2
IP route cache hash table entries: 2048 (order: 1, 8192 bytes)
TCP established hash table entries: 8192 (order: 3, 32768 bytes)
TCP bind hash table entries: 4096 (order: 2, 16384 bytes)
TCP: Hash tables configured (established 8192 bind 4096)
TCP reno registered
IPv4 over IPv4 tunneling driver
GRE over IPv4 tunneling driver
TCP bic registered
NET: Registered protocol family 1
NET: Registered protocol family 17
802.1Q VLAN Support v1.8 Ben Greear <greearb@candelatech.com>
All bugs added by David S. Miller <davem@redhat.com>
VFP support v0.3: implementor 41 architecture 1 part 10 variant 9 rev 0
eth0: link up
IP-Config: Complete:
device=eth0, addr=10.1.6.50, mask=255.255.255.0, gw=10.1.6.1,
host=arm, domain=, nis-domain=home,
bootserver=255.255.255.255, rootserver=10.1.6.1, rootpath=
Looking up port of RPC 100003/2 on 10.1.6.1
Root-NFS: Unable to get nfsd port number from server, using default
Looking up port of RPC 100005/1 on 10.1.6.1
Root-NFS: Unable to get mountd port number from server, using default
Root-NFS: Server returned error -5 while mounting /nfs/share/arm
VFS: Unable to mount root fs via NFS, trying floppy.
VFS: Cannot open root device "<NULL>" or unknown-block(2,0)
Please append a correct "root=" boot option
Kernel panic - not syncing: VFS: Unable to mount root fs on
unknown-block(2,0)
and i don't know what is the reason and i don't know what the line root
=boot option
this is the script which i run
#!/bin/sh
console="ttyAMA0" # serial console
nfsserver="10.1.6.1" # address of NFS server
nfsdir="/nfs/share/arm" # exported share where debian/arm is installed
address="10.1.6.50" # address for guest server
gateway="10.1.6.1" # default gateway
netmask="255.255.255.0" # subnet mask
hostname="arm.home" # hostname for guest server
device="eth0" # interface that guest server will use
mem=256 # memory for guest server in Mb
tap="/var/run/vde/tap0.ctl" # vde tap socket
kernel="/usr/local/etc/images/zimage.arm" # arm kernel
nfsopts="rsize=8192,wsize=8192,hard,intr,tcp,nolock" # nfs options
consoleopt="console=$console"
nfsrootopt="nfsroot=$nfsserver:$nfsdir,$nfsopts"
ipopt="ip=$address::$gateway:$netmask:$hostname:$device"
init=""
if [ "x$1" == "xsingle" ]
then
init="init=/bin/bash"
fi
vdeq qemu-system-arm -sock $tap -m $mem \
-kernel $kernel -nographic \
-append "$consoleopt root= /dev/nfs $nfsrootopt $ipopt $init"
and i don't know this line root = /dev/nfs , where this directory is
empty
thanks for helping me
i hope to reply me at this mail mhamed@future-group.com
or at eng_m_elsaidy@yahoo.com
Hamed
^ permalink raw reply
* Please pull from 'fixes-2.6.24'
From: Kumar Gala @ 2007-10-16 14:10 UTC (permalink / raw)
To: Paul Mackerras; +Cc: linuxppc-dev
(Note, this tree is based on a recent linus tree)
Please pull from 'fixes-2.6.24' branch of
master.kernel.org:/pub/scm/linux/kernel/git/galak/powerpc.git fixes-2.6.24
to receive the following updates:
arch/powerpc/math-emu/math.c | 13 +++++++++----
arch/powerpc/sysdev/fsl_pci.c | 2 +-
2 files changed, 10 insertions(+), 5 deletions(-)
Kumar Gala (1):
[POWERPC] Fix handling of stfiwx math emulation
Tony Li (1):
[POWERPC] Add missing semicolon for fsl_pci.c
commit 01db9953a70e8ad33fbcf91d629f8a8ee59b3484
Author: Tony Li <tony.li@freescale.com>
Date: Tue Oct 16 15:15:23 2007 +0800
[POWERPC] Add missing semicolon for fsl_pci.c
Signed-off-by: Tony Li <tony.li@freescale.com>
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
commit ba02946a903015840ef672ccc9dc8620a7e83de6
Author: Kumar Gala <galak@kernel.crashing.org>
Date: Thu Oct 11 17:07:34 2007 -0500
[POWERPC] Fix handling of stfiwx math emulation
Its legal for the stfiwx instruction to have RA = 0 as part of its
effective address calculation. This is illegal for all other XE
form instructions.
Add code to compute the proper effective address for stfiwx if
RA = 0 rather than treating it as illegal.
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
diff --git a/arch/powerpc/math-emu/math.c b/arch/powerpc/math-emu/math.c
index 69058b2..381306b 100644
--- a/arch/powerpc/math-emu/math.c
+++ b/arch/powerpc/math-emu/math.c
@@ -407,11 +407,16 @@ do_mathemu(struct pt_regs *regs)
case XE:
idx = (insn >> 16) & 0x1f;
- if (!idx)
- goto illegal;
-
op0 = (void *)¤t->thread.fpr[(insn >> 21) & 0x1f];
- op1 = (void *)(regs->gpr[idx] + regs->gpr[(insn >> 11) & 0x1f]);
+ if (!idx) {
+ if (((insn >> 1) & 0x3ff) == STFIWX)
+ op1 = (void *)(regs->gpr[(insn >> 11) & 0x1f]);
+ else
+ goto illegal;
+ } else {
+ op1 = (void *)(regs->gpr[idx] + regs->gpr[(insn >> 11) & 0x1f]);
+ }
+
break;
case XEU:
diff --git a/arch/powerpc/sysdev/fsl_pci.c b/arch/powerpc/sysdev/fsl_pci.c
index af090c9..33df4c3 100644
--- a/arch/powerpc/sysdev/fsl_pci.c
+++ b/arch/powerpc/sysdev/fsl_pci.c
@@ -255,7 +255,7 @@ DECLARE_PCI_FIXUP_EARLY(0x1957, PCI_DEVICE_ID_MPC8533E, quirk_fsl_pcie_transpare
DECLARE_PCI_FIXUP_EARLY(0x1957, PCI_DEVICE_ID_MPC8533, quirk_fsl_pcie_transparent);
DECLARE_PCI_FIXUP_EARLY(0x1957, PCI_DEVICE_ID_MPC8544E, quirk_fsl_pcie_transparent);
DECLARE_PCI_FIXUP_EARLY(0x1957, PCI_DEVICE_ID_MPC8544, quirk_fsl_pcie_transparent);
-DECLARE_PCI_FIXUP_EARLY(0x1957, PCI_DEVICE_ID_MPC8572E, quirk_fsl_pcie_transparent)
+DECLARE_PCI_FIXUP_EARLY(0x1957, PCI_DEVICE_ID_MPC8572E, quirk_fsl_pcie_transparent);
DECLARE_PCI_FIXUP_EARLY(0x1957, PCI_DEVICE_ID_MPC8572, quirk_fsl_pcie_transparent);
DECLARE_PCI_FIXUP_EARLY(0x1957, PCI_DEVICE_ID_MPC8641, quirk_fsl_pcie_transparent);
DECLARE_PCI_FIXUP_EARLY(0x1957, PCI_DEVICE_ID_MPC8641D, quirk_fsl_pcie_transparent);
^ permalink raw reply related
* Serial init / BRG
From: Alan Bennett @ 2007-10-16 14:19 UTC (permalink / raw)
To: Scott Wood, linuxppc-dev
For some reason I'm unable to track down the right sequence to
initialize my serial ports. (note: my console is working, but
attempts to initialize SCC1 and SCC4 fail). My console has the luxury
of having uboot initialize it and its brg, but SCC1 / SCC4 aren't so
lucky.
A few questions: To use 3 brgs, should I have 1 brg entry and X reg
values or three brg entries in my device tree? what are the third and
fourth reg values of the brg item in the device tree. I'll need 3
separate baud rates on the serial lines. Should I just add code to
initialize the brg's in u-boot or figure out how to get the kernel to
do it?
boot sequence
===========
CPM UART serial mem=e0011a80 pram=e0000000
ttyCPM0 at MMIO 0xe0011a80 (irq = 16) is a CPM UART
CPM UART serial mem=e0011a00 pram=e0008000
CPM uart[1]:init_scc - sup = e0008000
ttyCPM1 at MMIO 0xe0011a00 (irq = 40) is a CPM UART
CPM UART serial mem=e0011a60 pram=e0008300
CPM uart[2]:init_scc - sup = e0008300
ttyCPM2 at MMIO 0xe0011a60 (irq = 43) is a CPM UART
BRG Values after above
=================
brgc1: 0x00000000
brgc2: 0x00000000
brgc3: 0x00000000
brgc4: 0x00000000
brgc5: 0x00000000
brgc6: 0x00000000
brgc7: 0x0001004e
brgc8: 0x00000000
Device Tree:
brg@119f0 {
compatible = "fsl,mpc8272-brg",
"fsl,cpm2-brg",
"fsl,cpm-brg";
reg = <119f0 10 115f0 10>;
};
/* Monitor port/SMC1 */
serial@11a80 {
device_type = "serial";
compatible = "fsl,mpc8248-smc-uart",
"fsl,cpm2-smc-uart";
reg = <11a80 20 0 40>;
interrupts = <4 8>;
interrupt-parent = <&PIC>;
fsl,cpm-brg = <7>;
fsl,cpm-command = <1d000000>;
};
/* "Serial" port/SCC1 */
serial@11a00 {
device_type = "serial";
compatible = "fsl,mpc8248-scc-uart",
"fsl,cpm2-scc-uart";
reg = <11a00 20 8000 100>;
interrupts = <28 8>;
interrupt-parent = <&PIC>;
fsl,cpm-brg = <1>;
fsl,cpm-command = <00800000>;
};
/* "Serial" port/SCC4 */
serial@11a60 {
device_type = "serial";
compatible = "fsl,mpc8248-scc-uart",
"fsl,cpm2-scc-uart";
reg = <11a60 20 8300 100>;
interrupts = <2B 8>;
interrupt-parent = <&PIC>;
fsl,cpm-brg = <4>;
fsl,cpm-command = <0CE00000>;
};
^ permalink raw reply
* Re: [PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers
From: Joachim Fenkes @ 2007-10-16 21:20 UTC (permalink / raw)
To: Jeff Garzik
Cc: Thomas Q Klein, Jan-Bernd Themann, netdev, Paul Mackerras, LKML,
LinuxPPC-Dev, Christoph Raisch, Marcus Eder, Paul Mackerras,
Stefan Roscher
In-Reply-To: <OF48E0997F.B61F7220-ONC125736F.002D7F06-C125736F.002DD39C@de.ibm.com>
On Tuesday 09 October 2007 10:21, Jan-Bernd Themann wrote:
> Roland Dreier <rdreier@cisco.com> wrote on 03.10.2007 20:05:44:
> > > > Replace struct ibmebus_dev and struct ibmebus_driver with struct=20
of_device
> > > > and struct of_platform_driver, respectively. Match the external=20
ibmebus
> > > > interface and drivers using it.
> > > >
> > > > Signed-off-by: Joachim Fenkes <fenkes@de.ibm.com>
> > >
> > > This is somewhat difficult as this patch touches files that are the
> > > responsibility of three different maintainers. =A0Is it possible to
> > > split the patch into three, one for each maintainer (possibly by
> > > keeping both old and new interfaces around for a little while)?
> > >=20
> > > If not, then you need to get an Acked-by and an agreement that this
> > > change can go via the powerpc.git tree from Roland Dreier and Jeff
> > > Garzik.
> >
> > I don't see anything objectionable in the infiniband parts of the
> > patch -- I don't have any way to test the changes but it all looks
> > like a straightforward conversion to a new platform API. So:
> >
> > Acked-by: Roland Dreier <rolandd@cisco.com>
> >
> > - R.
>
> Looks good from eHEA driver perspective.
>
> Acked-by: Jan-Bernd Themann <themann@de.ibm.com>
Jeff, do you have any objections against this patch going into the kernel
via Paul's powerpc.git tree? It touches only a few lines of ehea which are
specific to the bus interface changes.
You can see the full patch here:
http://patchwork.ozlabs.org/linuxppc/patch?id=3D13750
If you have no objections, please ack the patch so Paul can include it.
Thanks and regards,
Joachim
^ permalink raw reply
* Re: [PATCH v2 4/7] bestcomm: core bestcomm support for Freescale MPC5200
From: tnt @ 2007-10-16 13:21 UTC (permalink / raw)
To: Grant Likely; +Cc: linuxppc-dev, paulus, domen.puncer
In-Reply-To: <fa686aa40710150704j15f3a511rf5924573282c966b@mail.gmail.com>
> On 10/15/07, Matt Sealey <matt@genesi-usa.com> wrote:
>>
>> My nits:
>>
>> Grant Likely wrote:
>> > From: Sylvain Munaut <tnt@246tNt.com>
>> > +static int __devinit
>> > +bcom_engine_init(void)
>>
>> Why "bcom" and not "bestcomm"?
>
> I can type 'bcom' twice as fast. :-) bcom is a suitable shortening;
> I'm not concerned about it.
I prefer bcom as well. Much shorter and there is no ambiguity.
If you use theses, you are writing a 5200 driver. In that context you
should be able to figure out what 'bcom' stands for ... (and if not, maybe
you shouldn't be using them ;)
>> > + /* Disable COMM Bus Prefetch, apparently it's not reliable yet
>> */
>> > + /* FIXME: This should be done on 5200 and not 5200B ... */
>> > + out_be16(&bcom_eng->regs->PtdCntrl,
>> in_be16(&bcom_eng->regs->PtdCntrl) | 1);
>>
>> This really, really shouldn't even be here, could it be moved to a
>> platform
>> init, or switched on a PVR/SVR here?
>
> I think I'd like to leave it here for getting this series merged; it
> may not be good to have it here; but it's not dangerous either. I'm
> trying to keep churn on this series down to a minimum.
>
> Please submit a patch to make this change once it's merged.
Mmmm.
I think it _does_ belong here. COMM bus prefetch _is_ a bestcomm engine
option.
But indeed as the comment says, it maybe should be enabled on 5200B.
Not a big concern for me at the moment tough.
Sylvain
^ permalink raw reply
* cross compilation issue
From: Venkatesh Ananthakrishnan, TLS-Chennai @ 2007-10-16 14:24 UTC (permalink / raw)
To: linuxppc-embedded
[-- Attachment #1: Type: text/plain, Size: 1431 bytes --]
Hai
I am newbi to linux.
I wrote the application usb libusb which works fine with x86 pc.
I want to compile the application for ppc. I have cross compiled libusb.
I have tool chain also.
If I give ppc_6xx-gcc filename.c
It gives the error message as usb.h No such a file or directory.
How to give include path and library path during compilation?
Please do the needful
Regards,
Venkatesh
DISCLAIMER:
-----------------------------------------------------------------------------------------------------------------------
The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only.
It shall not attach any liability on the originator or HCL or its affiliates. Any views or opinions presented in
this email are solely those of the author and may not necessarily reflect the opinions of HCL or its affiliates.
Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of
this message without the prior written consent of the author of this e-mail is strictly prohibited. If you have
received this email in error please delete it and notify the sender immediately. Before opening any mail and
attachments please check them for viruses and defect.
-----------------------------------------------------------------------------------------------------------------------
[-- Attachment #2: Type: text/html, Size: 4005 bytes --]
^ permalink raw reply
* ioctl32: Unknown cmd
From: Geert Uytterhoeven @ 2007-10-16 14:45 UTC (permalink / raw)
To: Arnd Bergmann, Jens Axboe; +Cc: Linux/PPC Development, Linux Kernel Development
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1182 bytes --]
Hi Arnd, Jens,
The recent (post 2.6.23) changes to compat_ioctl made the reporting of
unsupported ioctls more verbose. E.g. on the PS3 I get:
| ioctl32(cdrom_id:608): Unknown cmd fd(3) cmd(00005331){t:'S';sz:0} arg(00000000) on /dev/.tmp-11-0
| ioctl32(hdparm:1427): Unknown cmd fd(3) cmd(0000031f){t:03;sz:0} arg(00000000) on /dev/ps3da
| ioctl32(hdparm:1427): Unknown cmd fd(3) cmd(0000031f){t:03;sz:0} arg(00000000) on /dev/ps3da
The first one is triggered by the detection of the CD/DVD/BD-ROM driver,
The others are triggered by me running hdparm.
Was this intentional?
With kind regards,
Geert Uytterhoeven
Software Architect
Sony Network and Software Technology Center Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium
Phone: +32 (0)2 700 8453
Fax: +32 (0)2 700 8622
E-mail: Geert.Uytterhoeven@sonycom.com
Internet: http://www.sony-europe.com/
Sony Network and Software Technology Center Europe
A division of Sony Service Centre (Europe) N.V.
Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium
VAT BE 0413.825.160 · RPR Brussels
Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619
^ permalink raw reply
* Re: cross compilation issue
From: ravi.rao @ 2007-10-16 14:51 UTC (permalink / raw)
To: avenkatesh
Cc: linuxppc-embedded-bounces+ravi.rao=rflelect.com,
linuxppc-embedded
In-Reply-To: <66E8AEE9980BB44CA5FCAD39EBA56AC6029A29DD@CHN-HCLT-EVS02.HCLT.CORP.HCL.IN>
[-- Attachment #1: Type: text/plain, Size: 2603 bytes --]
Hi,
Easiest way is to edit the x86 Makefile so that gcc and ld points to Ur
tool chain's ppc_6xx-gcc & ppc_6xx-ld..
Thanks,
Ravishankar Govindarao
RFL Electronics Inc.
E-mail : Ravi.Rao@rflelect.com
Voice: 973.334.3100 Ext. 233
Fax: 973.334.3863
CONFIDENTIALITY NOTE
This e-mail, including any attachments, may contain confidential and/or
legally privileged information. The Information is intended only for the
use of the individual or entity named on this e-mail . If you are not the
intended recipient, you are hereby notified that any disclosure, copying,
distribution, or the taking of any action in reliance on the contents of
this transmitted Information is strictly prohibited. Further, if you are
not the intended recipient, please notify us by return e-mail and delete
the Information promptly.
"Venkatesh Ananthakrishnan, TLS-Chennai" <avenkatesh@hcl.in>
Sent by: linuxppc-embedded-bounces+ravi.rao=rflelect.com@ozlabs.org
10/16/2007 10:24 AM
To
<linuxppc-embedded@ozlabs.org>
cc
Subject
cross compilation issue
Hai
I am newbi to linux.
I wrote the application usb libusb which works fine with x86 pc.
I want to compile the application for ppc. I have cross compiled libusb. I
have tool chain also.
If I give ppc_6xx-gcc filename.c
It gives the error message as usb.h No such a file or directory.
How to give include path and library path during compilation?
Please do the needful
Regards,
Venkatesh
DISCLAIMER:
-----------------------------------------------------------------------------------------------------------------------
The contents of this e-mail and any attachment(s) are confidential and
intended for the named recipient(s) only.
It shall not attach any liability on the originator or HCL or its
affiliates. Any views or opinions presented in
this email are solely those of the author and may not necessarily reflect
the opinions of HCL or its affiliates.
Any form of reproduction, dissemination, copying, disclosure,
modification, distribution and / or publication of
this message without the prior written consent of the author of this
e-mail is strictly prohibited. If you have
received this email in error please delete it and notify the sender
immediately. Before opening any mail and
attachments please check them for viruses and defect.
-----------------------------------------------------------------------------------------------------------------------
_______________________________________________
Linuxppc-embedded mailing list
Linuxppc-embedded@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-embedded
[-- Attachment #2: Type: text/html, Size: 4726 bytes --]
^ permalink raw reply
* Re: [PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers
From: Jeff Garzik @ 2007-10-16 15:00 UTC (permalink / raw)
To: Joachim Fenkes
Cc: Thomas Q Klein, Jan-Bernd Themann, netdev, Paul Mackerras, LKML,
LinuxPPC-Dev, Christoph Raisch, Marcus Eder, Paul Mackerras,
Stefan Roscher
In-Reply-To: <200710162320.00630.fenkes@de.ibm.com>
Joachim Fenkes wrote:
> On Tuesday 09 October 2007 10:21, Jan-Bernd Themann wrote:
>> Roland Dreier <rdreier@cisco.com> wrote on 03.10.2007 20:05:44:
>>> > > Replace struct ibmebus_dev and struct ibmebus_driver with struct
> of_device
>>> > > and struct of_platform_driver, respectively. Match the external
> ibmebus
>>> > > interface and drivers using it.
>>> > >
>>> > > Signed-off-by: Joachim Fenkes <fenkes@de.ibm.com>
>>> >
>>> > This is somewhat difficult as this patch touches files that are the
>>> > responsibility of three different maintainers. �Is it possible to
>>> > split the patch into three, one for each maintainer (possibly by
>>> > keeping both old and new interfaces around for a little while)?
>>> >
>>> > If not, then you need to get an Acked-by and an agreement that this
>>> > change can go via the powerpc.git tree from Roland Dreier and Jeff
>>> > Garzik.
>>>
>>> I don't see anything objectionable in the infiniband parts of the
>>> patch -- I don't have any way to test the changes but it all looks
>>> like a straightforward conversion to a new platform API. So:
>>>
>>> Acked-by: Roland Dreier <rolandd@cisco.com>
>>>
>>> - R.
>> Looks good from eHEA driver perspective.
>>
>> Acked-by: Jan-Bernd Themann <themann@de.ibm.com>
>
> Jeff, do you have any objections against this patch going into the kernel
> via Paul's powerpc.git tree? It touches only a few lines of ehea which are
> specific to the bus interface changes.
>
> You can see the full patch here:
> http://patchwork.ozlabs.org/linuxppc/patch?id=13750
>
> If you have no objections, please ack the patch so Paul can include it.
Fine with me...
Jeff
^ permalink raw reply
* [PATCH 0/5] IB/ehca: SRQ and MR/MW fixes
From: Joachim Fenkes @ 2007-10-16 15:22 UTC (permalink / raw)
To: LinuxPPC-Dev, LKML, OF-General, Roland Dreier, OF-EWG
Cc: Stefan Roscher, Christoph Raisch
Here are some more fixes for the eHCA driver, fixing some problems we found
during internal system test.
[1/5] fixes the QP pointer determination for SRQ base QPs
[2/5] fixes a masking error in {,re}reg_phys_mr()
[3/5] fixes a bug in alloc_fmr() and simplifies some code
[4/5] refactors hca_cap_mr_pgsize and fixes a problem with ib_srp
[5/5] enables large page MRs by default
I built the patches on top of Roland's for-2.6.24 git branch. Please review
and queue them for 2.6.24-rc1 if you're okay with them. Thanks!
Cheers,
Joachim
=2D-=20
Joachim Fenkes =A0-- =A0eHCA Linux Driver Developer and Hardware Tamer
IBM Deutschland Entwicklung GmbH =A0-- =A0Dept. 3627 (I/O Firmware Dev. 2)
Schoenaicher Strasse 220 =A0-- =A071032 Boeblingen =A0-- =A0Germany
eMail: fenkes@de.ibm.com
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox