LinuxPPC-Dev Archive on lore.kernel.org

* Re: [PATCH 0/4] PowerPC: implement GPIO API
From: Segher Boessenkool @ 2007-12-23  2:47 UTC (permalink / raw)
  To: avorontsov; +Cc: linuxppc-dev
In-Reply-To: <20071221202824.GA4607@localhost.localdomain>

> OF device tree GPIOs bindings are similar to IRQs:

But GPIOs are a very different thing.  Most importantly, the "number"
of a GPIO is completely local to the GPIO controller.

> pario0: gpio-controller@0 {
> 	#gpio-cells = <2>;

Your Linux code doesn't actually use this.  Why is it needed, anyway?
You should be able to encode a GPIO identifier in a single 32-bit word,
for any possible GPIO controller.

> 	num-ports = <7>;

What is this?  What is a "port"?  This doesn't belong in a generic GPIO
binding.

> device@0 {
> 	gpios = <bank pin bank pin bank pin>;
> 	gpio-parent = <&pario0>;

Not every GPIO controller has banks.  Not every device uses GPIOs
on a single GPIO controller.  It is inconvenient to force all bindings
to use the same name ("gpios") for its property that shows the GPIOs
(and for it to have only one such property).

So I recommend:

-- Advise (in the generic GPIO binding) people to use
	< phandle-of-gpio-controller gpio-id-on-that-controller >
to refer to a GPIO from some device node;

-- And either:
	-- Define (in the generic GPIO binding) that a "gpio-id" is a single
	   32-bit cell;
    or
	-- Define (in the generic GPIO binding) that a "gpio-id" is a number
	   of 32-bit cells, and that that number of cells is encoded as a 
32-bit
	   integer in the "#gpio-cells" property in the device node of the
	   respective GPIO controller.

(I like the first option better, unless someone can think of some 
reasonable
situation where some specific GPIO controller binding needs more than 
32 bits
to encode GPIO #).

Segher

^ permalink raw reply