* Re: [PATCH 02/18] ide: fix ide_find_port()
From: Sergei Shtylyov @ 2008-02-08 17:23 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: linux-ide, linux-kernel, linuxppc-dev
In-Reply-To: <20080208004434.17746.33986.sendpatchset@localhost.localdomain>
Bartlomiej Zolnierkiewicz wrote:
> * Instead of checking for '->io_ports[IDE_DATA_OFFSET] == 0' check for
> '->chipset == ide_unknown' when looking for an empty ide_hwifs[] slot.
> * Do ide-pnp initialization after ide-generic when IDE is built-in
> (ide-pnp is the only user of ide_find_port() which needs such fixup).
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
^ permalink raw reply
* Re: [PATCH] Fix compilation of powerpc asm-offsets.c with old gcc
From: Paul Jackson @ 2008-02-08 18:06 UTC (permalink / raw)
To: Linus Torvalds; +Cc: linux-kernel, linuxppc-dev, paulus, akpm, tglx
In-Reply-To: <alpine.LFD.1.00.0802071449240.2896@woody.linux-foundation.org>
Linus wrote:
> Please, when mentioning hex numbers, also do the one-liner shortlog.
> ...
> without _requiring_ people to be git users to get the gist of the
> matter, ok?
Thanks for sticking up for us git-challenged contributors.
Can anyone point me at instructions providing the shortest
path for getting from one of those git hex numbers to the
log or change it represents, for non-git users?
Or do those instructions begin with a first step of:
1. become a git user
2. ...
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.940.382.4214
^ permalink raw reply
* Re: [PATCH] Fix powerpc vdso clock_getres().
From: Sean MacLennan @ 2008-02-08 18:16 UTC (permalink / raw)
To: Tony Breeds; +Cc: LinuxPPC-dev, Thomas Gleixner, Paul Mackerras
In-Reply-To: <20080207064750.GG6887@bakeyournoodle.com>
Tony Breeds wrote:
> Since implementing highres timers on powerpc the clock_getres syscall
> has reported different resolutions due to the vdso using the a low res
> value. In the patch d7f71674ad7c3c4467e48f6ab9e85516dae2720
> ([POWERPC] Use a sensible default for clock_getres() in the VDSO), the
> powerpc vdso was updated to use the correct value.
>
> This fix doesn't work on older compilers. Below is a fix for powerpc,
> that introduces a new (generic) #define MONOTONIC_RES_NSEC which is
> equal to the 64 value stored in KTIME_MONOTONIC_RES.
>
Just a confirmation that this patch fixed my compile issue. And I was
using gcc-4.0.0.
Thanks,
Sean
^ permalink raw reply
* Re: [PATCH] [POWERPC] Xilinx: hwicap driver
From: Randy Dunlap @ 2008-02-08 16:49 UTC (permalink / raw)
To: Stephen Neuendorffer; +Cc: linuxppc-dev, jirislaby, linux-kernel
In-Reply-To: <20080208021747.92253161805C@mail10-sin.bigfish.com>
On Thu, 7 Feb 2008 18:17:41 -0800 Stephen Neuendorffer wrote:
> drivers/char/Kconfig | 7 +
> drivers/char/Makefile | 1 +
> drivers/char/xilinx_hwicap/Makefile | 7 +
> drivers/char/xilinx_hwicap/buffer_icap.c | 380 ++++++++++++
> drivers/char/xilinx_hwicap/buffer_icap.h | 57 ++
> drivers/char/xilinx_hwicap/fifo_icap.c | 381 ++++++++++++
> drivers/char/xilinx_hwicap/fifo_icap.h | 62 ++
> drivers/char/xilinx_hwicap/xilinx_hwicap.c | 923 ++++++++++++++++++++++++++++
> drivers/char/xilinx_hwicap/xilinx_hwicap.h | 193 ++++++
> 9 files changed, 2011 insertions(+), 0 deletions(-)
> create mode 100644 drivers/char/xilinx_hwicap/Makefile
> create mode 100644 drivers/char/xilinx_hwicap/buffer_icap.c
> create mode 100644 drivers/char/xilinx_hwicap/buffer_icap.h
> create mode 100644 drivers/char/xilinx_hwicap/fifo_icap.c
> create mode 100644 drivers/char/xilinx_hwicap/fifo_icap.h
> create mode 100644 drivers/char/xilinx_hwicap/xilinx_hwicap.c
> create mode 100644 drivers/char/xilinx_hwicap/xilinx_hwicap.h
>
> diff --git a/drivers/char/xilinx_hwicap/buffer_icap.c b/drivers/char/xilinx_hwicap/buffer_icap.c
> new file mode 100644
> index 0000000..dfea2bd
> --- /dev/null
> +++ b/drivers/char/xilinx_hwicap/buffer_icap.c
> @@ -0,0 +1,380 @@
> +/**
> + * buffer_icap_get_status: Get the contents of the status register.
> + * @parameter base_address: is the base address of the device
> + *
Hi,
For this function and many others in these source files:
Please see Documentation/kernel-doc-nano-HOWTO.txt for the correct
kernel-doc notation format.
If you have questions or need help, please ask.
Hints:
a. function name & short description: separate name & description with '-'
b. parameters are listed as: @base_address: (without "parameter")
> + * The status register contains the ICAP status and the done bit.
> + *
> + * D8 - cfgerr
> + * D7 - dalign
> + * D6 - rip
> + * D5 - in_abort_l
> + * D4 - Always 1
> + * D3 - Always 1
> + * D2 - Always 1
> + * D1 - Always 1
> + * D0 - Done bit
> + **/
> +static inline u32 buffer_icap_get_status(void __iomem *base_address)
> +{
> + return in_be32(base_address + XHI_STATUS_REG_OFFSET);
> +}
> diff --git a/drivers/char/xilinx_hwicap/xilinx_hwicap.h b/drivers/char/xilinx_hwicap/xilinx_hwicap.h
> new file mode 100644
> index 0000000..5718679
> --- /dev/null
> +++ b/drivers/char/xilinx_hwicap/xilinx_hwicap.h
> @@ -0,0 +1,193 @@
> +#ifndef XILINX_HWICAP_H_ /* prevent circular inclusions */
> +#define XILINX_HWICAP_H_ /* by using protection macros */
> +
> +#include <linux/types.h>
> +#include <linux/cdev.h>
> +#include <linux/version.h>
> +#include <linux/platform_device.h>
> +
> +#include <asm/io.h>
> +
> +struct hwicap_drvdata {
BTW, you can also use kernel-doc for structs, unions, & enums.
> + u32 write_buffer_in_use; /* Always in [0,3] */
> + u8 write_buffer[4];
> + u32 read_buffer_in_use; /* Always in [0,3] */
> + u8 read_buffer[4];
> + resource_size_t mem_start;/* phys. address of the control registers */
> + resource_size_t mem_end; /* phys. address of the control registers */
> + resource_size_t mem_size;
> + void __iomem *base_address;/* virt. address of the control registers */
> +
> + struct device *dev;
> + struct cdev cdev; /* Char device structure */
> + dev_t devt;
> +
> + const struct hwicap_driver_config *config;
> + const struct config_registers *config_regs;
> + void *private_data;
> + bool is_open;
> + struct mutex sem;
> +};
> +
> +struct hwicap_driver_config {
> + int (*get_configuration)(struct hwicap_drvdata *drvdata, u32 *data,
> + u32 size);
> + int (*set_configuration)(struct hwicap_drvdata *drvdata, u32 *data,
> + u32 size);
> + void (*reset)(struct hwicap_drvdata *drvdata);
> +};
> +
> +/* Number of times to poll the done regsiter */
> +#define XHI_MAX_RETRIES 10
---
~Randy
^ permalink raw reply
* Re: [PATCH] Fix compilation of powerpc asm-offsets.c with old gcc
From: Olof Johansson @ 2008-02-08 18:21 UTC (permalink / raw)
To: Paul Jackson
Cc: linux-kernel, linuxppc-dev, paulus, tglx, Linus Torvalds, akpm
In-Reply-To: <20080208120623.3ad74e3a.pj@sgi.com>
On Fri, Feb 08, 2008 at 12:06:23PM -0600, Paul Jackson wrote:
> Linus wrote:
> > Please, when mentioning hex numbers, also do the one-liner shortlog.
> > ...
> > without _requiring_ people to be git users to get the gist of the
> > matter, ok?
>
>
> Thanks for sticking up for us git-challenged contributors.
>
> Can anyone point me at instructions providing the shortest
> path for getting from one of those git hex numbers to the
> log or change it represents, for non-git users?
>
> Or do those instructions begin with a first step of:
>
> 1. become a git user
> 2. ...
Does this count?
1. Go to http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git
2. Enter the SHA string in the 'search' field at the top right
-Olo
^ permalink raw reply
* Re: [PATCH] Fix compilation of powerpc asm-offsets.c with old gcc
From: Harvey Harrison @ 2008-02-08 18:20 UTC (permalink / raw)
To: Paul Jackson
Cc: linux-kernel, linuxppc-dev, paulus, akpm, Linus Torvalds, tglx
In-Reply-To: <20080208120623.3ad74e3a.pj@sgi.com>
On Fri, 2008-02-08 at 12:06 -0600, Paul Jackson wrote:
> Linus wrote:
> > Please, when mentioning hex numbers, also do the one-liner shortlog.
> > ...
> > without _requiring_ people to be git users to get the gist of the
> > matter, ok?
>
>
> Thanks for sticking up for us git-challenged contributors.
>
> Can anyone point me at instructions providing the shortest
> path for getting from one of those git hex numbers to the
> log or change it represents, for non-git users?
>
Replace <SHA> as needed:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=<SHA>
Harvey
^ permalink raw reply
* Re: [PATCH] Fix compilation of powerpc asm-offsets.c with old gcc
From: Olof Johansson @ 2008-02-08 18:23 UTC (permalink / raw)
To: Paul Jackson
Cc: linux-kernel, linuxppc-dev, paulus, tglx, Linus Torvalds, akpm
In-Reply-To: <20080208182154.GA10295@lixom.net>
On Fri, Feb 08, 2008 at 12:21:54PM -0600, Olof Johansson wrote:
> On Fri, Feb 08, 2008 at 12:06:23PM -0600, Paul Jackson wrote:
> > Linus wrote:
> > > Please, when mentioning hex numbers, also do the one-liner shortlog.
> > > ...
> > > without _requiring_ people to be git users to get the gist of the
> > > matter, ok?
> >
> >
> > Thanks for sticking up for us git-challenged contributors.
> >
> > Can anyone point me at instructions providing the shortest
> > path for getting from one of those git hex numbers to the
> > log or change it represents, for non-git users?
> >
> > Or do those instructions begin with a first step of:
> >
> > 1. become a git user
> > 2. ...
>
> Does this count?
>
> 1. Go to http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git
> 2. Enter the SHA string in the 'search' field at the top right
Ack, that just found the commit that referred to it, not the original
one. My bad.
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=<hex value>
Will bring it up though.
-Olof
^ permalink raw reply
* Re: [PATCH] Fix compilation of powerpc asm-offsets.c with old gcc
From: Simon Holm Thøgersen @ 2008-02-08 18:31 UTC (permalink / raw)
To: Paul Jackson
Cc: linux-kernel, linuxppc-dev, paulus, akpm, Linus Torvalds, tglx
In-Reply-To: <20080208120623.3ad74e3a.pj@sgi.com>
fre, 08 02 2008 kl. 12:06 -0600, skrev Paul Jackson:
> Linus wrote:
> > Please, when mentioning hex numbers, also do the one-liner shortlog.
> > ...
> > without _requiring_ people to be git users to get the gist of the
> > matter, ok?
>
>
> Thanks for sticking up for us git-challenged contributors.
>
> Can anyone point me at instructions providing the shortest
> path for getting from one of those git hex numbers to the
> log or change it represents, for non-git users?
Use gitweb [1], Linus' tree is here [2]. Just search for the hex.
[1] http://git.kernel.org/
[2]
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=summary
Simon Holm Thøgersen
^ permalink raw reply
* Re: [PATCH] Fix compilation of powerpc asm-offsets.c with old gcc
From: Paul Jackson @ 2008-02-08 18:39 UTC (permalink / raw)
To: Olof Johansson
Cc: linux-kernel, linuxppc-dev, paulus, tglx, torvalds, akpm,
Harvey Harrison
In-Reply-To: <20080208182343.GB10295@lixom.net>
Thanks, Olof and Harvey.
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=
Just what I was looking for.
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.940.382.4214
^ permalink raw reply
* RE: [Virtex 4 PPC] Problem mountin rootfs via NFS
From: Sugathan, Rupesh @ 2008-02-08 18:27 UTC (permalink / raw)
To: IngoM, linuxppc-embedded
in the meantime, I get up my toolchain and an linux-kernel from xilinx
git-repository.
Hardware is an FX12 Mini-Module form AVNET, standard design with
LL-TEMAC, EDK 9.2.
Kernel boots fine till he try to mount his rootfs via NFS. NFS is
working correctly, probed with some other maschines. Some times kernel
can mount NFS, somtimes kernel panics trying this.
I already try some additional parameters found here on the list like
"tcp,no_lock" but didn't help. Also probed direct connection, connection
via a 100 MBit switch. No success.
Another thing I tried is set ip=3Ddhcp, the device find our DHCP-Server
and gets an address. So I think network should ok, but where comes the
NFS trouble from?
=20
Do you have a 'console' device file set up in your NFS rootfilesystem?=20
Thanks
--
Rupesh Sugathan
^ permalink raw reply
* APU FPU in Virtex ppc405
From: A. Nolson @ 2008-02-08 18:51 UTC (permalink / raw)
To: linuxppc-embedded
Hi,
I have just heard that Xilinx has freed the FPU module for the PPC
architecture in EDK9.2i. WIll I be able to make it work with my
Secretlab Linux 2.6.24rc3? Will the eldk toolchain for PPC_4xxfp work?
Will it be just a matter of integrating it with the XPS BSP?I make an
extensive use of floating point in my applications and this will be
really useful.
Thanks for your help.
^ permalink raw reply
* RE: [Virtex 4 PPC] Problem mountin rootfs via NFS
From: IngoM @ 2008-02-08 19:00 UTC (permalink / raw)
To: linuxppc-embedded
In-Reply-To: <EE63F03D9E04774997AEBCD21FC77F25190363@ccomm-ex1.ccomm.com>
Dear Rupesh,
Sugathan, Rupesh wrote:
>
>
> <snip>
>
>
> Do you have a 'console' device file set up in your NFS rootfilesystem?
>
>
no, I don't think so. When I'm back in office Monday morning I'll looking
into detail for you.
But the error seems to be some low-level network issue: sometimes kernel can
mount NFS, sometimes not and so on.
Best Regards,
Ingo
--
View this message in context: http://www.nabble.com/-Virtex-4-PPC--Problem-mountin-rootfs-via-NFS-tp15355858p15361890.html
Sent from the linuxppc-embedded mailing list archive at Nabble.com.
^ permalink raw reply
* [PATCH 5/5] Tsi108_eth: Add ethtool support
From: Alexandre Bounine @ 2008-02-08 19:17 UTC (permalink / raw)
To: jgarzik, netdev; +Cc: linuxppc-dev
Add ethtool support to tsi108_eth network driver.
=20=20=20
Signed-off-by: Alexandre Bounine <alexandreb@tundra.com>
---
diff -pNur linux-2.6.24/drivers/net/tsi108_eth.c
linux-2.6.24-fix/drivers/net/tsi108_eth.c
--- linux-2.6.24/drivers/net/tsi108_eth.c 2008-02-06
17:10:53.000000000 -0500
+++ linux-2.6.24-fix/drivers/net/tsi108_eth.c 2008-02-06
18:09:43.000000000 -0500
@@ -36,6 +36,7 @@
#include <linux/net.h>
#include <linux/netdevice.h>
#include <linux/etherdevice.h>
+#include <linux/ethtool.h>
#include <linux/skbuff.h>
#include <linux/slab.h>
#include <linux/spinlock.h>
@@ -1519,12 +1520,46 @@ static void tsi108_init_mac(struct net_d
TSI_WRITE(TSI108_EC_INTMASK, ~0);
}
=20
+static int tsi108_get_settings(struct net_device *dev, struct
ethtool_cmd *cmd)
+{
+ struct tsi108_prv_data *data =3D netdev_priv(dev);
+ unsigned long flags;
+ int rc;
+=09
+ spin_lock_irqsave(&data->txlock, flags);
+ rc =3D mii_ethtool_gset(&data->mii_if, cmd);
+ spin_unlock_irqrestore(&data->txlock, flags);
+
+ return rc;
+}
+
+static int tsi108_set_settings(struct net_device *dev, struct
ethtool_cmd *cmd)
+{
+ struct tsi108_prv_data *data =3D netdev_priv(dev);
+ unsigned long flags;
+ int rc;
+
+ spin_lock_irqsave(&data->txlock, flags);
+ rc =3D mii_ethtool_sset(&data->mii_if, cmd);
+ spin_unlock_irqrestore(&data->txlock, flags);
+=09
+ return rc;
+}
+
static int tsi108_do_ioctl(struct net_device *dev, struct ifreq *rq,
int cmd)
{
struct tsi108_prv_data *data =3D netdev_priv(dev);
+ if (!netif_running(dev))
+ return -EINVAL;
return generic_mii_ioctl(&data->mii_if, if_mii(rq), cmd, NULL);
}
=20
+static const struct ethtool_ops tsi108_ethtool_ops =3D {
+ .get_link =3D ethtool_op_get_link,
+ .get_settings =3D tsi108_get_settings,
+ .set_settings =3D tsi108_set_settings,
+};
+
static int
tsi108_init_one(struct platform_device *pdev)
{
@@ -1589,6 +1624,7 @@ tsi108_init_one(struct platform_device *
dev->get_stats =3D tsi108_get_stats;
netif_napi_add(dev, &data->napi, tsi108_poll, 64);
dev->do_ioctl =3D tsi108_do_ioctl;
+ dev->ethtool_ops =3D &tsi108_ethtool_ops;
=20
/* Apparently, the Linux networking code won't use
scatter-gather
* if the hardware doesn't do checksums. However, it's faster
---=0D
=0D
Important Notice: This message is intended for the use of the individual to=
whom it is addressed and may contain information which is privileged, conf=
idential and/or exempt from disclosure under applicable law. If the reader =
of this message is not the intended recipient, or is not the employee or ag=
ent responsible for delivering the message to the intended recipient, you a=
re hereby notified that any dissemination, distribution, or copying of this=
communication is strictly prohibited. If you have received this communicat=
ion in error, please notify the sender immediately by telephone or return e=
-mail and delete the original message from your systems. Thank you. =0D
^ permalink raw reply
* [PATCH 4/5] Tsi108_eth: fix link recovery after disconnect
From: Alexandre Bounine @ 2008-02-08 19:17 UTC (permalink / raw)
To: jgarzik, netdev; +Cc: linuxppc-dev
Bug fix for tsi108_eth network driver.
This patch fixes a problem with link recovery after connection was lost.
=20=20=20
Signed-off-by: Alexandre Bounine <alexandreb@tundra.com>
---
diff -pNur linux-2.6.24/drivers/net/tsi108_eth.c
linux-2.6.24-fix/drivers/net/tsi108_eth.c
--- linux-2.6.24/drivers/net/tsi108_eth.c 2008-02-06
16:16:00.000000000 -0500
+++ linux-2.6.24-fix/drivers/net/tsi108_eth.c 2008-02-06
16:57:41.000000000 -0500
@@ -338,22 +338,21 @@ static void tsi108_check_phy(struct net_
=20
TSI_WRITE(TSI108_MAC_CFG2, mac_cfg2_reg);
TSI_WRITE(TSI108_EC_PORTCTRL, portctrl_reg);
+ }
=20
- if (data->link_up =3D=3D 0) {
- /* The manual says it can take 3-4 usecs
for the speed change
- * to take effect.
- */
- udelay(5);
-
- spin_lock(&data->txlock);
- if (is_valid_ether_addr(dev->dev_addr)
&& data->txfree)
- netif_wake_queue(dev);
+ if (data->link_up =3D=3D 0) {
+ /* The manual says it can take 3-4 usecs for the
speed change
+ * to take effect.
+ */
+ udelay(5);
=20
- data->link_up =3D 1;
- spin_unlock(&data->txlock);
- }
- }
+ spin_lock(&data->txlock);
+ if (is_valid_ether_addr(dev->dev_addr) &&
data->txfree)
+ netif_wake_queue(dev);
=20
+ data->link_up =3D 1;
+ spin_unlock(&data->txlock);
+ }
} else {
if (data->link_up =3D=3D 1) {
netif_stop_queue(dev);
@@ -1267,12 +1266,11 @@ static void tsi108_init_phy(struct net_d
* PHY_STAT register before the link up status bit is set.
*/
=20
- data->link_up =3D 1;
+ data->link_up =3D 0;
=20
while (!((phyval =3D tsi108_read_mii(data, MII_BMSR)) &
BMSR_LSTATUS)) {
if (i++ > (MII_READ_DELAY / 10)) {
- data->link_up =3D 0;
break;
}
spin_unlock_irqrestore(&phy_lock, flags);
---=0D
=0D
Important Notice: This message is intended for the use of the individual to=
whom it is addressed and may contain information which is privileged, conf=
idential and/or exempt from disclosure under applicable law. If the reader =
of this message is not the intended recipient, or is not the employee or ag=
ent responsible for delivering the message to the intended recipient, you a=
re hereby notified that any dissemination, distribution, or copying of this=
communication is strictly prohibited. If you have received this communicat=
ion in error, please notify the sender immediately by telephone or return e=
-mail and delete the original message from your systems. Thank you. =0D
^ permalink raw reply
* [PATCH 2/5] Tsi108_eth: fix detection of 1000Mb mode
From: Alexandre Bounine @ 2008-02-08 19:17 UTC (permalink / raw)
To: jgarzik, netdev; +Cc: linuxppc-dev
Bug fix for tsi108_eth network driver.
This patch fixes a problem with detection of 1000Mb speed.=20
=20=20=20
Signed-off-by: Alexandre Bounine <alexandreb@tundra.com>
---
diff -pNur linux-2.6.24/drivers/net/tsi108_eth.c
linux-2.6.24-fix/drivers/net/tsi108_eth.c
--- linux-2.6.24/drivers/net/tsi108_eth.c 2008-02-06
15:09:19.000000000 -0500
+++ linux-2.6.24-fix/drivers/net/tsi108_eth.c 2008-02-06
15:34:12.000000000 -0500
@@ -1287,6 +1287,7 @@ static void tsi108_init_phy(struct net_d
spin_lock_irqsave(&phy_lock, flags);
}
=20
+ data->mii_if.supports_gmii =3D
mii_check_gmii_support(&data->mii_if);
printk(KERN_DEBUG "PHY_STAT reg contains %08x\n", phyval);
data->phy_ok =3D 1;
data->init_media =3D 1;
@@ -1584,7 +1585,6 @@ tsi108_init_one(struct platform_device *
data->mii_if.phy_id =3D einfo->phy;
data->mii_if.phy_id_mask =3D 0x1f;
data->mii_if.reg_num_mask =3D 0x1f;
- data->mii_if.supports_gmii =3D
mii_check_gmii_support(&data->mii_if);
=20
data->phy =3D einfo->phy;
data->phy_type =3D einfo->phy_type;
---=0D
=0D
Important Notice: This message is intended for the use of the individual to=
whom it is addressed and may contain information which is privileged, conf=
idential and/or exempt from disclosure under applicable law. If the reader =
of this message is not the intended recipient, or is not the employee or ag=
ent responsible for delivering the message to the intended recipient, you a=
re hereby notified that any dissemination, distribution, or copying of this=
communication is strictly prohibited. If you have received this communicat=
ion in error, please notify the sender immediately by telephone or return e=
-mail and delete the original message from your systems. Thank you. =0D
^ permalink raw reply
* [PATCH 0/5] Tsi108_eth: set of driver fix-ups
From: Alexandre Bounine @ 2008-02-08 19:16 UTC (permalink / raw)
To: jgarzik, netdev; +Cc: linuxppc-dev
This is set of small fixes for Tsi108 Ethernet driver.
Based on kernel version 2.6.24=20
---=0D
=0D
Important Notice: This message is intended for the use of the individual to=
whom it is addressed and may contain information which is privileged, conf=
idential and/or exempt from disclosure under applicable law. If the reader =
of this message is not the intended recipient, or is not the employee or ag=
ent responsible for delivering the message to the intended recipient, you a=
re hereby notified that any dissemination, distribution, or copying of this=
communication is strictly prohibited. If you have received this communicat=
ion in error, please notify the sender immediately by telephone or return e=
-mail and delete the original message from your systems. Thank you. =0D
^ permalink raw reply
* [PATCH 1/5] Tsi108_eth: add missing linking to driver data
From: Alexandre Bounine @ 2008-02-08 19:16 UTC (permalink / raw)
To: jgarzik, netdev; +Cc: linuxppc-dev
Bug fix for tsi108_eth network driver.
This patch adds missing linking to driver data.=20
=20=20=20
Signed-off-by: Alexandre Bounine <alexandreb@tundra.com>
---
diff -pNur linux-2.6.24/drivers/net/tsi108_eth.c
linux-2.6.24-fix/drivers/net/tsi108_eth.c
--- linux-2.6.24/drivers/net/tsi108_eth.c 2008-01-24
17:58:37.000000000 -0500
+++ linux-2.6.24-fix/drivers/net/tsi108_eth.c 2008-02-06
14:30:04.000000000 -0500
@@ -1629,6 +1629,7 @@ tsi108_init_one(struct platform_device *
goto register_fail;
}
=20
+ platform_set_drvdata(pdev, dev);
printk(KERN_INFO "%s: Tsi108 Gigabit Ethernet, MAC: %s\n",
dev->name, print_mac(mac, dev->dev_addr));
#ifdef DEBUG
---=0D
=0D
Important Notice: This message is intended for the use of the individual to=
whom it is addressed and may contain information which is privileged, conf=
idential and/or exempt from disclosure under applicable law. If the reader =
of this message is not the intended recipient, or is not the employee or ag=
ent responsible for delivering the message to the intended recipient, you a=
re hereby notified that any dissemination, distribution, or copying of this=
communication is strictly prohibited. If you have received this communicat=
ion in error, please notify the sender immediately by telephone or return e=
-mail and delete the original message from your systems. Thank you. =0D
^ permalink raw reply
* [PATCH 3/5] Tsi108_eth: remove not needed code
From: Alexandre Bounine @ 2008-02-08 19:17 UTC (permalink / raw)
To: jgarzik, netdev; +Cc: linuxppc-dev
Code clean-up for tsi108_eth network driver.
This patch removes not needed dummy read and the corresponding comment.
The PHY logic requires two reads from the status register to get=20
current link status. This is done correctly inside mii_check_media().=20=20
=20=20=20
Signed-off-by: Alexandre Bounine <alexandreb@tundra.com>
---
diff -pNur linux-2.6.24/drivers/net/tsi108_eth.c
linux-2.6.24-fix/drivers/net/tsi108_eth.c
--- linux-2.6.24/drivers/net/tsi108_eth.c 2008-02-06
15:47:35.000000000 -0500
+++ linux-2.6.24-fix/drivers/net/tsi108_eth.c 2008-02-06
15:54:14.000000000 -0500
@@ -297,18 +297,11 @@ static void tsi108_check_phy(struct net_
u32 speed;
unsigned long flags;
=20
- /* Do a dummy read, as for some reason the first read
- * after a link becomes up returns link down, even if
- * it's been a while since the link came up.
- */
-
spin_lock_irqsave(&phy_lock, flags);
=20
if (!data->phy_ok)
goto out;
=20
- tsi108_read_mii(data, MII_BMSR);
-
duplex =3D mii_check_media(&data->mii_if, netif_msg_link(data),
data->init_media);
data->init_media =3D 0;
=20
---=0D
=0D
Important Notice: This message is intended for the use of the individual to=
whom it is addressed and may contain information which is privileged, conf=
idential and/or exempt from disclosure under applicable law. If the reader =
of this message is not the intended recipient, or is not the employee or ag=
ent responsible for delivering the message to the intended recipient, you a=
re hereby notified that any dissemination, distribution, or copying of this=
communication is strictly prohibited. If you have received this communicat=
ion in error, please notify the sender immediately by telephone or return e=
-mail and delete the original message from your systems. Thank you. =0D
^ permalink raw reply
* [PATCH] powerpc: fix DEBUG_PREEMPT warning when warning
From: Hugh Dickins @ 2008-02-08 18:25 UTC (permalink / raw)
To: Paul Mackerras; +Cc: linuxppc-dev, linux-kernel
The powerpc show_regs prints CPU using smp_processor_id: change that to
raw_smp_processor_id, so that when it's showing a WARN_ON backtrace without
preemption disabled, DEBUG_PREEMPT doesn't mess up that warning with its own.
Signed-off-by: Hugh Dickins <hugh@veritas.com>
---
powerpc/kernel/process.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- 2.6.24-git18/arch/powerpc/kernel/process.c 2008-01-24 22:58:37.000000000 +0000
+++ linux/arch/powerpc/kernel/process.c 2008-02-08 12:01:31.000000000 +0000
@@ -462,7 +462,7 @@ void show_regs(struct pt_regs * regs)
current, task_pid_nr(current), current->comm, task_thread_info(current));
#ifdef CONFIG_SMP
- printk(" CPU: %d", smp_processor_id());
+ printk(" CPU: %d", raw_smp_processor_id());
#endif /* CONFIG_SMP */
for (i = 0; i < 32; i++) {
^ permalink raw reply
* Re: APU FPU in Virtex ppc405
From: Grant Likely @ 2008-02-08 19:32 UTC (permalink / raw)
To: A. Nolson; +Cc: linuxppc-embedded
In-Reply-To: <47ACA4BB.6010903@gmail.com>
On Feb 8, 2008 11:51 AM, A. Nolson <alohanono@gmail.com> wrote:
> Hi,
>
> I have just heard that Xilinx has freed the FPU module for the PPC
> architecture in EDK9.2i. WIll I be able to make it work with my
> Secretlab Linux 2.6.24rc3? Will the eldk toolchain for PPC_4xxfp work?
> Will it be just a matter of integrating it with the XPS BSP?I make an
> extensive use of floating point in my applications and this will be
> really useful.
It's been 2 years since I last played with the FPU core. At the time
it wasn't a complete FPU so the eldk 4xxfp toolchain would not work.
I had to build my own. I don't know if the new core is a complete
implementation.
Cheers,
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
^ permalink raw reply
* Re: Leds
From: Grant Likely @ 2008-02-08 19:43 UTC (permalink / raw)
To: Simon Kagstrom; +Cc: Marco Stornelli, LinuxPPC-Embedded
In-Reply-To: <20080208112002.42a15c0d@seasc0532.dyn.rnd.as.sw.ericsson.se>
On Feb 8, 2008 3:20 AM, Simon Kagstrom <simon.kagstrom@ericsson.com> wrote:
> Hi Marco,
>
> On Fri, 08 Feb 2008 11:02:16 +0100
> Marco Stornelli <marco.stornelli@coritel.it> wrote:
>
> > how can specify a led device in a dts file? These leds are connected
> > with gpio to the microprocessor. I can't find anything like a led node
> > in the dts files of the other boards. Have you got any suggestions?
>
> Although I'm not sure if it's the "standard" way, we just added a
> "home-made" node like this:
>
> resetLED@c0018000 {
> device_type = "leds";
> compatible = "reset-leds";
> reg = <c0018000 00008000>;
> };
I've been thinking about this a bit over the last couple of months,
and I think that there is a better way. Since many LEDs are simply
hooked up to GPIO blocks and we're moving towards a common GPIO api
(and device tree binding), I think it would be better to use two
nodes; a node for the gpio block and a node for all the LEDs in the
system. For example (the GPIO dt bindings may differ from my example
here, but you get the gist):
GPIO0: gpio-controller@1418 {
#gpio-cells = <2>;
compatible = "fsl,qe-pario-bank";
reg = <0x1418 0x18>;
gpio-controller;
};
GPIO1: gpio-controller@1460 {
#gpio-cells = <2>;
compatible = "fsl,qe-pario-bank";
reg = <0x1460 0x18>;
gpio-controller;
};
leds@0 {
compatible = "gpio-leds";
led-labels = "led1", "led2", "led3", "led4";
gpios = <&GPIO0 2 0 /* LED1 */
&GPIO0 3 0 /* LED2 */
&GPIO1 8 0 /* LED3 */
&GPIO1 9 0 /* LED4 */
>;
/* More properties are probably needed here to correctly setup
the output levels */
};
Doing it this way means the GPIO block will be usable for more than
just LEDs. Plus once the 'gpio-leds' driver is written leds can be
hooked up almost trivially on new boards.
Cheers,
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
^ permalink raw reply
* [patch 0/6] PS3 fixups for 2.6.25
From: Geoff Levand @ 2008-02-08 22:52 UTC (permalink / raw)
To: paulus; +Cc: linuxppc-dev
Paul,
Here are a few PS3 fixups to apply for 2.6.25.
[patch 1/6] PS3: Fix lpm set bookmark
[patch 2/6] PS3: Fix lpm read pm interval
[patch 3/6] PS3: Fix bootwrapper hang bug
[patch 4/6] PS3: Use system reboot on restart
[patch 5/6] PS3: Sys-manager code cleanup
[patch 6/6] PS3: Update sys-manager button events
-Geoff
--
^ permalink raw reply
* [patch 1/6] PS3: Fix lpm set bookmark
From: Geoff Levand @ 2008-02-08 22:52 UTC (permalink / raw)
To: paulus; +Cc: linuxppc-dev, Takashi Yamamoto
In-Reply-To: <20080208224723.029462363@am.sony.com>
From: Takashi Yamamoto <TakashiA.Yamamoto@jp.sony.com>
Fix the ps3_set_bookmark() routine of the PS3 logical performance
monitor driver.
To properly set a performance monitor bookmark the Cell processor
requires no instruction branches near the setting of the bookmark
SPR. Testing showed that the use of the db10cyc instruction did
not work correctly. This change replaces the db10cyc instruction
with 10 nop instructions.
Signed-off-by: Takashi Yamamoto <TakashiA.Yamamoto@jp.sony.com>
Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
---
drivers/ps3/ps3-lpm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/ps3/ps3-lpm.c
+++ b/drivers/ps3/ps3-lpm.c
@@ -181,9 +181,9 @@ void ps3_set_bookmark(u64 bookmark)
* includes cycles before the call.
*/
- asm volatile("or 29, 29, 29;"); /* db10cyc */
+ asm volatile("nop;nop;nop;nop;nop;nop;nop;nop;nop;");
mtspr(SPRN_BKMK, bookmark);
- asm volatile("or 29, 29, 29;"); /* db10cyc */
+ asm volatile("nop;nop;nop;nop;nop;nop;nop;nop;nop;");
}
EXPORT_SYMBOL_GPL(ps3_set_bookmark);
--
^ permalink raw reply
* [patch 2/6] PS3: Fix lpm read pm interval
From: Geoff Levand @ 2008-02-08 22:52 UTC (permalink / raw)
To: paulus; +Cc: linuxppc-dev, Takashi Yamamoto
In-Reply-To: <20080208224723.029462363@am.sony.com>
From: Takashi Yamamoto <TakashiA.Yamamoto@jp.sony.com>
ps3_read_pm (pm_interval) should return an actual HW register value
because the pm_interval register is a counter register.
This patch removes the shadow pm_interval register.
Signed-off-by: Takashi Yamamoto <TakashiA.Yamamoto@jp.sony.com>
Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
---
drivers/ps3/ps3-lpm.c | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)
--- a/drivers/ps3/ps3-lpm.c
+++ b/drivers/ps3/ps3-lpm.c
@@ -76,7 +76,6 @@
*
* @pm_control: Shadow of the processor's pm_control register.
* @pm_start_stop: Shadow of the processor's pm_start_stop register.
- * @pm_interval: Shadow of the processor's pm_interval register.
* @group_control: Shadow of the processor's group_control register.
* @debug_bus_control: Shadow of the processor's debug_bus_control register.
*
@@ -91,7 +90,6 @@
struct ps3_lpm_shadow_regs {
u64 pm_control;
u64 pm_start_stop;
- u64 pm_interval;
u64 group_control;
u64 debug_bus_control;
};
@@ -408,7 +406,14 @@ u32 ps3_read_pm(u32 cpu, enum pm_reg_nam
case pm_start_stop:
return lpm_priv->shadow.pm_start_stop;
case pm_interval:
- return lpm_priv->shadow.pm_interval;
+ result = lv1_set_lpm_interval(lpm_priv->lpm_id, 0, 0, &val);
+ if (result) {
+ val = 0;
+ dev_dbg(sbd_core(), "%s:%u: lv1 set_inteval failed: "
+ "reg %u, %s\n", __func__, __LINE__, reg,
+ ps3_result(result));
+ }
+ return (u32)val;
case group_control:
return lpm_priv->shadow.group_control;
case debug_bus_control:
@@ -475,10 +480,8 @@ void ps3_write_pm(u32 cpu, enum pm_reg_n
lpm_priv->shadow.pm_control = val;
break;
case pm_interval:
- if (val != lpm_priv->shadow.pm_interval)
- result = lv1_set_lpm_interval(lpm_priv->lpm_id, val,
- PS3_WRITE_PM_MASK, &dummy);
- lpm_priv->shadow.pm_interval = val;
+ result = lv1_set_lpm_interval(lpm_priv->lpm_id, val,
+ PS3_WRITE_PM_MASK, &dummy);
break;
case pm_start_stop:
if (val != lpm_priv->shadow.pm_start_stop)
@@ -1140,7 +1143,6 @@ int ps3_lpm_open(enum ps3_lpm_tb_type tb
lpm_priv->shadow.pm_control = PS3_LPM_SHADOW_REG_INIT;
lpm_priv->shadow.pm_start_stop = PS3_LPM_SHADOW_REG_INIT;
- lpm_priv->shadow.pm_interval = PS3_LPM_SHADOW_REG_INIT;
lpm_priv->shadow.group_control = PS3_LPM_SHADOW_REG_INIT;
lpm_priv->shadow.debug_bus_control = PS3_LPM_SHADOW_REG_INIT;
--
^ permalink raw reply
* [patch 3/6] PS3: Fix bootwrapper hang bug
From: Geoff Levand @ 2008-02-08 22:52 UTC (permalink / raw)
To: paulus; +Cc: linuxppc-dev
In-Reply-To: <20080208224723.029462363@am.sony.com>
Fix a bug in the lv1_get_repository_node_value() routine of the PS3
bootwrapper. Changes in the PS3 system firmware 2.20 cause this bug
to hang the system when branching from the bootwrapper to the kernel
_start.
Since the video system has not yet been enabled at the time
the bug is hit, the system hangs with a blank screen. Earlier
firmwares don't cause such a catastrophic failure, and so this
bug went undetected.
Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
---
arch/powerpc/boot/ps3-hvcall.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/powerpc/boot/ps3-hvcall.S
+++ b/arch/powerpc/boot/ps3-hvcall.S
@@ -145,7 +145,7 @@
.macro STORE_REGS_5_2
lwz r11, 16(r1)
std r4, 0(r11)
- lwz r11, 24(r1)
+ lwz r11, 20(r1)
std r5, 0(r11)
.endm
--
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox