* Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier
From: Dave Hansen @ 2008-02-14 17:38 UTC (permalink / raw)
To: Badari Pulavarty
Cc: Thomas Q Klein, ossthema, Jan-Bernd Themann, Greg KH,
linux-kernel, apw, linuxppc-dev, Christoph Raisch, netdev, tklein
In-Reply-To: <1203010575.12312.6.camel@dyn9047017100.beaverton.ibm.com>
On Thu, 2008-02-14 at 09:36 -0800, Badari Pulavarty wrote:
>
> I am not sure what you are trying to do with walk_memory_resource().
> The
> behavior is different on ppc64. Hotplug memory usage assumes that all
> the memory resources (all system memory, not just IOMEM) are
> represented
> in /proc/iomem. Its the case with i386 and ia64. But on ppc64 is
> contains ONLY iomem related. Paulus didn't want to export all the
> system
> memory into /proc/iomem on ppc64. So I had to workaround by providing
> arch-specific walk_memory_resource() function for ppc64.
OK, let's use that one.
-- Dave
^ permalink raw reply
* Re: /proc/bus/pci and domains
From: Jesse Barnes @ 2008-02-14 18:39 UTC (permalink / raw)
To: linux-pci; +Cc: Greg KH, paulus, anton, Martin Mares, linuxppc-dev
In-Reply-To: <mj+md-20080214.093558.3352.nikam@ucw.cz>
On Thursday, February 14, 2008 1:40 am Martin Mares wrote:
> Hi Greg!
>
> > I have no idea, it sounds like a PPC specific thing, not anything the
> > PCI core does, right? So I'll add the ppc list to the cc: and ask if
> > anyone there has any ideas?
>
> Unfortunately, this is not PPC specific at all -- proc_attach_device()
> calls pci_proc_domain(bus), which is an arch-specific hook turning on
> the weird behavior I described. This hook can return non-zero even on
> x86 if there are buses outside domain 0.
>
> I think that the hook itself is correct, it only should trigger more
> consistent behavior of the generic code :)
>
> Would it be acceptable for the PPC folks to modify the code to add
> domain numbers to the device numbers in /proc/bus/pci/devices in the
> same format as the bus directories already have?
>
> If so, I will cook up a patch.
I've run into this too, on machines with many domains. It's unfortunate that
there's no way to preserve compatibility, but I agree that the brokenness may
as well be consistent.
Jesse
^ permalink raw reply
* RE: [PATCH] [POWERPC] Enable correct operation of serial ports withnonzero regshift.
From: Stephen Neuendorffer @ 2008-02-14 18:55 UTC (permalink / raw)
To: Pavel Kiryukhin, linuxppc-dev
In-Reply-To: <47B35ED8.7020404@ru.mvista.com>
> --- a/arch/powerpc/kernel/legacy_serial.c
> +++ b/arch/powerpc/kernel/legacy_serial.c
> + /* get regshift if present*/
> + regshift =3D get_property(np, "reg-shift", NULL);
of_get_property, presumably?
--- a/drivers/serial/of_serial.c
+++ b/drivers/serial/of_serial.c
> + regshift =3D get_property(np, "reg-shift", NULL);
ditto...
Otherwise,=20
Acked-by: Stephen Neuendorffer <stephen.neuendorffer@xilinx.com>
Also, can you post a patch to the Xilinx portion of
booting-without-of.txt that has the device tree entries necessary to get
the uart to work? (Since I happened to be tracking down what I assume
is the same issue when you posted the patch!)
Steve
^ permalink raw reply
* High resolution timer support in 2.6.24+ for MPC831x?
From: Leon Woestenberg @ 2008-02-14 20:26 UTC (permalink / raw)
To: linuxppc-embedded
Hello all,
although I can enable high res timers in 2.6.24, the item note says it
does nothing if the platform does not have support for it.
My platform is a MPC8313E-RDB, and I suspect no high res clock source
implementation exists for it in 2.6.24, because
clock_getres(CLOCK_REALTIME,) gives me 1/HZ.
Is this correct and/or is anything in the works?
Regards,
--
Leon
^ permalink raw reply
* Re: [PATCH 05/11] ppc/mpc8xx: remove ppc_ide_md hooks
From: Vitaly Bordug @ 2008-02-14 20:46 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: linux-ide, linux-kernel, Bartlomiej Zolnierkiewicz, linuxppc-dev
In-Reply-To: <20080214003656.12879.21968.sendpatchset@localhost.localdomain>
On Thu, 14 Feb 2008 01:36:56 +0100
Bartlomiej Zolnierkiewicz wrote:
> * Initialize IDE ports in mpc8xx_ide_probe().
>
> * Remove m8xx_ide_init() and ppc_ide_md hooks - no need for them
> (IDE mpc8xx host driver takes care of all this setup).
>
> * Remove needless 'if (irq)' and 'if (data_port >= MAX_HWIFS)' checks
> from m8xx_ide_init_hwif_ports().
>
> * Remove 'ctrl_port' and 'irq' arguments from
> m8xx_ide_init_hwif_ports().
>
> * Rename m8xx_ide_init_hwif_ports() to m8xx_ide_init_ports().
>
> * Add __init tag to m8xx_ide_init_ports().
>
> This patch fixes hwif->irq always being overriden to 0 (==
> auto-probe, is this even working on PPC?) because of
> ide_init_default_irq() call in ide.c.
>
> There should be no other functional changes.
>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Vitaly Bordug <vitb@kernel.crashing.org>
> ---
> arch/ppc/syslib/m8xx_setup.c | 6 ---
> drivers/ide/ppc/mpc8xx.c | 86
> +++++++++++-------------------------------- 2 files changed, 22
> insertions(+), 70 deletions(-)
>
> Index: b/arch/ppc/syslib/m8xx_setup.c
> ===================================================================
> --- a/arch/ppc/syslib/m8xx_setup.c
> +++ b/arch/ppc/syslib/m8xx_setup.c
> @@ -87,8 +87,6 @@ void m8xx_calibrate_decr(void);
>
> unsigned char __res[sizeof(bd_t)];
>
> -extern void m8xx_ide_init(void);
> -
> extern unsigned long find_available_memory(void);
> extern void m8xx_cpm_reset(void);
> extern void m8xx_wdt_handler_install(bd_t *bp);
> @@ -474,8 +472,4 @@ platform_init(unsigned long r3, unsigned
>
> ppc_md.find_end_of_memory = m8xx_find_end_of_memory;
> ppc_md.setup_io_mappings = m8xx_map_io;
> -
> -#if defined(CONFIG_BLK_DEV_MPC8xx_IDE)
> - m8xx_ide_init();
> -#endif
> }
> Index: b/drivers/ide/ppc/mpc8xx.c
> ===================================================================
> --- a/drivers/ide/ppc/mpc8xx.c
> +++ b/drivers/ide/ppc/mpc8xx.c
> @@ -99,32 +99,6 @@ static int _slot_ = -1; /*
> will be rea /* Make clock cycles and always round up */
> #define PCMCIA_MK_CLKS( t, T ) (( (t) * ((T)/1000000) + 999U ) /
> 1000U )
> -
> -
> -/*
> - * IDE stuff.
> - */
> -static int
> -m8xx_ide_default_irq(unsigned long base)
> -{
> -#ifdef CONFIG_BLK_DEV_MPC8xx_IDE
> - if (base >= MAX_HWIFS)
> - return 0;
> -
> - printk("[%d] m8xx_ide_default_irq
> %d\n",__LINE__,ioport_dsc[base].irq);
> -
> - return (ioport_dsc[base].irq);
> -#else
> - return 9;
> -#endif
> -}
> -
> -static unsigned long
> -m8xx_ide_default_io_base(int index)
> -{
> - return index;
> -}
> -
> #define M8XX_PCMCIA_CD2(slot) (0x10000000 >> (slot << 4))
> #define M8XX_PCMCIA_CD1(slot) (0x08000000 >> (slot << 4))
>
> @@ -149,12 +123,11 @@ static int pcmcia_schlvl = PCMCIA_SCHLVL
> */
>
> /*
> - * m8xx_ide_init_hwif_ports for a direct IDE interface _using_
> + * m8xx_ide_init_ports() for a direct IDE interface _using_
> + * MPC8xx's internal PCMCIA interface
> */
> #if defined(CONFIG_IDE_8xx_PCCARD) || defined(CONFIG_IDE_8xx_DIRECT)
> -static void
> -m8xx_ide_init_hwif_ports(hw_regs_t *hw, unsigned long data_port,
> - unsigned long ctrl_port, int *irq)
> +static void __init m8xx_ide_init_ports(hw_regs_t *hw, unsigned long
> data_port) {
> unsigned long *p = hw->io_ports;
> int i;
> @@ -173,8 +146,6 @@ m8xx_ide_init_hwif_ports(hw_regs_t *hw,
> unsigned long base;
>
> *p = 0;
> - if (irq)
> - *irq = 0;
>
> pcmp = (pcmconf8xx_t *)(&(((immap_t
> *)IMAP_ADDR)->im_pcmcia));
> @@ -248,9 +219,6 @@ m8xx_ide_init_hwif_ports(hw_regs_t *hw,
> }
> }
>
> - if (data_port >= MAX_HWIFS)
> - return;
> -
> if (_slot_ == -1) {
> printk ("PCMCIA slot has not been defined! Using A
> as default\n"); _slot_ = 0;
> @@ -292,11 +260,13 @@ m8xx_ide_init_hwif_ports(hw_regs_t *hw,
> *p++ = base + ioport_dsc[data_port].reg_off[i];
> }
>
> - if (irq) {
> + hw->irq = ioport_dsc[data_port].irq;
> + hw->ack_intr = (ide_ack_intr_t *)ide_interrupt_ack;
> +
> #ifdef CONFIG_IDE_8xx_PCCARD
> + {
> unsigned int reg;
>
> - *irq = ioport_dsc[data_port].irq;
> if (_slot_)
> pgcrx = &((immap_t *)
> IMAP_ADDR)->im_pcmcia.pcmc_pgcrb; else
> @@ -306,14 +276,11 @@ m8xx_ide_init_hwif_ports(hw_regs_t *hw,
> reg |= mk_int_int_mask (pcmcia_schlvl) << 24;
> reg |= mk_int_int_mask (pcmcia_schlvl) << 16;
> *pgcrx = reg;
> -#else /* direct connected IDE drive, i.e. external IRQ, not
> the PCMCIA irq */
> - *irq = ioport_dsc[data_port].irq;
> -#endif /* CONFIG_IDE_8xx_PCCARD */
> }
> +#endif /* CONFIG_IDE_8xx_PCCARD */
>
> ide_hwifs[data_port].pio_mask = ATA_PIO4;
> ide_hwifs[data_port].set_pio_mode = m8xx_ide_set_pio_mode;
> - ide_hwifs[data_port].ack_intr = (ide_ack_intr_t
> *)ide_interrupt_ack;
> /* Enable Harddisk Interrupt,
> * and make it edge sensitive
> @@ -329,16 +296,15 @@ m8xx_ide_init_hwif_ports(hw_regs_t *hw,
> /* Enable falling edge irq */
> pcmp->pcmc_per = 0x100000 >> (16 * _slot_);
> #endif /* CONFIG_IDE_8xx_PCCARD */
> -} /* m8xx_ide_init_hwif_ports() using 8xx internal PCMCIA
> interface */ +}
> #endif /* CONFIG_IDE_8xx_PCCARD || CONFIG_IDE_8xx_DIRECT */
>
> /*
> - * m8xx_ide_init_hwif_ports for a direct IDE interface _not_ using
> + * m8xx_ide_init_ports() for a direct IDE interface _not_ using
> * MPC8xx's internal PCMCIA interface
> */
> #if defined(CONFIG_IDE_EXT_DIRECT)
> -void m8xx_ide_init_hwif_ports (hw_regs_t *hw,
> - unsigned long data_port, unsigned long ctrl_port, int *irq)
> +static void __init m8xx_ide_init_ports(hw_regs_t *hw, unsigned long
> data_port) {
> unsigned long *p = hw->io_ports;
> int i;
> @@ -349,8 +315,6 @@ void m8xx_ide_init_hwif_ports (hw_regs_t
> unsigned long base;
>
> *p = 0;
> - if (irq)
> - *irq = 0;
>
> if (!ide_base) {
>
> @@ -372,9 +336,6 @@ void m8xx_ide_init_hwif_ports (hw_regs_t
> #endif
> }
>
> - if (data_port >= MAX_HWIFS)
> - return;
> -
> base = ide_base + ioport_dsc[data_port].base_off;
> #ifdef DEBUG
> printk ("base: %08x + %08x = %08x\n",
> @@ -392,14 +353,12 @@ void m8xx_ide_init_hwif_ports (hw_regs_t
> *p++ = base + ioport_dsc[data_port].reg_off[i];
> }
>
> - if (irq) {
> - /* direct connected IDE drive, i.e. external IRQ */
> - *irq = ioport_dsc[data_port].irq;
> - }
> + /* direct connected IDE drive, i.e. external IRQ */
> + hw->irq = ioport_dsc[data_port].irq;
> + hw->ack_intr = (ide_ack_intr_t *)ide_interrupt_ack;
>
> ide_hwifs[data_port].pio_mask = ATA_PIO4;
> ide_hwifs[data_port].set_pio_mode = m8xx_ide_set_pio_mode;
> - ide_hwifs[data_port].ack_intr = (ide_ack_intr_t
> *)ide_interrupt_ack;
> /* Enable Harddisk Interrupt,
> * and make it edge sensitive
> @@ -407,8 +366,7 @@ void m8xx_ide_init_hwif_ports (hw_regs_t
> /* (11-18) Set edge detect for irq, no wakeup from low power
> mode */ ((immap_t *) IMAP_ADDR)->im_siu_conf.sc_siel |=
> (0x80000000 >> ioport_dsc[data_port].irq);
> -} /* m8xx_ide_init_hwif_ports() for CONFIG_IDE_8xx_DIRECT */
> -
> +}
> #endif /* CONFIG_IDE_8xx_DIRECT */
>
>
> @@ -829,20 +787,20 @@ static int identify (volatile u8 *p)
> return (0); /* don't know */
> }
>
> -void m8xx_ide_init(void)
> -{
> - ppc_ide_md.default_irq = m8xx_ide_default_irq;
> - ppc_ide_md.default_io_base = m8xx_ide_default_io_base;
> - ppc_ide_md.ide_init_hwif = m8xx_ide_init_hwif_ports;
> -}
> -
> static int __init mpc8xx_ide_probe(void)
> {
> + hw_regs_t hw;
> u8 idx[4] = { 0xff, 0xff, 0xff, 0xff };
>
> #ifdef IDE0_BASE_OFFSET
> + memset(&hw, 0, sizeof(hw));
> + m8xx_ide_init_ports(&hw, 0);
> + ide_init_port_hw(&ide_hwifs[0], &hw);
> idx[0] = 0;
> #ifdef IDE1_BASE_OFFSET
> + memset(&hw, 0, sizeof(hw));
> + m8xx_ide_init_ports(&hw, 1);
> + ide_init_port_hw(&ide_hwifs[1], &hw);
> idx[1] = 1;
> #endif
> #endif
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
--
Sincerely, Vitaly
^ permalink raw reply
* Re: High resolution timer support in 2.6.24+ for MPC831x?
From: Scott Wood @ 2008-02-14 20:51 UTC (permalink / raw)
To: Leon Woestenberg; +Cc: linuxppc-embedded
In-Reply-To: <c384c5ea0802141226m630fcc11h60627cde75cb8b0e@mail.gmail.com>
Leon Woestenberg wrote:
> Hello all,
>
> although I can enable high res timers in 2.6.24, the item note says it
> does nothing if the platform does not have support for it.
>
> My platform is a MPC8313E-RDB, and I suspect no high res clock source
> implementation exists for it in 2.6.24, because
> clock_getres(CLOCK_REALTIME,) gives me 1/HZ.
>
> Is this correct and/or is anything in the works?
The timebase/decrementer can be used as a high clock source on virtually
all powerpc chips; I tried clock_getres(CLOCK_REALTIME) on an 8313erdb,
and I got 1 ns. Did you turn on CONFIG_HIGH_RES_TIMERS?
-Scott
^ permalink raw reply
* Re: [PATCH 0/4]: Respun LMB patches.
From: Becky Bruce @ 2008-02-14 20:58 UTC (permalink / raw)
To: David Miller; +Cc: sparclinux, linuxppc-dev, linux-kernel
In-Reply-To: <20080213.170938.34536425.davem@davemloft.net>
On Feb 13, 2008, at 7:09 PM, David Miller wrote:
>
> I've taken into consideration the various feedback, and
> ported the bug fix and other LMB patches posted recently
> in an effort to keep the patch churn by others down wrt.
> my moving of these files.
>
> 1) Use HAVE_LMB as suggested by Sam.
>
> 2) Fix potential build errors wrt. asm/prom.h dependencies.
>
> My algorithm was:
>
> a) If the file only included asm/lmb.h I added an include
> of both linux/lmb.c and asm/prom.h
>
> b) If the file already includes asm/prom.h, I merely
> changed the asm/lmb.h to linux/lmb.h
>
> Header include mimimizations can be done as followon patches.
>
> 3) Integrate Kumar Gala's initial region fix.
>
> 4) Integrate Becky Bruce's large physical addressing change,
> but using u64 instead of phys_addr_t.
>
> It's all at:
>
> master.kernel.org:/pub/scm/linux/kernel/git/davem/lmb-2.6.git
>
> like before.
Thanks for picking up the patches from Kumar and myself and fitting
them into your series - this is much appreciated. FYI, I applied the
entire patch series to my local tree and test-booted both mpc8641 and
mpc8568mds and both build and boot cleanly. I also built pasemi and
ebony, those build cleanly as well.
Cheers,
Becky
^ permalink raw reply
* Re: [PATCH 0/4]: Respun LMB patches.
From: Josh Boyer @ 2008-02-14 21:24 UTC (permalink / raw)
To: Becky Bruce; +Cc: sparclinux, linuxppc-dev, David Miller, linux-kernel
In-Reply-To: <38133B3C-75A2-4465-9484-7BF8E7E85D1D@freescale.com>
On Thu, 14 Feb 2008 14:58:22 -0600
Becky Bruce <becky.bruce@freescale.com> wrote:
>
> On Feb 13, 2008, at 7:09 PM, David Miller wrote:
>
> >
> > I've taken into consideration the various feedback, and
> > ported the bug fix and other LMB patches posted recently
> > in an effort to keep the patch churn by others down wrt.
> > my moving of these files.
> >
> > 1) Use HAVE_LMB as suggested by Sam.
> >
> > 2) Fix potential build errors wrt. asm/prom.h dependencies.
> >
> > My algorithm was:
> >
> > a) If the file only included asm/lmb.h I added an include
> > of both linux/lmb.c and asm/prom.h
> >
> > b) If the file already includes asm/prom.h, I merely
> > changed the asm/lmb.h to linux/lmb.h
> >
> > Header include mimimizations can be done as followon patches.
> >
> > 3) Integrate Kumar Gala's initial region fix.
> >
> > 4) Integrate Becky Bruce's large physical addressing change,
> > but using u64 instead of phys_addr_t.
> >
> > It's all at:
> >
> > master.kernel.org:/pub/scm/linux/kernel/git/davem/lmb-2.6.git
> >
> > like before.
>
>
> Thanks for picking up the patches from Kumar and myself and fitting
> them into your series - this is much appreciated. FYI, I applied the
> entire patch series to my local tree and test-booted both mpc8641 and
> mpc8568mds and both build and boot cleanly. I also built pasemi and
> ebony, those build cleanly as well.
I plan on actually testing this on Ebony, Walnut, and Bamboo either
later tonight or tomorrow. I don't expect many issues.
Dave, those above boards would cover the build of PowerPC 4xx CPU cores.
Just an FYI.
josh
^ permalink raw reply
* Re: /proc/bus/pci and domains
From: David Miller @ 2008-02-14 21:43 UTC (permalink / raw)
To: mj; +Cc: greg, linux-pci, paulus, anton, linuxppc-dev
In-Reply-To: <mj+md-20080214.093558.3352.nikam@ucw.cz>
From: Martin Mares <mj@ucw.cz>
Date: Thu, 14 Feb 2008 10:40:22 +0100
> Would it be acceptable for the PPC folks to modify the code to add
> domain numbers to the device numbers in /proc/bus/pci/devices in the
> same format as the bus directories already have?
Be careful, things like the X server parse that file, and X's
parser does not expect domain numbers there so you will break
things :-(
^ permalink raw reply
* Re: /proc/bus/pci and domains
From: Martin Mares @ 2008-02-14 21:45 UTC (permalink / raw)
To: David Miller; +Cc: greg, linux-pci, paulus, anton, linuxppc-dev
In-Reply-To: <20080214.134305.237408044.davem@davemloft.net>
Hi!
> > Would it be acceptable for the PPC folks to modify the code to add
> > domain numbers to the device numbers in /proc/bus/pci/devices in the
> > same format as the bus directories already have?
>
> Be careful, things like the X server parse that file, and X's
> parser does not expect domain numbers there so you will break
> things :-(
Yes, but neither does it expect domain numbers in the directory names,
I guess :-)
But thanks for the tip, I will check X before I post the patch.
Have a nice fortnight
--
Martin `MJ' Mares <mj@ucw.cz> http://mj.ucw.cz/
Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth
A student who changes the course of history is probably taking an exam.
^ permalink raw reply
* Re: /proc/bus/pci and domains
From: Martin Mares @ 2008-02-14 21:46 UTC (permalink / raw)
To: Matthew Wilcox; +Cc: greg, linuxppc-dev, paulus, anton, linux-pci, David Miller
In-Reply-To: <20080214214506.GB7657@parisc-linux.org>
Hi!
> > Be careful, things like the X server parse that file, and X's
> > parser does not expect domain numbers there so you will break
> > things :-(
>
> It might be best if we only place domain 0 in that file.
Yes, that's another possilibity. However, in such cases we should probably
create the subdirectories only for domain 0 as well.
Have a nice fortnight
--
Martin `MJ' Mares <mj@ucw.cz> http://mj.ucw.cz/
Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth
"Beware of bugs in the above code; I have only proved it correct, not tried it." -- D.E.K.
^ permalink raw reply
* Please pull powerpc.git merge branch
From: Paul Mackerras @ 2008-02-14 22:00 UTC (permalink / raw)
To: torvalds; +Cc: linuxppc-dev, akpm, linux-kernel
Linus,
Please do
git pull \
git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc.git merge
to get a collection of bug-fixes and very minor cleanups for powerpc
(plus one commit wiring up the timerfd syscalls).
Thanks,
Paul.
arch/powerpc/Kconfig | 4 ---
arch/powerpc/boot/Makefile | 2 +
arch/powerpc/boot/ps3-hvcall.S | 2 +
arch/powerpc/kernel/Makefile | 2 +
arch/powerpc/kernel/process.c | 2 +
arch/powerpc/kernel/vdso.c | 12 ++++----
arch/powerpc/platforms/512x/Kconfig | 1 -
arch/powerpc/platforms/52xx/Kconfig | 2 -
arch/powerpc/platforms/Kconfig | 2 -
arch/powerpc/platforms/Kconfig.cputype | 4 ---
arch/powerpc/platforms/cell/ras.c | 11 ++++++-
arch/powerpc/platforms/embedded6xx/Kconfig | 4 ---
arch/powerpc/platforms/iseries/vio.c | 2 +
drivers/char/hvc_rtas.c | 2 +
drivers/ps3/ps3-lpm.c | 22 ++++++++------
drivers/ps3/ps3-sys-manager.c | 44 ++++++++++++++++++++--------
include/asm-powerpc/systbl.h | 4 ++-
include/asm-powerpc/unistd.h | 6 +++-
include/asm-ppc/page.h | 2 +
19 files changed, 76 insertions(+), 54 deletions(-)
Adrian Bunk (3):
[POWERPC] vdso_do_func_patch{32,64}() must be __init
[POWERPC] free_property() must not be __init
[POWERPC] hvc_rtas_init() must be __init
Geoff Levand (4):
[POWERPC] PS3: Fix bootwrapper hang bug
[POWERPC] PS3: Use system reboot on restart
[POWERPC] PS3: Sys-manager code cleanup
[POWERPC] PS3: Update sys-manager button events
Grant Likely (1):
[POWERPC] Remove unused CONFIG_WANT_DEVICE_TREE
Hugh Dickins (1):
[POWERPC] Fix DEBUG_PREEMPT warning when warning
Kumar Gala (1):
[POWERPC] Remove generated files on make clean
Michael Ellerman (1):
[POWERPC] Cell RAS: Remove DEBUG, and add license and copyright
Stefan Roese (1):
[POWERPC] Fix arch/ppc compilation - add typedef for pgtable_t
Stephen Rothwell (1):
[POWERPC] Wire up new timerfd syscalls
Takashi Yamamoto (2):
[POWERPC] PS3: Fix setting bookmark in logical performance monitor
[POWERPC] PS3: Fix reading pm interval in logical performance monitor
^ permalink raw reply
* Re: [PATCH 0/4]: Respun LMB patches.
From: David Miller @ 2008-02-14 22:13 UTC (permalink / raw)
To: becky.bruce; +Cc: sparclinux, linuxppc-dev, linux-kernel
In-Reply-To: <38133B3C-75A2-4465-9484-7BF8E7E85D1D@freescale.com>
From: Becky Bruce <becky.bruce@freescale.com>
Date: Thu, 14 Feb 2008 14:58:22 -0600
> Thanks for picking up the patches from Kumar and myself and fitting
> them into your series - this is much appreciated. FYI, I applied the
> entire patch series to my local tree and test-booted both mpc8641 and
> mpc8568mds and both build and boot cleanly. I also built pasemi and
> ebony, those build cleanly as well.
Thanks for all of the testing.
^ permalink raw reply
* Re: /proc/bus/pci and domains
From: Matthew Wilcox @ 2008-02-14 21:45 UTC (permalink / raw)
To: David Miller; +Cc: greg, mj, linuxppc-dev, paulus, anton, linux-pci
In-Reply-To: <20080214.134305.237408044.davem@davemloft.net>
On Thu, Feb 14, 2008 at 01:43:05PM -0800, David Miller wrote:
> From: Martin Mares <mj@ucw.cz>
> Date: Thu, 14 Feb 2008 10:40:22 +0100
>
> > Would it be acceptable for the PPC folks to modify the code to add
> > domain numbers to the device numbers in /proc/bus/pci/devices in the
> > same format as the bus directories already have?
>
> Be careful, things like the X server parse that file, and X's
> parser does not expect domain numbers there so you will break
> things :-(
It might be best if we only place domain 0 in that file.
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
^ permalink raw reply
* Re: [PATCH 0/4]: Respun LMB patches.
From: David Miller @ 2008-02-14 22:15 UTC (permalink / raw)
To: jwboyer; +Cc: sparclinux, linux-kernel, linuxppc-dev
In-Reply-To: <20080214152448.49c69238@zod.rchland.ibm.com>
From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Date: Thu, 14 Feb 2008 15:24:48 -0600
> I plan on actually testing this on Ebony, Walnut, and Bamboo either
> later tonight or tomorrow. I don't expect many issues.
>
> Dave, those above boards would cover the build of PowerPC 4xx CPU cores.
Ok.
^ permalink raw reply
* Re: /proc/bus/pci and domains
From: David Miller @ 2008-02-14 22:17 UTC (permalink / raw)
To: mj; +Cc: greg, linux-pci, paulus, anton, linuxppc-dev
In-Reply-To: <mj+md-20080214.214339.22251.nikam@ucw.cz>
From: Martin Mares <mj@ucw.cz>
Date: Thu, 14 Feb 2008 22:45:14 +0100
> But thanks for the tip, I will check X before I post the patch.
X now uses sysfs when available, therefore I think it's
best not to try and muck with this deprecated interface
if possible.
^ permalink raw reply
* Re: /proc/bus/pci and domains
From: Martin Mares @ 2008-02-14 22:21 UTC (permalink / raw)
To: David Miller; +Cc: greg, linux-pci, paulus, anton, linuxppc-dev
In-Reply-To: <20080214.141711.222843930.davem@davemloft.net>
> X now uses sysfs when available, therefore I think it's
> best not to try and muck with this deprecated interface
> if possible.
However, the interface is fatally broken on machines with domains
and the breakage is visible (e.g., run lspci when /sys is not mounted).
I originally intended to just disable the proc backend on the affected
architectures, but it turned out than even x86 can be affected.
Have a nice fortnight
--
Martin `MJ' Mares <mj@ucw.cz> http://mj.ucw.cz/
Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth
"God doesn't play dice." -- Albert Einstein
^ permalink raw reply
* Re: [PATCH 2/8] pseries: phyp dump: reserve-release proof-of-concept
From: Olof Johansson @ 2008-02-14 23:12 UTC (permalink / raw)
To: Tony Breeds; +Cc: linuxppc-dev
In-Reply-To: <20080214034621.GA6887@bakeyournoodle.com>
On Thu, Feb 14, 2008 at 02:46:21PM +1100, Tony Breeds wrote:
> Hi Manish,
> Sorry for the minor nits but this should be:
>
> ---
> * Linas Vepstas, Manish Ahuja 2008
> * Copyright 2008 IBM Corp.
> ---
>
> You can optionally use the '??' symbol after word 'Copyright' but you
> shouldn't use '(c)' anymore.
>
> Also in at least one place you've misspelt "Copyright"
If we're going to nitpick, then I'd like to point out that the whole
series needs to be run through checkpatch and at least the whitespace
issues should be taken care of.
I'm still not convinced that this is a useful feature compared to
hardening kdump, especially now that ehea can handle kexec/kdump (patch
posted the other day). But in the end it's up to Paul if he wants to
take it or not, not me.
-Olof
^ permalink raw reply
* Re: [PATCH 0/4]: Respun LMB patches.
From: Olof Johansson @ 2008-02-14 23:21 UTC (permalink / raw)
To: Becky Bruce; +Cc: sparclinux, linuxppc-dev, David Miller, linux-kernel
In-Reply-To: <38133B3C-75A2-4465-9484-7BF8E7E85D1D@freescale.com>
On Thu, Feb 14, 2008 at 02:58:22PM -0600, Becky Bruce wrote:
> Thanks for picking up the patches from Kumar and myself and fitting
> them into your series - this is much appreciated. FYI, I applied the
> entire patch series to my local tree and test-booted both mpc8641 and
> mpc8568mds and both build and boot cleanly. I also built pasemi and
> ebony, those build cleanly as well.
pasemi_defconfig boots happily on my boards here. I've kicked off my
"build all powerpc defconfigs" script while I leave the house for a
couple of hours, but as others have said, no problems are expected...
-Olof
^ permalink raw reply
* Re: [PATCH] [POWERPC] Enable correct operation of serial ports withnonzero regshift.
From: Stephen Rothwell @ 2008-02-14 23:27 UTC (permalink / raw)
To: Stephen Neuendorffer; +Cc: linuxppc-dev, Pavel Kiryukhin
In-Reply-To: <20080214185534.81F625F808D@mail186-dub.bigfish.com>
[-- Attachment #1: Type: text/plain, Size: 468 bytes --]
On Thu, 14 Feb 2008 10:55:31 -0800 "Stephen Neuendorffer" <stephen.neuendorffer@xilinx.com> wrote:
>
> > --- a/arch/powerpc/kernel/legacy_serial.c
> > +++ b/arch/powerpc/kernel/legacy_serial.c
> > + /* get regshift if present*/
> > + regshift = get_property(np, "reg-shift", NULL);
>
> of_get_property, presumably?
Damn, how did I miss that? :-)
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply
* RE: [PATCH] [POWERPC] Enable correct operation of serial ports withnonzero regshift.
From: Stephen Neuendorffer @ 2008-02-14 23:33 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linuxppc-dev, Pavel Kiryukhin
In-Reply-To: <20080215102706.1b7c30c1.sfr@canb.auug.org.au>
gcc knows better. :)
> -----Original Message-----
> From: Stephen Rothwell [mailto:sfr@canb.auug.org.au]
> Sent: Thursday, February 14, 2008 3:27 PM
> To: Stephen Neuendorffer
> Cc: Pavel Kiryukhin; linuxppc-dev@ozlabs.org
> Subject: Re: [PATCH] [POWERPC] Enable correct operation of serial
ports withnonzero regshift.
>=20
> On Thu, 14 Feb 2008 10:55:31 -0800 "Stephen Neuendorffer"
<stephen.neuendorffer@xilinx.com> wrote:
> >
> > > --- a/arch/powerpc/kernel/legacy_serial.c
> > > +++ b/arch/powerpc/kernel/legacy_serial.c
> > > + /* get regshift if present*/
> > > + regshift =3D get_property(np, "reg-shift", NULL);
> >
> > of_get_property, presumably?
>=20
> Damn, how did I miss that? :-)
>=20
> --
> Cheers,
> Stephen Rothwell sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/
^ permalink raw reply
* Re: [PATCH 0/4]: Respun LMB patches.
From: Stephen Rothwell @ 2008-02-15 0:58 UTC (permalink / raw)
To: David Miller; +Cc: Olof Johansson, sparclinux, linux-kernel, linuxppc-dev
In-Reply-To: <20080214232152.GB15724@lixom.net>
[-- Attachment #1: Type: text/plain, Size: 899 bytes --]
On Thu, 14 Feb 2008 17:21:52 -0600 Olof Johansson <olof@lixom.net> wrote:
>
> On Thu, Feb 14, 2008 at 02:58:22PM -0600, Becky Bruce wrote:
>
> > Thanks for picking up the patches from Kumar and myself and fitting
> > them into your series - this is much appreciated. FYI, I applied the
> > entire patch series to my local tree and test-booted both mpc8641 and
> > mpc8568mds and both build and boot cleanly. I also built pasemi and
> > ebony, those build cleanly as well.
>
> pasemi_defconfig boots happily on my boards here. I've kicked off my
> "build all powerpc defconfigs" script while I leave the house for a
> couple of hours, but as others have said, no problems are expected...
It builds and boots on legacy iSeries (and seems to be working ok) as well.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply
* Re: [PATCH 3/8] pseries: phyp dump: use sysfs to release reserved mem
From: Tony Breeds @ 2008-02-15 1:05 UTC (permalink / raw)
To: Manish Ahuja; +Cc: mahuja, linuxppc-dev, linasvepstas, paulus
In-Reply-To: <47B146BE.5010807@austin.ibm.com>
On Tue, Feb 12, 2008 at 01:11:58AM -0600, Manish Ahuja wrote:
<snip>
> +static ssize_t
> +show_release_region(struct kset * kset, char *buf)
> +{
> + return sprintf(buf, "ola\n");
> +}
> +
> +static struct subsys_attribute rr = __ATTR(release_region, 0600,
> + show_release_region,
> + store_release_region);
Any reason this sysfs attribute can't be write only? The show method
doesn't seem needed.
> +static int __init phyp_dump_setup(void)
> +{
<snip>
> + /* Is there dump data waiting for us? */
> + rtas = of_find_node_by_path("/rtas");
> + dump_header = of_get_property(rtas, "ibm,kernel-dump", &header_len);
Hmm this isn't good. You need to check rtas != NULL.
> + if (dump_header == NULL) {
> + release_all();
> + return 0;
> + }
> +
> + /* Should we create a dump_subsys, analogous to s390/ipl.c ? */
> + rc = subsys_create_file(&kernel_subsys, &rr);
> + if (rc) {
> + printk (KERN_ERR "phyp-dump: unable to create sysfs file (%d)\n", rc);
> + release_all();
> + return 0;
> + }
>
> return 0;
> }
> -
> subsys_initcall(phyp_dump_setup);
Hmm I think this really should be a:
machine_subsys_initcall(pseries, phyp_dump_setup)
Yours Tony
linux.conf.au http://linux.conf.au/ || http://lca2008.linux.org.au/
Jan 28 - Feb 02 2008 The Australian Linux Technical Conference!
^ permalink raw reply
* dtc: Fold comment handling test into testsuite
From: David Gibson @ 2008-02-15 4:14 UTC (permalink / raw)
To: Jon Loeliger; +Cc: linuxppc-dev
For ages dtc has included a sample dts, comment-test.dts, for checking
various lexical corner cases in comment processing. In fact, it
predates the automated testsuite, and has never been integrated into
it. This patch addresses this oversight, folding the comment handling
test in with the rest of the testsuite.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Index: dtc/comment-test.dts
===================================================================
--- dtc.orig/comment-test.dts 2008-02-15 15:01:06.000000000 +1100
+++ /dev/null 1970-01-01 00:00:00.000000000 +0000
@@ -1,38 +0,0 @@
-/* regexps for lexing comments are.. tricky. Check if we've actually
- * got it right */
-
-/ {
- // line comment
- prop1;
- /* comment */
- prop2;
- /* multiline
-
- notaprop1;
-
- comment */
- prop3;
- /**/
- prop4;
- /***/
- prop5;
- /****/
- prop6;
- /* another
- * multiline
- * comment */
- prop7;
- /* yet
- * another
- * multline
- * comment
- */
- prop8;
- /** try this */
- prop9;
- /* and this **/
- prop10;
- child /* finally */ {
- };
-};
-/* final comment */
Index: dtc/tests/comments.dts
===================================================================
--- /dev/null 1970-01-01 00:00:00.000000000 +0000
+++ dtc/tests/comments.dts 2008-02-15 15:05:50.000000000 +1100
@@ -0,0 +1,39 @@
+/* regexps for lexing comments are.. tricky. Check if we've actually
+ * got it right */
+/dts-v1/;
+
+/ {
+ // line comment
+ prop1;
+ /* comment */
+ prop2;
+ /* multiline
+
+ notaprop1;
+
+ comment */
+ prop3;
+ /**/
+ prop4;
+ /***/
+ prop5;
+ /****/
+ prop6;
+ /* another
+ * multiline
+ * comment */
+ prop7;
+ /* yet
+ * another
+ * multline
+ * comment
+ */
+ prop8;
+ /** try this */
+ prop9;
+ /* and this **/
+ prop10;
+ child /* finally */ {
+ };
+};
+/* final comment */
Index: dtc/tests/run_tests.sh
===================================================================
--- dtc.orig/tests/run_tests.sh 2008-02-15 15:01:20.000000000 +1100
+++ dtc/tests/run_tests.sh 2008-02-15 15:08:09.000000000 +1100
@@ -155,6 +155,10 @@ dtc_tests () {
run_test dtc.sh -I dts -O dtb -o dtc_path-references.test.dtb path-references.dts
run_test path-references dtc_path-references.test.dtb
+ run_test dtc.sh -I dts -O dtb -o dtc_comments.test.dtb comments.dts
+ run_test dtc.sh -I dts -O dtb -o dtc_comments-cmp.test.dtb comments-cmp.dts
+ run_test dtbs_equal_ordered dtc_comments.test.dtb dtc_comments-cmp.test.dtb
+
# Check -Odts mode preserve all dtb information
for tree in test_tree1.dtb dtc_tree1.test.dtb dtc_escapes.test.dtb ; do
run_test dtc.sh -I dtb -O dts -o odts_$tree.test.dts $tree
Index: dtc/tests/comments-cmp.dts
===================================================================
--- /dev/null 1970-01-01 00:00:00.000000000 +0000
+++ dtc/tests/comments-cmp.dts 2008-02-15 15:07:04.000000000 +1100
@@ -0,0 +1,16 @@
+/dts-v1/;
+
+/ {
+ prop1;
+ prop2;
+ prop3;
+ prop4;
+ prop5;
+ prop6;
+ prop7;
+ prop8;
+ prop9;
+ prop10;
+ child {
+ };
+};
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
^ permalink raw reply
* a question on an error of building 2.6.24.2
From: Jingyu Liu @ 2008-02-15 4:19 UTC (permalink / raw)
To: linuxppc-dev
[-- Attachment #1: Type: text/plain, Size: 874 bytes --]
Hi there,
I am using a cross-compiler gcc 4.1.2 and glibc 2.3.6 to build 2.6.24.2 for
a adder875 board. At the end of building, the ld gives the following error
messages:
LD init/built-in.o
LD vmlinux
`.exit.data' referenced in section `.exit.text' of drivers/built-in.o:
defined in discarded section `.exit.data' of drivers/built-in.o
`.exit.data' referenced in section `.exit.text' of drivers/built-in.o:
defined in discarded section `.exit.data' of drivers/built-in.o
`.exit.data' referenced in section `.exit.text' of drivers/built-in.o:
defined in discarded section `.exit.data' of drivers/built-in.o
`.exit.data' referenced in section `.exit.text' of drivers/built-in.o:
defined in discarded section `.exit.data' of drivers/built-in.o
make: *** [vmlinux] Error 1
.config file is also attached.
Is it gcc problem, or something else?
Thanks.
Jingyu
[-- Attachment #2: Type: text/html, Size: 1129 bytes --]
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox