LinuxPPC-Dev Archive on lore.kernel.org

* [PATCH 1/5] phylib: don't create a phydev for ID-less PHYs.
From: Paul Gortmaker @ 2008-04-10 17:51 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: scottwood, linux-net, Paul Gortmaker
In-Reply-To: <1207849922-2436-1-git-send-email-paul.gortmaker@windriver.com>

I've tested on 8360, 8540 and 8641D and in all cases, the PHY
ID returned for bus addr 0x1f is all zeros, and not all 0xf.
This means we've been allocating a phydev for this "ghost".

In addition to marking 0x0 as an invalid PHY ID, I've also
changed the existing somewhat useless printk to actually
list the bus IDs where it found a PHY so we get a basic
bus summary.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 drivers/net/phy/mdio_bus.c   |    4 +++-
 drivers/net/phy/phy_device.c |    5 +++--
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
index 963630c..e33a119 100644
--- a/drivers/net/phy/mdio_bus.c
+++ b/drivers/net/phy/mdio_bus.c
@@ -59,6 +59,7 @@ int mdiobus_register(struct mii_bus *bus)
 	if (bus->reset)
 		bus->reset(bus);
 
+	pr_info("%s: PHY(s) at:", bus->name);
 	for (i = 0; i < PHY_MAX_ADDR; i++) {
 		struct phy_device *phydev;
 
@@ -97,12 +98,13 @@ int mdiobus_register(struct mii_bus *bus)
 				phy_device_free(phydev);
 				phydev = NULL;
 			}
+			printk(" 0x%x", i);
 		}
 
 		bus->phy_map[i] = phydev;
 	}
 
-	pr_info("%s: probed\n", bus->name);
+	printk("\n");
 
 	return err;
 }
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index f4c4fd8..740dd2e 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -116,8 +116,9 @@ struct phy_device * get_phy_device(struct mii_bus *bus, int addr)
 
 	phy_id |= (phy_reg & 0xffff);
 
-	/* If the phy_id is all Fs, there is no device there */
-	if (0xffffffff == phy_id)
+	/* If the phy_id is all Fs, there is no device there. Similarly
+ 	   it seems common to get an ID of zero at addr 0x1f */
+	if (0xffffffff == phy_id || 0 == phy_id)
 		return NULL;
 
 	dev = phy_device_create(bus, addr, phy_id);
-- 
1.5.4.3

^ permalink raw reply related