LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] powerpc: Add configurable -Werror for arch/powerpc
From: Michael Ellerman @ 2009-04-07  2:00 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: Kumar Gala

Add an option, on by default, to build all code under arch/powerpc with
-Werror, which causes gcc to treat warnings as errors.

The intention is to make it harder for people to inadvertantly introduce
errors in the arch/powerpc code. It needs to be configurable so that
if a warning is introduced, people can easily work around it while it's
being fixed.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
---
 arch/powerpc/Kconfig.debug      |    8 ++++++++
 arch/powerpc/kernel/Makefile    |    4 ++++
 arch/powerpc/kvm/Makefile       |    4 ++++
 arch/powerpc/lib/Makefile       |    4 ++++
 arch/powerpc/mm/Makefile        |    4 ++++
 arch/powerpc/oprofile/Makefile  |    4 ++++
 arch/powerpc/platforms/Makefile |    4 ++++
 arch/powerpc/sysdev/Makefile    |    4 ++++
 arch/powerpc/xmon/Makefile      |    4 ++++
 9 files changed, 40 insertions(+), 0 deletions(-)

v2: Leave math-emu alone, it's a steaming pile of warnings.

diff --git a/arch/powerpc/Kconfig.debug b/arch/powerpc/Kconfig.debug
index a1098e2..58d5c22 100644
--- a/arch/powerpc/Kconfig.debug
+++ b/arch/powerpc/Kconfig.debug
@@ -2,6 +2,14 @@ menu "Kernel hacking"
 
 source "lib/Kconfig.debug"
 
+config PPC_WERROR
+	bool "Build arch/powerpc code with -Werror"
+	default y
+	help
+	  This option tells the compiler to build all of the code under
+	  arch/powerpc with the -Werror flag, which means all warnings
+	  are treated as errors.
+
 config PRINT_STACK_DEPTH
 	int "Stack depth to print" if DEBUG_KERNEL
 	default 64
diff --git a/arch/powerpc/kernel/Makefile b/arch/powerpc/kernel/Makefile
index 71901fb..b11ef4e 100644
--- a/arch/powerpc/kernel/Makefile
+++ b/arch/powerpc/kernel/Makefile
@@ -12,6 +12,10 @@ CFLAGS_prom_init.o      += -fPIC
 CFLAGS_btext.o		+= -fPIC
 endif
 
+ifeq ($(CONFIG_PPC_WERROR),y)
+EXTRA_CFLAGS += -Werror
+endif
+
 ifdef CONFIG_FUNCTION_TRACER
 # Do not trace early boot code
 CFLAGS_REMOVE_cputable.o = -pg -mno-sched-epilog
diff --git a/arch/powerpc/kvm/Makefile b/arch/powerpc/kvm/Makefile
index 4b2df66..51d2337 100644
--- a/arch/powerpc/kvm/Makefile
+++ b/arch/powerpc/kvm/Makefile
@@ -2,6 +2,10 @@
 # Makefile for Kernel-based Virtual Machine module
 #
 
+ifeq ($(CONFIG_PPC_WERROR),y)
+EXTRA_CFLAGS += -Werror
+endif
+
 EXTRA_CFLAGS += -Ivirt/kvm -Iarch/powerpc/kvm
 
 common-objs-y = $(addprefix ../../../virt/kvm/, kvm_main.o coalesced_mmio.o)
diff --git a/arch/powerpc/lib/Makefile b/arch/powerpc/lib/Makefile
index 8db3527..536db60 100644
--- a/arch/powerpc/lib/Makefile
+++ b/arch/powerpc/lib/Makefile
@@ -2,6 +2,10 @@
 # Makefile for ppc-specific library files..
 #
 
+ifeq ($(CONFIG_PPC_WERROR),y)
+EXTRA_CFLAGS += -Werror
+endif
+
 ifeq ($(CONFIG_PPC64),y)
 EXTRA_CFLAGS		+= -mno-minimal-toc
 endif
diff --git a/arch/powerpc/mm/Makefile b/arch/powerpc/mm/Makefile
index 17290bc..4880a16 100644
--- a/arch/powerpc/mm/Makefile
+++ b/arch/powerpc/mm/Makefile
@@ -2,6 +2,10 @@
 # Makefile for the linux ppc-specific parts of the memory manager.
 #
 
+ifeq ($(CONFIG_PPC_WERROR),y)
+EXTRA_CFLAGS += -Werror
+endif
+
 ifeq ($(CONFIG_PPC64),y)
 EXTRA_CFLAGS	+= -mno-minimal-toc
 endif
diff --git a/arch/powerpc/oprofile/Makefile b/arch/powerpc/oprofile/Makefile
index 2ef6b0d..e607c74 100644
--- a/arch/powerpc/oprofile/Makefile
+++ b/arch/powerpc/oprofile/Makefile
@@ -1,3 +1,7 @@
+ifeq ($(CONFIG_PPC_WERROR),y)
+EXTRA_CFLAGS += -Werror
+endif
+
 ifeq ($(CONFIG_PPC64),y)
 EXTRA_CFLAGS	+= -mno-minimal-toc
 endif
diff --git a/arch/powerpc/platforms/Makefile b/arch/powerpc/platforms/Makefile
index f741919..b18b921 100644
--- a/arch/powerpc/platforms/Makefile
+++ b/arch/powerpc/platforms/Makefile
@@ -1,4 +1,8 @@
 
+ifeq ($(CONFIG_PPC_WERROR),y)
+EXTRA_CFLAGS += -Werror
+endif
+
 obj-$(CONFIG_FSL_ULI1575)	+= fsl_uli1575.o
 
 obj-$(CONFIG_PPC_PMAC)		+= powermac/
diff --git a/arch/powerpc/sysdev/Makefile b/arch/powerpc/sysdev/Makefile
index b33b28a..508c305 100644
--- a/arch/powerpc/sysdev/Makefile
+++ b/arch/powerpc/sysdev/Makefile
@@ -1,3 +1,7 @@
+ifeq ($(CONFIG_PPC_WERROR),y)
+EXTRA_CFLAGS += -Werror
+endif
+
 ifeq ($(CONFIG_PPC64),y)
 EXTRA_CFLAGS			+= -mno-minimal-toc
 endif
diff --git a/arch/powerpc/xmon/Makefile b/arch/powerpc/xmon/Makefile
index 9cb03b7..3348822 100644
--- a/arch/powerpc/xmon/Makefile
+++ b/arch/powerpc/xmon/Makefile
@@ -1,5 +1,9 @@
 # Makefile for xmon
 
+ifeq ($(CONFIG_PPC_WERROR),y)
+EXTRA_CFLAGS += -Werror
+endif
+
 ifdef CONFIG_PPC64
 EXTRA_CFLAGS += -mno-minimal-toc
 endif
-- 
1.6.2.1

^ permalink raw reply related

* Re: [alsa-devel] [PATCH] ASoC: fsl_dma: Pass the proper device for dma mapping routines
From: Mark Brown @ 2009-04-06 22:38 UTC (permalink / raw)
  To: Timur Tabi; +Cc: alsa-devel, Takashi Iwai, linuxppc-dev, Liam Girdwood
In-Reply-To: <49DA6ECE.4010900@freescale.com>

On Mon, Apr 06, 2009 at 04:06:22PM -0500, Timur Tabi wrote:
> Acked-by: Timur Tabi <timur@freescale.com>

> Mark and Takashi: this patch is a must-fix for 2.6.30

Applied, thanks.

^ permalink raw reply

* Re: [PATCH] powerpc: Keep track of emulated instructions
From: Michael Neuling @ 2009-04-06 22:43 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Linux/PPC Development
In-Reply-To: <alpine.LRH.2.00.0904061430090.11076@vixen.sonytel.be>

In message <alpine.LRH.2.00.0904061430090.11076@vixen.sonytel.be> you wrote:
> On Fri, 3 Apr 2009, Kumar Gala wrote:
> > On Apr 3, 2009, at 7:08 AM, Geert Uytterhoeven wrote:
> > >Finally (after ca. 1.5 years), he're an updated version of my patch to k=
> eep
> > >track of emulated instructions.  In the light of Kumar's `Emulate enough=
>  of
> > >SPE
> > >instructions to make gcc happy' patch, he probably also wants to keep tr=
> ack
> > >of
> > >the actual runtime overhead.
> > >
> > >Changes since last version:
> > > - arch/powerpc/kernel/sysfs.c is now compiled on ppc32, so we can provi=
> de
> > >   counters in sysfs on ppc32, too,
> > > - WARN_EMULATED() is a no-op if CONFIG_SYSCTL is disabled,
> > > - Add warnings for altivec,
> > > - Add warnings for recently introduced emulation of vsx and isel
> > >   instructions.
> > =
> 
> > pretty cool.  Do we think counters should be sysfs or debugfs?
> 
> What do you prefer?
> 
> On MIPS, unaligned exception handling control is in debugfs.

Would per process counters be too hard?  Stick them in the thread_struct
and export them via /proc/<pid>/emulated. 

Mikey

> 
> > Also it would be nice to be able to zero out the counters.
> 
> By writing to the individual counters, or by writing to a global `clear' fi=
> le?
> 
> BTW, should the individual counters be readable by everybody? Currently the=
> y're
> readable by root only.
> 
> With kind regards,
> 
> Geert Uytterhoeven
> Software Architect
> 
> Sony Techsoft Centre Europe
> The Corporate Village =B7 Da Vincilaan 7-D1 =B7 B-1935 Zaventem =B7 Belgium
> 
> Phone:    +32 (0)2 700 8453
> Fax:      +32 (0)2 700 8622
> E-mail:   Geert.Uytterhoeven@sonycom.com
> Internet: http://www.sony-europe.com/
> 
> A division of Sony Europe (Belgium) N.V.
> VAT BE 0413.825.160 =B7 RPR Brussels
> Fortis =B7 BIC GEBABEBB =B7 IBAN BE41293037680010
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
> 

^ permalink raw reply

* Hotplug on PPC4xx
From: Sean MacLennan @ 2009-04-06 22:20 UTC (permalink / raw)
  To: linuxppc-dev

I am trying to run the /sbin/hotplug from the kernel and it doesn't
work. Has anybody got it running?

I know I am being a bit vague, but I don't want to write a long email
and find out that it is a know problem ;)

Basically, I want to automount SD cards and USB keys. So if anybody
knows a better way than hotplug, let me know. I would rather not have
to setup udev/hald/dbus.

Cheers,
   Sean

^ permalink raw reply

* [PATCH] powerpc: Update Warp to use leds-gpio driver
From: Sean MacLennan @ 2009-04-06 21:58 UTC (permalink / raw)
  To: linuxppc-dev

Now that leds-gpio is a proper OF platform driver, the Warp can use
the leds-gpio driver rather than the old out-of-kernel driver.

One side-effect is the leds-gpio driver always turns the leds off
while the old driver left them alone. So we have to set them back to
the correct settings.

Signed-off-by: Sean MacLennan <smaclennan@pikatech.com>
---
diff --git a/arch/powerpc/boot/dts/warp.dts b/arch/powerpc/boot/dts/warp.dts
index 7e183ff..01bfb56 100644
--- a/arch/powerpc/boot/dts/warp.dts
+++ b/arch/powerpc/boot/dts/warp.dts
@@ -1,7 +1,7 @@
 /*
  * Device Tree Source for PIKA Warp
  *
- * Copyright (c) 2008 PIKA Technologies
+ * Copyright (c) 2008-2009 PIKA Technologies
  *   Sean MacLennan <smaclennan@pikatech.com>
  *
  * This file is licensed under the terms of the GNU General Public
@@ -158,7 +158,7 @@
 
 					partition@0 {
 						label = "splash";
-						reg = <0x00000000 0x00020000>;
+						reg = <0x00000000 0x00010000>;
 					};
 					partition@300000 {
 						label = "fpga";
@@ -244,28 +244,27 @@
 			};
 
 			GPIO0: gpio@ef600b00 {
-				compatible = "ibm,gpio-440ep";
+				compatible = "ibm,ppc4xx-gpio";
 				reg = <0xef600b00 0x00000048>;
 				#gpio-cells = <2>;
 				gpio-controller;
 			};
 
 			GPIO1: gpio@ef600c00 {
-				compatible = "ibm,gpio-440ep";
+				compatible = "ibm,ppc4xx-gpio";
 				reg = <0xef600c00 0x00000048>;
 				#gpio-cells = <2>;
 				gpio-controller;
+			};
 
-				led@31 {
-					compatible = "linux,gpio-led";
-					linux,name = ":green:";
-					gpios = <&GPIO1 31 0>;
-				};		
-	
-				led@30 {	
-					compatible = "linux,gpio-led";
-					linux,name = ":red:";
-					gpios = <&GPIO1 30 0>;
+			power-leds {
+				compatible = "gpio-leds";
+				green {
+					gpios = <&GPIO1 0 0>;
+					default-state = "on";
+				};
+				red {
+					gpios = <&GPIO1 1 0>;
 				};
 			};
 
diff --git a/arch/powerpc/platforms/44x/warp.c b/arch/powerpc/platforms/44x/warp.c
index 960edf8..c511880 100644
--- a/arch/powerpc/platforms/44x/warp.c
+++ b/arch/powerpc/platforms/44x/warp.c
@@ -1,7 +1,7 @@
 /*
  * PIKA Warp(tm) board specific routines
  *
- * Copyright (c) 2008 PIKA Technologies
+ * Copyright (c) 2008-2009 PIKA Technologies
  *   Sean MacLennan <smaclennan@pikatech.com>
  *
  * This program is free software; you can redistribute  it and/or modify it
@@ -15,6 +15,7 @@
 #include <linux/i2c.h>
 #include <linux/interrupt.h>
 #include <linux/delay.h>
+#include <linux/of_gpio.h>
 
 #include <asm/machdep.h>
 #include <asm/prom.h>
@@ -23,6 +24,7 @@
 #include <asm/uic.h>
 #include <asm/ppc4xx.h>
 
+
 static __initdata struct of_device_id warp_of_bus[] = {
 	{ .compatible = "ibm,plb4", },
 	{ .compatible = "ibm,opb", },
@@ -55,6 +57,8 @@ define_machine(warp) {
 };
 
 
+static u32 post_info;
+
 /* I am not sure this is the best place for this... */
 static int __init warp_post_info(void)
 {
@@ -77,21 +81,21 @@ static int __init warp_post_info(void)
 
 	iounmap(fpga);
 
-	if (post1 || post2)
+	if (post1 || post2) {
 		printk(KERN_INFO "Warp POST %08x %08x\n", post1, post2);
-	else
+		post_info = 1;
+	} else
 		printk(KERN_INFO "Warp POST OK\n");
 
 	return 0;
 }
-machine_late_initcall(warp, warp_post_info);
 
 
 #ifdef CONFIG_SENSORS_AD7414
 
 static LIST_HEAD(dtm_shutdown_list);
 static void __iomem *dtm_fpga;
-static void __iomem *gpio_base;
+static unsigned green_led, red_led;
 
 
 struct dtm_shutdown {
@@ -134,14 +138,17 @@ int pika_dtm_unregister_shutdown(void (*func)(void *arg), void *arg)
 static irqreturn_t temp_isr(int irq, void *context)
 {
 	struct dtm_shutdown *shutdown;
+	int value = 1;
 
 	local_irq_disable();
 
+	gpio_set_value(green_led, 0);
+
 	/* Run through the shutdown list. */
 	list_for_each_entry(shutdown, &dtm_shutdown_list, list)
 		shutdown->func(shutdown->arg);
 
-	printk(KERN_EMERG "\n\nCritical Temperature Shutdown\n");
+	printk(KERN_EMERG "\n\nCritical Temperature Shutdown\n\n");
 
 	while (1) {
 		if (dtm_fpga) {
@@ -149,52 +156,34 @@ static irqreturn_t temp_isr(int irq, void *context)
 			out_be32(dtm_fpga + 0x14, reset);
 		}
 
-		if (gpio_base) {
-			unsigned leds = in_be32(gpio_base);
-
-			/* green off, red toggle */
-			leds &= ~0x80000000;
-			leds ^=  0x40000000;
-
-			out_be32(gpio_base, leds);
-		}
-
+		gpio_set_value(red_led, value);
+		value ^= 1;
 		mdelay(500);
 	}
 }
 
 static int pika_setup_leds(void)
 {
-	struct device_node *np;
-	const u32 *gpios;
-	int len;
+	struct device_node *np, *child;
 
-	np = of_find_compatible_node(NULL, NULL, "linux,gpio-led");
+	np = of_find_compatible_node(NULL, NULL, "gpio-leds");
 	if (!np) {
-		printk(KERN_ERR __FILE__ ": Unable to find gpio-led\n");
-		return -ENOENT;
-	}
-
-	gpios = of_get_property(np, "gpios", &len);
-	of_node_put(np);
-	if (!gpios || len < 4) {
-		printk(KERN_ERR __FILE__
-		       ": Unable to get gpios property (%d)\n", len);
+		printk(KERN_ERR __FILE__ ": Unable to find leds\n");
 		return -ENOENT;
 	}
 
-	np = of_find_node_by_phandle(gpios[0]);
-	if (!np) {
-		printk(KERN_ERR __FILE__ ": Unable to find gpio\n");
-		return -ENOENT;
-	}
+	for_each_child_of_node(np, child)
+		if (strcmp(child->name, "green") == 0) {
+			green_led = of_get_gpio(child, 0);
+			/* Turn back on the green LED */
+			gpio_set_value(green_led, 1);
+		} else if (strcmp(child->name, "red") == 0) {
+			red_led = of_get_gpio(child, 0);
+			/* Set based on post */
+			gpio_set_value(red_led, post_info);
+		}
 
-	gpio_base = of_iomap(np, 0);
 	of_node_put(np);
-	if (!gpio_base) {
-		printk(KERN_ERR __FILE__ ": Unable to map gpio");
-		return -ENOMEM;
-	}
 
 	return 0;
 }
@@ -270,10 +259,10 @@ static int pika_dtm_thread(void __iomem *fpga)
 	}
 
 found_it:
-	i2c_put_adapter(adap);
-
 	pika_setup_critical_temp(client);
 
+	i2c_put_adapter(adap);
+
 	printk(KERN_INFO "PIKA DTM thread running.\n");
 
 	while (!kthread_should_stop()) {
@@ -311,6 +300,9 @@ static int __init pika_dtm_start(void)
 	if (dtm_fpga == NULL)
 		return -ENOENT;
 
+	/* Must get post info before thread starts. */
+	warp_post_info();
+
 	dtm_thread = kthread_run(pika_dtm_thread, dtm_fpga, "pika-dtm");
 	if (IS_ERR(dtm_thread)) {
 		iounmap(dtm_fpga);
@@ -333,6 +325,8 @@ int pika_dtm_unregister_shutdown(void (*func)(void *arg), void *arg)
 	return 0;
 }
 
+machine_late_initcall(warp, warp_post_info);
+
 #endif
 
 EXPORT_SYMBOL(pika_dtm_register_shutdown);

^ permalink raw reply related

* Re: sata device failed to IDENTIFY...
From: Timur Tabi @ 2009-04-06 21:34 UTC (permalink / raw)
  To: Tirumala Reddy Marri; +Cc: linuxppc-dev, rizwan ahmad
In-Reply-To: <AC5E1C3367E37D44970B81A6ADD1DA2C071F4271@SDCEXCHANGE01.ad.amcc.com>

On Mon, Mar 23, 2009 at 3:07 AM, rizwan ahmad <rizwanamu@gmail.com> wrote:
> ata1: SATA link up 1.5 Gbps (SStatus 113 SControl 310)
> ata1.00: qc timeout (cmd 0xec)
> ata1.00: failed to IDENTIFY (I/O error, err_mask=0x4)

I'm seeing the same exact thing on a Freescale MPC8610 HPCD board.
This happens only on 2.6.30.  It works fine on 2.6.29.

Unfortunately, my rootfs is on my SATA drive, so it will be a bit
difficult to boot and get an lspci output.

^ permalink raw reply

* Re: [PATCH] ASoC: fsl_dma: Pass the proper device for dma mapping routines
From: Timur Tabi @ 2009-04-06 21:06 UTC (permalink / raw)
  To: Anton Vorontsov
  Cc: alsa-devel, Takashi Iwai, Mark Brown, linuxppc-dev, Liam Girdwood
In-Reply-To: <20090404183319.GA22203@oksana.dev.rtsoft.ru>

Anton Vorontsov wrote:
> The driver should pass a device that specifies internal DMA ops, but
> substream->pcm is just a logical device, and thus doesn't have arch-
> specific dma callbacks, therefore following bug appears:
> 
>   Freescale Synchronous Serial Interface (SSI) ASoC Driver
>   ------------[ cut here ]------------
>   kernel BUG at arch/powerpc/include/asm/dma-mapping.h:237!
>   Oops: Exception in kernel mode, sig: 5 [#1]
>   ...
>   NIP [c02259c4] snd_malloc_dev_pages+0x58/0xac
>   LR [c0225c74] snd_dma_alloc_pages+0xf8/0x108
>   Call Trace:
>   [df02bde0] [df02be2c] 0xdf02be2c (unreliable)
>   [df02bdf0] [c0225c74] snd_dma_alloc_pages+0xf8/0x108
>   [df02be10] [c023a100] fsl_dma_new+0x68/0x124
>   [df02be20] [c02342ac] soc_new_pcm+0x1bc/0x234
>   [df02bea0] [c02343dc] snd_soc_new_pcms+0xb8/0x148
>   [df02bed0] [c023824c] cs4270_probe+0x34/0x124
>   [df02bef0] [c0232fe8] snd_soc_instantiate_card+0x1a4/0x2f4
>   [df02bf20] [c0233164] snd_soc_instantiate_cards+0x2c/0x68
>   [df02bf30] [c0234704] snd_soc_register_platform+0x60/0x80
>   [df02bf50] [c03d5664] fsl_soc_platform_init+0x18/0x28
>   ...
> 
> This patch fixes the issue by using card's device instead.
> 
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---

Acked-by: Timur Tabi <timur@freescale.com>

Mark and Takashi: this patch is a must-fix for 2.6.30

-- 
Timur Tabi
Linux kernel developer at Freescale

^ permalink raw reply

* [PATCH 3/3] powerpc: allow 256kB pages with SHMEM
From: Hugh Dickins @ 2009-04-06 21:01 UTC (permalink / raw)
  To: Andrew Morton; +Cc: yanok, linux-kernel, linuxppc-dev, prodyuth
In-Reply-To: <Pine.LNX.4.64.0904062151250.21044@blonde.anvils>

Now that shmem's divisions by zero and SHMEM_MAX_BYTES are fixed,
let powerpc 256kB pages coexist with CONFIG_SHMEM again.

Signed-off-by: Hugh Dickins <hugh@veritas.com>
---
Added linuxppc-dev and some other Cc's for this 3/3: sorry
if you didn't see 1/3 and 2/3, they were just in mm/shmem.c.

 arch/powerpc/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- 2.6.29-git13/arch/powerpc/Kconfig	2009-04-06 11:47:57.000000000 +0100
+++ linux/arch/powerpc/Kconfig	2009-04-06 18:18:47.000000000 +0100
@@ -462,7 +462,7 @@ config PPC_64K_PAGES
 
 config PPC_256K_PAGES
 	bool "256k page size" if 44x
-	depends on !STDBINUTILS && (!SHMEM || BROKEN)
+	depends on !STDBINUTILS
 	help
 	  Make the page size 256k.
 

^ permalink raw reply

* [PATCH] powerpc: Fix tlbilx opcode
From: Kumar Gala @ 2009-04-06 20:36 UTC (permalink / raw)
  To: linuxppc-dev

The tlbilx opcode was not matching the Power ISA 2.06 arch spec.
The old opcode was an early suggested opcode that changed during the
2.06 architecture process.

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
 arch/powerpc/include/asm/ppc-opcode.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/include/asm/ppc-opcode.h b/arch/powerpc/include/asm/ppc-opcode.h
index f4a4db8..640ccbb 100644
--- a/arch/powerpc/include/asm/ppc-opcode.h
+++ b/arch/powerpc/include/asm/ppc-opcode.h
@@ -43,7 +43,7 @@
 
 #define PPC_INST_STSWI			0x7c0005aa
 #define PPC_INST_STSWX			0x7c00052a
-#define PPC_INST_TLBILX			0x7c000626
+#define PPC_INST_TLBILX			0x7c000024
 #define PPC_INST_WAIT			0x7c00007c
 
 /* macros to insert fields into opcodes */
-- 
1.6.0.6

^ permalink raw reply related

* Re: Recap: Kernel oops while duming user core.
From: Scott Wood @ 2009-04-06 18:26 UTC (permalink / raw)
  To: Fredrik Arnerup; +Cc: linuxppc-dev
In-Reply-To: <1C9CDA9B925A4C77B150D492AFFD022F@edgeware.tv>

On Mon, Apr 06, 2009 at 05:23:12PM +0200, Fredrik Arnerup wrote:
> Was the kernel oops when dumping core ever resolved?
> (http://ozlabs.org/pipermail/linuxppc-dev/2008-February/051080.html, quoted
> below)
> 
> What was the cause? Is there a patch? A bug tracker ticket?

It was fixed here:
http://ozlabs.org/pipermail/linuxppc-dev/2008-February/051350.html

> Using ELDK here, so still running 2.6.24 ...

Please consider upgrading.

-Scott

^ permalink raw reply

* Re: making cuImage with ELDK 4.2
From: Scott Wood @ 2009-04-06 18:16 UTC (permalink / raw)
  To: Yigal Goldberger; +Cc: linuxppc-dev
In-Reply-To: <932829.65089.qm@web38905.mail.mud.yahoo.com>

On Mon, Apr 06, 2009 at 04:14:51AM -0700, Yigal Goldberger wrote:
> 
> Hi all,
> I'm trying to make cuImage using kernel 2.6.24.2 .
> The problem is I can't find a match between a dtc version and a dts file that will compile . I took dtc-v1.2.0 from several sources and tried to make them . They all fail with the same error : 
> 	 CC dtc-lexer.lex.o
> dtc-lexer.lex.c: In function `yylex':
> dtc-lexer.lex.c:762: warning: label `find_rule' defined but not used
> dtc-lexer.l: At top level:
> dtc-lexer.lex.c:1870: warning: 'yy_flex_realloc' defined but not used
> 	 CC dtc-parser.tab.o

I believe you need a newer flex.

And a newer kernel, but not because of this. :-)

-Scott

^ permalink raw reply

* Recap: Kernel oops while duming user core.
From: Fredrik Arnerup @ 2009-04-06 15:23 UTC (permalink / raw)
  To: linuxppc-dev

Hi,

Was the kernel oops when dumping core ever resolved?
(http://ozlabs.org/pipermail/linuxppc-dev/2008-February/051080.html, quoted
below)

What was the cause? Is there a patch? A bug tracker ticket?
Using ELDK here, so still running 2.6.24 ...

Thanks,
/Fredrik Arnerup


////////////////////////////////////////
Kernel oops while duming user core.
Rune Torgersen runet at innovsys.com
Fri Feb 1 00:45:33 EST 2008

Hi

I get the following kernel core while a user program I have is dumping
core.
Any DIeas at what to look for? (this is runnign 2.6.24, arch/powerpc on
a 8280)
When runnign the program on 2.6.18 arch/ppc, the program gets a sig 11
and dumps core.
On 2.6.24, I ghet the kernel oops, and then the program hangs sround
forever and is unkillable.

Unable to handle kernel paging request for data at address 0x48024000
Faulting instruction address: 0xc000ef88
Oops: Kernel access of bad area, sig: 11 [#1]
PREEMPT Innovative Systems ApMax
Modules linked in: drv_wd(P) drv_scc devcom drv_pcir tipc drv_ss7
drv_auxcpu drv_leds(P) drv_ethsw proc_sysinfo(P) i2c_8266(P)
NIP: c000ef88 LR: c0012180 CTR: 00000080
REGS: eebc9b70 TRAP: 0300   Tainted: P         (2.6.24)
MSR: 00009032 <EE,ME,IR,DR>  CR: 24004442  XER: 00000000
DAR: 48024000, DSISR: 20000000
TASK = eebac3c0[3131] 'armd' THREAD: eebc8000
GPR00: ee9b7d00 eebc9c20 eebac3c0 48024000 00000080 399a4181 48024000
00000000
GPR08: 399a4181 ee9b7d00 00000000 c2000000 44004422 10100f38 ee82fc00
bfffffff
GPR16: ef377060 00000030 ee9b7d00 00000000 eebc9cdc 00000011 eebc9cd8
eeb96480
GPR24: ee9b7d00 399a4181 48024000 eeb9a370 eeb9a370 399a4181 48024000
c2733480
NIP [c000ef88] __flush_dcache_icache+0x14/0x40
LR [c0012180] update_mmu_cache+0x74/0x114
Call Trace:
[eebc9c20] [eebc8000] 0xeebc8000 (unreliable)
[eebc9c40] [c005d060] handle_mm_fault+0x630/0xbc0
[eebc9c80] [c005d9e4] get_user_pages+0x3f4/0x4fc
[eebc9cd0] [c00aa7c4] elf_core_dump+0x9a4/0xc5c
[eebc9d60] [c00779e4] do_coredump+0x6e0/0x748
[eebc9e50] [c002a5b0] get_signal_to_deliver+0x40c/0x45c
[eebc9e80] [c0008ce8] do_signal+0x50/0x294
[eebc9f40] [c000fb98] do_user_signal+0x74/0xc4
--- Exception: 300 at 0x10044efc
    LR = 0x10044ec0
Instruction dump:
4d820020 7c8903a6 7c001bac 38630020 4200fff8 7c0004ac 4e800020 60000000
54630026 38800080 7c8903a6 7c661b78 <7c00186c> 38630020 4200fff8
7c0004ac
---[ end trace 97db37eaf213da3c ]---
note: armd[3131] exited with preempt_count 2
 

^ permalink raw reply

* Re: [PATCH 1/2] powerpc/ftrace: Fix #if that should be #ifdef
From: Michael Ellerman @ 2009-04-06 14:59 UTC (permalink / raw)
  To: Steven Rostedt; +Cc: linuxppc-dev, Steven Rostedt
In-Reply-To: <1239029152.4753.2.camel@localhost.localdomain>

[-- Attachment #1: Type: text/plain, Size: 1064 bytes --]

On Mon, 2009-04-06 at 10:45 -0400, Steven Rostedt wrote:
> On Tue, 2009-04-07 at 00:40 +1000, Michael Ellerman wrote:
> > Commit bb7253403f7a4670a128e4c080fd8ea1bd4d5029 (powerpc64,
> > ftrace: save toc only on modules for function graph), added a
> > 
> > Fixes the following warning on 32-bit builds:
> >  arch/powerpc/kernel/ftrace.c:562:5: error: "CONFIG_PPC64" is not defined
> > 
> > Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
> 
> Acked-by: Steven Rostedt <rostedt@goodmis.org>
> 
> Hmm, maybe I'll keep the "Git Author" as srostedt@redhat.com, and change
> the signature to my goodmis account. Maybe that would be less confusing.

Thanks for the acks.

Yeah I copied the address from your S-O-B, so I'd say that address
should be the one you want mail to go to.

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply

* Re: [PATCH 2/2] powerpc/ftrace: Fix printf format warning
From: Steven Rostedt @ 2009-04-06 14:46 UTC (permalink / raw)
  To: Michael Ellerman; +Cc: linuxppc-dev, Steven Rostedt
In-Reply-To: <e74b6f429f71479547bbae5871cdc87b7c6b78b5.1239028836.git.michael@ellerman.id.au>


On Tue, 2009-04-07 at 00:40 +1000, Michael Ellerman wrote:
> 'tramp' is an unsigned long, so print it with %lx.
> 
> Fixes the following build warning:
> arch/powerpc/kernel/ftrace.c:291: error: format ‘%x’ expects type ‘unsigned int’, but argument 2 has type ‘long unsigned int’
> 
> Signed-off-by: Michael Ellerman <michael@ellerman.id.au>

Acked-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve

> ---
>  arch/powerpc/kernel/ftrace.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/powerpc/kernel/ftrace.c b/arch/powerpc/kernel/ftrace.c
> index e9d9d38..e1edf5a 100644
> --- a/arch/powerpc/kernel/ftrace.c
> +++ b/arch/powerpc/kernel/ftrace.c
> @@ -288,7 +288,7 @@ __ftrace_make_nop(struct module *mod,
>  	if (tramp & 0x8000)
>  		tramp -= 0x10000;
>  
> -	pr_debug(" %x ", tramp);
> +	pr_debug(" %lx ", tramp);
>  
>  	if (tramp != addr) {
>  		printk(KERN_ERR

^ permalink raw reply

* Re: [PATCH 1/2] powerpc/ftrace: Fix #if that should be #ifdef
From: Steven Rostedt @ 2009-04-06 14:45 UTC (permalink / raw)
  To: Michael Ellerman; +Cc: linuxppc-dev, Steven Rostedt
In-Reply-To: <db258c8de9d950c23d61abdcd121361a7bb40f75.1239028836.git.michael@ellerman.id.au>

Note, I only use my Red Hat email account to acknowledge who pays me to
do the work. But I'm much more reachable at rostedt@goodmis.org (as it
says in the maintainers file). I may go weeks without reading the RH
email.

On Tue, 2009-04-07 at 00:40 +1000, Michael Ellerman wrote:
> Commit bb7253403f7a4670a128e4c080fd8ea1bd4d5029 (powerpc64,
> ftrace: save toc only on modules for function graph), added a
> 
> Fixes the following warning on 32-bit builds:
>  arch/powerpc/kernel/ftrace.c:562:5: error: "CONFIG_PPC64" is not defined
> 
> Signed-off-by: Michael Ellerman <michael@ellerman.id.au>

Acked-by: Steven Rostedt <rostedt@goodmis.org>

Hmm, maybe I'll keep the "Git Author" as srostedt@redhat.com, and change
the signature to my goodmis account. Maybe that would be less confusing.

-- Steve

> ---
>  arch/powerpc/kernel/ftrace.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/powerpc/kernel/ftrace.c b/arch/powerpc/kernel/ftrace.c
> index e74f2dd..e9d9d38 100644
> --- a/arch/powerpc/kernel/ftrace.c
> +++ b/arch/powerpc/kernel/ftrace.c
> @@ -559,7 +559,7 @@ void prepare_ftrace_return(unsigned long *parent, unsigned long self_addr)
>  	if (unlikely(atomic_read(&current->tracing_graph_pause)))
>  		return;
>  
> -#if CONFIG_PPC64
> +#ifdef CONFIG_PPC64
>  	/* non core kernel code needs to save and restore the TOC */
>  	if (REGION_ID(self_addr) != KERNEL_REGION_ID)
>  		return_hooker = (unsigned long)&mod_return_to_handler;

^ permalink raw reply

* [PATCH 2/2] powerpc/ftrace: Fix printf format warning
From: Michael Ellerman @ 2009-04-06 14:40 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: srostedt
In-Reply-To: <db258c8de9d950c23d61abdcd121361a7bb40f75.1239028836.git.michael@ellerman.id.au>

'tramp' is an unsigned long, so print it with %lx.

Fixes the following build warning:
arch/powerpc/kernel/ftrace.c:291: error: format ‘%x’ expects type ‘unsigned int’, but argument 2 has type ‘long unsigned int’

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
---
 arch/powerpc/kernel/ftrace.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/kernel/ftrace.c b/arch/powerpc/kernel/ftrace.c
index e9d9d38..e1edf5a 100644
--- a/arch/powerpc/kernel/ftrace.c
+++ b/arch/powerpc/kernel/ftrace.c
@@ -288,7 +288,7 @@ __ftrace_make_nop(struct module *mod,
 	if (tramp & 0x8000)
 		tramp -= 0x10000;
 
-	pr_debug(" %x ", tramp);
+	pr_debug(" %lx ", tramp);
 
 	if (tramp != addr) {
 		printk(KERN_ERR
-- 
1.6.2.1

^ permalink raw reply related

* [PATCH 1/2] powerpc/ftrace: Fix #if that should be #ifdef
From: Michael Ellerman @ 2009-04-06 14:40 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: srostedt

Commit bb7253403f7a4670a128e4c080fd8ea1bd4d5029 (powerpc64,
ftrace: save toc only on modules for function graph), added a

Fixes the following warning on 32-bit builds:
 arch/powerpc/kernel/ftrace.c:562:5: error: "CONFIG_PPC64" is not defined

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
---
 arch/powerpc/kernel/ftrace.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/kernel/ftrace.c b/arch/powerpc/kernel/ftrace.c
index e74f2dd..e9d9d38 100644
--- a/arch/powerpc/kernel/ftrace.c
+++ b/arch/powerpc/kernel/ftrace.c
@@ -559,7 +559,7 @@ void prepare_ftrace_return(unsigned long *parent, unsigned long self_addr)
 	if (unlikely(atomic_read(&current->tracing_graph_pause)))
 		return;
 
-#if CONFIG_PPC64
+#ifdef CONFIG_PPC64
 	/* non core kernel code needs to save and restore the TOC */
 	if (REGION_ID(self_addr) != KERNEL_REGION_ID)
 		return_hooker = (unsigned long)&mod_return_to_handler;
-- 
1.6.2.1

^ permalink raw reply related

* Re: [PATCH 1/3] spi_mpc83xx: Handles other Freescale processors
From: Kumar Gala @ 2009-04-06 14:36 UTC (permalink / raw)
  To: Gary Thomas; +Cc: linuxppc-dev, Andrew Morton, linux-kernel, David Brownell
In-Reply-To: <49DA12C7.9000900@mlbassoc.com>


On Apr 6, 2009, at 9:33 AM, Gary Thomas wrote:

> Kumar Gala wrote:
>>
>> On Apr 4, 2009, at 2:28 PM, Anton Vorontsov wrote:
>>
>>> With this patch we'll able to select spi_mpc83xx driver on the  
>>> MPC86xx
>>> platforms. Let the driver depend on FSL_SOC, so we don't have to  
>>> worry
>>> about Kconfig anymore.
>>>
>>> Also remove the "experimental" dependency, the driver has been  
>>> tested
>>> to work on a various hardware, and surely not experimental anymore.
>>>
>>> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
>>> ---
>>> drivers/spi/Kconfig |   14 ++++++--------
>>> 1 files changed, 6 insertions(+), 8 deletions(-)
>>
>> this looks fine, but why don't we go ahead and rename things as well?
>> SPI_MPC83xx -> SPI_MPC8xxx, spi_mpc83xx.c -> spi_mpc8xxx.c
>
> mpc8xxx implies mpc82xx (e.g. mpc8272) which is not the same  
> controller
> as on the mpc83xx

True, but normally the 82xx drivers are "cpm" prefixed.  I think 8xxx  
is at better name than 83xx.

- k

^ permalink raw reply

* Re: [PATCH 1/3] spi_mpc83xx: Handles other Freescale processors
From: Gary Thomas @ 2009-04-06 14:33 UTC (permalink / raw)
  To: Kumar Gala; +Cc: linuxppc-dev, Andrew Morton, linux-kernel, David Brownell
In-Reply-To: <6758B03E-2525-4754-83FA-643CED277CC6@kernel.crashing.org>

Kumar Gala wrote:
> 
> On Apr 4, 2009, at 2:28 PM, Anton Vorontsov wrote:
> 
>> With this patch we'll able to select spi_mpc83xx driver on the MPC86xx
>> platforms. Let the driver depend on FSL_SOC, so we don't have to worry
>> about Kconfig anymore.
>>
>> Also remove the "experimental" dependency, the driver has been tested
>> to work on a various hardware, and surely not experimental anymore.
>>
>> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
>> ---
>> drivers/spi/Kconfig |   14 ++++++--------
>> 1 files changed, 6 insertions(+), 8 deletions(-)
> 
> this looks fine, but why don't we go ahead and rename things as well? 
> SPI_MPC83xx -> SPI_MPC8xxx, spi_mpc83xx.c -> spi_mpc8xxx.c

mpc8xxx implies mpc82xx (e.g. mpc8272) which is not the same controller
as on the mpc83xx

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

^ permalink raw reply

* Please pull from 'next' branch (for 2.6.30)
From: Kumar Gala @ 2009-04-06 14:29 UTC (permalink / raw)
  To: Benjamin Herrenschmidt, Paul Mackerras; +Cc: linuxppc-dev

Please pull from 'next' branch of

	master.kernel.org:/pub/scm/linux/kernel/git/galak/powerpc.git next

to receive the following updates:

 arch/powerpc/Kconfig                    |    1
 arch/powerpc/boot/dts/ksi8560.dts       |    4 +--
 arch/powerpc/boot/dts/pq2fads.dts       |   20 +++++++++++++-----
 arch/powerpc/boot/dts/sbc8548.dts       |    4 +--
 arch/powerpc/boot/dts/sbc8560.dts       |    4 +--
 arch/powerpc/boot/dts/socrates.dts      |    1
 arch/powerpc/boot/dts/stx_gp3_8560.dts  |    4 +--
 arch/powerpc/boot/dts/tqm8540.dts       |    4 +--
 arch/powerpc/boot/dts/tqm8541.dts       |    4 +--
 arch/powerpc/boot/dts/tqm8555.dts       |    4 +--
 arch/powerpc/boot/dts/tqm8560.dts       |    4 +--
 arch/powerpc/include/asm/mpic.h         |   12 +++++++++++
 arch/powerpc/include/asm/reg.h          |   30 ++++++++++++++++++++++++++++
 arch/powerpc/include/asm/reg_booke.h    |   30 ----------------------------
 arch/powerpc/include/asm/sfp-machine.h  |    6 ++---
 arch/powerpc/sysdev/mpic.c              |   34 ++++++++++++++++++++++++++++++++
 drivers/serial/cpm_uart/cpm_uart_core.c |   14 ++++++-------
 drivers/video/fsl-diu-fb.c              |   34 +++++++++++++++++++-------------
 include/linux/fsl_devices.h             |   22 --------------------
 19 files changed, 139 insertions(+), 97 deletions(-)

Anton Vorontsov (1):
      fsl-diu-fb: Pass the proper device for dma mapping routines

Grant Likely (1):
      powerpc: Remove unused symbols from fsl_devices.h

Josh Boyer (1):
      powerpc: Make LOWMEM_CAM_NUM depend on FSL_BOOKE

Kumar Gala (4):
      powerpc/85xx: Use fsl,mpc85.. as prefix for memory ctrl & l2-cache nodes
      powerpc: Move SPEFSCR defines to common header
      powerpc/math-emu: Change types to work on ppc64
      powerpc: Add support for CoreInt delivery of interrupts on MPIC

Scott Wood (3):
      cpm_uart: Initialize port.dev before it's used.
      cpm_uart: Disable CPM udbg when re-initing CPM uart, even if not the console.
      powerpc/pq2fads: Update device tree for use with device-tree-aware u-boot.

Wolfgang Grandegger (1):
      powerpc/85xx: Re-add the device_type soc to socrates.dts

^ permalink raw reply

* Re: [PATCH] fsl-diu-fb: Pass the proper device for dma mapping routines
From: Kumar Gala @ 2009-04-06 14:16 UTC (permalink / raw)
  To: Anton Vorontsov
  Cc: linuxppc-dev, Andrew Morton, Timur Tabi, Antonino Daplas,
	linux-kernel
In-Reply-To: <20090404183120.GA21671@oksana.dev.rtsoft.ru>


On Apr 4, 2009, at 1:31 PM, Anton Vorontsov wrote:

> The driver should pass a device that specifies internal DMA ops, but
> currently NULL pointers are passed, and thus following bug pops up:
>
>  Freescale DIU driver
>  ------------[ cut here ]------------
>  kernel BUG at arch/powerpc/include/asm/dma-mapping.h:237!
>  Oops: Exception in kernel mode, sig: 5 [#1]
>  ...
>  NIP [c01658b4] allocate_buf+0x0/0x8
>  LR [c0306554] fsl_diu_probe+0x2b4/0x518
>  Call Trace:
>  [df02be10] [c030638c] fsl_diu_probe+0xec/0x518 (unreliable)
>  [df02be60] [c020cdec] of_platform_device_probe+0x5c/0x84
>  [df02be80] [c018f5d0] really_probe+0x78/0x1a0
>  [df02bea0] [c018f7c0] __driver_attach+0xa4/0xa8
>  [df02bec0] [c018ea00] bus_for_each_dev+0x60/0x9c
>  [df02bef0] [c018f414] driver_attach+0x24/0x34
>  [df02bf00] [c018f168] bus_add_driver+0x12c/0x1cc
>  [df02bf20] [c018fbdc] driver_register+0x6c/0x110
>  [df02bf30] [c020ccb4] of_register_driver+0x54/0x70
>  [df02bf40] [c03d0a50] fsl_diu_init+0x70/0xa4
>  ...
>
> This patch fixes the issue.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
> drivers/video/fsl-diu-fb.c |   34 +++++++++++++++++++++-------------
> 1 files changed, 21 insertions(+), 13 deletions(-)

applied

- k

^ permalink raw reply

* Re: [PATCH 1/3] spi_mpc83xx: Handles other Freescale processors
From: Kumar Gala @ 2009-04-06 14:13 UTC (permalink / raw)
  To: Anton Vorontsov; +Cc: linuxppc-dev, Andrew Morton, David Brownell, linux-kernel
In-Reply-To: <20090404192802.GA12183@oksana.dev.rtsoft.ru>


On Apr 4, 2009, at 2:28 PM, Anton Vorontsov wrote:

> With this patch we'll able to select spi_mpc83xx driver on the MPC86xx
> platforms. Let the driver depend on FSL_SOC, so we don't have to worry
> about Kconfig anymore.
>
> Also remove the "experimental" dependency, the driver has been tested
> to work on a various hardware, and surely not experimental anymore.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
> drivers/spi/Kconfig |   14 ++++++--------
> 1 files changed, 6 insertions(+), 8 deletions(-)

this looks fine, but why don't we go ahead and rename things as well?   
SPI_MPC83xx -> SPI_MPC8xxx, spi_mpc83xx.c -> spi_mpc8xxx.c

- k

^ permalink raw reply

* Re: [PATCH] pq2fads: Update device tree for use with device-tree-aware u-boot.
From: Kumar Gala @ 2009-04-06 14:10 UTC (permalink / raw)
  To: Scott Wood; +Cc: linuxppc-dev
In-Reply-To: <20090403205846.GA20155@loki.buserror.net>


On Apr 3, 2009, at 3:58 PM, Scott Wood wrote:

> Add aliases, and correct CS0 offset to match how u-boot
> programs it (this was not a problem with cuImage because
> the wrapper would reprogram the localbus to match the device
> tree).
>
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> ---
> arch/powerpc/boot/dts/pq2fads.dts |   20 ++++++++++++++------
> 1 files changed, 14 insertions(+), 6 deletions(-)

applied

- k

^ permalink raw reply

* Re: [PATCH] cpm_uart: Disable CPM udbg when re-initing CPM uart, even if not the console.
From: Kumar Gala @ 2009-04-06 14:10 UTC (permalink / raw)
  To: Scott Wood; +Cc: linuxppc-dev
In-Reply-To: <20090403211549.GA22860@loki.buserror.net>


On Apr 3, 2009, at 4:15 PM, Scott Wood wrote:

> Previously, if udbg was using the CPM uart, and the normal CPM uart  
> driver
> was enabled, but the console was directed elsewhere, udbg would not be
> stopped prior to initialization.  This resulted in udbg hanging  
> forever
> waiting for the CPM to process a descriptor.
>
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> ---
> drivers/serial/cpm_uart/cpm_uart_core.c |    8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)


applied

- k

^ permalink raw reply

* Re: [PATCH] cpm_uart: Initialize port.dev before it's used.
From: Kumar Gala @ 2009-04-06 14:09 UTC (permalink / raw)
  To: Scott Wood; +Cc: linuxppc-dev
In-Reply-To: <20090403204844.GA20017@loki.buserror.net>


On Apr 3, 2009, at 3:48 PM, Scott Wood wrote:

> Previously, this caused NULL to sometimes be passed as a device
> to the DMA code.  With recent DMA changes, that now causes a BUG().
>
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> ---
> This is a regression triggered by DMA changes; please apply for  
> 2.6.30.

applied

- k

^ permalink raw reply


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox