* Re: term_adt746x: Invert bit required on this Powerbook G4
From: Max Vozeler @ 2009-11-04 12:39 UTC (permalink / raw)
To: Michel Dänzer; +Cc: linuxppc-dev
In-Reply-To: <20091104122355.GA7269@quark.vpn.nusquama.org>
On Wed, Nov 04, 2009 at 01:23:55PM +0100, Max Vozeler wrote:
> After some poking around, in which everything seemed to be
> according to plan including write of 0 to both FAN_SPD_SET regs,
> I noticed that explicitly *setting* the invert bit as in
>
> - write_reg(th, MANUAL_MODE[fan],
> - (manual|MANUAL_MASK) & (~INVERT_MASK));
> + write_reg(th, MANUAL_MODE[fan],
> + (manual|MANUAL_MASK|INVERT_MASK));
>
> seems to cure it. The fan appears to behave normally now, it
> turns on slowly when the temp limits are reached, otherwise it
> stays off. The temperature is reasonable (ie, no too hot).
>
> So, puzzeled, I checked the spec, and it appears very clear on
> the question of invert: It should be off by default.
Another datapoint:
The PRAM battery in this Powerbook is old, so it forgets e.g.
clock state completely when not connected to the power supply.
These are the PWM1/PWM2 registers during probe_thermostat()
after such a complete poweroff:
[ 28.332700] adt746x: ADT7460 initializing
[ 28.385266] ZZZ MANUAL_MODE[0] 0xd2
[ 28.385832] ZZZ MANUAL_MODE[1] 0x82
So if I'm reading this correctly, PWM1 starts off with the
invert bit (0x10) set, for some reason.
Max
^ permalink raw reply
* term_adt746x: Invert bit required on this Powerbook G4
From: Max Vozeler @ 2009-11-04 12:23 UTC (permalink / raw)
To: Michel Dänzer; +Cc: linuxppc-dev
I installed Ubuntu 8.10 on this Powerbook G4 ("alu" I think)
for a friend of mine. As soon as therm_adt746x got loaded, the
fan turned into a noise steam engine.
This was on Ubuntu's 2.6.31 kernel (2.6.31-14-powerpc) which
includes 0512a9a8e277a9de2. I could reproduce it with latest
mainline as well.
The effect was just as Michel described in the changelog; The
fan was running while temps were well below any of the limits,
and it stopped only when I set ridiculously low limits.
[ 1087.141482] adt746x: version 1 (supported)
[ 1087.141495] adt746x: Thermostat bus: 1, address: 0x2e, limit_adjust: 0, fan_speed: -1
[ 1087.141503] sensor 0: HDD BOTTOMSIDE
[ 1087.141507] sensor 1: CPU TOPSIDE
[ 1087.141512] sensor 2: GPU ON DIE
[ 1087.161365] adt746x: ADT7460 initializing
[ 1087.165245] adt746x: Lowering max temperatures from 73, 80, 109 to 70, 50, 70
[ 1087.165261] adt746x: Setting speed to 0 for CPU TOPSIDE fan.
[ 1087.166302] adt746x: Setting speed to 0 for GPU ON DIE fan.
(What "worked" was limit_adjust=-30, fan did turn off, but so did
the Powerbook shortly after, despite being cold.)
After some poking around, in which everything seemed to be
according to plan including write of 0 to both FAN_SPD_SET regs,
I noticed that explicitly *setting* the invert bit as in
- write_reg(th, MANUAL_MODE[fan],
- (manual|MANUAL_MASK) & (~INVERT_MASK));
+ write_reg(th, MANUAL_MODE[fan],
+ (manual|MANUAL_MASK|INVERT_MASK));
seems to cure it. The fan appears to behave normally now, it
turns on slowly when the temp limits are reached, otherwise it
stays off. The temperature is reasonable (ie, no too hot).
So, puzzeled, I checked the spec, and it appears very clear on
the question of invert: It should be off by default.
I'm about to give the laptop back to my friend, but I suppose I
could borrow it for further tests if anyone could guide me how
to dig further into this.
Any hw/openfirmware details interesting?
Max
^ permalink raw reply
* Re: [PATCH 3/5] powerpc/86xx: Enable NVRAM on GE Fanuc's SBC610
From: Martyn Welch @ 2009-11-05 14:23 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev
In-Reply-To: <DAE90CFA-DC33-4BF6-9381-35B0BC1D45C4@kernel.crashing.org>
Kumar Gala wrote:
>
> On Jul 2, 2009, at 11:12 AM, Martyn Welch wrote:
>
>> This patch enables the NVRAM found on the GE Fanuc SBC610
>>
>> Signed-off-by: Martyn Welch <martyn.welch@gefanuc.com>
>> ---
>>
>> arch/powerpc/boot/dts/gef_sbc610.dts | 6 ++++++
>> arch/powerpc/configs/86xx/gef_sbc610_defconfig | 4 ++--
>> arch/powerpc/platforms/86xx/Kconfig | 1 +
>> arch/powerpc/platforms/86xx/gef_sbc610.c | 5 +++++
>> 4 files changed, 14 insertions(+), 2 deletions(-)
>
> I assume these still work w/the updates to the other patches?
>
> - k
I'm just updating your tree to ensure that the patches still apply (and
compile) cleanly. I'm fairly confident that they will.
Martyn
--
Martyn Welch MEng MPhil MIET (Principal Software Engineer) T:+44(0)1327322748
GE Fanuc Intelligent Platforms Ltd, |Registered in England and Wales
Tove Valley Business Park, Towcester, |(3828642) at 100 Barbirolli Square,
Northants, NN12 6PF, UK T:+44(0)1327359444 |Manchester,M2 3AB VAT:GB 927559189
^ permalink raw reply
* Re: [PATCH RFC] gianfar: Make polling safe with IRQs disabled
From: Anton Vorontsov @ 2009-11-05 14:20 UTC (permalink / raw)
To: Jon Loeliger
Cc: linuxppc-dev, Jason Wessel, Andy Fleming, David Miller, netdev
In-Reply-To: <E1N62ti-0003iS-K2@jdl.com>
On Thu, Nov 05, 2009 at 08:01:10AM -0600, Jon Loeliger wrote:
> > When using KGDBoE, gianfar driver spits 'Interrupt problem' messages,
> > which appears to be a legitimate warning, i.e. we may end up calling
> > netif_receive_skb() or vlan_hwaccel_receive_skb() with IRQs disabled.
> >
> > This patch reworks the RX path so that if netpoll is enabled (the
> > only case when the driver don't know from what context the polling
> > may be called), we check whether IRQs are disabled, and if so we
> > fall back to safe variants of skb receiving functions.
> >
> > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> > ---
> >
> > I'm not sure if this is suitable for mainline since it doesn't
> > have KGDBoE support. Jason, if the patch is OK, would you like
> > to merge it into KGDB tree?
>
> It's a legitimate problem with or without KGDBoE. I see it
> occasionally when conn_track is enabled as well, for example.
Hm, then I'd better remove the #ifdef CONFIG_NETPOLL.
Interestingly though, why conn_track does the polling with irqs
disabled, could be a bug in the conn_track? Because pretty much
drivers assume that polling is called with IRQs enabled.
If it's easily reproducible, could you replace the printk() with
WARN_ON(1) and post the backtrace? Or I can try to reproduce the
issue if you tell me how.
Thanks!
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
^ permalink raw reply
* Re: [PATCH] powerpc/8xxx: enable IPsec ESP by default on mpc83xx/mpc85xx
From: Kumar Gala @ 2009-11-05 14:19 UTC (permalink / raw)
To: Kim Phillips; +Cc: linuxppc-dev
In-Reply-To: <20091012113527.a822b6b4.kim.phillips@freescale.com>
On Oct 12, 2009, at 11:35 AM, Kim Phillips wrote:
>
> Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
> ---
> arch/powerpc/configs/mpc83xx_defconfig | 15 ++++++++-------
> arch/powerpc/configs/mpc85xx_defconfig | 16 ++++++++--------
> arch/powerpc/configs/mpc85xx_smp_defconfig | 16 ++++++++--------
> 3 files changed, 24 insertions(+), 23 deletions(-)
applied to merge
- k
^ permalink raw reply
* Re: [PATCH 7/7] powerpc/83xx: Add power management support for MPC83xx QE boards
From: Kumar Gala @ 2009-11-05 14:11 UTC (permalink / raw)
To: Anton Vorontsov; +Cc: Scott Wood, linuxppc-dev, Timur Tabi
In-Reply-To: <20090915214402.GG24821@oksana.dev.rtsoft.ru>
On Sep 15, 2009, at 4:44 PM, Anton Vorontsov wrote:
> Simply add power management controller nodes and sleep properties.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> Acked-by: Scott Wood <scottwood@freescale.com>
> ---
> arch/powerpc/boot/dts/kmeter1.dts | 7 +++++++
> arch/powerpc/boot/dts/mpc832x_mds.dts | 9 +++++++++
> arch/powerpc/boot/dts/mpc832x_rdb.dts | 9 +++++++++
> arch/powerpc/boot/dts/mpc836x_mds.dts | 9 +++++++++
> arch/powerpc/boot/dts/mpc836x_rdk.dts | 9 +++++++++
> 5 files changed, 43 insertions(+), 0 deletions(-)
applied to next
- k
^ permalink raw reply
* Re: [PATCH 6/7] powerpc/86xx: Add power management support for MPC8610HPCD boards
From: Kumar Gala @ 2009-11-05 14:11 UTC (permalink / raw)
To: Anton Vorontsov; +Cc: Scott Wood, linuxppc-dev, Timur Tabi
In-Reply-To: <20090915214400.GF24821@oksana.dev.rtsoft.ru>
On Sep 15, 2009, at 4:44 PM, Anton Vorontsov wrote:
> This patch adds needed nodes and properties to support suspend/resume
> on the MPC8610HPCD boards.
>
> There is a dedicated switch (SW9) that is used to wake up the boards.
> By default the SW9 button is routed to IRQ8, but could be re-routed
> (via PIXIS) to sreset.
>
> With 'no_console_suspend' kernel command line argument specified, the
> board is also able to wakeup upon serial port input.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> Acked-by: Scott Wood <scottwood@freescale.com> [dts]
> ---
> Documentation/powerpc/dts-bindings/fsl/board.txt | 4 ++
> arch/powerpc/boot/dts/mpc8610_hpcd.dts | 26 ++++++++++++
> arch/powerpc/platforms/86xx/mpc8610_hpcd.c | 48 +++++++++++++
> +++++++--
> 3 files changed, 74 insertions(+), 4 deletions(-)
applied to next
- k
^ permalink raw reply
* Re: [PATCH 4/7] powerpc/85xx/86xx: Add suspend/resume support
From: Kumar Gala @ 2009-11-05 14:11 UTC (permalink / raw)
To: Anton Vorontsov; +Cc: Scott Wood, linuxppc-dev, Timur Tabi
In-Reply-To: <20090915214357.GD24821@oksana.dev.rtsoft.ru>
On Sep 15, 2009, at 4:43 PM, Anton Vorontsov wrote:
> This patch adds suspend/resume support for MPC8540 and MPC8641D-
> compatible CPUs. To reach sleep state, we just write the SLP bit
> into the PM control and status register.
>
> So far we don't support Deep Sleep mode as found in newer MPC85xx
> CPUs (i.e. MPC8536). It can be relatively easy implemented though,
> and for it we reserve 'mem' suspend type.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> Acked-by: Scott Wood <scottwood@freescale.com>
> ---
> arch/powerpc/Kconfig | 11 +++++-
> arch/powerpc/sysdev/Makefile | 1 +
> arch/powerpc/sysdev/fsl_pmc.c | 88 ++++++++++++++++++++++++++++++++
> +++++++++
> 3 files changed, 99 insertions(+), 1 deletions(-)
> create mode 100644 arch/powerpc/sysdev/fsl_pmc.c
applied to next
- k
^ permalink raw reply
* Re: [PATCH 5/7] powerpc/85xx: Add power management support for MPC85xxMDS boards
From: Kumar Gala @ 2009-11-05 14:11 UTC (permalink / raw)
To: Anton Vorontsov; +Cc: Scott Wood, linuxppc-dev, Timur Tabi
In-Reply-To: <20090915214359.GE24821@oksana.dev.rtsoft.ru>
On Sep 15, 2009, at 4:43 PM, Anton Vorontsov wrote:
> - Add power management controller nodes;
> - Add interrupts for RTC nodes, the RTC interrupt may be used as a
> wakeup source;
> - Add sleep properties and sleep-nexus nodes.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> Acked-by: Scott Wood <scottwood@freescale.com>
> ---
> arch/powerpc/boot/dts/mpc8568mds.dts | 119 ++++++++++++++++++
> +----------
> arch/powerpc/boot/dts/mpc8569mds.dts | 111 +++++++++++++++++
> +---------
> arch/powerpc/platforms/85xx/mpc85xx_mds.c | 1 +
> 3 files changed, 153 insertions(+), 78 deletions(-)
applied to next
- k
^ permalink raw reply
* Re: [PATCH 3/7] powerpc/qe: Implement QE driver for handling resume on MPC85xx
From: Kumar Gala @ 2009-11-05 14:11 UTC (permalink / raw)
To: Anton Vorontsov; +Cc: Scott Wood, linuxppc-dev, Timur Tabi
In-Reply-To: <20090915214355.GC24821@oksana.dev.rtsoft.ru>
On Sep 15, 2009, at 4:43 PM, Anton Vorontsov wrote:
> So far the driver is used to reset QE upon resume, which is needed on
> 85xx. Later we can move some QE initialization steps into probe().
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
> arch/powerpc/sysdev/qe_lib/qe.c | 34 ++++++++++++++++++++++++++++++
> ++++
> 1 files changed, 34 insertions(+), 0 deletions(-)
applied to next
- k
^ permalink raw reply
* Re: [PATCH 3/5] powerpc/86xx: Enable NVRAM on GE Fanuc's SBC610
From: Kumar Gala @ 2009-11-05 14:10 UTC (permalink / raw)
To: Martyn Welch; +Cc: linuxppc-dev
In-Reply-To: <20090702161231.31202.87763.stgit@ES-J7S4D2J.amer.consind.ge.com>
On Jul 2, 2009, at 11:12 AM, Martyn Welch wrote:
> This patch enables the NVRAM found on the GE Fanuc SBC610
>
> Signed-off-by: Martyn Welch <martyn.welch@gefanuc.com>
> ---
>
> arch/powerpc/boot/dts/gef_sbc610.dts | 6 ++++++
> arch/powerpc/configs/86xx/gef_sbc610_defconfig | 4 ++--
> arch/powerpc/platforms/86xx/Kconfig | 1 +
> arch/powerpc/platforms/86xx/gef_sbc610.c | 5 +++++
> 4 files changed, 14 insertions(+), 2 deletions(-)
I assume these still work w/the updates to the other patches?
- k
^ permalink raw reply
* Re: [PATCH 7/8] spi_mpc8xxx: Turn qe_mode into flags
From: Kumar Gala @ 2009-11-05 13:47 UTC (permalink / raw)
To: Anton Vorontsov
Cc: David Brownell, Greg Kroah-Hartman, linux-kernel, linuxppc-dev,
spi-devel-general, Andrew Morton
In-Reply-To: <20091012164925.GG4578@oksana.dev.rtsoft.ru>
On Oct 12, 2009, at 11:49 AM, Anton Vorontsov wrote:
> Soon there will be more flags introduced in subsequent patches, so
> let's turn qe_mode into flags.
>
> Also introduce mpc8xxx_spi_strmode() and print current SPI mode.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> Acked-by: David Brownell <dbrownell@users.sourceforge.net>
> ---
> drivers/spi/spi_mpc8xxx.c | 30 +++++++++++++++++++-----------
> include/linux/fsl_devices.h | 2 +-
> 2 files changed, 20 insertions(+), 12 deletions(-)
applied to next
- k
^ permalink raw reply
* Re: [PATCH 5/7] powerpc/85xx: Add power management support for MPC85xxMDS boards
From: Anton Vorontsov @ 2009-11-05 14:08 UTC (permalink / raw)
To: Kumar Gala; +Cc: Scott Wood, linuxppc-dev, Timur Tabi
In-Reply-To: <AFE1C29A-88D4-4A1D-B7AD-A797CCC855D3@kernel.crashing.org>
On Thu, Nov 05, 2009 at 08:02:44AM -0600, Kumar Gala wrote:
[...]
> >diff --git a/arch/powerpc/boot/dts/mpc8568mds.dts b/arch/powerpc/
> >boot/dts/mpc8568mds.dts
> >index 00c2bbd..6d892ba 100644
> >--- a/arch/powerpc/boot/dts/mpc8568mds.dts
> >+++ b/arch/powerpc/boot/dts/mpc8568mds.dts
> >@@ -40,6 +40,8 @@
> > i-cache-line-size = <32>; // 32 bytes
> > d-cache-size = <0x8000>; // L1, 32K
> > i-cache-size = <0x8000>; // L1, 32K
> >+ sleep = <&pmc 0x00008000 // core
> >+ &pmc 0x00004000>; // timebase
> >
> >Just so I'm clear this is the devdisr bit position?
>
> Also where in the code do we use this? I'm not seeing it.
We don't use it (yet). The per-device power management is not yet
implemented. It is relatively easy to do on 83xx, but on 85xx there
is a restriction: we can't re-enable the device after we disable it,
i.e. POR sequence is needed. Though, we may want to disable all
'unused' (say echo 1 > /sys/devices/.../permanently_disable) to save
some power.
Thanks,
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
^ permalink raw reply
* Re: [PATCH 5/7] powerpc/85xx: Add power management support for MPC85xxMDS boards
From: Kumar Gala @ 2009-11-05 14:06 UTC (permalink / raw)
To: avorontsov; +Cc: Scott Wood, linuxppc-dev, Timur Tabi
In-Reply-To: <20091105140407.GA16698@oksana.dev.rtsoft.ru>
On Nov 5, 2009, at 8:04 AM, Anton Vorontsov wrote:
> On Thu, Nov 05, 2009 at 07:58:49AM -0600, Kumar Gala wrote:
> [...]
>> --- a/arch/powerpc/boot/dts/mpc8568mds.dts
>> +++ b/arch/powerpc/boot/dts/mpc8568mds.dts
>> @@ -40,6 +40,8 @@
>> i-cache-line-size = <32>; // 32 bytes
>> d-cache-size = <0x8000>; // L1, 32K
>> i-cache-size = <0x8000>; // L1, 32K
>> + sleep = <&pmc 0x00008000 // core
>> + &pmc 0x00004000>; // timebase
>>
>> Just so I'm clear this is the devdisr bit position?
>
> Yep, as described in the bindings.
I don't think the binding is clear that for 85xx these are DEVDISR bit
positions for the given SoC.
- k
^ permalink raw reply
* Re: [PATCH 5/7] powerpc/85xx: Add power management support for MPC85xxMDS boards
From: Anton Vorontsov @ 2009-11-05 14:04 UTC (permalink / raw)
To: Kumar Gala; +Cc: Scott Wood, linuxppc-dev, Timur Tabi
In-Reply-To: <197B3989-3373-4172-B5FA-727CA1EEE2AA@kernel.crashing.org>
On Thu, Nov 05, 2009 at 07:58:49AM -0600, Kumar Gala wrote:
[...]
> --- a/arch/powerpc/boot/dts/mpc8568mds.dts
> +++ b/arch/powerpc/boot/dts/mpc8568mds.dts
> @@ -40,6 +40,8 @@
> i-cache-line-size = <32>; // 32 bytes
> d-cache-size = <0x8000>; // L1, 32K
> i-cache-size = <0x8000>; // L1, 32K
> + sleep = <&pmc 0x00008000 // core
> + &pmc 0x00004000>; // timebase
>
> Just so I'm clear this is the devdisr bit position?
Yep, as described in the bindings.
Thanks,
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
^ permalink raw reply
* Re: [PATCH 5/7] powerpc/85xx: Add power management support for MPC85xxMDS boards
From: Kumar Gala @ 2009-11-05 14:02 UTC (permalink / raw)
To: Kumar Gala; +Cc: Scott Wood, linuxppc-dev, Timur Tabi
In-Reply-To: <197B3989-3373-4172-B5FA-727CA1EEE2AA@kernel.crashing.org>
On Nov 5, 2009, at 7:58 AM, Kumar Gala wrote:
>
> On Sep 15, 2009, at 4:43 PM, Anton Vorontsov wrote:
>
>> - Add power management controller nodes;
>> - Add interrupts for RTC nodes, the RTC interrupt may be used as a
>> wakeup source;
>> - Add sleep properties and sleep-nexus nodes.
>>
>> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
>> Acked-by: Scott Wood <scottwood@freescale.com>
>> ---
>> arch/powerpc/boot/dts/mpc8568mds.dts | 119 ++++++++++++++++++
>> +----------
>> arch/powerpc/boot/dts/mpc8569mds.dts | 111 +++++++++++++++++
>> +---------
>> arch/powerpc/platforms/85xx/mpc85xx_mds.c | 1 +
>> 3 files changed, 153 insertions(+), 78 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/mpc8568mds.dts b/arch/powerpc/
> boot/dts/mpc8568mds.dts
> index 00c2bbd..6d892ba 100644
> --- a/arch/powerpc/boot/dts/mpc8568mds.dts
> +++ b/arch/powerpc/boot/dts/mpc8568mds.dts
> @@ -40,6 +40,8 @@
> i-cache-line-size = <32>; // 32 bytes
> d-cache-size = <0x8000>; // L1, 32K
> i-cache-size = <0x8000>; // L1, 32K
> + sleep = <&pmc 0x00008000 // core
> + &pmc 0x00004000>; // timebase
>
> Just so I'm clear this is the devdisr bit position?
Also where in the code do we use this? I'm not seeing it.
- k
^ permalink raw reply
* Re: [PATCH 5/7] powerpc/85xx: Add power management support for MPC85xxMDS boards
From: Kumar Gala @ 2009-11-05 13:58 UTC (permalink / raw)
To: Anton Vorontsov; +Cc: Scott Wood, linuxppc-dev, Timur Tabi
In-Reply-To: <20090915214359.GE24821@oksana.dev.rtsoft.ru>
On Sep 15, 2009, at 4:43 PM, Anton Vorontsov wrote:
> - Add power management controller nodes;
> - Add interrupts for RTC nodes, the RTC interrupt may be used as a
> wakeup source;
> - Add sleep properties and sleep-nexus nodes.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> Acked-by: Scott Wood <scottwood@freescale.com>
> ---
> arch/powerpc/boot/dts/mpc8568mds.dts | 119 ++++++++++++++++++
> +----------
> arch/powerpc/boot/dts/mpc8569mds.dts | 111 +++++++++++++++++
> +---------
> arch/powerpc/platforms/85xx/mpc85xx_mds.c | 1 +
> 3 files changed, 153 insertions(+), 78 deletions(-)
diff --git a/arch/powerpc/boot/dts/mpc8568mds.dts b/arch/powerpc/boot/
dts/mpc8568mds.dts
index 00c2bbd..6d892ba 100644
--- a/arch/powerpc/boot/dts/mpc8568mds.dts
+++ b/arch/powerpc/boot/dts/mpc8568mds.dts
@@ -40,6 +40,8 @@
i-cache-line-size = <32>; // 32 bytes
d-cache-size = <0x8000>; // L1, 32K
i-cache-size = <0x8000>; // L1, 32K
+ sleep = <&pmc 0x00008000 // core
+ &pmc 0x00004000>; // timebase
Just so I'm clear this is the devdisr bit position?
- k
^ permalink raw reply related
* Re: [PATCH 8/8] spi_mpc8xxx: Add support for QE DMA mode and CPM1/CPM2 chips
From: Kumar Gala @ 2009-11-05 13:47 UTC (permalink / raw)
To: Anton Vorontsov
Cc: David Brownell, Greg Kroah-Hartman, linux-kernel, linuxppc-dev,
spi-devel-general, Andrew Morton
In-Reply-To: <20091012164927.GH4578@oksana.dev.rtsoft.ru>
On Oct 12, 2009, at 11:49 AM, Anton Vorontsov wrote:
> This patch adds QE buffer descriptors mode support for the
> spi_mpc8xxx driver, and as a side effect we now support CPM1
> and CPM2 SPI controllers.
>
> That means that today we support almost all MPC SPI controllers:
>
> - MPC834x-style controllers (support PIO mode only);
> - CPM1 and CPM2 controllers (support DMA mode only);
> - QE SPI controllers in CPU mode (PIO mode with shift quirks);
> - QE SPI controllers in buffer descriptors (DMA) mode;
>
> The only controller we don't currently support is a newer eSPI
> (with a dedicated chip selects and a bit different registers map).
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> Acked-by: David Brownell <dbrownell@users.sourceforge.net>
> ---
> drivers/spi/Kconfig | 3 -
> drivers/spi/spi_mpc8xxx.c | 540 ++++++++++++++++++++++++++++++++++++
> +++++----
> 2 files changed, 500 insertions(+), 43 deletions(-)
applied to next
- k
^ permalink raw reply
* Re: [PATCH 3/6] P2020DS: Fixup sdhc to use PIO mode
From: Kumar Gala @ 2009-11-05 13:52 UTC (permalink / raw)
To: Gao Guanhua-B22826; +Cc: linuxppc-dev, sdhci-devel
In-Reply-To: <CF6163088BDE8747873ADAA4AF922BF287EDB0@zmy16exm21.fsl.freescale.net>
On Sep 24, 2009, at 3:28 AM, Gao Guanhua-B22826 wrote:
> Thanks, I will add them.
>
>> -----Original Message-----
>> From: Anton Vorontsov [mailto:avorontsov@ru.mvista.com]
>> Sent: Wednesday, September 23, 2009 7:55 PM
>> To: Gao Guanhua-B22826
>> Cc: sdhci-devel@lists.ossman.eu; linuxppc-dev@ozlabs.org
>> Subject: Re: [PATCH 3/6] P2020DS: Fixup sdhc to use PIO mode
>>
>> On Wed, Sep 23, 2009 at 05:08:09PM +0800, Gao Guanhua wrote:
>>> The SDHC can not work on DMA mode because of the hardware
>> bug, so we
>>> set a broken dma flag and use PIO mode. This patch applies
>> to Rev1.0.
>>
>> Signed-off-by line is missing (in all patches).
>
Any plan to update & repost these patches?
- k
^ permalink raw reply
* Re: [PATCH 6/8] spi_mpc8xxx: Factor out SPI mode change steps into a call
From: Kumar Gala @ 2009-11-05 13:47 UTC (permalink / raw)
To: Anton Vorontsov
Cc: David Brownell, Greg Kroah-Hartman, linux-kernel, linuxppc-dev,
spi-devel-general, Andrew Morton
In-Reply-To: <20091012164924.GF4578@oksana.dev.rtsoft.ru>
On Oct 12, 2009, at 11:49 AM, Anton Vorontsov wrote:
> We'll add more steps soon, so get rid of the duplication.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> Acked-by: David Brownell <dbrownell@users.sourceforge.net>
> ---
> drivers/spi/spi_mpc8xxx.c | 56 ++++++++++++++++++
> +-------------------------
> 1 files changed, 24 insertions(+), 32 deletions(-)
applied to next
- k
^ permalink raw reply
* Re: [PATCH 5/8] spi_mpc8xxx: Fix uninitialized variable
From: Kumar Gala @ 2009-11-05 13:47 UTC (permalink / raw)
To: Anton Vorontsov
Cc: David Brownell, Greg Kroah-Hartman, linux-kernel, linuxppc-dev,
spi-devel-general, Andrew Morton
In-Reply-To: <20091012164922.GE4578@oksana.dev.rtsoft.ru>
On Oct 12, 2009, at 11:49 AM, Anton Vorontsov wrote:
> This patch fixes the following warning:
>
> CC drivers/spi/spi_mpc8xxx.o
> spi_mpc8xxx.c: In function 'of_mpc8xxx_spi_probe':
> spi_mpc8xxx.c:681: warning: 'ret' may be used uninitialized in this
> function
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> Acked-by: David Brownell <dbrownell@users.sourceforge.net>
> ---
> drivers/spi/spi_mpc8xxx.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
applied to next
- k
^ permalink raw reply
* Re: [PATCH 4/8] powerpc/qe&cpm: Implement static inline stubs for non-QE/CPM builds
From: Kumar Gala @ 2009-11-05 13:46 UTC (permalink / raw)
To: Anton Vorontsov
Cc: David Brownell, Greg Kroah-Hartman, linux-kernel, linuxppc-dev,
spi-devel-general, Andrew Morton
In-Reply-To: <20091012164920.GD4578@oksana.dev.rtsoft.ru>
On Oct 12, 2009, at 11:49 AM, Anton Vorontsov wrote:
> This is needed to avoid ugly #ifdefs in drivers. Also update
> fsl_qe_udc
> driver so that now it doesn't define its own versions that cause build
> breakage when the generic stubs are used.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
> ---
> arch/powerpc/include/asm/cpm.h | 44 ++++++++++++++++++++++++++++++
> +++++++++
> arch/powerpc/include/asm/qe.h | 11 ++++++++-
> drivers/usb/gadget/fsl_qe_udc.h | 15 -------------
> 3 files changed, 54 insertions(+), 16 deletions(-)
applied to next
- k
^ permalink raw reply
* Re: [PATCH 3/8] powerpc/cpm: Move CPMFCR_* defines into cpm.h
From: Kumar Gala @ 2009-11-05 13:46 UTC (permalink / raw)
To: Anton Vorontsov
Cc: David Brownell, Greg Kroah-Hartman, linux-kernel, linuxppc-dev,
spi-devel-general, Andrew Morton
In-Reply-To: <20091012164918.GC4578@oksana.dev.rtsoft.ru>
On Oct 12, 2009, at 11:49 AM, Anton Vorontsov wrote:
> The bits are generic to CPM devices, so let's move them to the
> common header file, so drivers won't need to privately reintroduce
> another bunch of the same bits (as we can't include cpm2.h header
> together with cpm1.h).
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
> arch/powerpc/include/asm/cpm.h | 16 ++++++++++++++++
> arch/powerpc/include/asm/cpm2.h | 8 --------
> 2 files changed, 16 insertions(+), 8 deletions(-)
applied to next
- k
^ permalink raw reply
* Re: [PATCH 2/8] powerpc/qe&cpm2: Avoid redefinitions in CPM2 and QE headers
From: Kumar Gala @ 2009-11-05 13:46 UTC (permalink / raw)
To: Anton Vorontsov
Cc: David Brownell, Greg Kroah-Hartman, linux-kernel, linuxppc-dev,
spi-devel-general, Andrew Morton
In-Reply-To: <20091012164916.GB4578@oksana.dev.rtsoft.ru>
On Oct 12, 2009, at 11:49 AM, Anton Vorontsov wrote:
> struct mcc defined in both immap_qe.h and immap_cpm2.h, so they will
> conflic when included in a single file. The mcc struct is easy to deal
> with, since it isn't used in any driver (yet), so let's just rename QE
> version to qe_mcc.
>
> The ucb_ctlr is a bit trickier, since it is used by fsl_qe_udc driver,
> and the driver supports both CPM and QE UDCs, plus the QE version is
> used to form a bigger immap struct.
>
> I don't want to touch too much of USB code in this series, so for now
> let's just copy most generic version into the common cpm.h header,
> later we'll create cpm_usb.h where we'll place common USB structs that
> are used by QE/CPM UDC and QE Host drivers (FHCI).
>
> And as for the structs in qe.h and cpm2.h, just prefix them with qe_
> and cpm_.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
> arch/powerpc/include/asm/cpm.h | 22 ++++++++++++++++++++++
> arch/powerpc/include/asm/immap_cpm2.h | 2 +-
> arch/powerpc/include/asm/immap_qe.h | 8 ++++----
> 3 files changed, 27 insertions(+), 5 deletions(-)
applied to next
- k
^ permalink raw reply
* Re: [PATCH 1/8] powerpc/cpm: Remove SPI defines and spi structs
From: Kumar Gala @ 2009-11-05 13:46 UTC (permalink / raw)
To: Anton Vorontsov
Cc: David Brownell, Greg Kroah-Hartman, linux-kernel, linuxppc-dev,
spi-devel-general, Andrew Morton
In-Reply-To: <20091012164913.GA4578@oksana.dev.rtsoft.ru>
On Oct 12, 2009, at 11:49 AM, Anton Vorontsov wrote:
> When cpm2.h included into spi_mpc8xxx driver, the SPI defines
> in the header conflict with defines in the driver.
>
> We don't need them in the header file, so remove them. Plus
> remove "struct spi", we'll use a better version in the driver.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
> arch/powerpc/include/asm/cpm1.h | 45
> ---------------------------------------
> arch/powerpc/include/asm/cpm2.h | 39
> ---------------------------------
> 2 files changed, 0 insertions(+), 84 deletions(-)
applied to next
- k
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox